RE: [PHP-DEV] SPL docs

2006-06-08 Thread Soenke Ruempler
Derick Rethans wrote on Friday, June 09, 2006 8:25 AM: > On Thu, 8 Jun 2006, Andi Gutmans wrote: > >> Any chance we can get the SPL docs integrated into the PHP manual? I >> get questions about it here and there and think that as it's in the >> default PHP distro it mak

Re: [PHP-DEV] SPL docs

2006-06-08 Thread Derick Rethans
On Thu, 8 Jun 2006, Andi Gutmans wrote: > Any chance we can get the SPL docs integrated into the PHP manual? I > get questions about it here and there and think that as it's in the > default PHP distro it makes sense to have that as part of the official > PHP manual. There is no way we can do

[PHP-DEV] [PATCH] Keeping module dtors kosher for PHP 5* [WAS: [PATCH] Automatic module globals management]

2006-06-08 Thread Steph Fox
I've done it again - this was an invisible patch :) OK, relabelling the email. Nothing new to see here, move along... - Original Message - From: "Steph Fox" <[EMAIL PROTECTED]> To: "Ilia Alshanetsky" <[EMAIL PROTECTED]>; "Dmitry Stogov" <[EMAIL PROTECTED]>; "Andi Gutmans" <[EMAIL PROT

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
Andi, Why so? It doesn't affect any compatibility. Yes it does, and more particularly it prevents any fix for the win32/ZTS issue until people upgrade to the new module API. If everyone has to add an extra #ifdef into MSHUTDOWN to get around the new situation, but then has to take it away a

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Pierre
On Thu, 8 Jun 2006 23:34:10 +0200 [EMAIL PROTECTED] (Pierre) wrote: > On 6/8/06, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: > > The patch is good, but I think this change maybe a bit too extreme > > for PHP 5.2 > > I agree. As far as I remember, we even discussed a similar solution > some years

[PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Andi Gutmans
Why so? It doesn't affect any compatibility. At 02:31 PM 6/8/2006, Ilia Alshanetsky wrote: The patch is good, but I think this change maybe a bit too extreme for PHP 5.2 On 8-Jun-06, at 8:15 AM, Dmitry Stogov wrote: Hi, The attached patch (for PHP_5_2) implements automatic management of mod

[PHP-DEV] SPL docs

2006-06-08 Thread Andi Gutmans
Hey Marcus, Any chance we can get the SPL docs integrated into the PHP manual? I get questions about it here and there and think that as it's in the default PHP distro it makes sense to have that as part of the official PHP manual. Andi -- PHP Internals - PHP Runtime Development Mailing Lis

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Pierre
On 6/8/06, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: The patch is good, but I think this change maybe a bit too extreme for PHP 5.2 I agree. As far as I remember, we even discussed a similar solution some years ago and decided to delay it until someone comes with a better one, which indeed di

[PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Ilia Alshanetsky
The patch is good, but I think this change maybe a bit too extreme for PHP 5.2 On 8-Jun-06, at 8:15 AM, Dmitry Stogov wrote: Hi, The attached patch (for PHP_5_2) implements automatic management of module globals. The problem that module globals must be unregistered before extension unloa

Re: [PHP-DEV] [PATCH] arg_info and friends

2006-06-08 Thread Hannes Magnusson
Hi Marcus On 6/8/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: Hello Hannes, Thursday, June 8, 2006, 12:37:09 PM, you wrote: > Hi Marcus > On 6/8/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: >> Hello Hannes, >> >> Monday, May 29, 2006, 8:52:51 PM, you wrote: >> >> > Hi all >> >> > I've creat

[PHP-DEV] Reflection API b0rked in HEAD and PHP_5_2

2006-06-08 Thread Sebastian Bergmann
http://phpfi.com/122573 -- Sebastian Bergmann http://www.sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] arg_info and friends

2006-06-08 Thread Marcus Boerger
Hello Hannes, Thursday, June 8, 2006, 12:37:09 PM, you wrote: > Hi Marcus > On 6/8/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: >> Hello Hannes, >> >> Monday, May 29, 2006, 8:52:51 PM, you wrote: >> >> > Hi all >> >> > I've created a patch[1] that welcomes new friend into the >> > zend_arg_info

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Derick Rethans
On Thu, 8 Jun 2006, Steph Fox wrote: > People with custom extensions at least are only working with one version of > PHP at a time, I'd hope :) Are you kidding? There are people using Xdebug for PHP 4.3.x, 4.4.x, 5.0.x, 5.1.x and 5.2.x... that's already enough headaches to maintain with ifdefs

[PHP-DEV] Win snapshot is not built (PHP 5.2)

2006-06-08 Thread Marian Kostadinov
Once again, 5.2 snapshot for windows cannot be built. Can anyone fix this, please?

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Andi Gutmans
At 11:33 AM 6/8/2006, Steph Fox wrote: It's not going to be a headache because they can still use it the way it should be done today. ... for the last two months or so... that's not a 'should', that's a workaround. For the 5.1.x tree you can do the fixes immediately with the way Dmitry has

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Pierre
On 6/8/06, Steph Fox <[EMAIL PROTECTED]> wrote: People with custom extensions at least are only working with one version of PHP at a time, I'd hope :) Not really. Especially not when you provide it as a product. --Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
It's not going to be a headache because they can still use it the way it should be done today. ... for the last two months or so... that's not a 'should', that's a workaround. For the 5.1.x tree you can do the fixes immediately with the way Dmitry has previously proposed Huh? Did I mi

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
Hi Rasmus, It'd make more sense to apply the patch partially in 5_2 and change the module API number (to address that issue and give extension authors some hope of understanding what's going on), and apply the whole thing in HEAD and bump the API number again. I really think applying it in 5_2

[PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Andi Gutmans
It's not going to be a headache because they can still use it the way it should be done today. For the 5.1.x tree you can do the fixes immediately with the way Dmitry has previously proposed At 11:18 AM 6/8/2006, Steph Fox wrote: Andi, hi, I read the whole thread. I agree with Sara. Whi

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Rasmus Lerdorf
Steph Fox wrote: Andi, hi, I read the whole thread. I agree with Sara. While I understand where Steph is coming from, I still think this is a good change. It would allow us to use this method in the current tree right away, and for PECL authors who want to stay compatible with older version

[PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
Andi, hi, I read the whole thread. I agree with Sara. While I understand where Steph is coming from, I still think this is a good change. It would allow us to use this method in the current tree right away, and for PECL authors who want to stay compatible with older versions they can use the

[PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Andi Gutmans
I read the whole thread. I agree with Sara. While I understand where Steph is coming from, I still think this is a good change. It would allow us to use this method in the current tree right away, and for PECL authors who want to stay compatible with older versions they can use the old & ugly

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
I'm sorry Steph, I know your position, but I just don't understand it. This is a minor gain at no cost. Minor enough that it's not worth it to me to fight with you over it, but no-cost enough to compel me to against my better judgement... :) That's because you're missing that this was origina

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Sara Golemon
For the modules which are part of the core distribution this is a non-issue as they're branched. For PECL modules this is the same "how old of a PHP version am I (as the package maintainer) willing to support?". That package maintainer can: (A) Not use the new API, (B) Wrap up some #ifdef's, o

Re: [PHP-DEV] [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
DS>>The attached patch (for PHP_5_2) implements automatic management of module DS>>globals. DS>>The problem that module globals must be unregistered before extension DS>>unloading, because "globls_dtor" function is unloaded together with DS>>extension and cannot be called. I think the patch itse

Re: [PHP-DEV] [PATCH] Automatic module globals management

2006-06-08 Thread Stanislav Malyshev
DS>>The attached patch (for PHP_5_2) implements automatic management of module DS>>globals. DS>>The problem that module globals must be unregistered before extension DS>>unloading, because "globls_dtor" function is unloaded together with DS>>extension and cannot be called. I think the patch itself

Re: [PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
Yes, I know. But altered modules won't be able to use older versions of PHP readily, and that's going to be a real problem in PECL - especially if this goes into 5_2 branch. For the modules which are part of the core distribution this is a non-issue as they're branched. For PECL modules this

[PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Sara Golemon
Yes, I know. But altered modules won't be able to use older versions of PHP readily, and that's going to be a real problem in PECL - especially if this goes into 5_2 branch. For the modules which are part of the core distribution this is a non-issue as they're branched. For PECL modules this

[PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
Hi Sara, I think you're missing the fact that Dmitry's patch only *enables* an extension to register CTOR/DTORs in the module entry struct. Existing modules can continue to use the manual calls in MINIT/MSHUTDOWN without breaking. Yes, I know. But altered modules won't be able to use older

[PHP-DEV] Re: [PATCH] Automatic module globals management

2006-06-08 Thread Sara Golemon
The attached patch (for PHP_5_2) implements automatic management of module globals. The problem that module globals must be unregistered before extension unloading, because "globls_dtor" function is unloaded together with extension and cannot be called. Dmitry- I like the concept especially as

Re: [PHP-DEV] [PATCH] Automatic module globals management

2006-06-08 Thread Steph Fox
Hey Dmitry, all, Disclaimer: I've had a sneak preview on this one. I really don't like this going into 5_2 branch, and the more I think about it the less sure I am about it going into HEAD either. It would mean renaming all the ctor/dtor functions to the new globals, which is going to take an

[PHP-DEV] [PATCH] Automatic module globals management

2006-06-08 Thread Dmitry Stogov
Hi, The attached patch (for PHP_5_2) implements automatic management of module globals. The problem that module globals must be unregistered before extension unloading, because "globls_dtor" function is unloaded together with extension and cannot be called. To solve this problem extension writers

Re: [PHP-DEV] [PATCH] arg_info and friends

2006-06-08 Thread Hannes Magnusson
Hi Marcus On 6/8/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: Hello Hannes, Monday, May 29, 2006, 8:52:51 PM, you wrote: > Hi all > I've created a patch[1] that welcomes new friend into the > zend_arg_info family, resource, and a new flag for ZEND_ME_MAPPING and > pals, ZEND_ACC_INFO_MAP_TO_