Hi Rasmus,
It'd make more sense to apply the patch partially in 5_2 and change the
module API number (to address that issue and give extension authors some
hope of understanding what's going on), and apply the whole thing in HEAD
and bump the API number again. I really think applying it in 5_2 is going
to leave extension writers with a headache.
As soon as you change the module api number you have a headache. At
Yahoo! we would need to compile some 200 or so custom extensions. If we
are forced to do that, a little tweak in the code itself is minor.
We aren't _forced_ to do that, I wrote a small patch over a week ago that
fixes it internally and doesn't even touch the module_entry struct. But the
more robust way would be to do as Dmitry's suggesting with the
ZEND_MG(whatever) part of his patch.
People with custom extensions at least are only working with one version of
PHP at a time, I'd hope :)
-Rasmus
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
