Re: [PHP-DEV] Re: realpath patch

2004-10-01 Thread Andi Gutmans
Yep I agree. That makes sense to me. Andi At 12:01 PM 10/1/2004 -0700, Rasmus Lerdorf wrote: On Fri, 1 Oct 2004, Andi Gutmans wrote: > At 11:24 AM 10/1/2004 -0700, Sara Golemon wrote: > > > I'd like to commit the realpath() patch I sent to the list for review a > > > week or so ago. Unless there ar

Re: [PHP-DEV] Re: realpath patch

2004-10-01 Thread Rasmus Lerdorf
On Fri, 1 Oct 2004, Sara Golemon wrote: > > The > > only case that trips us up is the one where a user has direct access to > > create whatever symlinks he wants in his own directory and then by hitting > > that symlink through the web server he is effectively reading any file the > > web server us

Re: [PHP-DEV] Re: realpath patch

2004-10-01 Thread Sara Golemon
> With safemode on they can't do this symlink trick directly from > php because PHP's symlink() safemode checks source and target paths. > Good call... > The > only case that trips us up is the one where a user has direct access to > create whatever symlinks he wants in his own directory and then

Re: [PHP-DEV] Re: realpath patch

2004-10-01 Thread Sander Steffann
Hi, But like my syscall patches, realpath caching isn't something all that many really need. Turning it off when safemode/open_basedir is on should be fine. Sounds good to me. Sander -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: realpath patch

2004-10-01 Thread Rasmus Lerdorf
On Fri, 1 Oct 2004, Andi Gutmans wrote: > At 11:24 AM 10/1/2004 -0700, Sara Golemon wrote: > > > I'd like to commit the realpath() patch I sent to the list for review a > > > week or so ago. Unless there are any objections I'll commit it (to HEAD) > >in > > > 1-2 days. This will give it some more e

[PHP-DEV] [PATCH] Small ini file optimization

2004-10-01 Thread Robert Silva
During php_init_config() in php_ini.c, it currently loads environment settings, (on windows, system directories and registry settings), binary locations building the path to search for ini files. If you specify -n on the command line, any code that would use these paths are excluded so building th

Re: [PHP-DEV] Re: realpath patch

2004-10-01 Thread Andi Gutmans
At 11:24 AM 10/1/2004 -0700, Sara Golemon wrote: > I'd like to commit the realpath() patch I sent to the list for review a > week or so ago. Unless there are any objections I'll commit it (to HEAD) in > 1-2 days. This will give it some more exposure and will have more people > testing it. > Somehow

[PHP-DEV] Re: realpath patch

2004-10-01 Thread Sara Golemon
> I'd like to commit the realpath() patch I sent to the list for review a > week or so ago. Unless there are any objections I'll commit it (to HEAD) in > 1-2 days. This will give it some more exposure and will have more people > testing it. > Somehow the patch is no longer in my news spool, so rath

Re: [PHP-DEV] Variable fetch optimization

2004-10-01 Thread Andi Gutmans
http://snaps.php.net/~andi/Zend.m4.diff.gz http://snaps.php.net/~andi/cv.diff.gz At 09:31 AM 10/1/2004 -0700, Andi Gutmans wrote: Hi, Attached is a patch to optimize variable fetches (basically it caches the fetches so that variables aren't re-fetched every time, most noticeable in loops with the

[PHP-DEV] Variable fetch optimization

2004-10-01 Thread Andi Gutmans
Hi, Attached is a patch to optimize variable fetches (basically it caches the fetches so that variables aren't re-fetched every time, most noticeable in loops with the loop control counter but also it's a general improvement). It's similar to the patch Sterling and Thies did a year ago in their

RE: [PHP-DEV] [PATCH]Add SO_ORIGINAL_DST support and SOL_IP constant to socket_get_options()

2004-10-01 Thread Robert Silva
It looks like this is specific to the Linux kernel getsockopt implementation. There may be other ways to do it on different platforms, but SO_ORIGINAL_DST is not it. Bob Silva -Original Message- From: Leonardo Pedretti [mailto:[EMAIL PROTECTED] Sent: Friday, October 01, 2004 7:02 AM To

Re: [PHP-DEV] [PATCH]Add SO_ORIGINAL_DST support and SOL_IP constant to socket_get_options()

2004-10-01 Thread Leonardo Pedretti
Help needed on this details bob is commenting about the patch (i don't have much experience on the configure scripts). It would be interesting that someone reports the existence/equivalence of the SO_ORIGINAL_DST option on some other systems. Regards Leo On Thursday 30 September 2004 17:12, you

Re-2: [PHP-DEV] Re: declaring classes as static or final

2004-10-01 Thread michael . virnstein
> > You mean like an interface adds abstract to all functoins... exactly. needless to say, that the variable $this would not be available in those classes and that subclasses of that class have to be static also. what i'm not sure about is, if it would be better to let ppl type static on the