Help needed on this details bob is commenting about the patch (i don't have 
much experience on the configure scripts).
It would be interesting that someone reports the existence/equivalence of the 
SO_ORIGINAL_DST option on some other systems.

Regards
Leo

On Thursday 30 September 2004 17:12, you wrote:
> > This patch adds some quite useful functionalities to socket_get_options()
> > function.
> > ...
> > Things NOT tested: I don't have solaris, bsd, etc. to test it. If someone
> > can test it and report necessary changes, or errors so I can make the
> > changes, It will be appreciated.
>
> At minimum, I would imagine that
>
>   a) changing the autoconf script so that it properly detects if the
>      underlying operating system has support for the capability in question
>      is required;
>
>   b) adding #ifdef/#endif pairs based on the autoconf rewrite to include
>      the proper files on a per-architecture basis.
>
> If you only have Linux, then doing (a) and (b) for the Linux-specific
> case would get your patch a lot farther.  If this patch is applied
> as-is to the PHP sources and then compiled on anything except linux,
> it will break because of #include <linux/...> (at minimum).
>
> Not that I'm authoritative about PHP adoption; but having submitted
> patches before to a variety of projects I've found you're likely
> to get farther if you create your patch so that it doesn't break
> anyone else's system.
>
> -Bob

-- 

Leonardo Pedretti
Axon Sistemas
Líder de Equipo Proyecto Basalto

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to