Re: [PHP-DEV] [patch] re-invoking default error handler

Sara Golemon wrote: This just means replacing the first line of that patch with: if (Z_TYPE_P(retval) != IS_NULL && !zend_is_true(retval)) { This would be fine with me. What do we all thing about feasibility of this patch going into PHP 5? +0 No great harm in doing it, but for myself if I'm go

Re: [PHP-DEV] RC3RC1

* Thus wrote Curt Zirzow ([EMAIL PROTECTED]): > I tracked it down that it broke for me at revision 1.21 (the pty > support for proc_open), the macro #define _XOPEN_SOURCE 500 causes > my system to change which POSIX version to compile with. Actually it was revision 1.24 that broke things for me,

Re: [PHP-DEV] RC3RC1

* Thus wrote Daniel Fahlgren ([EMAIL PROTECTED]): > On Thu, May 27, 2004 at 08:11:17PM +, Curt Zirzow wrote: > > * Thus wrote Andi Gutmans ([EMAIL PROTECTED]): > > > Please test. If there are no critical problems I'll release RC3 tomorrow > > > which I think will be the last RC for 5.0. > > >

Re: [PHP-DEV] RC3RC1

* Thus wrote Daniel Fahlgren ([EMAIL PROTECTED]): > On Thu, May 27, 2004 at 08:11:17PM +, Curt Zirzow wrote: > > * Thus wrote Andi Gutmans ([EMAIL PROTECTED]): > > > Please test. If there are no critical problems I'll release RC3 tomorrow > > > which I think will be the last RC for 5.0. > > >

Re: [PHP-DEV] [patch] re-invoking default error handler

> > Nah, I know. I'm not saying I'm against it, all I'm saying is that noone > > will hear any objections from me. It puts an extra tool in the hands of the > > user at negligible cost and that's a good thing. All I meant by my comment > > was that it's a tool I don't ever see myself (personally

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

Is it not possible to do this at the time set_streams_context is called? I am weary of having this done per-request for all PHP requests regardless of whether or not they actually call anything in libxml. -Rasmus On Fri, 28 May 2004, Andi Gutmans wrote: > Anyone see a problem with this patch?

Re: [PHP-DEV] RC3RC1

on 27/5/04 21:11, Curt Zirzow at [EMAIL PROTECTED] wrote: > In file included > from /usr/home/curt/source/php-5.0.0RC3RC1/Zend/zend.h:244, > from /usr/home/curt/source/php-5.0.0RC3RC1/main/php.h:34, > from /usr/home/curt/source/php-5.0.0RC3RC1/ext/standard/proc_open.c:25: > /usr/home/curt/source/p

Re: [PHP-DEV] RC3RC1

On Thu, May 27, 2004 at 08:11:17PM +, Curt Zirzow wrote: > * Thus wrote Andi Gutmans ([EMAIL PROTECTED]): > > Please test. If there are no critical problems I'll release RC3 tomorrow > > which I think will be the last RC for 5.0. > > > > I'm getting an error during compile, > [..] > In file i

Re: [PHP-DEV] [patch] re-invoking default error handler

On Thu, 27 May 2004, Sara Golemon wrote: > Nah, I know. I'm not saying I'm against it, all I'm saying is that noone > will hear any objections from me. It puts an extra tool in the hands of the > user at negligible cost and that's a good thing. All I meant by my comment > was that it's a tool I

Re: [PHP-DEV] [patch] re-invoking default error handler

> > +0 > > > > No great harm in doing it, but for myself if I'm going to override the error > > handler, I'm going to override the entire error handler. > > The need that came up here was that people only wanted to use their error > handler for their own trigger_error()'ed errors. For normal PHP e

Re: [PHP-DEV] [patch] re-invoking default error handler

On Thu, 27 May 2004, Sara Golemon wrote: > > > This just means replacing the first line of that patch with: > > > if (Z_TYPE_P(retval) != IS_NULL && !zend_is_true(retval)) { > > > > This would be fine with me. What do we all thing about feasibility of > > this patch going into PHP 5? > > > +0

Re: [PHP-DEV] [patch] re-invoking default error handler

> > This just means replacing the first line of that patch with: > > if (Z_TYPE_P(retval) != IS_NULL && !zend_is_true(retval)) { > > This would be fine with me. What do we all thing about feasibility of > this patch going into PHP 5? > +0 No great harm in doing it, but for myself if I'm goin

Re: [PHP-DEV] [patch] re-invoking default error handler

On Thu, 27 May 2004, Sara Golemon wrote: > This just means replacing the first line of that patch with: > if (Z_TYPE_P(retval) != IS_NULL && !zend_is_true(retval)) { This would be fine with me. What do we all thing about feasibility of this patch going into PHP 5? - Andrei -- PHP Internal

Re: [PHP-DEV] [PATCH] libxml - Move Callback Reg to Request Init

Anyone see a problem with this patch? If not, I'd like to include it in RC3 because it makes sense. Andi At 10:13 PM 5/26/2004 -0700, Paul Querna wrote: Patch Moves the Registering of the PHP XML Streams to the request init, instead of installing them globaly in the Module init. This is needed if

Re: [PHP-DEV] [patch] re-invoking default error handler

> Of course there is a BC problem. Current error handlers do not have to > return anything. Once the patch is added, the default handler will all > of a sudden be invoked, when the developer did not really mean it. I > realize that the "convention" is to return false if you didn't process > it, but

Re: [PHP-DEV] RC3RC1

* Thus wrote Andi Gutmans ([EMAIL PROTECTED]): > Please test. If there are no critical problems I'll release RC3 tomorrow > which I think will be the last RC for 5.0. > I'm getting an error during compile, /bin/sh /usr/home/curt/source/php-5.0.0RC3RC1/libtool --silent --preserve-dup-deps --mode=

Re: [PHP-DEV] [patch] re-invoking default error handler

On Thu, 27 May 2004, Lenar Lõhmus wrote: > >> It's backwards compatible with previous functionality, i.e. if you don't > >> return anything, the default handler does not get invoked. > > > > This argument may overrule my preference, of course. > > Since error_handler is called from inside PHP eng

Re: [PHP-DEV] [patch] re-invoking default error handler

Jon Parise wrote: > The convention(*) for these kinds of things is generally to return > 'true' when you've handled the message/event and want to discontinue > further processing. Returning 'false' indicates that you haven't > handled the event. You are right. That's how it should be done. >> I

Re: [PHP-DEV] [patch] re-invoking default error handler

On Thu, May 27, 2004 at 08:50:48AM -0700, Andrei Zmievski wrote: > Attached is a small patch that can let you do the following. If you set > a custom error handler via set_error_handler() but don't want to > implement all the details of handling every single error level, now you > can simply handl

Re: [PHP-DEV] Re: Constant value as a zval*

Sure. At 08:52 AM 5/27/2004 -0700, Andrei Zmievski wrote: On Thu, 27 May 2004, Andi Gutmans wrote: > I don't think there's a good reason especially as I used zval * for class > constants. Probably just because it's legacy code and it was never changed. > I'll try and play around with it right after

[PHP-DEV] CVS Account Request: chess

Translating the documentation (specificaly translating the english pear manual to spanish Version) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: Constant value as a zval*

On Thu, 27 May 2004, Andi Gutmans wrote: > I don't think there's a good reason especially as I used zval * for class > constants. Probably just because it's legacy code and it was never changed. > I'll try and play around with it right after 5.0. Should we add it to something like TODO5.1 so we d

[PHP-DEV] [patch] re-invoking default error handler

Attached is a small patch that can let you do the following. If you set a custom error handler via set_error_handler() but don't want to implement all the details of handling every single error level, now you can simply handle the ones you are interested. Basically, if you return 1 from your error

[PHP-DEV] RC3RC1

Please test. If there are no critical problems I'll release RC3 tomorrow which I think will be the last RC for 5.0. http://snaps.php.net/~andi/php-5.0.0RC3RC1.tar.bz2 http://snaps.php.net/~andi/php-5.0.0RC3RC1.tar.gz Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, vis

Re: [PHP-DEV] RC3

On May 27, 2004, at 7:21 AM, Rob Richards wrote: I have a few DOM element and attribute validation bug fixes I need to finalize and forward to Rob. I've been tardy on finishing them up, but I will get my act together in time for RC3. :) All of the DOM changes are commited. Yea, we are good to go. -

Re: [PHP-DEV] feof hangs (bug #25939)

Wez Furlong wrote: I have to go out for a couple of hours; if you could track down where PHP is blocking in the 4.3 branch, I'd very much appreciate it. It hangs in main/network.c the change introduced from 1.83.2.20 to 1.83.2.21 in the select shown here if no data can be read (yet). This doesn't

RE: [PHP-DEV] feof hangs (bug #25939)

I just fixed PHP 5, but can't see how 4.3 could hang (admittedly only looked briefly). I have to go out for a couple of hours; if you could track down where PHP is blocking in the 4.3 branch, I'd very much appreciate it. --Wez. > -Original Message- > From: Christian Schneider [mailto:[EM

[PHP-DEV] feof hangs (bug #25939)

I tried to reopen bug #25939 because I ran into the same problem as but it's not my bug report. Should I open a new bug? I agree with the last comment that feof should not hang. Sample script: $fd = fsockopen('www.php.net', 80); feof($fd); This hangs for P

Re: [PHP-DEV] Re: PHP5-rc2 coredumps with Smarty-2.6.2, error handler and exceptions

This should be fixed now. At 06:47 PM 5/6/2004 +0200, Derick Rethans wrote: On Thu, 6 May 2004, Cristiano Duarte wrote: > Cristiano Duarte wrote: > > > Hi internals, > > > > this piece of code causes coredumps with PHP5-RC2: > I also tested with latest CVS (2004-05-06). File a bug (including a back

Re: [PHP-DEV] RC3

From: Adam Maccabee Trachtenberg > On Tue, 25 May 2004, Andi Gutmans wrote: > > > I'd like to release RC3 on Thursday/Friday. I believe this to be the last > > RC before we can release. > > If anyone has bug fixes to commit please do so within the next couple of days. > > I have a few DOM element

Re: [PHP-DEV] RC3

Any news? I'd like to roll RC3 (or at least an RC1 version of RC3 which people can sanity test). Andi At 10:48 AM 5/25/2004 -0400, Adam Maccabee Trachtenberg wrote: On Tue, 25 May 2004, Andi Gutmans wrote: > I'd like to release RC3 on Thursday/Friday. I believe this to be the last > RC before we