This just means replacing the first line of that patch with: if (Z_TYPE_P(retval) != IS_NULL && !zend_is_true(retval)) {
This would be fine with me. What do we all thing about feasibility of this patch going into PHP 5?
+0
No great harm in doing it, but for myself if I'm going to override the error handler, I'm going to override the entire error handler.
-Sara
You can't handle all errorlevels with a custom error handler, at the moment E_STRICT (why this one by the way?), E_ERROR, E_PARSE, E_CORE_ERROR, E_CORE_WARNING, E_COMPILE_ERROR and E_COMPILE_WARNING cannot be handled. So I can understand that one decides to leave E_NOTICE and E_WARNING to PHP as well and only handles E_USER_* himself.
I see a situation where it might be useful, but I won't use it myself.
And a point to be taken in consideration: it might obscure the error handling process a bit. Right now it isn't very easy to understand (I see new colleagues have a hard time trying to understand this monthly) :).
Bert
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
