to be timestamped;
if this happens before igc_ptp_init() is called, adapter->ptp_tx_lock is
going to be uninitialized, and (3) is going to crash.
If there's anything that makes this impossible/extremely unlikely, the
patch looks good:
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
Corinna Vinschen writes:
> On Apr 24 17:06, Vinicius Costa Gomes wrote:
>> Andrew Lunn writes:
>>
>> > On Tue, Apr 23, 2024 at 12:24:54PM +0200, Corinna Vinschen wrote:
>> >> During successful probe, igc logs this:
>> >>
>>
>
> The reason is that igc_ptp_init() is called very early, even before
> register_netdev() has been called. So the netdev_info() call works
> on a partially uninitialized netdev.
>
> Fix th
Mikhail Gavrilov writes:
> On Tue, May 21, 2024 at 10:34 AM Sasha Neftin wrote:
>>
>> Any thought? Revert?
>>
>
> Sorry for the noise. Is there any solution?
Sasha has provided the revert[1], so it's on its way to be fixed.
[1]
https://lore.kernel.org/intel-wired-lan/20240529051307.3094901-
location
> failures. Introduce a new flag for signaling that condition.
>
> [1] -
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=3be507547e6177e5c808544bd6a2efa2c7f1d436
>
> Signed-off-by: Kurt Kanzenbach
> ---
Acked-by: Vinicius Costa Gomes
Sebastian Andrzej Siewior writes:
> On 2024-06-12 12:49:21 [-0700], Vinicius Costa Gomes wrote:
>> > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
>> > b/drivers/net/ethernet/intel/igc/igc_main.c
>> > index 305e05294a26..e666739dfac7 100644
>> &g
case TAPRIO_CMD_QUEUE_STATS:
> + igc_taprio_queue_stats(adapter->netdev, &qopt->queue_stats);
> + return 0;
> + default:
> + return -EOPNOTSUPP;
> + }
> +
Yeah, moving the command parsing to be done earlier sounds like the
right fix:
Acked-by: Vinicius Costa Gomes
> if (err)
> return err;
>
> --
> 2.25.1
>
--
Vinicius
12-igc_mqprio-v2-1-587924e6b...@linutronix.de
>
> Changes in v2:
> - Improve changelog (Paul Menzel)
> - Link to v1:
> https://lore.kernel.org/r/20240212-igc_mqprio-v1-1-7aed95b73...@linutronix.de
Acked-by: Vinicius Costa Gomes
--
Vinicius
g between the modes in the hardware.
So I would like some confirmation that ETF offloading/LaunchTime was
also tested with this change. Just to be sure.
But code-wise, looks good:
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
> taprio_offload_enable field to indicate that the current running taprio
> was triggered by user, instead of triggered by non-qbv feature like etf.
>
> Fixes: ae4fe4698300 ("igc: Add qbv_config_change_errors counter")
> Signed-off-by: Faizal Rahim
> Reviewed-by: Simon Horman
> ---
Looks good:
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
t; 4. Check the timestamp on listener via wireshark
>
> Test Result:
> 100 Mbps: 113 ~193 ns
> 1000 Mbps: 52 ~ 84 ns
> 2500 Mbps: 95 ~ 223 ns
>
> Note that the test result is similar to the patch "igc: Correct the
> launchtime offset".
>
> Fixes: 790835fcc0cb
), and a couple
> of solutions that worked but that were subpar:
>
> 1. The issue was not observed for a phc2sys(8) running on a fully
>isolated nohz_full core. We do not have the luxury of dedicating a a
>core for it.
This one is interesting. Was it because the isolated CPU
"Abdul Rahim, Faizal" writes:
> Hi Vinicius,
>
> On 11/7/2024 6:44 am, Vinicius Costa Gomes wrote:
>> Faizal Rahim writes:
>>
>>> Following the "igc: Fix TX Hang issue when QBV Gate is close" changes,
>>> remaining issues with the r
; ---
> v1:
> https://patchwork.kernel.org/project/netdevbpf/patch/20240701100058.3301229-1-faizal.abdul.ra...@linux.intel.com/
>
> Changelog:
> v1 -> v2
> - Update commit description (Paul).
> - Rename qbvfullth -> qbvfullthreshold (Paul).
> ---
Looks fine.
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
Hi,
"Abdul Rahim, Faizal" writes:
> On 12/7/2024 1:10 am, Vinicius Costa Gomes wrote:
>> "Abdul Rahim, Faizal" writes:
>>
>>> Hi Vinicius,
>>>
>>> On 11/7/2024 6:44 am, Vinicius Costa Gomes wrote:
>>>> Faizal Rahim
Daiwei Li writes:
> Hi,
>
> It appears this change breaks PTP on the 82580 controller, as ptp4l reports:
>
>> timed out while polling for tx timestamp increasing tx_timestamp_timeout or
>> increasing kworker priority may correct this issue, but a driver bug likely
>> causes it
>
> The 82580 contr
verts commit ee14cc9ea19b ("igb: Fix missing time sync
events").
Fixes: ee14cc9ea19b ("igb: Fix missing time sync events")
Reported-by: Daiwei Li
Closes:
https://lore.kernel.org/intel-wired-lan/CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w...@mail.gmail.com/
Signed-off
if (hw->mac.type == e1000_82580) {
> + /* 82580 has a hardware bug that requires a explicit
> +* write to clear the TimeSync interrupt cause.
> +*/
> + wr32(E1000_TSICR, tsicr & mask);
Yeah, I should have thought about t
table tree, please rebase against:
https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git/
For credits, you can add something like:
Suggested-by: Vinicius Costa Gomes
>
> drivers/net/ethernet/intel/igb/igb_main.c | 10 ++
> 1 file changed, 10 insertions(+)
&g
uot;igb: Fix missing time sync events")
> Closes:
> https://lore.kernel.org/intel-wired-lan/CAN0jFd1kO0MMtOh8N2Ztxn6f7vvDKp2h507sMryobkBKe=xk=w...@mail.gmail.com/
> Tested-by: Daiwei Li
> Suggested-by: Vinicius Costa Gomes
> Signed-off-by: Daiwei Li
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
use flex filters for
matching vlan-etype with a partial mask. But I don't think there's any
real use case for partial masks, better to reject them:
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
___
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
h
> Signed-off-by: Rodrigo Cataldo
> ---
Very good catch.
Acked-by: Vinicius Costa Gomes
Just for curiosity, my test machines are busy right now, what kind of
difference are you seeing?
> This is a simple fix for the credit calculation on igc devices
> (i225/i226) to match the Intel
Rodrigo CADORE CATALDO writes:
>> -Original Message-
>> From: Vinicius Costa Gomes
>>
>> Rodrigo Cataldo via B4 Relay
>> writes:
>>
>> > From: Rodrigo Cataldo
>> >
>> > According to the Intel Software Manual for I
lakshmi.sowjany...@intel.com writes:
> From: Lakshmi Sowjanya D
>
> Remove convert_art_to_tsc() and convert_art_ns_to_tsc(), as this patch
> series introduces a generic function ktime_real_to_base_clock() to
> convert realtime to base clock domain.
>
> Add hardware abstraction, struct clocksource
Song Yoong Siang writes:
> This patch adds support to per-packet Tx hardware timestamp request to
> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that
> user needs to enable Tx HW timestamp capability via igc_ioctl() with
> SIOCSHWTSTAMP cmd before sending xsk Tx timestamp re
"Song, Yoong Siang" writes:
> On Tuesday, January 2, 2024 10:51 PM, Gomes, Vinicius
> wrote:
>>Song Yoong Siang writes:
>>
>>> This patch adds support to per-packet Tx hardware timestamp request to
>>> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that
>>> user needs to en
ut in the igb case, I haven't seen myself or heard about any issues
that seem related to this. So I think it's more like a possible issue.
But it seems like a good idea to fix it there was well.
Vinicius Costa Gomes (2):
igc: Fix missing time sync events
igb: Fix missing time
(3) it will be ignored, causing events to be
missed.
Remove the extra clear in (3).
Fixes: 2c344ae24501 ("igc: Add support for TX timestamping")
Signed-off-by: Vinicius Costa Gomes
---
drivers/net/ethernet/intel/igc/igc_main.c | 12 +---
1 file changed, 1 insertion(+), 11 d
ns between (1) and (3) it will be ignored, causing events to be
missed.
Remove the extra clear in (3).
Fixes: 00c65578b47b ("igb: enable internal PPS for the i210")
Signed-off-by: Vinicius Costa Gomes
---
drivers/net/ethernet/intel/igb/igb_main.c | 23 +--
1 fi
Richard Cochran writes:
> On Sat, Feb 17, 2024 at 07:05:07AM -0800, Richard Cochran wrote:
>
>> Does setting ICR.Time_Sync[TXTS] also clear ICR.Time_Sync[RXTS] ?
>>
>> That is what you seem to be saying.
>
> Okay, so you really mean that if the _same_ bit becomes set between
> the read and the a
he same double
clearing is present there.
But in the igb case, I haven't seen myself or heard about any issues
that seem related to this. So I think it's more like a possible issue.
But it seems like a good idea to fix it there was well.
Vinicius Costa Gomes (2):
igc: Fix missing time s
between (1) and (3) it will be ignored,
causing events to be missed.
Remove the extra clear in (3).
Fixes: 2c344ae24501 ("igc: Add support for TX timestamping")
Reviewed-by: Kurt Kanzenbach
Tested-by: Kurt Kanzenbach # Intel i225
Signed-off-by: Vinicius Costa Gomes
---
drivers/net/ethern
appens again between (1) and (3) it will be ignored,
causing events to be missed.
Remove the extra clear in (3).
Fixes: 00c65578b47b ("igb: enable internal PPS for the i210")
Acked-by: Richard Cochran
Signed-off-by: Vinicius Costa Gomes
---
drivers/net/ethernet/intel/igb/igb_ma
domain support. Remove the stale comment/FIXME.
>
> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
> Signed-off-by: Kurt Kanzenbach
> ---
Ugh, sorry for forgetting about that.
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
Song Yoong Siang writes:
> This patch adds support to per-packet Tx hardware timestamp request to
> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that
> user needs to enable Tx HW timestamp capability via igc_ioctl() with
> SIOCSHWTSTAMP cmd before sending xsk Tx hardware tim
all into igc_ptp_suspend(), so I believe the checking in igc_sxk_wakeup()
> should be enough to prevent the situation that you mentioned.
>
Oh, I missed that one, sorry. Then:
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
Piotr Kwapulinski writes:
> Add low level support for Admin Command Interface (ACI). ACI is the
> Firmware interface used by a driver to communicate with E610 adapter. Add
> the following ACI features:
> - data structures, macros, register definitions
> - commands handling
> - events handling
>
Piotr Kwapulinski writes:
> Add low level link management support for E610 device. Link management
> operations are handled via the Admin Command Interface. Add the following
> link management operations:
> - get link capabilities
> - set up link
> - get media type
> - get link status, link statu
"Kwapulinski, Piotr" writes:
>>-Original Message-
>>From: Gomes, Vinicius
>>Sent: Friday, April 5, 2024 2:04 AM
>>To: Kwapulinski, Piotr ;
>>intel-wired-...@lists.osuosl.org
>>Cc: Kwapulinski, Piotr ; net...@vger.kernel.org;
>>Jagielski, Jedrzej ; Michal Swiatkowski
>>; Wegrzyn, Stef
We can re-use the IGC_SET_FLAG() macro to simplify setting some values
in the TX data descriptor. With the macro it's easier to get the
meaning of the operations.
Signed-off-by: Vinicius Costa Gomes
---
drivers/net/ethernet/intel/igc/igc_main.c | 10 --
1 file changed, 4 inser
nternal latencies
for the free-running timestamps, decided to do the adjustments so the path
delay when using vclocks is similar to the one when using the physical clock.
One future improvement is to implement the .getcrosscycless() function.
Signed-off-by: Vinicius Costa Gomes
---
Vinicius Costa
e some changes at how the timestamps are done for RX, the
conversion and adjustment of timestamps are now done closer to the
consumption of the timestamp instead of near the reception.
Signed-off-by: Vinicius Costa Gomes
---
drivers/net/ethernet/intel/igc/igc.h | 21 ++-
drivers/net/ethe
heckpatch.pl doesn't seem to like.
Patches 4 and 5 read more like fixes to me. I think they could be
proposed to -net, as they contain fixes to user visible issues. Do you
think that makes sense?
As for the code, feel free to add my Ack to the series:
Acked-by: Vinici
Joe Damato writes:
> Link queues to NAPI instances via netdev-genl API so that users can
> query this information with netlink. Handle a few cases in the driver:
> 1. Link/unlink the NAPIs when XDP is enabled/disabled
> 2. Handle IGC_FLAG_QUEUE_PAIRS enabled and disabled
>
> Example output wh
Joe Damato writes:
> Greetings:
>
> This is an RFC to get feedback before submitting an actual series and
> because I have a question for igc maintainers, see below.
>
> This series addss support for netdev-genl to igc so that userland apps
> can query IRQ, queue, and NAPI instance relationships.
7;irq': 132},
> {'defer-hard-irqs': 0,
> 'gro-flush-timeout': 0,
> 'id': 8195,
> 'ifindex': 2,
> 'irq': 131},
> {'defer-hard-irqs': 0,
> 'gro-flush-timeout': 0,
> 'id': 8194,
> 'ifindex': 2,
> 'irq': 130},
> {'defer-hard-irqs': 0,
> 'gro-flush-timeout': 0,
> 'id': 8193,
> 'ifindex': 2,
> 'irq': 129}]
>
> Signed-off-by: Joe Damato
> ---
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump napi-get --json='{"ifindex": 2}'
> [{'id': 8196, 'ifindex': 2, 'irq': 148},
> {'id': 8195, 'ifindex': 2, 'irq': 147},
> {'id': 8194, 'ifindex': 2, 'irq': 146},
> {'id': 8193, 'ifindex': 2, 'irq': 145}]
>
> Now we examine which queues these NAPIs are associated with, expecting
> that since IGC_FLAG_QUEUE_PAIRS is disabled each RX and TX queue will
> have its own NAPI instance:
>
> $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump queue-get --json='{"ifindex": 2}'
> [{'id': 0, 'ifindex': 2, 'napi-id': 8193, 'type': 'rx'},
> {'id': 1, 'ifindex': 2, 'napi-id': 8194, 'type': 'rx'},
> {'id': 0, 'ifindex': 2, 'napi-id': 8195, 'type': 'tx'},
> {'id': 1, 'ifindex': 2, 'napi-id': 8196, 'type': 'tx'}]
>
> Signed-off-by: Joe Damato
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
Song Yoong Siang writes:
> Improve XDP_SETUP_PROG process by avoiding unnecessary link down/up event
> and hardware device reset.
>
Some examples of problems that these hardware resets are causing would
be good.
> Signed-off-by: Song Yoong Siang
> ---
The duplication of code doesn't look that
tadata prints:
> found skb hwtstamp = 1736509937.852786132
>
> Fixes: 069b142f5819 ("igc: Add support for PTP .getcyclesx64()")
> Signed-off-by: Zdenek Bouska
Acked-by: Vinicius Costa Gomes
Cheers,
--
Vinicius
49 matches
Mail list logo
