We can re-use the IGC_SET_FLAG() macro to simplify setting some values
in the TX data descriptor. With the macro it's easier to get the
meaning of the operations.

Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c 
b/drivers/net/ethernet/intel/igc/igc_main.c
index 293b45717683..6be8dd536e10 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -1299,14 +1299,12 @@ static void igc_tx_olinfo_status(struct igc_ring 
*tx_ring,
        u32 olinfo_status = paylen << IGC_ADVTXD_PAYLEN_SHIFT;
 
        /* insert L4 checksum */
-       olinfo_status |= (tx_flags & IGC_TX_FLAGS_CSUM) *
-                         ((IGC_TXD_POPTS_TXSM << 8) /
-                         IGC_TX_FLAGS_CSUM);
+       olinfo_status |= IGC_SET_FLAG(tx_flags, IGC_TX_FLAGS_CSUM,
+                                     (IGC_TXD_POPTS_TXSM << 8));
 
        /* insert IPv4 checksum */
-       olinfo_status |= (tx_flags & IGC_TX_FLAGS_IPV4) *
-                         (((IGC_TXD_POPTS_IXSM << 8)) /
-                         IGC_TX_FLAGS_IPV4);
+       olinfo_status |= IGC_SET_FLAG(tx_flags, IGC_TX_FLAGS_IPV4,
+                                     (IGC_TXD_POPTS_IXSM << 8));
 
        tx_desc->read.olinfo_status = cpu_to_le32(olinfo_status);
 }

-- 
2.41.0

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Reply via email to