Re: [Intel-wired-lan] [PATCH] e1000e: move force SMBUS near the end of enable_ulp function

2024-04-15 Thread Lifshits, Vitaly
On 4/13/2024 12:27 PM, Hui Wang wrote: The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue") introduces a regression on CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without this commit, the ethernet works well after suspend and resume, but after applyin

Re: [Intel-wired-lan] [PATCH] e1000e: move force SMBUS near the end of enable_ulp function

2024-04-17 Thread Lifshits, Vitaly
On 4/13/2024 12:27 PM, Hui Wang wrote: The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue") introduces a regression on CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without this commit, the ethernet works well after suspend and resume, but after applyin

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: Fix S0ix residency on Meteor Lake corporate systems

2024-05-29 Thread Lifshits, Vitaly
On 5/28/2024 1:43 PM, Paul Menzel wrote: Dear Vitaly, Thank you for the patch. Am 28.05.24 um 12:33 schrieb Vitaly Lifshits: From: Dima Ruinskiy On vPro systems,the  configuration of the I219-LM to achieve power s/,the  /, the / Thank you for noticing it. I will fix it in a v2. gat

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix force smbus during suspend flow

2024-06-19 Thread Lifshits, Vitaly
Hi Hui, On 6/14/2024 4:53 AM, Hui Wang wrote: Hi Vitaly I tested the patch on a laptop with the ethernet card [8086:550A], the system suspend and resume worked well with the cable plugged or unplugged. But I still think that reverting 2 regression commits is a better solution. Reverting th

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-06-20 Thread Lifshits, Vitaly
On 6/20/2024 9:47 AM, Paul Menzel wrote: Dear Vitaly, Thank you for your patch. For the summary, it’d be great if you could be more specific by saying it’s about limiting the scope. Am 20.06.24 um 08:36 schrieb Vitaly Lifshits: Commit 861e8086029e ("e1000e: move force SMBUS from enable u

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-06-23 Thread Lifshits, Vitaly
of your device is 80 and not 0 as usual, do you use virtualization features? If so, can you please disable them and retest? -Original Message- From: Lifshits, Vitaly Sent: Wednesday, June 19, 2024 11:37 PM To: intel-wired-lan@osuosl.org Cc: hui.w...@canonical.com; Lifshits, Vitaly ; Bra

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change I219 (19) devices to ADP

2024-08-18 Thread Lifshits, Vitaly
Dear Paul, On 8/15/2024 5:16 PM, Paul Menzel wrote: Dear Vitaly, Thank you for the patch. Am 15.08.24 um 15:11 schrieb Vitaly Lifshits: Change the MAC and board types of I219 (19) devices from MTP to ADP. These devices have hardware more closely related to ADP than MTP. According to what

Re: [Intel-wired-lan] [PATH iwl-next v1 1/1] e1000e: Minor flow correction in e1000_shutdown function

2024-01-04 Thread Lifshits, Vitaly
Dear Paul, Thank you for your comments. On 1/3/2024 5:27 PM, Paul Menzel wrote: Dear Vitaly, Thank you for the patch. In the commit message summary, it’d be great if you used a statement by adding a verb in imperative mood. Maybe: Correct flow in e1000_shutdown() Am 03.01.24 um 09:50 sch

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue

2024-02-29 Thread Lifshits, Vitaly
On 2/12/2024 11:00 AM, Paul Menzel wrote: Dear Vitaly, Thank you for your patch. Am 11.02.24 um 16:12 schrieb Vitaly Lifshits: Forcing SMBUS inside the ULP enabling flow leads to sporadic PHY loss on some systems. Please list the systems you know of. On some Meteor-lake systems, we also

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue

2024-02-29 Thread Lifshits, Vitaly
On 2/29/2024 4:31 PM, Paul Menzel wrote: Dear Vitaly, Thank you for your reply. Am 29.02.24 um 11:34 schrieb Lifshits, Vitaly: On 2/12/2024 11:00 AM, Paul Menzel wrote: Am 11.02.24 um 16:12 schrieb Vitaly Lifshits: Forcing SMBUS inside the ULP enabling flow leads to sporadic PHY

Re: [Intel-wired-lan] [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure_tx/rx()

2024-09-05 Thread Lifshits, Vitaly
On 9/4/2024 3:36 PM, Vitaly Lifshits wrote: On 9/4/2024 3:13 PM, Andrew Lunn wrote: On Wed, Sep 04, 2024 at 02:56:46PM +0900, Takamitsu Iwai wrote: So you have confirmed with the datsheet that the write is not needed? As i said, this is a hardware register, not memory. Writes are not always

Re: [Intel-wired-lan] igc: Network failure, reboot required: igc: Failed to read reg 0xc030!

2024-09-13 Thread Lifshits, Vitaly
On 9/12/2024 10:45 PM, Jesper Juhl wrote: Would you be able to decode the stack trace? It may be helpful to figure out which line of code this is: igc_update_stats+0x8a/0x6d0 [igc 22e0a697bfd5a86bd5c20d279bfffd 131de6bb32] Of course. Just tell me what to do. - Jesper On Thu, 12 Sept 202

Re: [Intel-wired-lan] igc: Network failure, reboot required: igc: Failed to read reg 0xc030!

2024-09-15 Thread Lifshits, Vitaly
On 9/14/2024 12:52 AM, Jesper Juhl wrote: On Fri, 13 Sept 2024 at 09:02, Lifshits, Vitaly wrote: On 9/12/2024 10:45 PM, Jesper Juhl wrote: Would you be able to decode the stack trace? It may be helpful to figure out which line of code this is: igc_update_stats+0x8a/0x6d0 [igc

Re: [Intel-wired-lan] [PATCH RFC net-next] e1000e: Fix real-time violations on link up

2024-10-15 Thread Lifshits, Vitaly
On 10/14/2024 8:59 PM, Gerhard Engleder wrote: On 12.10.24 20:42, Andrew Lunn wrote: On Fri, Oct 11, 2024 at 09:54:12PM +0200, Gerhard Engleder wrote: From: Gerhard Engleder Link down and up triggers update of MTA table. This update executes many PCIe writes and a final flush. Thus, PCIe w

Re: [Intel-wired-lan] e1000e preventing sleep and causing repeated desktop hangs

2024-10-06 Thread Lifshits, Vitaly
On 10/4/2024 1:31 PM, Yonatan Avhar wrote: [1.] One line summary of the problem: When suspending my Lenovo ThinkPad P14s Gen 5 (Intel) with the latest Fedora 40 kernel, the system fails to suspend, then begins to hang/stutter every few seconds. [2.] Full description of the problem/report:

Re: [Intel-wired-lan] [PATCH v2 net-next] e1000e: makes e1000_watchdog_task use queue_delayed_work

2024-10-05 Thread Lifshits, Vitaly
On 10/2/2024 7:59 PM, Dmitrii Ermakov wrote: Replaces watchdog timer with delayed_work as advised in the driver's TODO comment. Signed-off-by: Dmitrii Ermakov --- V1 -> V2: Removed redundant line wraps, renamed e1000_watchdog to e1000_watchdog_work drivers/net/ethernet/intel/e1000e/e1000

Re: [Intel-wired-lan] [net-next v3 2/2] igc: Link queues to NAPI instances

2024-10-22 Thread Lifshits, Vitaly
On 10/21/2024 8:48 PM, Vinicius Costa Gomes wrote: Joe Damato writes: Link queues to NAPI instances via netdev-genl API so that users can query this information with netlink. Handle a few cases in the driver: 1. Link/unlink the NAPIs when XDP is enabled/disabled 2. Handle IGC_FLAG_QUE

Re: [Intel-wired-lan] [net-next v3 1/2] igc: Link IRQs to NAPI instances

2024-10-22 Thread Lifshits, Vitaly
On 10/21/2024 8:48 PM, Vinicius Costa Gomes wrote: Joe Damato writes: Link IRQs to NAPI instances via netdev-genl API so that users can query this information with netlink. Compare the output of /proc/interrupts (noting that IRQ 144 is the "other" IRQ which does not appear to have a NAPI i

Re: [Intel-wired-lan] [PATCH iwl-next v5 2/2] igc: Link queues to NAPI instances

2024-10-29 Thread Lifshits, Vitaly
On 10/28/2024 9:52 PM, Joe Damato wrote: Link queues to NAPI instances via netdev-genl API so that users can query this information with netlink. Handle a few cases in the driver: 1. Link/unlink the NAPIs when XDP is enabled/disabled 2. Handle IGC_FLAG_QUEUE_PAIRS enabled and disabled E

Re: [Intel-wired-lan] [PATCH iwl-next v6 2/2] igc: Link queues to NAPI instances

2024-10-30 Thread Lifshits, Vitaly
On 10/29/2024 10:12 PM, Joe Damato wrote: Link queues to NAPI instances via netdev-genl API so that users can query this information with netlink. Handle a few cases in the driver: 1. Link/unlink the NAPIs when XDP is enabled/disabled 2. Handle IGC_FLAG_QUEUE_PAIRS enabled and disabled

Re: [Intel-wired-lan] [iwl-next v4 2/2] igc: Link queues to NAPI instances

2024-10-27 Thread Lifshits, Vitaly
On 10/23/2024 12:52 AM, Joe Damato wrote: Link queues to NAPI instances via netdev-genl API so that users can query this information with netlink. Handle a few cases in the driver: 1. Link/unlink the NAPIs when XDP is enabled/disabled 2. Handle IGC_FLAG_QUEUE_PAIRS enabled and disabled E

Re: [Intel-wired-lan] [PATCH iwl-next v6 1/2] igc: Link IRQs to NAPI instances

2024-10-30 Thread Lifshits, Vitaly
On 10/29/2024 10:12 PM, Joe Damato wrote: Link IRQs to NAPI instances via netdev-genl API so that users can query this information with netlink. Compare the output of /proc/interrupts (noting that IRQ 128 is the "other" IRQ which does not appear to have a NAPI instance): $ cat /proc/interrup

Re: [Intel-wired-lan] [net-next v3 1/2] e1000e: Link NAPI instances to queues and IRQs

2024-10-01 Thread Lifshits, Vitaly
On 10/1/2024 1:50 PM, Simon Horman wrote: On Mon, Sep 30, 2024 at 05:12:31PM +, Joe Damato wrote: Add support for netdev-genl, allowing users to query IRQ, NAPI, and queue information. After this patch is applied, note the IRQs assigned to my NIC: $ cat /proc/interrupts | grep ens | cut

Re: [Intel-wired-lan] I226-V 1G limited to ~250Mbit with ASPM enabled

2024-12-08 Thread Lifshits, Vitaly
On 12/6/2024 6:06 PM, ValdikSS wrote: Hello Intel team, I have Intel NUC13ANKI5 machine, with I226-V network card, and gigabit Internet connection. After (presumably) latest UEFI v0033 update for the NUC, my network is limited to ~250 Mbit/s download unless I disable PCIE ASPM option in

Re: [Intel-wired-lan] [PATCH v2 RESEND net-next] e1000e: makes e1000_watchdog_task use queue_delayed_work

2025-01-06 Thread Lifshits, Vitaly
On 1/5/2025 1:38 PM, Dmitrii Ermakov wrote: Replaces watchdog timer with delayed_work as advised in the driver's TODO comment. Signed-off-by: Dmitrii Ermakov --- V1 -> V2: Removed redundant line wraps, renamed e1000_watchdog to e1000_watchdog_work drivers/net/ethernet/intel/e1000e/e1000.

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-01-30 Thread Lifshits, Vitaly
On 1/30/2025 7:11 PM, Stephen Hemminger wrote: I am using: 5a:00.0 Ethernet controller: Intel Corporation Ethernet Controller I226-LM (rev 04) Subsystem: Intel Corporation Device Flags: bus master, fast devsel, latency 0, IRQ 19, IOMMU group 20 Memory at 6c50

Re: [Intel-wired-lan] [PATCH] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

2025-02-04 Thread Lifshits, Vitaly
On 2/2/2025 7:08 PM, Piotr Wejman wrote: Update the driver to the new hw timestamping API. > Signed-off-by: Piotr Wejman --- drivers/net/ethernet/intel/e1000e/e1000.h | 2 +- drivers/net/ethernet/intel/e1000e/netdev.c | 52 -- 2 files changed, 20 insertions(+), 34 de

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-02-05 Thread Lifshits, Vitaly
On 1/31/2025 3:21 AM, Stephen Hemminger wrote: On Thu, 30 Jan 2025 21:17:30 +0200 "Lifshits, Vitaly" wrote: On 1/30/2025 7:11 PM, Stephen Hemminger wrote: I am using: 5a:00.0 Ethernet controller: Intel Corporation Ethernet Controller I226-LM (rev 04) Subsystem: Intel C

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-02-06 Thread Lifshits, Vitaly
On 2/6/2025 6:13 AM, Stephen Hemminger wrote: On Wed, 5 Feb 2025 12:36:31 +0200 "Lifshits, Vitaly" wrote: On 1/31/2025 3:21 AM, Stephen Hemminger wrote: On Thu, 30 Jan 2025 21:17:30 +0200 "Lifshits, Vitaly" wrote: On 1/30/2025 7:11 PM, Stephen Hemminger wrote:

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-02-11 Thread Lifshits, Vitaly
On 2/6/2025 10:09 PM, Stephen Hemminger wrote: On Thu, 6 Feb 2025 15:17:00 +0200 "Lifshits, Vitaly" wrote: On 2/6/2025 6:13 AM, Stephen Hemminger wrote: On Wed, 5 Feb 2025 12:36:31 +0200 "Lifshits, Vitaly" wrote: On 1/31/2025 3:21 AM, Stephen Hemminger wrote: On

Re: [Intel-wired-lan] [PATCH v2] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

2025-02-12 Thread Lifshits, Vitaly
On 2/8/2025 5:43 PM, Piotr Wejman wrote: Update the driver to use the new hardware timestamping API added in commit 66f7223039c0 ("net: add NDOs for configuring hardware timestamping"). Use Netlink extack for error reporting in e1000e_hwtstamp_set. Align the indentation of net_device_ops. Sig

Re: [Intel-wired-lan] [PATCH iwl-next v3] e1000e: Fix real-time violations on link up

2024-12-16 Thread Lifshits, Vitaly
On 12/14/2024 9:16 PM, Gerhard Engleder wrote: From: Gerhard Engleder Link down and up triggers update of MTA table. This update executes many PCIe writes and a final flush. Thus, PCIe will be blocked until all writes are flushed. As a result, DMA transfers of other targets suffer from delay

Re: [Intel-wired-lan] [PATCH] igc: Return early when failing to read EECD register

2024-12-16 Thread Lifshits, Vitaly
On 12/17/2024 3:23 AM, Chia-Lin Kao (AceLan) wrote: On Mon, Dec 16, 2024 at 06:53:10AM +0100, Przemek Kitszel wrote: On 12/16/24 06:14, Chia-Lin Kao (AceLan) wrote: When booting with a dock connected, the igc driver can get stuck for ~40 seconds if PCIe link is lost during initialization. T

Re: [Intel-wired-lan] [PATCH iwl-next v4] e1000e: Fix real-time violations on link up

2024-12-22 Thread Lifshits, Vitaly
On 12/19/2024 9:27 PM, Gerhard Engleder wrote: From: Gerhard Engleder Link down and up triggers update of MTA table. This update executes many PCIe writes and a final flush. Thus, PCIe will be blocked until all writes are flushed. As a result, DMA transfers of other targets suffer from delay

Re: [Intel-wired-lan] [PATCH iwl-net v2] igc: return early when failing to read EECD register

2024-12-22 Thread Lifshits, Vitaly
On 12/18/2024 4:37 AM, En-Wei Wu wrote: When booting with a dock connected, the igc driver may get stuck for ~40 seconds if PCIe link is lost during initialization. This happens because the driver access device after EECD register reads return all F's, indicating failed reads. Consequently, h

Re: [Intel-wired-lan] I226-V 1G limited to ~250Mbit with ASPM enabled

2025-01-22 Thread Lifshits, Vitaly
On 1/22/2025 4:57 PM, ValdikSS wrote: On 09.12.2024 12:21 PM, ValdikSS wrote: After (presumably) latest UEFI v0033 update for the NUC, my network is limited to ~250 Mbit/s download unless I disable PCIE ASPM option in UEFI settings. 56:00.0 Ethernet controller [0200]: Intel Corporation Ether

Re: [Intel-wired-lan] [PATCH net-next 2/3] igc: Remove unused igc_read/write_pci_cfg wrappers

2025-01-05 Thread Lifshits, Vitaly
On 1/2/2025 7:41 PM, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" igc_read_pci_cfg() and igc_write_pci_cfg were added in 2018 as part of commit 146740f9abc4 ("igc: Add support for PF") but have remained unused. Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: V

Re: [Intel-wired-lan] [PATCH net-next 1/3] igc: Remove unused igc_acquire/release_nvm

2025-01-05 Thread Lifshits, Vitaly
On 1/2/2025 7:41 PM, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" igc_acquire_nvm() and igc_release_nvm() were added in 2018 as part of commit ab4056126813 ("igc: Add NVM support") but never used. Remove them. The igc_1225.c has it's own specific implementations. Signed-off-by

Re: [Intel-wired-lan] [PATCH net-next 3/3] igc: Remove unused igc_read/write_pcie_cap_reg

2025-01-05 Thread Lifshits, Vitaly
On 1/2/2025 7:41 PM, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" The last uses of igc_read_pcie_cap_reg() and igc_write_pcie_cap_reg() were removed in 2019 by commit 16ecd8d9af26 ("igc: Remove the obsolete workaround") Remove them. Signed-off-by: Dr. David Alan Gilbert Revie

Re: [Intel-wired-lan] e1000e: How to set parameters using sysfs?

2025-02-23 Thread Lifshits, Vitaly
On 2/18/2025 5:59 PM, Paul Menzel wrote: Dear Linux folks, The driver e1000e has several parameters [1]:     $ modinfo e1000e     filename: /lib/modules/6.6.35.mx64.477/kernel/drivers/net/ethernet/intel/e1000e/e1000e.ko     […]     alias:  pci:v8086d105Esv*sd*bc*sc*i

Re: [Intel-wired-lan] igc: forcing speed configuration (no auto-neg) on I255

2025-02-23 Thread Lifshits, Vitaly
On 2/19/2025 1:14 PM, Mateusz Kusiak wrote: Hi all, I've done research regarding igc driver and I225 ethernet controller. I established that neither igc driver nor hardware (I255) support forced speed configuration (disabling auto-negotiation to be exact). Could anybody please confirm this?

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change k1 exit timeout on MTP and later platforms

2025-02-25 Thread Lifshits, Vitaly
On 2/24/2025 3:53 PM, Paul Menzel wrote: Dear Vitaly, Thank you for your patch. Am 24.02.25 um 11:12 schrieb Vitaly Lifshits: LAN devices starting from Meteorlake the interface between the MAC and Meteor Lake the PHY has a different frequency. The sentences reads a little strange. Ma

Re: [Intel-wired-lan] [PATCH iwl-next v3] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

2025-02-18 Thread Lifshits, Vitaly
On 2/18/2025 2:59 PM, Simon Horman wrote: On Sun, Feb 16, 2025 at 04:57:28PM +0100, Piotr Wejman wrote: Update the driver to use the new hardware timestamping API added in commit 66f7223039c0 ("net: add NDOs for configuring hardware timestamping"). Use Netlink extack for error reporting in e1

Re: [Intel-wired-lan] [PATCH] e1000e: Link flap workaround option for false IRP events

2025-03-02 Thread Lifshits, Vitaly
Hi Mark, Hi Andrew On Thu, Feb 27, 2025, at 11:07 AM, Andrew Lunn wrote: + e1e_rphy(hw, PHY_REG(772, 26), &phy_data); Please add some #define for these magic numbers, so we have some idea what PHY register you are actually reading. That in itself might help explain h

Re: [Intel-wired-lan] [PATCH] e1000e: Link flap workaround option for false IRP events

2025-03-04 Thread Lifshits, Vitaly
On 3/3/2025 5:34 AM, Mark Pearson wrote: Hi Andrew, On Sun, Mar 2, 2025, at 11:13 AM, Andrew Lunn wrote: On Sun, Mar 02, 2025 at 03:09:35PM +0200, Lifshits, Vitaly wrote: Hi Mark, Hi Andrew On Thu, Feb 27, 2025, at 11:07 AM, Andrew Lunn wrote: + e1e_rphy(hw

Re: [Intel-wired-lan] e1000e/I219-LM: Speed negotiation problems

2025-03-04 Thread Lifshits, Vitaly
On 3/3/2025 5:30 PM, Paul Menzel wrote: Dear Linux folks, On a Dell OptiPlex 7000/0F1HC1, BIOS 1.8.2 12/08/2022 with     00:1f.6 Ethernet controller [0200]: Intel Corporation Ethernet Connection (17) I219-LM [8086:1a1c] (rev 11) and Dell OptiPlex 7071/097YXY, BIOS 1.1.2 08/29/2019 with