Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events

2024-08-09 Thread Daiwei Li
Hi, It appears this change breaks PTP on the 82580 controller, as ptp4l reports: > timed out while polling for tx timestamp increasing tx_timestamp_timeout or > increasing kworker priority may correct this issue, but a driver bug likely > causes it The 82580 controller has a hardware bug in whic

Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events

2024-08-12 Thread Daiwei Li
> Of course, I'll prepare a patch for that. Excellent, thank you! On Fri, Aug 9, 2024 at 9:39 AM Vinicius Costa Gomes wrote: > > Daiwei Li writes: > > > Hi, > > > > It appears this change breaks PTP on the 82580 controller, as ptp4l reports: > > >

Re: [Intel-wired-lan] [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-12 Thread Daiwei Li
> @Daiwei Li, I don't have a 82580 handy, please confirm that the patch fixes the issue you are having. Thank you for the patch! I can confirm it fixes my issue. Below I offer a patch that also works in response to Paul's feedback. > Please also add a description of the test ca

[Intel-wired-lan] [PATCH iwl-net v2] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-13 Thread Daiwei Li
mail.gmail.com/ Tested-by: Daiwei Li Signed-off-by: Daiwei Li --- @Vinicius Gomes, this is my first time submitting a Linux kernel patch, so apologies if I missed any part of the procedure (e.g. this is currently on top of 6.7.12, the kernel I am running; should I be rebasing on inline?). Also, is ther

[Intel-wired-lan] [PATCH iwl-net v3] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-14 Thread Daiwei Li
@mail.gmail.com/ Tested-by: Daiwei Li Suggested-by: Vinicius Costa Gomes Signed-off-by: Daiwei Li --- drivers/net/ethernet/intel/igb/igb_main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.

Re: [Intel-wired-lan] [PATCH iwl-net v2] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-14 Thread Daiwei Li
Thank you for the review! I've sent out another patch that hopefully addresses the comments. On Tue, Aug 13, 2024 at 3:26 PM Vinicius Costa Gomes wrote: > > Daiwei Li writes: > > > 82580 NICs have a hardware bug that makes it > > necessary to write into the TSICR