[Intel-wired-lan] [PATCH iwl-next v8 00/15] ixgbe: Add basic devlink support

2025-03-13 Thread Jedrzej Jagielski
Create devlink specific directory for more convenient future feature development. Flashing and reloading are supported only by E610 devices. Introduce basic FW/NVM validation since devlink reload introduces possibility of runtime NVM update. Check FW API version, FW recovery mode and FW rollback

[Intel-wired-lan] [PATCH iwl-next v8 11/15] ixgbe: add device flash update via devlink

2025-03-13 Thread Jedrzej Jagielski
Use the pldmfw library to implement device flash update for the Intel ixgbe networking device driver specifically for E610 devices. This support uses the devlink flash update interface. Using the pldmfw library, the provided firmware file will be scanned for the three major components, "fw.undi" f

[Intel-wired-lan] [PATCH iwl-next v8 05/15] ixgbe: add E610 functions for acquiring flash data

2025-03-13 Thread Jedrzej Jagielski
From: Slawomir Mrozowicz Read NVM related info from the flash. Add several helper functions used to access the flash data, find memory banks, calculate offsets, calculate the flash size. Reviewed-by: Przemek Kitszel Reviewed-by: Mateusz Polchlopek Tested-by: Bharath R Signed-off-by: Slawomir

[Intel-wired-lan] [PATCH iwl-next v8 07/15] ixgbe: read the netlist version information

2025-03-13 Thread Jedrzej Jagielski
From: Slawomir Mrozowicz Add functions reading the netlist version info and use them as a part of the setting NVM info procedure. Reviewed-by: Mateusz Polchlopek Tested-by: Bharath R Signed-off-by: Slawomir Mrozowicz Co-developed-by: Piotr Kwapulinski Signed-off-by: Piotr Kwapulinski Signed

[Intel-wired-lan] [PATCH iwl-next v8 01/15] devlink: add value check to devlink_info_version_put()

2025-03-13 Thread Jedrzej Jagielski
Prevent from proceeding if there's nothing to print. Suggested-by: Przemek Kitszel Reviewed-by: Jiri Pirko Reviewed-by: Kalesh AP Tested-by: Bharath R Signed-off-by: Jedrzej Jagielski --- net/devlink/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/devlink/dev.c

[Intel-wired-lan] [PATCH iwl-next v8 02/15] ixgbe: wrap netdev_priv() usage

2025-03-13 Thread Jedrzej Jagielski
From: Przemek Kitszel Wrap use of netdev_priv() in order to change the allocator of the device private structure from alloc_etherdev_mq() to the devlink in next commit. All but one netdev_priv() calls in the whole driver are replaced, the remaining one is called on MACVLAN (so not ixgbe) device.

[Intel-wired-lan] [PATCH iwl-next v8 03/15] ixgbe: add initial devlink support

2025-03-13 Thread Jedrzej Jagielski
Add an initial support for devlink interface to ixgbe driver. Similarly to i40e driver the implementation doesn't enable devlink to manage device-wide configuration. Devlink instance is created for each physical function of PCIe device. Create separate directory for devlink related ixgbe files an

[Intel-wired-lan] [PATCH iwl-next v8 12/15] ixgbe: add support for devlink reload

2025-03-13 Thread Jedrzej Jagielski
The E610 adapters contain an embedded chip with firmware which can be updated using devlink flash. The firmware which runs on this chip is referred to as the Embedded Management Processor firmware (EMP firmware). Activating the new firmware image currently requires that the system be rebooted. Thi

[Intel-wired-lan] [PATCH iwl-next v8 13/15] ixgbe: add FW API version check

2025-03-13 Thread Jedrzej Jagielski
Add E610 specific function checking whether the FW API version is compatible with the driver expectations. The major API version should be less than or equal to the expected API version. If not the driver won't be fully operational. Check the minor version, and if it is more than two versions les

[Intel-wired-lan] [PATCH iwl-next v8 15/15] ixgbe: add support for FW rollback mode

2025-03-13 Thread Jedrzej Jagielski
From: Andrii Staikov The driver should detect whether the device entered FW rollback mode and then notify user with the dedicated message including FW and NVM versions. Even if the driver detected rollback mode, this should not result in an probe error and the normal flow proceeds. FW tries to

[Intel-wired-lan] [PATCH iwl-next v8 06/15] ixgbe: read the OROM version information

2025-03-13 Thread Jedrzej Jagielski
From: Slawomir Mrozowicz Add functions reading the OROM version info and use them as a part of the setting NVM info procedure. Reviewed-by: Mateusz Polchlopek Reviewed-by: Przemek Kitszel Tested-by: Bharath R Signed-off-by: Slawomir Mrozowicz Co-developed-by: Piotr Kwapulinski Signed-off-by

[Intel-wired-lan] [PATCH iwl-next v8 14/15] ixgbe: add E610 implementation of FW recovery mode

2025-03-13 Thread Jedrzej Jagielski
Add E610 implementation of fw_recovery_mode MAC operation. In case of E610 information about recovery mode is obtained from FW_MODES field in IXGBE_GL_MNG_FWSM register (0x000B6134). Introduce recovery specific probing flow and init only vital features. User should be able to perform NVM update

[Intel-wired-lan] [PATCH iwl-next v8 04/15] ixgbe: add handler for devlink .info_get()

2025-03-13 Thread Jedrzej Jagielski
Provide devlink .info_get() callback implementation to allow the driver to report detailed version information. The following info is reported: "serial_number" -> The PCI DSN of the adapter "fw.bundle_id" -> Unique identifier for the combined flash image "fw.undi" -> Version of the Option ROM c

[Intel-wired-lan] [PATCH iwl-next v8 09/15] ixgbe: add E610 functions getting PBA and FW ver info

2025-03-13 Thread Jedrzej Jagielski
Introduce 2 E610 specific callbacks implementations: -ixgbe_start_hw_e610() which expands the regular .start_hw callback with getting FW version information -ixgbe_read_pba_string_e610() which gets Product Board Assembly string Extend EEPROM ops with new .read_pba_string in order to distinguish ge

[Intel-wired-lan] [PATCH iwl-net v4 1/1] e1000e: change k1 configuration on MTP and later platforms

2025-03-13 Thread Vitaly Lifshits
Starting from Meteor Lake, the Kumeran interface between the integrated MAC and the I219 PHY works at a different frequency. This causes sporadic MDI errors when accessing the PHY, and in rare circumstances could lead to packet corruption. To overcome this, introduce minor changes to the Kumeran i

Re: [Intel-wired-lan] [PATCH net v2 2/5] renesas: reject PTP_STRICT_FLAGS as unsupported

2025-03-13 Thread Niklas Söderlund
Hi Jacob, Thanks for your work. On 2025-03-12 15:15:51 -0700, Jacob Keller wrote: > The ravb_ptp_extts() function checks the flags coming from the > PTP_EXTTS_REQUEST ioctl, to ensure that future flags are not accepted on > accident. > > This was updated to 'honor' the PTP_STRICT_FLAGS in commit

[Intel-wired-lan] [PATCH iwl-next] igc: enable HW vlan tag insertion/stripping by default

2025-03-13 Thread Rui Salvaterra
This is enabled by default in other Intel drivers I've checked (e1000, e1000e, iavf, igb and ice). Fixes an out-of-the-box performance issue when running OpenWrt on typical mini-PCs with igc-supported Ethernet controllers and 802.1Q VLAN configurations, as ethtool isn't part of the default packages

[Intel-wired-lan] [PATCH iwl-next v3] ice: add E830 Earliest TxTime First Offload support

2025-03-13 Thread Paul Greenwalt
E830 supports Earliest TxTime First (ETF) hardware offload, which is configured via the ETF Qdisc (see tc-etf(8)). ETF introduces a new Tx flow mechanism that utilizes a timestamp ring (tstamp_ring) alongside the standard Tx ring. This timestamp ring is used to indicate when hardware will transmit

Re: [Intel-wired-lan] [PATCH iwl-next v3] igc: Change Tx mode for MQPRIO offloading

2025-03-13 Thread Vladimir Oltean
On Tue, Mar 11, 2025 at 04:03:57PM +0800, Abdul Rahim, Faizal wrote: > On 7/3/2025 11:02 pm, Vladimir Oltean wrote: > > How do you and Faizal plan to serialize your changes on these flags? > > You delete IGC_FLAG_TSN_LEGACY_ENABLED and he adds > > IGC_FLAG_TSN_PREEMPT_ENABLED. > > From what I’ve e

Re: [Intel-wired-lan] [PATCH net-next 08/16] idpf: make complq cleaning dependent on scheduling mode

2025-03-13 Thread Alexander Lobakin
From: Maciej Fijalkowski Date: Fri, 7 Mar 2025 12:11:05 +0100 > On Wed, Mar 05, 2025 at 05:21:24PM +0100, Alexander Lobakin wrote: >> From: Michal Kubiak >> >> Extend completion queue cleaning function to support queue-based >> scheduling mode needed for XDP queues. >> Add 4-byte descriptor for

Re: [Intel-wired-lan] [PATCH net-next 10/16] idpf: add support for nointerrupt queues

2025-03-13 Thread Alexander Lobakin
From: Maciej Fijalkowski Date: Fri, 7 Mar 2025 13:10:29 +0100 > On Wed, Mar 05, 2025 at 05:21:26PM +0100, Alexander Lobakin wrote: >> Currently, queues are associated 1:1 with interrupt vectors as it's >> assumed queues are always interrupt-driven. >> In order to use a queue without an interrupt,

Re: [Intel-wired-lan] [PATCH net-next 09/16] idpf: remove SW marker handling from NAPI

2025-03-13 Thread Alexander Lobakin
From: Maciej Fijalkowski Date: Fri, 7 Mar 2025 12:42:10 +0100 > On Wed, Mar 05, 2025 at 05:21:25PM +0100, Alexander Lobakin wrote: >> From: Michal Kubiak >> >> SW marker descriptors on completion queues are used only when a queue >> is about to be destroyed. It's far from hotpath and handling it

[Intel-wired-lan] [PATCH v9 iwl-next 04/10] idpf: negotiate PTP capabilities and get PTP clock

2025-03-13 Thread Milena Olech
PTP capabilities are negotiated using virtchnl command. Add get capabilities function, direct access to read the PTP clock time and direct access to read the cross timestamp - system time and PTP clock time. Set initial PTP capabilities exposed to the stack. Reviewed-by: Alexander Lobakin Reviewe

[Intel-wired-lan] [PATCH v9 iwl-next 03/10] idpf: move virtchnl structures to the header file

2025-03-13 Thread Milena Olech
Move virtchnl structures to the header file to expose them for the PTP virtchnl file. Reviewed-by: Alexander Lobakin Reviewed-by: Willem de Bruijn Tested-by: Mina Almasry Signed-off-by: Milena Olech --- v1 -> v2: fix commit message title .../net/ethernet/intel/idpf/idpf_virtchnl.c | 86 +--

[Intel-wired-lan] [PATCH v9 iwl-next 02/10] virtchnl: add PTP virtchnl definitions

2025-03-13 Thread Milena Olech
PTP capabilities are negotiated using virtchnl commands. There are two available modes of the PTP support: direct and mailbox. When the direct access to PTP resources is negotiated, virtchnl messages returns a set of registers that allow read/write directly. When the mailbox access to PTP resources

[Intel-wired-lan] [PATCH v9 iwl-next 00/10] idpf: add initial PTP support

2025-03-13 Thread Milena Olech
This patch series introduces support for Precision Time Protocol (PTP) to Intel(R) Infrastructure Data Path Function (IDPF) driver. PTP feature is supported when the PTP capability is negotiated with the Control Plane (CP). IDPF creates a PTP clock and sets a set of supported functions. During the

[Intel-wired-lan] [PATCH v9 iwl-next 01/10] idpf: add initial PTP support

2025-03-13 Thread Milena Olech
PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the capabilities recognition. Initial PTP support includes PTP initialization and registration of the clock. Reviewed-by: Alexander Lobakin Reviewed-by: Vadim Fedorenko Reviewed-by: Willem de Bruijn Tested-by: Mina Almasry

[Intel-wired-lan] [PATCH v9 iwl-next 05/10] idpf: add mailbox access to read PTP clock time

2025-03-13 Thread Milena Olech
When the access to read PTP clock is specified as mailbox, the driver needs to send virtchnl message to perform PTP actions. Message is sent using idpf_mbq_opc_send_msg_to_peer_drv mailbox opcode, with the parameters received during PTP capabilities negotiation. Add functions to recognize PTP mess

[Intel-wired-lan] [PATCH v9 iwl-next 07/10] idpf: add Tx timestamp capabilities negotiation

2025-03-13 Thread Milena Olech
Tx timestamp capabilities are negotiated for the uplink Vport. Driver receives information about the number of available Tx timestamp latches, the size of Tx timestamp value and the set of indexes used for Tx timestamping. Add function to get the Tx timestamp capabilities and parse the uplink vpor

[Intel-wired-lan] [PATCH v9 iwl-next 09/10] idpf: add support for Rx timestamping

2025-03-13 Thread Milena Olech
Add Rx timestamp function when the Rx timestamp value is read directly from the Rx descriptor. In order to extend the Rx timestamp value to 64 bit in hot path, the PHC time is cached in the receive groups. Add supported Rx timestamp modes. Tested-by: YiFei Zhu Tested-by: Mina Almasry Signed-off-

[Intel-wired-lan] [PATCH iwl-next v8 10/15] ixgbe: extend .info_get with() stored versions

2025-03-13 Thread Jedrzej Jagielski
Add functions reading inactive versions from the inactive flash bank. Print stored NVM, OROM and netlist versions by devlink when there is an ongoing update for E610 device. Reviewed-by: Mateusz Polchlopek Reviewed-by: Przemek Kitszel Tested-by: Bharath R Co-developed-by: Slawomir Mrozowicz S

[Intel-wired-lan] [PATCH v9 iwl-next 08/10] idpf: add Tx timestamp flows

2025-03-13 Thread Milena Olech
Add functions to request Tx timestamp for the PTP packets, read the Tx timestamp when the completion tag for that packet is being received, extend the Tx timestamp value and set the supported timestamping modes. Tx timestamp is requested for the PTP packets by setting a TSYN bit and index value in

[Intel-wired-lan] [PATCH v9 iwl-next 10/10] idpf: change the method for mailbox workqueue allocation

2025-03-13 Thread Milena Olech
Since workqueues are created per CPU, the works scheduled to this workqueues are run on the CPU they were assigned. It may result in overloaded CPU that is not able to handle virtchnl messages in relatively short time. Allocating workqueue with WQ_UNBOUND and WQ_HIGHPRI flags allows scheduler to qu

[Intel-wired-lan] [PATCH v9 iwl-next 06/10] idpf: add PTP clock configuration

2025-03-13 Thread Milena Olech
PTP clock configuration operations - set time, adjust time and adjust frequency are required to control the clock and maintain synchronization process. Extend get PTP capabilities function to request for the clock adjustments and add functions to enable these actions using dedicated virtchnl messa

[Intel-wired-lan] [PATCH iwl-next v8 08/15] ixgbe: add .info_get extension specific for E610 devices

2025-03-13 Thread Jedrzej Jagielski
E610 devices give possibility to show more detailed info than the previous boards. Extend reporting NVM info with following pieces: fw.mgmt.api -> version number of the API fw.mgmt.build -> identifier of the source for the FW fw.psid.api -> version defining the format of the flash contents fw.n

[Intel-wired-lan] [PATCH net v2 3/5] net: lan743x: reject unsupported external timestamp requests

2025-03-13 Thread Jacob Keller
The lan743x_ptp_io_event_cap_en() function checks that the given request sets only one of PTP_RISING_EDGE or PTP_FALLING_EDGE, but not both. However, this driver does not check whether other flags (such as PTP_EXT_OFF) are set, nor whether any future unrecognized flags are set. Fix this by adding

Re: [Intel-wired-lan] [iwl-next v4 1/1] iidc/ice/irdma: Update IDC to support multiple consumers

2025-03-13 Thread Samudrala, Sridhar
On 3/2/2025 12:26 AM, Leon Romanovsky wrote: On Wed, Feb 26, 2025 at 11:01:52PM +, Ertman, David M wrote: -Original Message- From: Leon Romanovsky Sent: Wednesday, February 26, 2025 10:50 AM To: Ertman, David M Cc: Nikolova, Tatyana E ; j...@nvidia.com; intel-wired-...@lists.

Re: [Intel-wired-lan] [PATCH iwl-next v7 11/15] ixgbe: add device flash update via devlink

2025-03-13 Thread Jagielski, Jedrzej
From: Simon Horman Sent: Wednesday, March 12, 2025 3:56 PM >On Wed, Mar 12, 2025 at 01:58:39PM +0100, Jedrzej Jagielski wrote: > >... > >> diff --git a/Documentation/networking/devlink/ixgbe.rst >> b/Documentation/networking/devlink/ixgbe.rst >> index a41073a62776..41aedf4b8017 100644 >> --- a/

Re: [Intel-wired-lan] [PATCH iwl-net] ice: ensure periodic output start time is in the future

2025-03-13 Thread Rinitha, SX
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: 20 February 2025 03:43 > To: Nguyen, Anthony L ; Kitszel, Przemyslaw > ; Kubalewski, Arkadiusz > ; Kolacinski, Karol > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Keller, Jacob E > Sub