> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, March 7, 2025 7:54 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nguyen, Anthony L ;
> net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Mrozowicz,
> SlawomirX ; Polchlopek, Mateusz
> ;
On Wed, Mar 12, 2025 at 01:58:39PM +0100, Jedrzej Jagielski wrote:
...
> diff --git a/Documentation/networking/devlink/ixgbe.rst
> b/Documentation/networking/devlink/ixgbe.rst
> index a41073a62776..41aedf4b8017 100644
> --- a/Documentation/networking/devlink/ixgbe.rst
> +++ b/Documentation/netwo
The descriptor structure is the same in ice, ixgbe and i40e. Move it to
common libie header to use it across different driver.
Leave device specific adminq commands in separate folders. This lead to
a change that need to be done in filling/getting descriptor:
- previous: struct specific_desc *cmd;
Use libie_aq_desc instead of i40e_aq_desc. Do needed changes to allow
clean build.
Get version descriptor is a little less detailed on i40e. To not mess up
with shifting or union inside libie desc use get version descriptor from
i40e.
Move additional caps for i40e to libie.
Fix RCT in declaratio
An issue is observed on the i210 when autonegotiation advertisement is set
to a specific subset of the supported speeds but the requested settings
are not correctly set in the Copper Auto-Negotiation Advertisement Register
(Page 0, Register 4).
Initially, the advertisement register is correctly set
On Sun, Mar 09, 2025 at 06:46:36AM -0400, Faizal Rahim wrote:
> From: Vladimir Oltean
>
> It appears that stmmac is not the only hardware which requires a
> software-driven verification state machine for the MAC Merge layer.
>
> While on the one hand it's good to encourage hardware implementatio
On Sun, Mar 09, 2025 at 06:46:40AM -0400, Faizal Rahim wrote:
> In preparation for an upcoming patch that will modify the TX buffer size
> in TSN mode, replace IGC_TXPBSIZE_TSN and IGC_TXPBSIZE_DEFAULT
> implementation with new macros that utilizes FIELD_PREP and GENMASK for
> clarity.
>
> The ne
On Sun, Mar 09, 2025 at 06:46:45AM -0400, Faizal Rahim wrote:
> Add support for setting tx-min-frag-size via the set_mm callback in igc.
> If the requested value is unsupported, round it up to the smallest
> supported i226 size (64, 128, 192, 256) and send a netlink message to
> inform the user.
>
On Sun, Mar 09, 2025 at 06:46:42AM -0400, Faizal Rahim wrote:
> Prepare for an upcoming patch that modifies the RX buffer size in TSN mode.
> Refactor IGC_RXPBSIZE_EXP_BMC_DEFAULT and IGC_RXPBS_CFG_TS_EN using
> FIELD_PREP and GENMASK to improve clarity and maintainability. Refactor
> both macros f
On Sun, Mar 09, 2025 at 06:46:44AM -0400, Faizal Rahim wrote:
> This patch implements the "ethtool --set-mm" callback to trigger the
> frame preemption verification handshake.
>
> Uses the MAC Merge Software Verification (mmsv) mechanism in ethtool
> to perform the verification handshake for igc.
On Sun, Mar 09, 2025 at 06:46:47AM -0400, Faizal Rahim wrote:
> Implement "ethtool --show-mm" callback for IGC.
>
> Tested with command:
> $ ethtool --show-mm enp1s0.
> MAC Merge layer state for enp1s0:
> pMAC enabled: on
> TX enabled: on
> TX active: on
> TX minimum fragment size: 64
>
gcc-13.2.0
arc axs103_defconfigclang-21
arc defconfiggcc-14.2.0
arc randconfig-001-20250312clang-21
arc randconfig-001-20250312gcc-13.2.0
arc randconfig-002-20250312
On Sun, Mar 09, 2025 at 06:46:36AM -0400, Faizal Rahim wrote:
> @@ -7850,7 +7850,7 @@ int stmmac_suspend(struct device *dev)
> rtnl_unlock();
>
> if (stmmac_fpe_supported(priv))
> - timer_shutdown_sync(&priv->fpe_cfg.verify_timer);
> + ethtool_mmsv_stop(&priv->
On Wed, Mar 12, 2025 at 04:22:50PM +1300, Hamish Martin wrote:
> An issue is observed on the i210 when autonegotiation advertisement is set
> to a specific subset of the supported speeds but the requested settings
> are not correctly set in the Copper Auto-Negotiation Advertisement Register
> (Page
Use the pldmfw library to implement device flash update for
the Intel ixgbe networking device driver specifically for E610 devices.
This support uses the devlink flash update interface.
Using the pldmfw library, the provided firmware file will be scanned for
the three major components, "fw.undi" f
From: Przemek Kitszel
Wrap use of netdev_priv() in order to change the allocator of the device
private structure from alloc_etherdev_mq() to the devlink in next commit.
All but one netdev_priv() calls in the whole driver are replaced, the
remaining one is called on MACVLAN (so not ixgbe) device.
Prevent from proceeding if there's nothing to print.
Suggested-by: Przemek Kitszel
Reviewed-by: Jiri Pirko
Reviewed-by: Kalesh AP
Tested-by: Bharath R
Signed-off-by: Jedrzej Jagielski
---
net/devlink/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/devlink/dev.c
From: Jakub Kicinski
Date: Thu, 6 Mar 2025 17:12:08 -0800
> On Wed, 5 Mar 2025 17:21:27 +0100 Alexander Lobakin wrote:
>> +/**
>> + * idpf_xdp_is_prog_ena - check if there is an XDP program on adapter
>> + * @vport: vport to check
>> + */
>> +static inline bool idpf_xdp_is_prog_ena(const struct
On 3/10/2025 4:12 AM, Karol Kolacinski wrote:
Initialize TSPLL after initializing PHC in ice_ptp.c instead of calling
for each product in PHC init in ice_ptp_hw.c.
Reviewed-by: Michal Kubiak
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/ice_
From: Maciej Fijalkowski
Date: Fri, 7 Mar 2025 11:51:18 +0100
> On Wed, Mar 05, 2025 at 05:21:23PM +0100, Alexander Lobakin wrote:
>> Add the missing linking of NAPIs to netdev queues when enabling
>> interrupt vectors in order to support NAPI configuration and
>> interfaces requiring get_rx_queu
On Sun, Mar 09, 2025 at 06:46:48AM -0400, Faizal Rahim wrote:
> +/**
> + * igc_ethtool_get_frame_ass_error - Get the frame assembly error count.
> + * @reg_value: Register value for IGC_PRMEXCPRCNT
> + * Return: The count of frame assembly errors.
> + */
> +static u64 igc_ethtool_get_frame_ass_erro
From: Andrii Staikov
The driver should detect whether the device entered FW rollback
mode and then notify user with the dedicated message including
FW and NVM versions.
Even if the driver detected rollback mode, this should not result
in an probe error and the normal flow proceeds.
FW tries to
The E610 adapters contain an embedded chip with firmware which can be
updated using devlink flash. The firmware which runs on this chip is
referred to as the Embedded Management Processor firmware (EMP
firmware).
Activating the new firmware image currently requires that the system be
rebooted. Thi
E610 devices give possibility to show more detailed info than the previous
boards.
Extend reporting NVM info with following pieces:
fw.mgmt.api -> version number of the API
fw.mgmt.build -> identifier of the source for the FW
fw.psid.api -> version defining the format of the flash contents
fw.n
Introduce 2 E610 specific callbacks implementations:
-ixgbe_start_hw_e610() which expands the regular .start_hw callback with
getting FW version information
-ixgbe_read_pba_string_e610() which gets Product Board Assembly string
Extend EEPROM ops with new .read_pba_string in order to distinguish
ge
> -Original Message-
> From: Kitszel, Przemyslaw
> Sent: Tuesday, March 11, 2025 10:15 AM
> To: Kyungwook Boo
> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Loktionov,
> Aleksandr ; Nguyen, Anthony L
>
> Subject: Re: [PATCH iwl-next v2] i40e: fix MMIO write access to a
Create devlink specific directory for more convenient future feature
development.
Flashing and reloading are supported only by E610 devices.
Introduce basic FW/NVM validation since devlink reload introduces
possibility of runtime NVM update. Check FW API version, FW recovery mode
and FW rollback
From: Slawomir Mrozowicz
Add functions reading the OROM version info and use them
as a part of the setting NVM info procedure.
Reviewed-by: Mateusz Polchlopek
Reviewed-by: Przemek Kitszel
Tested-by: Bharath R
Signed-off-by: Slawomir Mrozowicz
Co-developed-by: Piotr Kwapulinski
Signed-off-by
Add an initial support for devlink interface to ixgbe driver.
Similarly to i40e driver the implementation doesn't enable
devlink to manage device-wide configuration. Devlink instance
is created for each physical function of PCIe device.
Create separate directory for devlink related ixgbe files
an
From: Slawomir Mrozowicz
Read NVM related info from the flash.
Add several helper functions used to access the flash data,
find memory banks, calculate offsets, calculate the flash size.
Reviewed-by: Przemek Kitszel
Reviewed-by: Mateusz Polchlopek
Tested-by: Bharath R
Signed-off-by: Slawomir
Provide devlink .info_get() callback implementation to allow the
driver to report detailed version information. The following info
is reported:
"serial_number" -> The PCI DSN of the adapter
"fw.bundle_id" -> Unique identifier for the combined flash image
"fw.undi" -> Version of the Option ROM c
From: Slawomir Mrozowicz
Add functions reading the netlist version info and use them
as a part of the setting NVM info procedure.
Reviewed-by: Mateusz Polchlopek
Tested-by: Bharath R
Signed-off-by: Slawomir Mrozowicz
Co-developed-by: Piotr Kwapulinski
Signed-off-by: Piotr Kwapulinski
Signed
Add E610 specific function checking whether the FW API version
is compatible with the driver expectations.
The major API version should be less than or equal to the expected
API version. If not the driver won't be fully operational.
Check the minor version, and if it is more than two versions les
Add functions reading inactive versions from the inactive flash
bank.
Print stored NVM, OROM and netlist versions by devlink when there
is an ongoing update for E610 device.
Reviewed-by: Mateusz Polchlopek
Reviewed-by: Przemek Kitszel
Tested-by: Bharath R
Co-developed-by: Slawomir Mrozowicz
S
Add E610 implementation of fw_recovery_mode MAC operation.
In case of E610 information about recovery mode is obtained
from FW_MODES field in IXGBE_GL_MNG_FWSM register (0x000B6134).
Introduce recovery specific probing flow and init only
vital features.
User should be able to perform NVM update
From: Maciej Fijalkowski
Date: Fri, 7 Mar 2025 11:32:15 +0100
> On Wed, Mar 05, 2025 at 05:21:22PM +0100, Alexander Lobakin wrote:
>> Currently, the maximum number of queues available for one vport is 16.
>> This is hardcoded, but then the function calculating the optimal number
>> of queues take
From: Eric Dumazet
Date: Fri, 7 Mar 2025 11:28:36 +0100
> On Wed, Mar 5, 2025 at 5:22 PM Alexander Lobakin
> wrote:
>>
>> Add the missing linking of NAPIs to netdev queues when enabling
>> interrupt vectors in order to support NAPI configuration and
>> interfaces requiring get_rx_queue()->napi t
From: Maciej Fijalkowski
Date: Fri, 7 Mar 2025 11:15:56 +0100
> On Wed, Mar 05, 2025 at 05:21:20PM +0100, Alexander Lobakin wrote:
>> Add the following counterparts of functions from libeth_xdp which need
>> special care on XSk path:
>>
>> * building &xdp_buff (head and frags);
>> * running XDP p
On 3/11/25 23:15, Joao Bonifacio wrote:
Static variables in C are implicitly initialized to zero,
so there is no need to explicitly set
and to 0. This change removes the redundant initialization
Thank you for reaching out, and sorry, but this change by itself is too
trivial, see:
https://www.k
From: Maciej Fijalkowski
Date: Fri, 7 Mar 2025 11:17:11 +0100
> On Wed, Mar 05, 2025 at 05:21:21PM +0100, Alexander Lobakin wrote:
>> No idea what the current barrier position was meant for. At that point,
>> nothing is read from the descriptor, only the pointer to the actual one
>> is fetched.
>
On Sun, Mar 09, 2025 at 06:46:37AM -0400, Faizal Rahim wrote:
> When the link partner goes down, "ethtool --show-mm" still displays
> "Verification status: SUCCEEDED," reflecting a previous state that is
> no longer valid.
>
> Reset the verification status to ensure it reflects the current state.
randconfig-001-20250312gcc-13.2.0
arc randconfig-002-20250312gcc-13.2.0
arm allmodconfiggcc-14.2.0
arm allyesconfiggcc-14.2.0
arm randconfig-001-20250312clang-19
arm
Use libie_aq_desc instead of ixgbe_aci_desc. Do needed changes to allow
clean build.
Move additional caps used in ixgbe to libie.
Reviewed-by: Przemek Kitszel
Reviewed-by: Aleksandr Loktionov
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h | 12 +-
.../eth
On Sun, Mar 09, 2025 at 06:46:46AM -0400, Faizal Rahim wrote:
> Since preemptible tc implementation is not ready yet, block it from being
> set in taprio. The existing code already blocks it in mqprio.
>
> Signed-off-by: Faizal Rahim
> ---
Reviewed-by: Vladimir Oltean
-20250312gcc-13.2.0
arc randconfig-002-20250312gcc-13.2.0
arm allmodconfiggcc-14.2.0
arm allyesconfiggcc-14.2.0
arm randconfig-001-20250312clang-19
arm randconfig-002
> -Original Message-
> From: Michal Swiatkowski
> Sent: Monday, March 10, 2025 11:04 PM
> To: Keller, Jacob E
> Cc: Nguyen, Anthony L ; Kitszel, Przemyslaw
> ; Andrew Lunn ; David
> S. Miller ; Eric Dumazet ; Jakub
> Kicinski ; Paolo Abeni ; Richard Cochran
> ; Ruud Bos ; Paul Barker
>
On 3/10/2025 4:12 AM, Karol Kolacinski wrote:
Collect TSPLL related functions and definitions and move them to
a separate file to have all TSPLL functionality in one place.
Move CGU related functions and definitions to ice_common.*
You lost changes with the move, specifically 4c9f13a65426 (
In preparation for adding .supported_extts_flags and
.supported_perout_flags to the ptp_clock_info structure, fix a couple of
places where drivers get existing flag gets grossly incorrect.
The igb driver claims 82580 supports strictly validating PTP_RISING_EDGE
and PTP_FALLING_EDGE, but doesn't ac
> Hi Andrew,
>
> Thanks for your feedback. I'll try and give more detail about what's
> happening with a concrete example.
>
> If we start with the device in a state where it is advertising:
> 1000BaseT Full
> 100baseT Full
> 100baseT Half
> 10baseT Full
> 10baseT Half
> I see the following setti
On Wed, 2025-03-12 at 23:25 +0100, Andrew Lunn wrote:
> > Hi Andrew,
> >
> > Thanks for your feedback. I'll try and give more detail about
> > what's
> > happening with a concrete example.
> >
> > If we start with the device in a state where it is advertising:
> > 1000BaseT Full
> > 100baseT Full
On Wed, 2025-03-12 at 14:05 +0100, Andrew Lunn wrote:
> On Wed, Mar 12, 2025 at 04:22:50PM +1300, Hamish Martin wrote:
> > An issue is observed on the i210 when autonegotiation advertisement
> > is set
> > to a specific subset of the supported speeds but the requested
> > settings
> > are not corre
On 3/12/2025 3:58 PM, Tony Nguyen wrote:
On 3/10/2025 4:12 AM, Karol Kolacinski wrote:
...
Reviewed-by: Michal Kubiak
Reviewed-by: Milena Olech
Milena's address is wrong, should be: milena.ol...@intel.com
Signed-off-by: Karol Kolacinski
On 2/27/2025 5:13 AM, Milena Olech wrote:
> +/**
> + * idpf_ptp_set_rx_tstamp - Enable or disable Rx timestamping
> + * @vport: Virtual port structure
> + * @rx_filter: bool value for whether timestamps are enabled or disabled
> + */
> +static void idpf_ptp_set_rx_tstamp(struct idpf_vport *vport
The ptp_ocp_signal_from_perout() function supports PTP_PEROUT_DUTY_CYCLE
and PTP_PEROUT_PHASE. It does not support PTP_PEROUT_ONE_SHOT, but does not
reject a request with such an unsupported flag.
Add the appropriate check to ensure that unsupported requests are rejected
both for PTP_PEROUT_ONE_SH
The ravb_ptp_extts() function checks the flags coming from the
PTP_EXTTS_REQUEST ioctl, to ensure that future flags are not accepted on
accident.
This was updated to 'honor' the PTP_STRICT_FLAGS in commit 6138e687c7b6
("ptp: Introduce strict checking of external time stamp options.").
However, the
In bcm_ptp_perout_locked, the driver rejects requests which have
PTP_PEROUT_PHASE set. This appears to be an attempt to reject any
unsupported flags. Unfortunately, this only checks one flag, but does not
protect against PTP_PEROUT_ONE_SHOT, or any future flags which may be
added.
Fix the check to
The igb_ptp_feature_enable_82580 function correctly checks that unknown
flags are not passed to the function. However, it does not actually check
PTP_RISING_EDGE or PTP_FALLING_EDGE when configuring the external timestamp
function.
The data sheet for the 82580 product says:
Upon a change in the
On 3/10/2025 4:12 AM, Karol Kolacinski wrote:
Rename TSPLL and CGU functions, definitions etc. to match the file name
and have constistent naming scheme.
s/constistent/consistent
Patches 2-4 do not compile stand-alone.
Reviewed-by: Michal Kubiak
Reviewed-by: Milena Olech
Signed-off-by:
On 3/10/2025 4:12 AM, Karol Kolacinski wrote:
...
+/**
+ * ice_tspll_default_freq - Return default frequency for a MAC type
+ * @mac_type: MAC type
+ */
+static enum ice_tspll_freq ice_tspll_default_freq(enum ice_mac_type mac_type)
...
+/**
+ * ice_tspll_check_params - Check if TSPLL par
59 matches
Mail list logo
