On 3/10/2025 4:12 AM, Karol Kolacinski wrote:
Collect TSPLL related functions and definitions and move them to a separate file to have all TSPLL functionality in one place. Move CGU related functions and definitions to ice_common.*
You lost changes with the move, specifically 4c9f13a65426 ("ice: use string choice helpers"). Please restore them. Also, please use the change/helper in patch 4.
Checkpatch reports missing SPDX: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #1323: FILE: drivers/net/ethernet/intel/ice/ice_tspll.c:1: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #1972: FILE: drivers/net/ethernet/intel/ice/ice_tspll.h:1:
Reviewed-by: Michal Kubiak <michal.kub...@intel.com> Reviewed-by: Milena Olech <milena-ol...@intel.com> Signed-off-by: Karol Kolacinski <karol.kolacin...@intel.com> --- drivers/net/ethernet/intel/ice/Makefile | 2 +- drivers/net/ethernet/intel/ice/ice.h | 1 + drivers/net/ethernet/intel/ice/ice_cgu_regs.h | 181 ----- drivers/net/ethernet/intel/ice/ice_common.c | 61 ++ drivers/net/ethernet/intel/ice/ice_common.h | 176 +++++ drivers/net/ethernet/intel/ice/ice_ptp.c | 1 - .../net/ethernet/intel/ice/ice_ptp_consts.h | 161 ----- drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 542 --------------- drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 43 -- drivers/net/ethernet/intel/ice/ice_tspll.c | 643 ++++++++++++++++++ drivers/net/ethernet/intel/ice/ice_tspll.h | 43 ++ 11 files changed, 925 insertions(+), 929 deletions(-) delete mode 100644 drivers/net/ethernet/intel/ice/ice_cgu_regs.h create mode 100644 drivers/net/ethernet/intel/ice/ice_tspll.c create mode 100644 drivers/net/ethernet/intel/ice/ice_tspll.h
