> -Original Message-
> From: Marcin Szycik
> Sent: Tuesday, February 11, 2025 11:13 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; michal.swiatkow...@linux.intel.com; Marcin
> Szycik ; Buvaneswaran, Sujai
> ; Martyna Szapar-Mudlaw
>
> Subject: [PATCH iwl-net 1/2]
> -Original Message-
> From: Marcin Szycik
> Sent: Tuesday, February 11, 2025 11:13 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; michal.swiatkow...@linux.intel.com; Marcin
> Szycik ; Buvaneswaran, Sujai
> ; Martyna Szapar-Mudlaw
>
> Subject: [PATCH iwl-net 2/2]
On Fri Feb 21 2025, Abdul Rahim, Faizal wrote:
> On 17/2/2025 7:45 pm, Kurt Kanzenbach wrote:
>> The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
>> this mode the hardware uses four packet buffers and considers queue
>> priorities.
>>
>> In order to harmonize the TAPRIO im
Dear Grzegorz,
Thank you for the patch.
Am 21.02.25 um 11:16 schrieb Grzegorz Nitka:
Add E825C 10GbE SGMII device to the list of devices supporting 100Mbit
link mode. Without that change, 100Mbit link mode is ignored in ethtool
interface. This change was missed while adding the support for E82
On Fri, Feb 21, 2025 at 09:30:09PM +0800, Abdul Rahim, Faizal wrote:
> On 21/2/2025 6:43 pm, Vladimir Oltean wrote:
> > On Fri, Feb 21, 2025 at 06:24:09PM +0800, Furong Xu wrote:
> > > Your fix is better when link is up/down, so I vote verify_enabled.
> >
> > Hmmm... I thought this was a bug in st
From: Przemek Kitszel
Wrap use of netdev_priv() in order to change the allocator of the device
private structure from alloc_etherdev_mq() to the devlink in next commit.
All but one netdev_priv() calls in the whole driver are replaced, the
remaining one is called on MACVLAN (so not ixgbe) device.
On Wed, Feb 19, 2025 at 06:06:51PM -0800, Jakub Kicinski wrote:
> On Wed, 19 Feb 2025 08:39:08 +0100 Kurt Kanzenbach wrote:
> > > My comment from the previous series still stands, which simply that
> > > I have no idea if the maintainers will accept changes using this API
> > > or prefer to wait un
Dear Grzegorz, dear Karol,
Thank you for your patch.
Am 21.02.25 um 13:31 schrieb Grzegorz Nitka:
From: Karol Kolacinski
Due to the bug in FW/NVM autoload mechanism (wrong default
SB_REM_DEV_CTL register settings), the access to peer PHY and CGU
clients was disabled by default.
I’d add a b
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Kurt Kanzenbach
> Sent: Monday, February 17, 2025 12:31 PM
> To: Nguyen, Anthony L ; Kitszel, Przemyslaw
>
> Cc: Andrew Lunn ; David S. Miller
> ; Eric Dumazet ; Jakub
> Kicinski ; Paolo Abeni ; Sebastian
> Andrzej Siewior ; Da
> -Original Message-
> From: Intel-wired-lan On Behalf Of Joe
> Damato
> Sent: Tuesday, February 18, 2025 10:15 PM
> To: Kurt Kanzenbach
> Cc: Nguyen, Anthony L ; Kitszel, Przemyslaw
> ; Andrew Lunn ;
> David S. Miller ; Eric Dumazet
> ; Jakub Kicinski ; Paolo Abeni
> ; Sebastian Andrz
The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610
device") introduced incorrect media type detection for E610 device. It
reproduces when advertised speed is modified after driver reload. Clear
the previous outdated PHY type high value.
Reproduction steps:
modprobe ixgbe
ethtool
Dear Piotr,
Thank you for the improved version. Two minor nits should you resend.
Am 21.02.25 um 14:53 schrieb Piotr Kwapulinski:
The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610
device") introduced incorrect media type detection for E610 device. It
reproduces when advert
This patch series adds full support for timesync operations for E8225C
devices which are configured in so called 2xNAC mode (Network
Acceleration Complex). 2xNAC mode is the mode in which IO die
is housing two complexes and each of them has its own PHY connected
to it. The complex which controls ti
From: Karol Kolacinski
According to the E825C specification, SBQ address for ports on a single
complex is device 2 for PHY 0 and device 13 for PHY1.
For accessing ports on a dual complex E825C (so called 2xNAC mode),
the driver should use destination device 2 (referred as phy_0) for
the current c
From: Karol Kolacinski
Due to the bug in FW/NVM autoload mechanism (wrong default
SB_REM_DEV_CTL register settings), the access to peer PHY and CGU
clients was disabled by default.
As the workaround solution, the register value was overwritten by the
driver at the probe or reset handling.
Remove
From: Karol Kolacinski
Rename ice_sbq_msg_dev to ice_sbq_dev_id to reflect the meaning of this
type more precisely. This enum type describes RDA (Remote Device Access)
client ids, accessible over SB (Side Band) interface.
Rename enum elements to make a driver namespace more cleaner and
consistent
On 21/2/2025 6:43 pm, Vladimir Oltean wrote:
On Fri, Feb 21, 2025 at 06:24:09PM +0800, Furong Xu wrote:
Your fix is better when link is up/down, so I vote verify_enabled.
Hmmm... I thought this was a bug in stmmac that was carried over to
ethtool_mmsv, but it looks like it isn't.
In fact,
Prevent from proceeding if there's nothing to print.
Suggested-by: Przemek Kitszel
Reviewed-by: Jiri Pirko
Signed-off-by: Jedrzej Jagielski
---
net/devlink/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/devlink/dev.c b/net/devlink/dev.c
index d6e3db300acb..026027
Create devlink specific directory for more convenient future feature
development.
Flashing and reloading are supported only by E610 devices.
Introduce basic FW/NVM validation since devlink reload introduces
possibility of runtime NVM update. Check FW API version, FW recovery mode
and FW rollback
From: Slawomir Mrozowicz
Add functions reading the OROM version info and use them
as a part of the setting NVM info procedure.
Reviewed-by: Mateusz Polchlopek
Reviewed-by: Przemek Kitszel
Signed-off-by: Slawomir Mrozowicz
Co-developed-by: Piotr Kwapulinski
Signed-off-by: Piotr Kwapulinski
S
Use the pldmfw library to implement device flash update for
the Intel ixgbe networking device driver specifically for E610 devices.
This support uses the devlink flash update interface.
Using the pldmfw library, the provided firmware file will be scanned for
the three major components, "fw.undi" f
From: Andrii Staikov
The driver should detect whether the device entered FW rollback
mode and then notify user with the dedicated message including
FW and NVM versions.
Even if the driver detected rollback mode, this should not result
in an probe error and the normal flow proceeds.
FW tries to
The E610 adapters contain an embedded chip with firmware which can be
updated using devlink flash. The firmware which runs on this chip is
referred to as the Embedded Management Processor firmware (EMP
firmware).
Activating the new firmware image currently requires that the system be
rebooted. Thi
Provide devlink .info_get() callback implementation to allow the
driver to report detailed version information. The following info
is reported:
"serial_number" -> The PCI DSN of the adapter
"fw.bundle_id" -> Unique identifier for the combined flash image
"fw.undi" -> Version of the Option ROM c
E610 devices give possibility to show more detailed info than the previous
boards.
Extend reporting NVM info with following pieces:
fw.mgmt.api -> version number of the API
fw.mgmt.build -> identifier of the source for the FW
fw.psid.api -> version defining the format of the flash contents
fw.n
Add E610 specific function checking whether the FW API version
is compatible with the driver expectations.
The major API version should be less than or equal to the expected
API version. If not the driver won't be fully operational.
Check the minor version, and if it is more than two versions les
Add an initial support for devlink interface to ixgbe driver.
Similarly to i40e driver the implementation doesn't enable
devlink to manage device-wide configuration. Devlink instance
is created for each physical function of PCIe device.
Create separate directory for devlink related ixgbe files
an
From: Slawomir Mrozowicz
Read NVM related info from the flash.
Add several helper functions used to access the flash data,
find memory banks, calculate offsets, calculate the flash size.
Reviewed-by: Przemek Kitszel
Reviewed-by: Mateusz Polchlopek
Signed-off-by: Slawomir Mrozowicz
Co-develop
From: Slawomir Mrozowicz
Add functions reading the netlist version info and use them
as a part of the setting NVM info procedure.
Reviewed-by: Mateusz Polchlopek
Signed-off-by: Slawomir Mrozowicz
Co-developed-by: Piotr Kwapulinski
Signed-off-by: Piotr Kwapulinski
Signed-off-by: Jedrzej Jagie
On Fri, Feb 21, 2025 at 05:42:49PM +0800, Furong Xu wrote:
> > +void ethtool_mmsv_link_state_handle(struct ethtool_mmsv *mmsv, bool up)
> > +{
> > + unsigned long flags;
> > +
> > + ethtool_mmsv_stop(mmsv);
> > +
> > + spin_lock_irqsave(&mmsv->lock, flags);
> > +
> > + if (up && mmsv->pmac_
Add E825C 10GbE SGMII device to the list of devices supporting 100Mbit
link mode. Without that change, 100Mbit link mode is ignored in ethtool
interface. This change was missed while adding the support for E825C
devices family.
Fixes: f64e189442332 ("ice: introduce new E825C devices family")
Signe
On Fri, Feb 21, 2025 at 06:24:09PM +0800, Furong Xu wrote:
> Your fix is better when link is up/down, so I vote verify_enabled.
Hmmm... I thought this was a bug in stmmac that was carried over to
ethtool_mmsv, but it looks like it isn't.
In fact, looking at the original refactoring patch I had at
-ci/archive/20250221/202502212058.5xvt80wb-...@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project
ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build):
(https://download.01.org/0day-ci/archive/20250221/202502212058.5xvt80wb-...@intel.com
On Fri, 21 Feb 2025 11:56:51 +0200, Vladimir Oltean
wrote:
> On Fri, Feb 21, 2025 at 05:42:49PM +0800, Furong Xu wrote:
> > > +void ethtool_mmsv_link_state_handle(struct ethtool_mmsv *mmsv, bool up)
> > > +{
> > > + unsigned long flags;
> > > +
> > > + ethtool_mmsv_stop(mmsv);
> > > +
> > > + sp
diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c
b/drivers/net/ethernet/intel/igc/igc_tsn.c
index
1e44374ca1ffbb86e9893266c590f318984ef574..6e4582de9602db2c6667f1736cc2acaa4d4b5201
100644
--- a/drivers/net/ethernet/intel/igc/igc_tsn.c
+++ b/drivers/net/ethernet/intel/igc/igc_tsn.c
@@ -4
E82X adapters do not have sequential IDs, lane number is PF ID.
Add check for ICE_MAC_GENERIC and skip checking port options.
Also, adjust logical port number for specific E825 device with external
PHY support (PCI device id 0x579F). For this particular device,
with 2x25G (PHY0) and 2x10G (PHY1)
Add E610 implementation of fw_recovery_mode MAC operation.
In case of E610 information about recovery mode is obtained
from FW_MODES field in IXGBE_GL_MNG_FWSM register (0x000B6134).
Introduce recovery specific probing flow and init only
vital features.
User should be able to perform NVM update
Introduce 2 E610 specific callbacks implementations:
-ixgbe_start_hw_e610() which expands the regular .start_hw callback with
getting FW version information
-ixgbe_read_pba_string_e610() which gets Product Board Assembly string
Extend EEPROM ops with new .read_pba_string in order to distinguish
ge
Add functions reading inactive versions from the inactive flash
banks.
Print stored NVM, OROM and netlist versions by devlink when there
is an ongoing update for E610 devices.
Reviewed-by: Mateusz Polchlopek
Reviewed-by: Przemek Kitszel
Co-developed-by: Slawomir Mrozowicz
Signed-off-by: Slawom
On Fri, 21 Feb 2025 15:53:26 -0500 Joe Damato wrote:
> > No strong preference. If rtnl_lock is not causing any issues
> > in this driver, the we can merge as is. I haven't followed
> > the past discussions, tho.
>
> Don't mean to side-track this thread, but does this mean you've
> changed your
The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610
device") introduced incorrect media type detection for E610 device. It
reproduces when advertised speed is modified after driver reload. Clear
the previous outdated PHY type high value.
Reproduction steps:
modprobe ixgbe
ethtool
On Wed, 19 Feb 2025 21:53:41 -0500, Faizal Rahim
wrote:
> From: Vladimir Oltean
>
> It appears that stmmac is not the only hardware which requires a
> software-driven verification state machine for the MAC Merge layer.
>
> While on the one hand it's good to encourage hardware implementations,
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
40GbE
head: bb3bb6c92e5719c0f5d7adb9d34db7e76705ac33
commit: 06e75161b9d4833518a7c266310a0635eab50616 [7/39] net: wangxun: Add
support for PTP clock
config: i386-buildonly-randconfig-005-20250222
(https://download.01.
On 2/20/2025 11:29 PM, Michal Swiatkowski wrote:
> On Thu, Feb 20, 2025 at 02:45:41PM -0800, Jacob Keller wrote:
>>
>>
>> On 2/19/2025 1:37 AM, Michal Swiatkowski wrote:
>>> On Tue, Feb 18, 2025 at 04:46:34PM -0800, Jacob Keller wrote:
From: Paul Greenwalt
With E830 Get Tx Topolo
On 2/20/2025 5:45 PM, Jakub Kicinski wrote:
> On Wed, 19 Feb 2025 17:32:54 +0100 Przemek Kitszel wrote:
>> Add a support for whole device devlink instance. Intented as a entity
>> over all PF devices on given physical device.
>>
>> In case of ice driver we have multiple PF devices (with their de
On 21/2/2025 10:44 pm, Vladimir Oltean wrote:
On Fri, Feb 21, 2025 at 09:30:09PM +0800, Abdul Rahim, Faizal wrote:
On 21/2/2025 6:43 pm, Vladimir Oltean wrote:
On Fri, Feb 21, 2025 at 06:24:09PM +0800, Furong Xu wrote:
Your fix is better when link is up/down, so I vote verify_enabled.
Hmm
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
40GbE
head: bb3bb6c92e5719c0f5d7adb9d34db7e76705ac33
commit: ce114069a654be6b1597da983a201c72ceca7a85 [8/39] net: wangxun: Support
to get ts info
config: i386-buildonly-randconfig-005-20250222
(https://download.01.org
47 matches
Mail list logo
