This patchset fix the dma API misuse problem as mentioned in [1].
>From the below performance data, the overhead is not so obvious
due to performance variations in arm64 server and less than 1 ns in
x86 server for time_bench_page_pool01_fast_path() and
time_bench_page_pool02_ptr_ring, and there is
On Wed, Feb 05, 2025 at 08:20:21PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> SA replay mode is initialized differently for user-space and
> kernel-space users, but the call to xfrm_init_replay() existed in
> common path with boolean protection. That caused to situation where
> we
Hi folks,
Our LNST testing team uncovered a crash in ixgbe when running an XDP
program, see this report:
https://bugzilla.redhat.com/show_bug.cgi?id=2343204
>From looking at the code, it seems to me that the culprit is this commit:
c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp(
On Wed, Feb 12, 2025 at 01:33:09PM +0100, Toke Høiland-Jørgensen wrote:
> Hi folks,
>
> Our LNST testing team uncovered a crash in ixgbe when running an XDP
> program, see this report:
> https://bugzilla.redhat.com/show_bug.cgi?id=2343204
>
> From looking at the code, it seems to me that the culp
On 2/8/2025 5:43 PM, Piotr Wejman wrote:
Update the driver to use the new hardware timestamping API added in commit
66f7223039c0 ("net: add NDOs for configuring hardware timestamping").
Use Netlink extack for error reporting in e1000e_hwtstamp_set.
Align the indentation of net_device_ops.
Sig
On Wed, Feb 12, 2025 at 09:07:18AM +0100, Paul Menzel wrote:
> Dear Michal, dear Paul,
>
>
> Thank you for your patch. For the summary/title you could use:
>
> ixgbe: Support Malicious Driver Detection (MDD)
>
> Am 12.02.25 um 08:57 schrieb Michal Swiatkowski:
> > From: Paul Greenwalt
> >
> >
Maciej Fijalkowski writes:
> On Wed, Feb 12, 2025 at 01:33:09PM +0100, Toke Høiland-Jørgensen wrote:
>> Hi folks,
>>
>> Our LNST testing team uncovered a crash in ixgbe when running an XDP
>> program, see this report:
>> https://bugzilla.redhat.com/show_bug.cgi?id=2343204
>>
>> From looking at
E610 devices give possibility to show more detailed info than the previous
boards.
Extend reporting NVM info with following pieces:
fw.mgmt.api -> version number of the API
fw.mgmt.build -> identifier of the source for the FW
fw.psid.api -> version defining the format of the flash contents
fw.n
Add E610 implementation of fw_recovery_mode MAC operation.
In case of E610 information about recovery mode is obtained
from FW_MODES field in IXGBE_GL_MNG_FWSM register (0x000B6134).
Introduce recovery specific probing flow and init only
vital features.
User should be able to perform NVM update
The E610 adapters contain an embedded chip with firmware which can be
updated using devlink flash. The firmware which runs on this chip is
referred to as the Embedded Management Processor firmware (EMP
firmware).
Activating the new firmware image currently requires that the system be
rebooted. Thi
Use the pldmfw library to implement device flash update for
the Intel ixgbe networking device driver specifically for E610 devices.
This support uses the devlink flash update interface.
Using the pldmfw library, the provided firmware file will be scanned for
the three major components, "fw.undi" f
Add functions reading inactive versions from the inactive flash
banks.
Print stored NVM, OROM and netlist versions by devlink when there
is an ongoing update for E610 devices.
Reviewed-by: Mateusz Polchlopek
Reviewed-by: Przemek Kitszel
Co-developed-by: Slawomir Mrozowicz
Signed-off-by: Slawom
Provide devlink .info_get() callback implementation to allow the
driver to report detailed version information. The following info
is reported:
"serial_number" -> The PCI DSN of the adapter
"fw.bundle_id" -> Unique identifier for the combined flash image
"fw.undi" -> Version of the Option ROM c
From: Slawomir Mrozowicz
Read NVM related info from the flash.
Add several helper functions used to access the flash data,
find memory banks, calculate offsets, calculate the flash size.
Reviewed-by: Przemek Kitszel
Reviewed-by: Mateusz Polchlopek
Signed-off-by: Slawomir Mrozowicz
Co-develop
Introduce 2 E610 specific callbacks implementations:
-ixgbe_start_hw_e610() which expands the regular .start_hw callback with
getting FW version information
-ixgbe_read_pba_string_e610() which gets Product Board Assembly string
Extend EEPROM ops with new .read_pba_string in order to distinguish
ge
Prevent from proceeding if there's nothing to print.
Suggested-by: Przemek Kitszel
Signed-off-by: Jedrzej Jagielski
---
net/devlink/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/devlink/dev.c b/net/devlink/dev.c
index d6e3db300acb..02602704bdea 100644
--- a/net/d
Add an initial support for devlink interface to ixgbe driver.
Similarly to i40e driver the implementation doesn't enable
devlink to manage device-wide configuration. Devlink instance
is created for each physical function of PCIe device.
Create separate directory for devlink related ixgbe files
an
From: Slawomir Mrozowicz
Add functions reading the OROM version info and use them
as a part of the setting NVM info procedure.
Reviewed-by: Mateusz Polchlopek
Reviewed-by: Przemek Kitszel
Signed-off-by: Slawomir Mrozowicz
Co-developed-by: Piotr Kwapulinski
Signed-off-by: Piotr Kwapulinski
S
Add E610 specific function checking whether the FW API version
is compatible with the driver expectations.
The major API version should be less than or equal to the expected
API version. If not the driver won't be fully operational.
Check the minor version, and if it is more than two versions les
13.2.0
arc randconfig-001-20250212gcc-13.2.0
arc randconfig-002-20250212gcc-13.2.0
arm allmodconfiggcc-14.2.0
arm allyesconfiggcc-14.2.0
arm randconfig-001-20250212cl
Wed, Feb 12, 2025 at 02:14:02PM +0100, jedrzej.jagiel...@intel.com wrote:
>Provide devlink .info_get() callback implementation to allow the
>driver to report detailed version information. The following info
>is reported:
>
> "serial_number" -> The PCI DSN of the adapter
> "fw.bundle_id" -> Unique i
Dear Michal,
Am 12.02.25 um 13:59 schrieb Michal Swiatkowski:
On Wed, Feb 12, 2025 at 09:07:18AM +0100, Paul Menzel wrote:
Thank you for your patch. For the summary/title you could use:
ixgbe: Support Malicious Driver Detection (MDD)
Am 12.02.25 um 08:57 schrieb Michal Swiatkowski:
From:
From: Slawomir Mrozowicz
Add functions reading the netlist version info and use them
as a part of the setting NVM info procedure.
Reviewed-by: Mateusz Polchlopek
Signed-off-by: Slawomir Mrozowicz
Co-developed-by: Piotr Kwapulinski
Signed-off-by: Piotr Kwapulinski
Signed-off-by: Jedrzej Jagie
From: Andrii Staikov
The driver should detect whether the device entered FW rollback
mode and then notify user with the dedicated message including
FW and NVM versions.
Even if the driver detected rollback mode, this should not result
in an probe error and the normal flow proceeds.
FW tries to
Create devlink specific directory for more convenient future feature
development.
Flashing and reloading are supported only by E610 devices.
Introduce basic FW/NVM validation since devlink reload introduces
possibility of runtime NVM update. Check FW API version, FW recovery mode
and FW rollback
Introduce page_pool_get_pp() API to avoid caller accessing
page->pp directly, in order to make the following patch more
reviewable as the following patch will change page->pp to
page->pp_item to fix the DMA API misuse problem.
Signed-off-by: Yunsheng Lin
---
drivers/net/ethernet/freescale/fec_ma
From: Jiri Pirko
Sent: Wednesday, February 12, 2025 4:09 PM
>Wed, Feb 12, 2025 at 02:14:01PM +0100, jedrzej.jagiel...@intel.com wrote:
>>Add an initial support for devlink interface to ixgbe driver.
>>
>>Similarly to i40e driver the implementation doesn't enable
>>devlink to manage device-wide co
Wed, Feb 12, 2025 at 02:14:01PM +0100, jedrzej.jagiel...@intel.com wrote:
>Add an initial support for devlink interface to ixgbe driver.
>
>Similarly to i40e driver the implementation doesn't enable
>devlink to manage device-wide configuration. Devlink instance
>is created for each physical functio
If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
then it returns -ENOSPC so there is no need to check for that in the
caller. In fact, because pf->msix.min is an unsigned int, it means that
any negative error codes are type promoted to high positive values and
treated as suc
Wed, Feb 12, 2025 at 02:14:00PM +0100, jedrzej.jagiel...@intel.com wrote:
>Prevent from proceeding if there's nothing to print.
>
>Suggested-by: Przemek Kitszel
>Signed-off-by: Jedrzej Jagielski
Reviewed-by: Jiri Pirko
On Wed, Feb 12, 2025 at 02:09:17PM +0100, Paul Menzel wrote:
> Dear Michal,
>
>
> Am 12.02.25 um 13:59 schrieb Michal Swiatkowski:
> > On Wed, Feb 12, 2025 at 09:07:18AM +0100, Paul Menzel wrote:
>
> > > Thank you for your patch. For the summary/title you could use:
> > >
> > > ixgbe: Support M
On 13/2/2025 6:01 am, Vladimir Oltean wrote:
On Mon, Feb 10, 2025 at 02:01:58AM -0500, Faizal Rahim wrote:
Introduces support for the FPE feature in the IGC driver.
The patches aligns with the upstream FPE API:
https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1156614-1-vla
If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
then it returns -ENOSPC so there is no need to check for that in the
caller. In fact, because pf->msix.min is an unsigned int, it means that
any negative error codes are type promoted to high positive values and
treated as suc
E610 NICs unlike the previous devices utilizing ixgbe driver
are notified in the case of overheating by the FW ACI event.
In event of overheat when threshold is exceeded, FW suspends all
traffic and sends overtemp event to the driver. Then driver
logs appropriate message and closes the adapter ins
On Thu, Feb 13, 2025 at 09:31:41AM +0300, Dan Carpenter wrote:
> If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
> then it returns -ENOSPC so there is no need to check for that in the
> caller. In fact, because pf->msix.min is an unsigned int, it means that
> any negative e
From: Andrew Lunn
Sent: Tuesday, February 11, 2025 3:17 PM
>> Actually there is only one adapter across all portfolio of ixgbe adapters
>> which supports this feature. That is 82599, none other supports it.
>> Even next generations (x540, x550) didn't provide support for reading thermal
>> data
On Wed, Feb 12, 2025 at 05:59:01PM -0800, Jakub Kicinski wrote:
> On Wed, 12 Feb 2025 17:46:54 +0100 Alexander Lobakin wrote:
> > > [PATCH next] ice: Fix signedness bug in ice_init_interrupt_scheme()
> >
> > I believe it should be "PATCH net" with
> >
> > > If pci_alloc_irq_vectors() can't allo
On 13/2/2025 5:54 am, Vladimir Oltean wrote:
On Mon, Feb 10, 2025 at 02:02:07AM -0500, Faizal Rahim wrote:
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b/drivers/net/ethernet/intel/igc/igc_main.c
index f15ac7565fbd..cd5160315993 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.
On Thu, Feb 13, 2025 at 08:26:09AM +0300, Dan Carpenter wrote:
> On Wed, Feb 12, 2025 at 05:59:01PM -0800, Jakub Kicinski wrote:
> > On Wed, 12 Feb 2025 17:46:54 +0100 Alexander Lobakin wrote:
> > > > [PATCH next] ice: Fix signedness bug in ice_init_interrupt_scheme()
> > >
> > > I believe it sh
From: Dan Carpenter
Date: Wed, 12 Feb 2025 18:27:09 +0300
> [PATCH next] ice: Fix signedness bug in ice_init_interrupt_scheme()
I believe it should be "PATCH net" with
> If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
> then it returns -ENOSPC so there is no need to chec
On Mon, Feb 10, 2025 at 06:38:51PM -0800, Emil Tantilov wrote:
> Current init logic ignores the error code from register_netdev(),
> which will cause WARN_ON() on attempt to unregister it, if there was one,
> and there is no info for the user that the creation of the netdev failed.
>
> WARNING: CP
-13.2.0
arc allyesconfiggcc-13.2.0
arc randconfig-001-20250212gcc-13.2.0
arc randconfig-002-20250212gcc-13.2.0
arcvdk_hs38_defconfiggcc-13.2.0
arm allnoconfig
gcc-13.2.0
arc allyesconfiggcc-13.2.0
arc randconfig-001-20250212gcc-13.2.0
arc randconfig-002-20250212gcc-13.2.0
arm allmodconfiggcc-14.2.0
arm allnoconfig
On Wed, Feb 12, 2025 at 12:56:48PM +0100, Steffen Klassert wrote:
> On Wed, Feb 05, 2025 at 08:20:21PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky
> >
> > SA replay mode is initialized differently for user-space and
> > kernel-space users, but the call to xfrm_init_replay() existed in
On Wed, Feb 12, 2025 at 3:10 PM Lifshits, Vitaly
wrote:
>
>
>
> On 2/8/2025 5:43 PM, Piotr Wejman wrote:
> > Update the driver to use the new hardware timestamping API added in commit
> > 66f7223039c0 ("net: add NDOs for configuring hardware timestamping").
> > Use Netlink extack for error reporti
-001-20250212gcc-13.2.0
arc randconfig-002-20250212gcc-13.2.0
arm allmodconfiggcc-14.2.0
arm allyesconfiggcc-14.2.0
arm randconfig-001-20250212clang-18
arm randconfig-002
Dear Michal, dear Paul,
Thank you for your patch. For the summary/title you could use:
ixgbe: Support Malicious Driver Detection (MDD)
Am 12.02.25 um 08:57 schrieb Michal Swiatkowski:
From: Paul Greenwalt
Add malicious driver detection. Support enabling MDD, disabling MDD,
handling a MDD ev
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Piotr Kwapulinski
> Sent: Thursday, February 6, 2025 8:49 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Kwapulinski, Piotr
> ; Dan Carpenter ;
> Michal Swiatkowski ; Kitszel,
> Przemyslaw
> Subject: [Int
On Wed, 12 Feb 2025 17:46:54 +0100 Alexander Lobakin wrote:
> > [PATCH next] ice: Fix signedness bug in ice_init_interrupt_scheme()
>
> I believe it should be "PATCH net" with
>
> > If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
> > then it returns -ENOSPC so there is n
On Mon, Feb 10, 2025 at 02:01:59AM -0500, Faizal Rahim wrote:
> From: Vladimir Oltean
>
> It appears that stmmac is not the only hardware which requires a
> software-driven verification state machine for the MAC Merge layer.
>
> While on the one hand it's good to encourage hardware implementatio
On Mon, Feb 10, 2025 at 03:11:10PM +0100, Grzegorz Nitka wrote:
> From: Karol Kolacinski
>
> Refactor the code by changing ice_ptp_init_phc_eth56g function
> name to ice_ptp_init_phc_e825, to be consistent with the naming pattern
> for other devices.
>
> Signed-off-by: Karol Kolacinski
> Signed
On 2/8/2025 5:22 AM, Larysa Zaremba wrote:
...
@@ -8393,20 +8395,42 @@ ice_setup_tc_cls_flower(struct ice_netdev_priv *np,
}
/**
- * ice_setup_tc_block_cb - callback handler registered for TC block
+ * ice_setup_tc_block_cb_ingress - callback handler for ingress TC block
* @type:
On Mon, Feb 10, 2025 at 03:11:11PM +0100, Grzegorz Nitka wrote:
> From: Karol Kolacinski
>
> Simplify ice_phy_reg_info_eth56g struct definition to include base
> address for the very first quad. Use base address info and 'step'
> value to determine address for specific PHY quad.
>
> Reviewed-by:
On Wed, Feb 12, 2025 at 05:25:47PM +0800, Yunsheng Lin wrote:
> This patchset fix the dma API misuse problem as mentioned in [1].
>
> 1.
> https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26...@kernel.org/T/
That's a very long and complicated thread. I gave up. You need to
provide a
On Mon, Feb 10, 2025 at 02:02:07AM -0500, Faizal Rahim wrote:
> Implemented "ethtool --include-statistics --show-mm" callback for IGC.
>
> Tested preemption scenario to check preemption statistics:
> 1) Trigger verification handshake on both boards:
> $ sudo ethtool --set-mm enp1s0 pmac-enable
On Mon, Feb 10, 2025 at 02:01:58AM -0500, Faizal Rahim wrote:
> Introduces support for the FPE feature in the IGC driver.
>
> The patches aligns with the upstream FPE API:
> https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1156614-1-vladimir.olt...@nxp.com/
> https://patchwork.k
56 matches
Mail list logo
