[Intel-wired-lan] [PATCH iwl-next v1 1/3] ice: Add sync delay for E825C

2025-02-06 Thread Grzegorz Nitka
From: Karol Kolacinski Implement setting GLTSYN_SYNC_DLAY for E825C products. This is the execution delay compensation of SYNC command between PHC and PHY. Also, refactor the code by changing ice_ptp_init_phc_eth56g function name to ice_ptp_init_phc_e825, to be consistent with the naming pattern

[Intel-wired-lan] [PATCH iwl-next v1 2/3] ice: Refactor E825C PHY registers info struct

2025-02-06 Thread Grzegorz Nitka
From: Karol Kolacinski Simplify ice_phy_reg_info_eth56g struct definition to include base address for the very first quad. Use base address info and 'step' value to determine address for specific PHY quad. Reviewed-by: Przemek Kitszel Signed-off-by: Karol Kolacinski Signed-off-by: Grzegorz Nit

[Intel-wired-lan] [PATCH iwl-next v1 3/3] ice: E825C PHY register cleanup

2025-02-06 Thread Grzegorz Nitka
From: Karol Kolacinski Minor PTP register refactor, including logical grouping E825C 1-step timestamping registers. Remove unused register definitions (PHY_REG_GPCS_BITSLIP, PHY_REG_REVISION). Also, apply preferred GENMASK macro (instead of ICE_M) for register fields definition affected by this p

[Intel-wired-lan] [PATCH iwl-next v1 0/3] E825C PTP cleanup

2025-02-06 Thread Grzegorz Nitka
This patch series simplifies PTP code related to E825C products by simplifying PHY register info definition. Cleanup the code by removing unused register definitions. Also, add sync delay compensation between PHC and PHY for E825C. Karol Kolacinski (3): ice: Add sync delay for E825C ice: Refac

Re: [Intel-wired-lan] [PATCH ipsec-next 1/5] xfrm: delay initialization of offload path till its actually requested

2025-02-06 Thread Leon Romanovsky
On Thu, Feb 06, 2025 at 02:16:08PM +0530, Bharat Bhushan wrote: > Hi Leon, > > On Wed, Feb 5, 2025 at 11:50 PM Leon Romanovsky wrote: > > > > From: Leon Romanovsky > > > > XFRM offload path is probed even if offload isn't needed at all. Let's > > make sure that x->type_offload pointer stays NULL

Re: [Intel-wired-lan] [PATCH bpf-next v9 4/5] igc: Refactor empty frame insertion for launch time support

2025-02-06 Thread Maciej Fijalkowski
On Thu, Feb 06, 2025 at 02:04:07PM +0800, Song Yoong Siang wrote: > Refactor the code for inserting an empty frame into a new function > igc_insert_empty_frame(). This change extracts the logic for inserting > an empty packet from igc_xmit_frame_ring() into a separate function, > allowing it to be

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: add support for thermal sensor event reception

2025-02-06 Thread Jagielski, Jedrzej
From: Andrew Lunn Sent: Tuesday, February 4, 2025 2:09 PM >On Tue, Feb 04, 2025 at 08:17:00AM +0100, Jedrzej Jagielski wrote: >> E610 NICs unlike the previous devices utilising ixgbe driver >> are notified in the case of overheatning by the FW ACI event. >> >> In event of overheat when treshold

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: add support for thermal sensor event reception

2025-02-06 Thread Andrew Lunn
On Thu, Feb 06, 2025 at 01:05:27PM +, Jagielski, Jedrzej wrote: > From: Andrew Lunn > Sent: Tuesday, February 4, 2025 2:09 PM > >On Tue, Feb 04, 2025 at 08:17:00AM +0100, Jedrzej Jagielski wrote: > >> E610 NICs unlike the previous devices utilising ixgbe driver > >> are notified in the case o

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: add support for thermal sensor event reception

2025-02-06 Thread Jagielski, Jedrzej
From: Andrew Lunn Sent: Thursday, February 6, 2025 2:59 PM >On Thu, Feb 06, 2025 at 01:05:27PM +, Jagielski, Jedrzej wrote: >> From: Andrew Lunn >> Sent: Tuesday, February 4, 2025 2:09 PM >> >On Tue, Feb 04, 2025 at 08:17:00AM +0100, Jedrzej Jagielski wrote: >> >> E610 NICs unlike the previ

Re: [Intel-wired-lan] [PATCH iwl-next v2 5/9] igc: Add support for frame preemption verification

2025-02-06 Thread Abdul Rahim, Faizal
Hi Vladimir, Thanks for the quick review, appreciate your help. On 6/2/2025 1:12 am, Vladimir Oltean wrote: On Wed, Feb 05, 2025 at 05:05:20AM -0500, Faizal Rahim wrote: This patch implements the "ethtool --set-mm" callback to trigger the frame preemption verification handshake. Uses the MA

[Intel-wired-lan] [tnguy-next-queue:for-next] BUILD SUCCESS d67627e7b53203ca150e54723abbed81a0716286

2025-02-06 Thread kernel test robot
-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250206gcc-13.2.0 arc randconfig-002-20250206gcc-13.2.0 arm allmodconfiggcc-14.2.0 arm allnoconfigclang-17

Re: [Intel-wired-lan] [PATCH bpf-next v9 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-06 Thread Maciej Fijalkowski
On Thu, Feb 06, 2025 at 02:04:06PM +0800, Song Yoong Siang wrote: > Enable launch time (Time-Based Scheduling) support for XDP zero copy via > the XDP Tx metadata framework. > > This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata > on Intel Tiger Lake platform. Below are th

Re: [Intel-wired-lan] [PATCH bpf-next v9 5/5] igc: Add launch time support to XDP ZC

2025-02-06 Thread Maciej Fijalkowski
On Thu, Feb 06, 2025 at 02:04:08PM +0800, Song Yoong Siang wrote: > Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx > metadata framework. > > This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata > on Intel I225-LM Ethernet controller. Below are the test

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-02-06 Thread Stephen Hemminger
On Thu, 6 Feb 2025 15:17:00 +0200 "Lifshits, Vitaly" wrote: > On 2/6/2025 6:13 AM, Stephen Hemminger wrote: > > On Wed, 5 Feb 2025 12:36:31 +0200 > > "Lifshits, Vitaly" wrote: > > > >> On 1/31/2025 3:21 AM, Stephen Hemminger wrote: > >>> On Thu, 30 Jan 2025 21:17:30 +0200 > >>> "Lifshits, V

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-02-06 Thread Lifshits, Vitaly
On 2/6/2025 6:13 AM, Stephen Hemminger wrote: On Wed, 5 Feb 2025 12:36:31 +0200 "Lifshits, Vitaly" wrote: On 1/31/2025 3:21 AM, Stephen Hemminger wrote: On Thu, 30 Jan 2025 21:17:30 +0200 "Lifshits, Vitaly" wrote: On 1/30/2025 7:11 PM, Stephen Hemminger wrote: I am using: 5a:00.0 E

Re: [Intel-wired-lan] [PATCH iwl-next v1 01/13] ixgbe: add initial devlink support

2025-02-06 Thread Tony Nguyen
On 2/3/2025 7:03 AM, Jedrzej Jagielski wrote: Add an initial support for devlink interface to ixgbe driver. Similarly to i40e driver the implementation doesn't enable devlink to manage device-wide configuration. Devlink instance is created for each physical function of PCIe device. Create se

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: health.c: fix compilation on gcc 7.5

2025-02-06 Thread Zhuo, Qiuxu
> From: Kitszel, Przemyslaw > [...] > Subject: [PATCH iwl-net v2] ice: health.c: fix compilation on gcc 7.5 > > GCC 7 is not as good as GCC 8+ in telling what is a compile-time const, and > thus could be used for static storage. > Fortunately keeping strings as const arrays is enough to make old

[Intel-wired-lan] [PATCH bpf-next v10 5/5] igc: Add launch time support to XDP ZC

2025-02-06 Thread Song Yoong Siang
Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx metadata framework. This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel I225-LM Ethernet controller. Below are the test steps and result. Test 1: Send a single packet with the launch time set to

[Intel-wired-lan] [PATCH iwl-net v2] ice: health.c: fix compilation on gcc 7.5

2025-02-06 Thread Przemek Kitszel
GCC 7 is not as good as GCC 8+ in telling what is a compile-time const, and thus could be used for static storage. Fortunately keeping strings as const arrays is enough to make old gcc happy. Excerpt from the report: My GCC is: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0. CC [M] drivers/net/ethern

[Intel-wired-lan] [PATCH bpf-next v10 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-06 Thread Song Yoong Siang
Extend the XDP Tx metadata framework so that user can requests launch time hardware offload, where the Ethernet device will schedule the packet for transmission at a pre-determined time called launch time. The value of launch time is communicated from user space to Ethernet driver via launch_time f

[Intel-wired-lan] [PATCH bpf-next v10 0/5] xsk: TX metadata Launch Time support

2025-02-06 Thread Song Yoong Siang
This series expands the XDP TX metadata framework to allow user applications to pass per packet 64-bit launch time directly to the kernel driver, requesting launch time hardware offload support. The XDP TX metadata framework will not perform any clock conversion or packet reordering. Please note t

[Intel-wired-lan] [PATCH bpf-next v10 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-06 Thread Song Yoong Siang
Add launch time hardware offload request to xdp_hw_metadata. Users can configure the delta of launch time relative to HW RX-time using the "-l" argument. By default, the delta is set to 0 ns, which means the launch time is disabled. By setting the delta to a non-zero value, the launch time hardware

[Intel-wired-lan] [PATCH bpf-next v10 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-06 Thread Song Yoong Siang
Enable launch time (Time-Based Scheduling) support for XDP zero copy via the XDP Tx metadata framework. This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel Tiger Lake platform. Below are the test steps and result. Test 1: Send a single packet with the launch time

[Intel-wired-lan] [PATCH bpf-next v10 4/5] igc: Refactor empty frame insertion for launch time support

2025-02-06 Thread Song Yoong Siang
Refactor the code for inserting an empty frame into a new function igc_insert_empty_frame(). This change extracts the logic for inserting an empty packet from igc_xmit_frame_ring() into a separate function, allowing it to be reused in future implementations, such as the XDP zero copy transmit funct

Re: [Intel-wired-lan] [PATCH net-next v7 1/5] net: move ARFS rmap management to core

2025-02-06 Thread Jakub Kicinski
On Tue, 4 Feb 2025 15:06:18 -0700 Ahmed Zaki wrote: > +void netif_napi_set_irq_locked(struct napi_struct *napi, int irq) > +{ > + int rc; > + > + /* Remove existing rmap entries */ > + if (napi->dev->rx_cpu_rmap_auto && > + napi->irq != irq && napi->irq > 0) this condition get

Re: [Intel-wired-lan] [PATCH net-next v7 2/5] net: napi: add CPU affinity to napi_config

2025-02-06 Thread Jakub Kicinski
On Wed, 5 Feb 2025 08:20:20 -0700 Ahmed Zaki wrote: > >> + if (napi->dev->rx_cpu_rmap_auto) { > >>rc = napi_irq_cpu_rmap_add(napi, irq); > >>if (rc) > >>netdev_warn(napi->dev, "Unable to update ARFS map > >> (%d)\n", > >>

Re: [Intel-wired-lan] [PATCH net-next v7 2/5] net: napi: add CPU affinity to napi_config

2025-02-06 Thread Jakub Kicinski
On Tue, 4 Feb 2025 15:06:19 -0700 Ahmed Zaki wrote: > + * @irq_affinity_auto: driver wants the core to manage the IRQ affinity. "manage" is probably too strong? "store" or "remember" ? Your commit message explains it quite nicely. > + * Set by netif_enable_irq_affinity(),

[Intel-wired-lan] [tnguy-next-queue:100GbE] BUILD SUCCESS d67c484647606b83c9e5cc7d445ff7d7d2012fa2

2025-02-06 Thread kernel test robot
gcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250206gcc-13.2.0 arc randconfig-002-20250206gcc-13.2.0 arm allmodconfiggcc-14.2.0 arm allnoconfig

Re: [Intel-wired-lan] [PATCH net-next v7 0/5] net: napi: add CPU affinity to napi->config

2025-02-06 Thread Joe Damato
On Tue, Feb 04, 2025 at 03:06:17PM -0700, Ahmed Zaki wrote: > Drivers usually need to re-apply the user-set IRQ affinity to their IRQs > after reset. However, since there can be only one IRQ affinity notifier > for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap > management in the

Re: [Intel-wired-lan] [PATCH ipsec-next 1/5] xfrm: delay initialization of offload path till its actually requested

2025-02-06 Thread Bharat Bhushan
On Thu, Feb 6, 2025 at 2:24 PM Leon Romanovsky wrote: > > On Thu, Feb 06, 2025 at 02:16:08PM +0530, Bharat Bhushan wrote: > > Hi Leon, > > > > On Wed, Feb 5, 2025 at 11:50 PM Leon Romanovsky wrote: > > > > > > From: Leon Romanovsky > > > > > > XFRM offload path is probed even if offload isn't ne

Re: [Intel-wired-lan] [PATCH iwl-net] ice: health.c: fix compilation on gcc 7.5

2025-02-06 Thread David Laight
On Wed, 5 Feb 2025 20:45:46 + Simon Horman wrote: > + Jiri > > On Wed, Feb 05, 2025 at 11:42:12AM +0100, Przemek Kitszel wrote: > > GCC 7 is not as good as GCC 8+ in telling what is a compile-time const, > > and thus could be used for static storage. So we could not use variables > > for tha

Re: [Intel-wired-lan] [PATCH ipsec-next 1/5] xfrm: delay initialization of offload path till its actually requested

2025-02-06 Thread Bharat Bhushan
Hi Leon, On Wed, Feb 5, 2025 at 11:50 PM Leon Romanovsky wrote: > > From: Leon Romanovsky > > XFRM offload path is probed even if offload isn't needed at all. Let's > make sure that x->type_offload pointer stays NULL for such path to > reduce ambiguity. > > Fixes: 9d389d7f84bb ("xfrm: Add a xfrm

Re: [Intel-wired-lan] [PATCH] igc: Fix HW RX timestamp when passed by ZC XDP

2025-02-06 Thread Mor Bar-Gabay
On 28/01/2025 14:26, Zdenek Bouska wrote: Fixes HW RX timestamp in the following scenario: - AF_PACKET socket with enabled HW RX timestamps is created - AF_XDP socket with enabled zero copy is created - frame is forwarded to the BPF program, where the timestamp should still be readable (extrac

Re: [Intel-wired-lan] [PATCH ipsec-next 1/5] xfrm: delay initialization of offload path till its actually requested

2025-02-06 Thread Leon Romanovsky
On Thu, Feb 06, 2025 at 07:29:13PM +0530, Bharat Bhushan wrote: > On Thu, Feb 6, 2025 at 2:24 PM Leon Romanovsky wrote: > > > > On Thu, Feb 06, 2025 at 02:16:08PM +0530, Bharat Bhushan wrote: > > > Hi Leon, > > > > > > On Wed, Feb 5, 2025 at 11:50 PM Leon Romanovsky wrote: > > > > > > > > From: L

Re: [Intel-wired-lan] [PATCH iwl-next v2 5/9] igc: Add support for frame preemption verification

2025-02-06 Thread Vladimir Oltean
On Thu, Feb 06, 2025 at 10:40:11PM +0800, Abdul Rahim, Faizal wrote: > > Hi Vladimir, > > Thanks for the quick review, appreciate your help. > > On 6/2/2025 1:12 am, Vladimir Oltean wrote: > > On Wed, Feb 05, 2025 at 05:05:20AM -0500, Faizal Rahim wrote: > > > This patch implements the "ethtool

[Intel-wired-lan] [PATCH iwl-net] ixgbe: fix media cage present detection for E610 device

2025-02-06 Thread Piotr Kwapulinski
The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610 device") introduced incorrect checking of media cage presence for E610 device. Fix it. Fixes: 23c0e5a16bcc ("ixgbe: Add link management support for E610 device") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/e