Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: Fix possible skb NULL pointer dereference

2025-01-23 Thread Kwapulinski, Piotr
>-Original Message- >From: Fijalkowski, Maciej >Sent: Monday, January 20, 2025 3:45 PM >To: Kwapulinski, Piotr >Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; >dan.carpen...@linaro.org; yuehaib...@huawei.com; Kitszel, Przemyslaw > >Subject: Re: [PATCH iwl-next v2] ixgbe:

Re: [Intel-wired-lan] [PATCH v4 iwl-net 2/3] ice: gather page_count()'s of each frag right before XDP prog call

2025-01-23 Thread Simon Horman
On Wed, Jan 22, 2025 at 04:10:45PM +0100, Maciej Fijalkowski wrote: > If we store the pgcnt on few fragments while being in the middle of > gathering the whole frame and we stumbled upon DD bit not being set, we > terminate the NAPI Rx processing loop and come back later on. Then on > next NAPI exe

Re: [Intel-wired-lan] [PATCH v4 iwl-net 1/3] ice: put Rx buffers after being done with current frame

2025-01-23 Thread Simon Horman
On Wed, Jan 22, 2025 at 04:10:44PM +0100, Maciej Fijalkowski wrote: > Introduce a new helper ice_put_rx_mbuf() that will go through gathered > frags from current frame and will call ice_put_rx_buf() on them. Current > logic that was supposed to simplify and optimize the driver where we go > through

Re: [Intel-wired-lan] [PATCH v4 iwl-net 3/3] ice: stop storing XDP verdict within ice_rx_buf

2025-01-23 Thread Simon Horman
On Wed, Jan 22, 2025 at 04:10:46PM +0100, Maciej Fijalkowski wrote: > Idea behind having ice_rx_buf::act was to simplify and speed up the Rx > data path by walking through buffers that were representing cleaned HW > Rx descriptors. Since it caused us a major headache recently and we > rolled back t

Re: [Intel-wired-lan] [PATCH v4 iwl-net 3/3] ice: stop storing XDP verdict within ice_rx_buf

2025-01-23 Thread Maciej Fijalkowski
On Thu, Jan 23, 2025 at 10:45:36AM +, Simon Horman wrote: > On Wed, Jan 22, 2025 at 04:10:46PM +0100, Maciej Fijalkowski wrote: > > Idea behind having ice_rx_buf::act was to simplify and speed up the Rx > > data path by walking through buffers that were representing cleaned HW > > Rx descriptor

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: Fix possible skb NULL pointer dereference

2025-01-23 Thread Maciej Fijalkowski
On Thu, Jan 23, 2025 at 09:19:34AM +0100, Kwapulinski, Piotr wrote: > >-Original Message- > >From: Fijalkowski, Maciej > >Sent: Monday, January 20, 2025 3:45 PM > >To: Kwapulinski, Piotr > >Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; > >dan.carpen...@linaro.org; yuehai

[Intel-wired-lan] [PATCH iwl-net v1] ice: fix memory leak in aRFS after reset

2025-01-23 Thread Grzegorz Nitka
Fix aRFS (accelerated Receive Flow Steering) structures memory leak by adding a checker to verify if aRFS memory is already allocated while configuring VSI. aRFS objects are allocated in two cases: - as part of VSI initialization (at probe), and - as part of reset handling However, VSI reconfigura

[Intel-wired-lan] [PATCH v5 iwl-net 3/3] ice: stop storing XDP verdict within ice_rx_buf

2025-01-23 Thread Maciej Fijalkowski
Idea behind having ice_rx_buf::act was to simplify and speed up the Rx data path by walking through buffers that were representing cleaned HW Rx descriptors. Since it caused us a major headache recently and we rolled back to old approach that 'puts' Rx buffers right after running XDP prog/creating

Re: [Intel-wired-lan] [PATCH net-next v6 1/5] net: move ARFS rmap management to core

2025-01-23 Thread Joe Damato
On Fri, Jan 17, 2025 at 05:33:31PM -0700, Ahmed Zaki wrote: > Add a new netdev flag "rx_cpu_rmap_auto". Drivers supporting ARFS should > set the flag via netif_enable_cpu_rmap() and core will allocate and manage > the ARFS rmap. Freeing the rmap is also done by core when the netdev is > freed. > >

Re: [Intel-wired-lan] [PATCH bpf-next v6 2/4] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-01-23 Thread Stanislav Fomichev
On 01/16, Song Yoong Siang wrote: > Add launch time hardware offload request to xdp_hw_metadata. Users can > configure the delta of launch time relative to HW RX-time using the "-l" > argument. By default, the delta is set to 0 ns, which means the launch time > is disabled. By setting the delta to

Re: [Intel-wired-lan] [PATCH net-next v6 1/5] net: move ARFS rmap management to core

2025-01-23 Thread Ahmed Zaki
On 2025-01-23 12:28 p.m., Joe Damato wrote: On Fri, Jan 17, 2025 at 05:33:31PM -0700, Ahmed Zaki wrote: Add a new netdev flag "rx_cpu_rmap_auto". Drivers supporting ARFS should set the flag via netif_enable_cpu_rmap() and core will allocate and manage the ARFS rmap. Freeing the rmap is also d

Re: [Intel-wired-lan] [PATCH net-next v6 2/5] net: napi: add CPU affinity to napi_config

2025-01-23 Thread Joe Damato
On Fri, Jan 17, 2025 at 05:33:32PM -0700, Ahmed Zaki wrote: > A common task for most drivers is to remember the user-set CPU affinity > to its IRQs. On each netdev reset, the driver should re-assign the > user's settings to the IRQs. > > Add CPU affinity mask to napi_config. To delegate the CPU af

Re: [Intel-wired-lan] [PATCH net-next v6 1/5] net: move ARFS rmap management to core

2025-01-23 Thread Joe Damato
On Thu, Jan 23, 2025 at 01:13:10PM -0700, Ahmed Zaki wrote: > > > On 2025-01-23 12:28 p.m., Joe Damato wrote: > > On Fri, Jan 17, 2025 at 05:33:31PM -0700, Ahmed Zaki wrote: > > > Add a new netdev flag "rx_cpu_rmap_auto". Drivers supporting ARFS should > > > set the flag via netif_enable_cpu_rmap

Re: [Intel-wired-lan] [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-23 Thread Stanislav Fomichev
On 01/23, Florian Bezdeka wrote: > Hi all, > > On Thu, 2025-01-23 at 16:41 +, Song, Yoong Siang wrote: > > On Thursday, January 23, 2025 11:40 PM, Bouska, Zdenek > > wrote: > > > > > > Hi Siang, > > > > > > I tested this patch series on 6.13 with Intel I226-LM (rev 04). > > > > > > I also

[Intel-wired-lan] [PATCH v5 iwl-net 2/3] ice: gather page_count()'s of each frag right before XDP prog call

2025-01-23 Thread Maciej Fijalkowski
If we store the pgcnt on few fragments while being in the middle of gathering the whole frame and we stumbled upon DD bit not being set, we terminate the NAPI Rx processing loop and come back later on. Then on next NAPI execution we work on previously stored pgcnt. Imagine that second half of page

[Intel-wired-lan] [PATCH v5 iwl-net 0/3] ice: fix Rx data path for heavy 9k MTU traffic

2025-01-23 Thread Maciej Fijalkowski
v4->v5: * add missing kdoc variable description in patch 3 (Simon Horman) * include review tags from Simon v3->v4: * fix kdoc issues (Simon Horman) * fix typo in commit msg in patch 1 (Simon Horman) v2->v3: * s/intel/iwl in patch subjects (Jakub Kicinski) v1->v2: * pass ntc to ice_put_rx_mbuf()

[Intel-wired-lan] [PATCH v5 iwl-net 1/3] ice: put Rx buffers after being done with current frame

2025-01-23 Thread Maciej Fijalkowski
Introduce a new helper ice_put_rx_mbuf() that will go through gathered frags from current frame and will call ice_put_rx_buf() on them. Current logic that was supposed to simplify and optimize the driver where we go through a batch of all buffers processed in current NAPI instance turned out to be

Re: [Intel-wired-lan] [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-23 Thread Florian Bezdeka
Hi all, On Thu, 2025-01-23 at 16:41 +, Song, Yoong Siang wrote: > On Thursday, January 23, 2025 11:40 PM, Bouska, Zdenek > wrote: > > > > Hi Siang, > > > > I tested this patch series on 6.13 with Intel I226-LM (rev 04). > > > > I also applied patch "selftests/bpf: Actuate tx_metadata_len

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 6a56c31b8e7c1d23b104fb6b432870c5769c5b89

2025-01-23 Thread kernel test robot
-20250123gcc-13.2.0 arc randconfig-002-20250123gcc-13.2.0 arm allnoconfigclang-17 arm randconfig-001-20250123clang-20 arm randconfig-002-20250123gcc-14.2.0 arm randconfig-003

Re: [Intel-wired-lan] [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-23 Thread Song, Yoong Siang
On Thursday, January 23, 2025 11:40 PM, Bouska, Zdenek wrote: > >Hi Siang, > >I tested this patch series on 6.13 with Intel I226-LM (rev 04). > >I also applied patch "selftests/bpf: Actuate tx_metadata_len in >xdp_hw_metadata" [1] >and "selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata" [2] s

Re: [Intel-wired-lan] [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-23 Thread Bouska, Zdenek
Hi Siang, I tested this patch series on 6.13 with Intel I226-LM (rev 04). I also applied patch "selftests/bpf: Actuate tx_metadata_len in xdp_hw_metadata" [1] and "selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata" [2] so that TX timestamps work. HW RX-timestamp was small (0.5956 instead of

Re: [Intel-wired-lan] [PATCH v4 iwl-net 3/3] ice: stop storing XDP verdict within ice_rx_buf

2025-01-23 Thread Przemek Kitszel
On 1/23/25 11:51, Maciej Fijalkowski wrote: On Thu, Jan 23, 2025 at 10:45:36AM +, Simon Horman wrote: On Wed, Jan 22, 2025 at 04:10:46PM +0100, Maciej Fijalkowski wrote: Idea behind having ice_rx_buf::act was to simplify and speed up the Rx data path by walking through buffers that were rep

Re: [Intel-wired-lan] [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config

2025-01-23 Thread Joe Damato
On Fri, Jan 17, 2025 at 05:33:30PM -0700, Ahmed Zaki wrote: > Drivers usually need to re-apply the user-set IRQ affinity to their IRQs > after reset. However, since there can be only one IRQ affinity notifier > for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap > management in the