Move call to ice_wait_for_fw() from ice_init_dev() into ice_init_hw(),
where it fits better. This requires also to move ice_wait_for_fw()
to ice_common.c.
ice_is_pf_c827() is now used only in ice_common.c, so it could be static.
CC: Arkadiusz Kubalewski
Reviewed-by: Marcin Szycik
Signed-off-by:
This series moves ice_init_hw() call to be prior to ice_adapter init.
To do so we need:
(patch 1) move waiting for FW into ice_init_hw();
(patch 2) split ice_init_hw() out of ice_init_dev(), so it could be
manually called in ice_init(). The change mandates similar
split in i
Split ice_init_hw() call out from ice_init_dev(). Such move enables
pulling the former to be even earlier on call path, what would enable
moving ice_adapter init to be between the two (in subsequent commit).
Such move enables ice_adapter to know about number of PFs.
Do the same for ice_deinit_hw()
Clean up goto labels after previous commit, to conform to single naming
scheme in ice_probe() and ice_init_dev().
Reviewed-by: Marcin Szycik
Signed-off-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice/ice_main.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
Move ice_adapter initialization to be after HW init, so it could use HW
capabilities, like number of PFs. This is needed for devlink-resource
based RSS LUT size management for PF/VF (not in this series).
Reviewed-by: Marcin Szycik
Signed-off-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ic
Hi Paolo,
On Wed, 2 Oct 2024 at 10:38, Paolo Abeni wrote:
>
> Hi,
>
> On 10/2/24 04:34, Yunsheng Lin wrote:
> > On 10/1/2024 9:32 PM, Paolo Abeni wrote:
> >> Is the problem only tied to VFs drivers? It's a pity all the page_pool
> >> users will have to pay a bill for it...
> >
> > I am afraid it
i386 allnoconfigclang-18
i386 allyesconfigclang-18
i386buildonly-randconfig-001-20241002clang-18
i386buildonly-randconfig-002-20241002clang-18
i386buildonly-randconfig-003-20241002clang-18
i386
nfiggcc-14.1.0
i386 allmodconfigclang-18
i386 allnoconfigclang-18
i386 allyesconfigclang-18
i386buildonly-randconfig-001-20241002clang-18
i386buildonly-randconfig-002-20
On Tue, 1 Oct 2024 07:44:36 -0700 Joe Damato wrote:
> > But if you change any core API, let's say rename a field used in several
> > drivers, you anyway need to adjust the affected drivers.
>
> Sorry, but that's a totally different argument.
>
> There are obvious cases where touching certain pa
Replaces watchdog timer with delayed_work as advised
in the driver's TODO comment.
Signed-off-by: Dmitrii Ermakov
---
V1 -> V2: Removed redundant line wraps, renamed e1000_watchdog to
e1000_watchdog_work
drivers/net/ethernet/intel/e1000e/e1000.h | 4 +--
drivers/net/ethernet/intel/e1000e/net
Hi,
On 10/2/24 04:34, Yunsheng Lin wrote:
On 10/1/2024 9:32 PM, Paolo Abeni wrote:
Is the problem only tied to VFs drivers? It's a pity all the page_pool
users will have to pay a bill for it...
I am afraid it is not only tied to VFs drivers, as:
attempting DMA unmaps after the driver has alre
allnoconfiggcc-13.2.0
arc allyesconfiggcc-13.2.0
arc axs103_defconfiggcc-13.2.0
archsdk_defconfiggcc-13.2.0
arc randconfig-001-20241002gcc-13.2.0
arc randconfig-002
On 9/30/2024 11:40 AM, Arkadiusz Kubalewski wrote:
The E810 Lan On Motherboard (LOM) design is vendor specific. Intel
provides the reference design, but it is up to vendor on the final
product design. For some cases, like Linux DPLL support, the static
values defined in the driver does not ref
On 10/02, Toke Høiland-Jørgensen wrote:
> Stanislav Fomichev writes:
>
> > On 10/01, Toke Høiland-Jørgensen wrote:
> >> Lorenzo Bianconi writes:
> >>
> >> >> On Mon Sep 30, 2024 at 1:49 PM CEST, Lorenzo Bianconi wrote:
> >> >> > > Lorenzo Bianconi writes:
> >> >> > >
> >> >> > > >> > We could
On 9/30/2024 5:08 AM, Karol Kolacinski wrote:
Current implementation checks revision of all PHYs on all PFs, which is
incorrect and may result in initialization failure. Check only the
revision of the current PHY.
This patch seems to be doing too many things. This part sounds like a patch.
On 9/30/2024 5:08 AM, Karol Kolacinski wrote:
Quad registers are read/written incorrectly. E825 devices always use
quad 0 address and differentiate between the PHYs by changing SBQ
destination device (phy_0 or phy_0_peer).
Add helpers for reading/writing PTP registers shared per quad and use
On 9/30/2024 5:08 AM, Karol Kolacinski wrote:
From: Jacob Keller
The PFTSYN_SEM, PFINT_TSYN_MSK and PFHH_SEM registers are defined in the
datasheet as "PF scoped". PF scoped registers appear in the datasheet to
have a different offset per PF. This is misleading. Each PF has its own
scope of
Add ice_ddp_send_hunk() that buffers "sent FW hunk" calls to AQ in order
to mark the "last" one in more elegant way. Next commit will add even
more complicated "sent FW" flow, so it's better to untangle a bit before.
Note that metadata buffers were not skipped for NOT-@indicate_last
segments, this
An optional flag field has been added to the signature segment header.
The field contains two flags, a "valid" bit, and a "last segment" bit
that indicates whether the segment is the last segment that will be
sent to firmware.
If the flag field's valid bit is NOT set, then as was done before,
assu
This series refactors sending DDP segments in accordance to computing
"last" bit of AQ request (1st patch), then adds support for extended
format ("valid" + "last" bits in a new "flags" field) of DDP that was
changed to support Multi-Segment DDP packages needed by E830.
v1:
adjusted authorship, re
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Mohamed Khalfella
> Sent: Wednesday, September 25, 2024 2:36 AM
> To: Nguyen, Anthony L ; Kitszel, Przemyslaw
> ; David S. Miller ; Eric
> Dumazet ; Jakub Kicinski ; Paolo Abeni
> ; Auke Kok ; Zhong, YuanYuan
> ; Jeff Garzik
Stanislav Fomichev writes:
> On 10/01, Toke Høiland-Jørgensen wrote:
>> Lorenzo Bianconi writes:
>>
>> >> On Mon Sep 30, 2024 at 1:49 PM CEST, Lorenzo Bianconi wrote:
>> >> > > Lorenzo Bianconi writes:
>> >> > >
>> >> > > >> > We could combine such a registration API with your header
>> >> >
allyesconfigclang-18
i386 allyesconfiggcc-12
i386buildonly-randconfig-001-20241002clang-18
i386buildonly-randconfig-002-20241002clang-18
i386buildonly-randconfig-003-20241002clang-18
i386buildonly-randconfig-004
allyesconfiggcc-12
i386buildonly-randconfig-001-20241002clang-18
i386buildonly-randconfig-002-20241002clang-18
i386buildonly-randconfig-003-20241002clang-18
i386buildonly-randconfig-004-20241002clang-18
i386buildonly-randconfig-005
On 10/1/2024 9:32 PM, Paolo Abeni wrote:
On 9/25/24 09:57, Yunsheng Lin wrote:
Networking driver with page_pool support may hand over page
still with dma mapping to network stack and try to reuse that
page after network stack is done with it and passes it back
to page_pool to avoid the penalty o
On 10/01, Toke Høiland-Jørgensen wrote:
> Lorenzo Bianconi writes:
>
> >> On Mon Sep 30, 2024 at 1:49 PM CEST, Lorenzo Bianconi wrote:
> >> > > Lorenzo Bianconi writes:
> >> > >
> >> > > >> > We could combine such a registration API with your header format,
> >> > > >> > so
> >> > > >> > that
On Wed, Oct 2, 2024 at 5:23 PM Przemek Kitszel
wrote:
>
> Split ice_init_hw() call out from ice_init_dev(). Such move enables
> pulling the former to be even earlier on call path, what would enable
> moving ice_adapter init to be between the two (in subsequent commit).
> Such move enables ice_adap
On Wed, Oct 2, 2024 at 5:23 PM Przemek Kitszel
wrote:
>
> Clean up goto labels after previous commit, to conform to single naming
> scheme in ice_probe() and ice_init_dev().
>
> Reviewed-by: Marcin Szycik
> Signed-off-by: Przemek Kitszel
LGTM,
Reviewed-by: Kalesh AP
--
Regards,
Kalesh A P
On Thu Oct 3, 2024 at 12:49 AM CEST, Stanislav Fomichev wrote:
> On 10/02, Toke Høiland-Jørgensen wrote:
> > Stanislav Fomichev writes:
> >
> > > On 10/01, Toke Høiland-Jørgensen wrote:
> > >> Lorenzo Bianconi writes:
> > >>
> > >> >> On Mon Sep 30, 2024 at 1:49 PM CEST, Lorenzo Bianconi wrote:
On Tue Oct 1, 2024 at 5:28 PM CEST, Toke Høiland-Jørgensen wrote:
> "Arthur Fabre" writes:
>
> > On Mon Sep 30, 2024 at 12:52 PM CEST, Toke Høiland-Jørgensen wrote:
> >> > Thinking about it more, my only relectance for a registration API is how
> >> > to communicate the ID back to other consumers
On Wed, Oct 2, 2024 at 5:23 PM Przemek Kitszel
wrote:
>
> Move ice_adapter initialization to be after HW init, so it could use HW
> capabilities, like number of PFs. This is needed for devlink-resource
> based RSS LUT size management for PF/VF (not in this series).
>
> Reviewed-by: Marcin Szycik
31 matches
Mail list logo
