[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS f9f8790a0508e8bafd364de310cfb88ef87a49d3

2024-09-25 Thread kernel test robot
gcc-14.1.0 arc allmodconfiggcc-13.2.0 arc allnoconfiggcc-14.1.0 arc allyesconfiggcc-13.2.0 arc defconfiggcc-14.1.0 arc randconfig-001-20240925

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix VF dynamic interrupt ctl register initialization

2024-09-25 Thread Singh, Krishneil K
> -Original Message- > From: Simon Horman > Sent: Monday, September 2, 2024 1:49 AM > To: Zaki, Ahmed > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Linga, Pavan > Kumar ; Kitszel, Przemyslaw > > Subject: Re: [PATCH iwl-net] idpf: fix VF dynamic interrupt ctl register >

Re: [Intel-wired-lan] [RFC net-next 1/1] idpf: Don't hard code napi_struct size

2024-09-25 Thread Simon Horman
On Wed, Sep 25, 2024 at 06:00:17PM +, Joe Damato wrote: > The sizeof(struct napi_struct) can change. Don't hardcode the size to > 400 bytes and instead use "sizeof(struct napi_struct)". > > While fixing this, also move other calculations into compile time > defines. > > Signed-off-by: Joe Dam

Re: [Intel-wired-lan] [PATCH v2 net-next] e1000e: Remove duplicated writel() in e1000_configure_tx/rx()

2024-09-25 Thread Mor Bar-Gabay
On 06/09/2024 5:17, Takamitsu Iwai wrote: Duplicated register initialization codes exist in e1000_configure_tx() and e1000_configure_rx(). For example, writel(0, tx_ring->head) writes 0 to tx_ring->head, which is adapter->hw.hw_addr + E1000_TDH(0). This initialization is already done in ew32(TD

[Intel-wired-lan] [RFC v2 net-next 0/2] e1000/e1000e: Link IRQs, NAPIs, and queues

2024-09-25 Thread Joe Damato
Greetings: This RFC v2 follows from an RFC submission I sent [1] for e1000e. The original RFC added netdev-genl support for e1000e, but this new RFC includes a patch to add support for e1000, as well. Supporting this API in these drivers is very useful as commonly used virtualization software, li

[Intel-wired-lan] [RFC v2 net-next 2/2] e1000: Link IRQs and queues to NAPIs

2024-09-25 Thread Joe Damato
Add support for netdev-genl, allowing users to query IRQ, NAPI, and queue information. After this patch is applied, note the IRQ assigned to my NIC: $ cat /proc/interrupts | grep enp0s8 | cut -f1 --delimiter=':' 18 Note the output from the cli: $ ./tools/net/ynl/cli.py --spec Documentation/net

[Intel-wired-lan] [RFC v2 net-next 1/2] e1000e: link NAPI instances to queues and IRQs

2024-09-25 Thread Joe Damato
Make e1000e compatible with the newly added netdev-genl APIs. $ cat /proc/interrupts | grep ens | cut -f1 --delimiter=':' 50 51 52 While e1000e allocates 3 IRQs (RX, TX, and other), it looks like e1000e only has a single NAPI, so I've associated the NAPI with the RX IRQ (50 on my system, seen

[Intel-wired-lan] [RFC net-next 1/1] idpf: Don't hard code napi_struct size

2024-09-25 Thread Joe Damato
The sizeof(struct napi_struct) can change. Don't hardcode the size to 400 bytes and instead use "sizeof(struct napi_struct)". While fixing this, also move other calculations into compile time defines. Signed-off-by: Joe Damato --- drivers/net/ethernet/intel/idpf/idpf_txrx.h | 10 +++--- 1 f

[Intel-wired-lan] [RFC net-next 0/1] idpf: Don't hardcode napi_struct size

2024-09-25 Thread Joe Damato
Greetings: While working on an RFC which adds fields to napi_struct [1], I got a warning from the kernel test robot about tripping an assertion in idpf which seems to hardcode the size of napi_struct. The assertion was triggered after applying patch 3 from the RFC [2]. I'm submitting this as an R

[Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-25 Thread Yunsheng Lin
Networking driver with page_pool support may hand over page still with dma mapping to network stack and try to reuse that page after network stack is done with it and passes it back to page_pool to avoid the penalty of dma mapping/unmapping. With all the caching in the network stack, some pages may

[Intel-wired-lan] [PATCH net v2 0/2] fix two bugs related to page_pool

2024-09-25 Thread Yunsheng Lin
Patch 1 fix a possible time window problem for page_pool. Patch 2 fix the kernel crash problem at iommu_get_dma_domain reported in [1]. When page_pool_put_unrefed_netmem() is called with allow_direct being true, there is only a newly added checking overhead introduced in patch 1, which seem to be

Re: [Intel-wired-lan] [PATCH net v2 0/2] fix two bugs related to page_pool

2024-09-25 Thread Yonglong Liu
Tested-by: Yonglong Liu On 2024/9/25 15:57, Yunsheng Lin wrote: Patch 1 fix a possible time window problem for page_pool. Patch 2 fix the kernel crash problem at iommu_get_dma_domain reported in [1]. When page_pool_put_unrefed_netmem() is called with allow_direct being true, there is only a ne

[Intel-wired-lan] [PATCH AUTOSEL 6.6 007/139] ice: Adjust over allocation of memory in ice_sched_add_root_node() and ice_sched_add_node()

2024-09-25 Thread Sasha Levin
From: Aleksandr Mishin [ Upstream commit 62fdaf9e8056e9a9e6fe63aa9c816ec2122d60c6 ] In ice_sched_add_root_node() and ice_sched_add_node() there are calls to devm_kcalloc() in order to allocate memory for array of pointers to 'ice_sched_node' structure. But incorrect types are used as sizeof() ar

[Intel-wired-lan] [PATCH AUTOSEL 6.6 018/139] e1000e: avoid failing the system during pm_suspend

2024-09-25 Thread Sasha Levin
From: Vitaly Lifshits [ Upstream commit 0a6ad4d9e1690c7faa3a53f762c877e477093657 ] Occasionally when the system goes into pm_suspend, the suspend might fail due to a PHY access error on the network adapter. Previously, this would have caused the whole system to fail to go to a low power state. A

[Intel-wired-lan] [PATCH AUTOSEL 6.11 009/244] ice: Adjust over allocation of memory in ice_sched_add_root_node() and ice_sched_add_node()

2024-09-25 Thread Sasha Levin
From: Aleksandr Mishin [ Upstream commit 62fdaf9e8056e9a9e6fe63aa9c816ec2122d60c6 ] In ice_sched_add_root_node() and ice_sched_add_node() there are calls to devm_kcalloc() in order to allocate memory for array of pointers to 'ice_sched_node' structure. But incorrect types are used as sizeof() ar

[Intel-wired-lan] [PATCH AUTOSEL 6.11 022/244] e1000e: avoid failing the system during pm_suspend

2024-09-25 Thread Sasha Levin
From: Vitaly Lifshits [ Upstream commit 0a6ad4d9e1690c7faa3a53f762c877e477093657 ] Occasionally when the system goes into pm_suspend, the suspend might fail due to a PHY access error on the network adapter. Previously, this would have caused the whole system to fail to go to a low power state. A

[Intel-wired-lan] [PATCH AUTOSEL 6.10 007/197] ice: Adjust over allocation of memory in ice_sched_add_root_node() and ice_sched_add_node()

2024-09-25 Thread Sasha Levin
From: Aleksandr Mishin [ Upstream commit 62fdaf9e8056e9a9e6fe63aa9c816ec2122d60c6 ] In ice_sched_add_root_node() and ice_sched_add_node() there are calls to devm_kcalloc() in order to allocate memory for array of pointers to 'ice_sched_node' structure. But incorrect types are used as sizeof() ar

[Intel-wired-lan] [PATCH AUTOSEL 6.10 019/197] e1000e: avoid failing the system during pm_suspend

2024-09-25 Thread Sasha Levin
From: Vitaly Lifshits [ Upstream commit 0a6ad4d9e1690c7faa3a53f762c877e477093657 ] Occasionally when the system goes into pm_suspend, the suspend might fail due to a PHY access error on the network adapter. Previously, this would have caused the whole system to fail to go to a low power state. A

Re: [Intel-wired-lan] [PATCH v2 1/1] igb: Do not bring the device up after non-fatal error

2024-09-25 Thread Simon Horman
On Tue, Sep 24, 2024 at 03:06:01PM -0600, Mohamed Khalfella wrote: > Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") > changed igb_io_error_detected() to ignore non-fatal pcie errors in order > to avoid hung task that can happen when igb_down() is called multiple > times. This ca

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 5b254fc607367e7420d07d72a2595a676bc1f84a

2024-09-25 Thread kernel test robot
allyesconfiggcc-13.2.0 arc randconfig-001-20240925gcc-13.2.0 arc randconfig-002-20240925gcc-13.2.0 arcvdk_hs38_smp_defconfigclang-20 arm allmodconfigclang-20 arm