Re: [Intel-wired-lan] [PATCH] ice: Use common error handling code in two functions

2024-09-19 Thread Przemek Kitszel
On 9/19/24 19:15, Markus Elfring wrote: From: Markus Elfring Date: Thu, 19 Sep 2024 19:00:25 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of two function implementations. Thank you for contribution, the change is fine, but not as a bugfix. Please

Re: [Intel-wired-lan] [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-19 Thread Jesper Dangaard Brouer
On 19/09/2024 13.15, Yunsheng Lin wrote: On 2024/9/19 17:42, Jesper Dangaard Brouer wrote: On 18/09/2024 19.06, Ilias Apalodimas wrote: In order not to do the dma unmmapping after driver has already unbound and stall the unloading of the networking driver, add the pool->items array to recor

Re: [Intel-wired-lan] [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-19 Thread Ilias Apalodimas
Hi Jesper, On Fri, 20 Sept 2024 at 00:04, Jesper Dangaard Brouer wrote: > > > > On 19/09/2024 13.15, Yunsheng Lin wrote: > > On 2024/9/19 17:42, Jesper Dangaard Brouer wrote: > >> > >> On 18/09/2024 19.06, Ilias Apalodimas wrote: > In order not to do the dma unmmapping after driver has alrea

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 2f0bdf7f38208cd8ddac5c4aa261829a8056c192

2024-09-19 Thread kernel test robot
gcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20240919gcc-13.2.0 arc randconfig-002-20240919gcc-13.2.0 arm allmodconfiggcc-14.1.0 arm allnoconfig

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: disallow DPLL_PIN_STATE_SELECTABLE for dpll output pins

2024-09-19 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Arkadiusz Kubalewski > Sent: Thursday, September 12, 2024 2:24 PM > To: intel-wired-...@lists.osuosl.org > Cc: Loktionov, Aleksandr ; Paul Menzel > ; Kubalewski, Arkadiusz > > Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice:

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: disallow DPLL_PIN_STATE_SELECTABLE for dpll output pins

2024-09-19 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Arkadiusz Kubalewski > Sent: Thursday, September 12, 2024 2:24 PM > To: intel-wired-...@lists.osuosl.org > Cc: Loktionov, Aleksandr ; Paul Menzel > ; Kubalewski, Arkadiusz > > Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice:

Re: [Intel-wired-lan] [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-19 Thread Yunsheng Lin
On 2024/9/19 1:06, Ilias Apalodimas wrote: > Hi Yunsheng, > > Thanks for looking into this! > > On Wed, 18 Sept 2024 at 14:24, Yunsheng Lin wrote: >> >> Networking driver with page_pool support may hand over page >> still with dma mapping to network stack and try to reuse that >> page after netw

Re: [Intel-wired-lan] [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-19 Thread Yunsheng Lin
On 2024/9/19 17:42, Jesper Dangaard Brouer wrote: > > On 18/09/2024 19.06, Ilias Apalodimas wrote: >>> In order not to do the dma unmmapping after driver has already >>> unbound and stall the unloading of the networking driver, add >>> the pool->items array to record all the pages including the on

Re: [Intel-wired-lan] [PATCH v7 net-next 11/15] testing: net-drv: add basic shaper test

2024-09-19 Thread Paolo Abeni
On 9/10/24 23:41, Stanislav Fomichev wrote: On 09/10, Paolo Abeni wrote: Leverage a basic/dummy netdevsim implementation to do functional coverage for NL interface. Signed-off-by: Paolo Abeni --- v5 -> v6: - additional test-cases for delegation and queue reconf v4 -> v5: - updated to ne

Re: [Intel-wired-lan] [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-19 Thread Jesper Dangaard Brouer
On 18/09/2024 19.06, Ilias Apalodimas wrote: In order not to do the dma unmmapping after driver has already unbound and stall the unloading of the networking driver, add the pool->items array to record all the pages including the ones which are handed over to network stack, so the page_pool can

Re: [Intel-wired-lan] [PATCH v7 net-next 14/15] iavf: Add net_shaper_ops support

2024-09-19 Thread Paolo Abeni
On 9/11/24 00:03, Jakub Kicinski wrote: On Tue, 10 Sep 2024 00:10:08 +0200 Paolo Abeni wrote: + if (adapter->netdev->reg_state == NETREG_REGISTERED) { + mutex_lock(&adapter->netdev->lock); + devlock = true; + } This leads to a false positive in cocci.

Re: [Intel-wired-lan] [PATCH v7 net-next 02/15] netlink: spec: add shaper YAML spec

2024-09-19 Thread Paolo Abeni
Hi, On 9/10/24 14:08, Paul Menzel wrote>> +config NET_SHAPER + bool It’d be great if you added a help text/description. […] Thank you for the feedback. The lack of description here is intentional: we don't want user to enable the knob explicitly, only via 'select'. I'll handle the

[Intel-wired-lan] [PATCH] ice: Use common error handling code in two functions

2024-09-19 Thread Markus Elfring
From: Markus Elfring Date: Thu, 19 Sep 2024 19:00:25 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of two function implementations. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/int

Re: [Intel-wired-lan] [PATCH] ice: Use common error handling code in two functions

2024-09-19 Thread Keller, Jacob E
> -Original Message- > From: Markus Elfring > Sent: Thursday, September 19, 2024 10:15 AM > To: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; David S. Miller > ; Eric Dumazet ; Keller, Jacob E > ; Jakub Kicinski ; Kolacinski, > Karol > ; Paolo Abeni ; Kitszel, > Przemyslaw ;