Initially, during VF creation it registers the PTP clock in
the system and negotiates with PF it's capabilities. In the
meantime the PF enables the Flexible Descriptor for VF.
Only this type of descriptor allows to receive Rx timestamps.
Enabling virtual clock would be possible, though it would pr
From: Jacob Keller
Add support for allowing a VF to enable PTP feature - Rx timestamps
The new capability is gated by VIRTCHNL_VF_CAP_PTP, which must be
set by the VF to request access to the new operations. In addition, the
VIRTCHNL_OP_1588_PTP_CAPS command is used to determine the specific
cap
From: Simei Su
To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by
the VF to request PTP capability and responded by the PF what capability
is enabled for that VF.
Hardware captures timestamps which contain only 32 bits of nominal
nanoseconds, as opposed to the 64bit timestamps
From: Jacob Keller
Support for allowing VF to negotiate the descriptor format requires that
the VF specify which descriptor format to use when requesting Rx queues.
The VF is supposed to request the set of supported formats via the new
VIRTCHNL_OP_GET_SUPPORTED_RXDIDS, and then set one of the sup
From: Jacob Keller
Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
driver the ability to determine what Rx descriptor formats are
available. This requires sending an additional message during
initialization and reset, the VIRTCHNL_OP_GET_SUPPORTED_RXDIDS. This
operation requ
From: Jacob Keller
Add a new extended capabilities negotiation to exchange information from
the PF about what PTP capabilities are supported by this VF. This
requires sending a VIRTCHNL_OP_1588_PTP_GET_CAPS message, and waiting
for the response from the PF. Handle this early on during the VF
init
From: Jacob Keller
Add the iavf_ptp.c file and fill it in with a skeleton framework to
allow registering the PTP clock device.
Add implementation of helper functions to check if a PTP capability
is supported and handle change in PTP capabilities.
Enabling virtual clock would be possible, though i
From: Jacob Keller
The Rx timestamps reported by hardware may only have 32 bits of storage
for nanosecond time. These timestamps cannot be directly reported to the
Linux stack, as it expects 64bits of time.
To handle this, the timestamps must be extended using an algorithm that
calculates the co
From: Jacob Keller
Implement support for reading the PHC time indirectly via the
VIRTCHNL_OP_1588_PTP_GET_TIME operation.
Based on some simple tests with ftrace, the latency of the indirect
clock access appears to be about ~110 microseconds. This is due to the
cost of preparing a message to send
Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
idpf and iavf Intel drivers. This commit changes the prefix from
idpf_* to libeth_* and moves mentioned structs to libeth's rx.h header
file.
Usage in idpf driver has been adjusted.
Suggested-by: Alexander Lobakin
Signed-off-by:
The union iavf_32byte_rx_desc consists of two unnamed structs defined
inside. One of them represents legacy 32 byte descriptor and second the
16 byte descriptor (extended to 32 byte). Each of them consists of
bunch of unions, structs and __le fields that represent specific fields
in descriptor.
Th
Rx timestamping introduced in PF driver caused the need of refactoring
the VF driver mechanism to check packet fields.
The function to check errors in descriptor has been removed and from
now only previously set struct fields are being checked. The field DD
(descriptor done) needs to be checked at
From: Jacob Keller
Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
negotiating to enable the advanced flexible descriptor layout. Add the
flexible NIC layout (RXDID=2) as a member of the Rx descriptor union.
Also add bit position definitions for the status and error indication
From: Jacob Keller
Add handlers for the .ndo_hwtstamp_get and .ndo_hwtstamp_set ops which allow
userspace to request timestamp enablement for the device. This support allows
standard Linux applications to request the timestamping desired.
As with other devices that support timestamping all packe
From: Jacob Keller
Add support for receive timestamps to the Rx hotpath. This support only
works when using the flexible descriptor format, so make sure that we
request this format by default if we have receive timestamp support
available in the PTP capabilities.
In order to report the timestamp
On 7/22/2024 11:23 AM, Mateusz Polchlopek wrote:
On 7/14/2024 4:23 PM, Jakub Kicinski wrote:
On Fri, 12 Jul 2024 05:32:48 -0400 Mateusz Polchlopek wrote:
+ err = devlink_health_report(reporter, msg, priv_ctx);
+ if (err) {
+ struct ice_pf *pf = devlink_health_reporter_priv(rep
On 7/14/2024 4:30 PM, Jakub Kicinski wrote:
On Fri, 12 Jul 2024 05:32:51 -0400 Mateusz Polchlopek wrote:
+ buf_pos = ice_emit_to_buf(buf, buf_size, buf_pos,
+ "skb len=%u headroom=%u headlen=%u tailroom=%u\n"
+ "mac=(%d,%d) net=(%d,%d) trans=%d\n"
+
On Tue Jul 30 2024, Song Yoong Siang wrote:
> From: Blanco Alcaine Hector
>
> This commit introduces the support to configure default Rx queue during
> runtime. A new sysfs attribute "default_rx_queue" has been added, allowing
> users to check and modify the default Rx queue.
>
> 1. Command to che
On 30.07.2024 03:23, Song Yoong Siang wrote:
> From: Blanco Alcaine Hector
>
> This commit introduces the support to configure default Rx queue during
> runtime. A new sysfs attribute "default_rx_queue" has been added, allowing
> users to check and modify the default Rx queue.
>
> 1. Command
On Thu, Jul 25, 2024 at 04:07:58PM -0600, Ahmed Zaki wrote:
> From: Junfeng Guo
>
> Parse the following DDP sections:
> - ICE_SID_RXPARSER_IMEM into an array of struct ice_imem_item
> - ICE_SID_RXPARSER_METADATA_INIT into an array of struct ice_metainit_item
> - ICE_SID_RXPARSER_CAM or ICE_SID
On Thu, Jul 25, 2024 at 04:08:01PM -0600, Ahmed Zaki wrote:
> From: Junfeng Guo
>
> Implement the core work of the runtime parser via:
> - ice_parser_rt_execute()
> - ice_parser_rt_reset()
> - ice_parser_rt_pkt_buf_set()
>
> Reviewed-by: Marcin Szycik
> Signed-off-by: Qi Zhang
> Signed-off-by:
On Thu, Jul 25, 2024 at 04:08:02PM -0600, Ahmed Zaki wrote:
> From: Junfeng Guo
>
> Add API ice_parser_dvm_set() to support turning on/off the parser's double
> vlan mode.
>
> Reviewed-by: Marcin Szycik
> Signed-off-by: Qi Zhang
> Signed-off-by: Junfeng Guo
> Co-developed-by: Ahmed Zaki
> Si
On Thu, Jul 25, 2024 at 04:08:04PM -0600, Ahmed Zaki wrote:
> From: Junfeng Guo
>
> Add API ice_parser_profile_init() to init a parser profile based on
> a parser result and a mask buffer. The ice_parser_profile struct is used
> by the low level FXP engine to create HW profile/field vectors.
>
>
On Thu, Jul 25, 2024 at 04:08:06PM -0600, Ahmed Zaki wrote:
> From: Junfeng Guo
>
> The SWAP Flag in the FDIR Programming Descriptor doesn't work properly,
> it is always set and cannot be unset (hardware bug). Thus, add a method
> to effectively disable the FDIR SWAP option by setting the FDSWAP
On Thu, Jul 25, 2024 at 04:08:07PM -0600, Ahmed Zaki wrote:
> From: Junfeng Guo
>
> Enable VFs to create FDIR filters from raw binary patterns.
> The corresponding processes for raw flow are added in the
> Parse / Create / Destroy stages.
>
> Reviewed-by: Marcin Szycik
> Signed-off-by: Junfeng
On Thu, Jul 25, 2024 at 04:08:08PM -0600, Ahmed Zaki wrote:
> In preparation for a second type of FDIR filters that can be added by
> tc-u32, move the add/del of the FDIR logic to be entirely contained in
> iavf_fdir.c.
>
> The iavf_find_fdir_fltr_by_loc() is renamed to iavf_find_fdir_fltr()
> to
On Thu, Jul 25, 2024 at 04:08:09PM -0600, Ahmed Zaki wrote:
> Add support for offloading cls U32 filters. Only "skbedit queue_mapping"
> and "drop" actions are supported. Also, only "ip" and "802_3" tc
> protocols are allowed. The PF must advertise the VIRTCHNL_VF_OFFLOAD_TC_U32
> capability flag.
Enable ethtool reset support. Each ethtool reset
type is mapped to the CVL reset type:
ETH_RESET_MAC - ICE_RESET_CORER
ETH_RESET_ALL - ICE_RESET_GLOBR
ETH_RESET_DEDICATED - ICE_RESET_PFR
Multiple reset flags are not supported.
Calling any reset type on port representor triggers VF reset.
Command
On Mon, Jul 29, 2024 at 10:54:50AM +0200, Alexander Lobakin wrote:
> From: Simon Horman
> Date: Fri, 26 Jul 2024 17:09:54 +0100
>
> > On Wed, Jul 24, 2024 at 03:40:22PM +0200, Alexander Lobakin wrote:
> >> The second tagged commit introduced a UAF, as it removed restoring
> >> q_vector->vport poi
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:14:55 -0400
> [PATCH iwl-next v8 00/14] Add support for Rx timestamping for both ice
> and iavf drivers.
Oops, please remove that period at the end of the sentence when sending
next version.
> Initially, during VF creation it registers the PTP
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:14:57 -0400
> From: Simei Su
>
> To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by
> the VF to request PTP capability and responded by the PF what capability
> is enabled for that VF.
[...]
> diff --git a/drivers/net/ether
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:14:58 -0400
> From: Jacob Keller
>
> Support for allowing VF to negotiate the descriptor format requires that
> the VF specify which descriptor format to use when requesting Rx queues.
> The VF is supposed to request the set of supported format
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:14:59 -0400
> From: Jacob Keller
>
> Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
> driver the ability to determine what Rx descriptor formats are
> available. This requires sending an additional message during
> initia
On 30.07.2024 03:23, Song Yoong Siang wrote:
> From: Blanco Alcaine Hector
>
> This commit introduces the support to configure default Rx queue during
Use imperative mood.
> runtime. A new sysfs attribute "default_rx_queue" has been added, allowing
> users to check and modify the default Rx
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:00 -0400
> From: Jacob Keller
>
> Add a new extended capabilities negotiation to exchange information from
> the PF about what PTP capabilities are supported by this VF. This
> requires sending a VIRTCHNL_OP_1588_PTP_GET_CAPS message, and wa
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:01 -0400
> From: Jacob Keller
>
> Add the iavf_ptp.c file and fill it in with a skeleton framework to
> allow registering the PTP clock device.
> Add implementation of helper functions to check if a PTP capability
> is supported and handle c
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:02 -0400
> From: Jacob Keller
>
> Implement support for reading the PHC time indirectly via the
> VIRTCHNL_OP_1588_PTP_GET_TIME operation.
[...]
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_ptp.c
> b/drivers/net/ethernet/intel/iavf
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:03 -0400
> From: Jacob Keller
>
> The Rx timestamps reported by hardware may only have 32 bits of storage
> for nanosecond time. These timestamps cannot be directly reported to the
> Linux stack, as it expects 64bits of time.
[...]
> +stat
On Tue, 30 Jul 2024 12:51:21 +0200 Wojciech Drewek wrote:
> ETH_RESET_MAC - ICE_RESET_CORER
Core doesn't really sound like MAC, what is it?
And does PF reset reset mostly PCIe side or more?
My knee jerk mapping would be to map Core to dedicated
and PF to DMA.
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:04 -0400
> Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
> idpf and iavf Intel drivers. This commit changes the prefix from
> idpf_* to libeth_* and moves mentioned structs to libeth's rx.h header
> file.
[...]
> diff -
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:05 -0400
> [PATCH iwl-next v8 10/14] iavf: flatten union iavf_32byte_rx_desc
I feel like the description is not precise. You change the descriptor
representation from single small fields to quad-words, so it should be
something like
iavf: de
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:06 -0400
> From: Jacob Keller
>
> Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
> negotiating to enable the advanced flexible descriptor layout. Add the
> flexible NIC layout (RXDID=2) as a member of the Rx descriptor un
-13.2.0
arc randconfig-001-20240730 gcc-13.2.0
arc randconfig-002-20240730 gcc-13.2.0
arm allmodconfig gcc-13.2.0
arm allmodconfig gcc-14.1.0
arm allnoconfig clang-20
On Tue, 30 Jul 2024 09:22:12 +0800 Song Yoong Siang wrote:
> This patch set introduces the support to configure default Rx queue during
> runtime.
> A new sysfs attribute "default_rx_queue" has been added, allowing users to
> check
> and modify the default Rx queue.
Why the extra uAPI.. a wildca
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:08 -0400
> From: Jacob Keller
>
> Add handlers for the .ndo_hwtstamp_get and .ndo_hwtstamp_set ops which allow
> userspace to request timestamp enablement for the device. This support allows
> standard Linux applications to request the times
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:09 -0400
> From: Jacob Keller
>
> Add support for receive timestamps to the Rx hotpath. This support only
> works when using the flexible descriptor format, so make sure that we
> request this format by default if we have receive timestamp s
On Mon, Jul 29, 2024 at 10:54:50AM +0200, Alexander Lobakin wrote:
> From: Simon Horman
> Date: Fri, 26 Jul 2024 17:09:54 +0100
>
> > On Wed, Jul 24, 2024 at 03:40:22PM +0200, Alexander Lobakin wrote:
> >> The second tagged commit introduced a UAF, as it removed restoring
> >> q_vector->vport poi
allnoconfig gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc defconfig gcc-13.2.0
arcnsimosci_defconfig gcc-13.2.0
arc randconfig-001-20240730 gcc-13.2.0
arc
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Mateusz Polchlopek
> Sent: Friday, July 26, 2024 3:49 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Drewek, Wojciech ;
> Polchlopek, Mateusz
> Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: Fix inc
49 matches
Mail list logo
