On 29.05.2024 02:02, Jacob Keller wrote:
>
>
> On 5/28/2024 12:16 PM, Jakub Kicinski wrote:
>> On Tue, 28 May 2024 13:01:32 +0200 Wojciech Drewek wrote:
>>> Subject: [PATCH iwl-net v2] ice: Add support for devlink loopback param.
>>
>> iwl-next, presumably
>>
>> Param makes sense, although the
On 5/28/2024 1:43 PM, Paul Menzel wrote:
Dear Vitaly,
Thank you for the patch.
Am 28.05.24 um 12:33 schrieb Vitaly Lifshits:
From: Dima Ruinskiy
On vPro systems,the configuration of the I219-LM to achieve power
s/,the /, the /
Thank you for noticing it.
I will fix it in a v2.
gat
Hi,
changes included in this patchset address an issue that customer has
been facing when AF_XDP ZC Tx sockets were used in combination with flow
control and regular Tx traffic.
After executing:
ethtool --set-priv-flags $dev link-down-on-close on
ethtool -A $dev rx on tx on
launching multiple ZC
From: Michal Kubiak
Address a scenario in which XSK ZC Tx produces descriptors to XDP Tx
ring when link is either not yet fully initialized or process of
stopping the netdev has already started. To avoid this, add checks
against carrier readiness in ice_xsk_wakeup() and in ice_xmit_zc().
One coul
When ice driver is spammed with multiple xdpsock instances and flow
control is enabled, there are cases when Rx queue gets stuck and unable
to reflect the disable state in QRX_CTRL register. Similar issue has
previously been addressed in commit 13a6233b033f ("ice: Add support to
enable/disable all
Given that ice_qp_dis() is called under rtnl_lock, synchronize_net() can
be called instead of synchronize_rcu() so that XDP rings can finish its
job in a faster way. Also let us do this as earlier in XSK queue disable
flow.
Additionally, turn off regular Tx queue before disabling irqs and NAPI.
F
Don't bail out right when spotting an error within ice_qp_{dis,ena}()
but rather track error and go through whole flow of disabling and
enabling queue pair.
Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Signed-off-by: Maciej Fijalkowski
---
drivers/net/ethernet/intel/ice/ice_xsk.c | 30 +++
This so we prevent Tx timeout issues. One of conditions checked on
running in the background dev_watchdog() is netif_carrier_ok(), so let
us turn it off when we disable the queues that belong to a q_vector
where XSK pool is being configured.
Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Sign
xsk_buff_pool pointers that ice ring structs hold are updated via
ndo_bpf that is executed in process context while it can be read by
remote CPU at the same time within NAPI poll. Use synchronize_net()
after pointer update and {READ,WRITE}_ONCE() when working with mentioned
pointer.
Fixes: 2d4238f
It is read by data path and modified from process context on remote cpu
so it is needed to use WRITE_ONCE to clear the pointer.
Fixes: efc2214b6047 ("ice: Add support for XDP")
Signed-off-by: Maciej Fijalkowski
---
drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
1 file changed, 1 insertion(+),
ice_cfg_txq_interrupt() internally handles XDP Tx ring. Do not use
ice_for_each_tx_ring() in ice_qvec_cfg_msix() as this causing us to
treat XDP ring that belongs to queue vector as Tx ring and therefore
misconfiguring the interrupts.
Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Signed-off-
Dear Vitaly,
Thank you for your reply.
Am 29.05.24 um 13:13 schrieb Lifshits, Vitaly:
On 5/28/2024 1:43 PM, Paul Menzel wrote:
Am 28.05.24 um 12:33 schrieb Vitaly Lifshits:
From: Dima Ruinskiy
On vPro systems,the configuration of the I219-LM to achieve power
s/,the /, the /
Thank y
On 5/29/2024 1:54 AM, Keller, Jacob E wrote:
-Original Message-
From: Jakub Kicinski
Sent: Tuesday, May 28, 2024 1:01 PM
To: Polchlopek, Mateusz
Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Keller, Jacob E
; Drewek, Wojciech ;
Rahul Rameshbabu
Subject: Re: [Intel-wi
Hi Alexander,
On 27/03/2024 3:23 pm, Alexander Lobakin wrote:
Now that we have generic bitmap_read() and bitmap_write(), which are
inline and try to take care of non-bound-crossing and aligned cases
to keep them optimized, collapse bitmap_{get,set}_value8() into
simple wrappers around the former
> -Original Message-
> From: Intel-wired-lan On Behalf Of Karen
> Ostrowska
> Sent: Tuesday, May 28, 2024 2:32 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Joyner, Eric ; net...@vger.kernel.org; Kitszel,
> Przemyslaw ; Ostrowska, Karen
> ; Michal Swiatkowski
>
> Subject: [Intel-wir
gcc
arc randconfig-001-20240529 gcc
arc randconfig-002-20240529 gcc
arm allmodconfig gcc
arm allnoconfig clang
arm allyesconfig
-001-20240529 gcc
arc randconfig-002-20240529 gcc
arm allmodconfig gcc
arm allnoconfig clang
arm allyesconfig gcc
arm defconfig clang
arm
Dear En-Wei,
Thank you for responding so quickly.
Am 29.05.24 um 05:17 schrieb En-Wei WU:
[…]
What effect does this have on resume time?
When we call ice_init_rdma() at resume time, it will allocate entries
at pf->irq_tracker.entries and update pf->msix_entries for later use
(request_irq)
gcc
arc allnoconfig gcc
arc allyesconfig gcc
arc defconfig gcc
arc randconfig-001-20240529 gcc
arc randconfig-002-20240529 gcc
arm
From: Jan Sokolowski
TC queues needs to be correctly updated when the number of queues on
a VSI is reconfigured, so netdev's queue and TC settings will be
dynamically adjusted and could accurately represent the underlying
hardware state after changes to the VSI queue counts.
Fixes: 0754d65bd4be
On Tue, 28 May 2024 15:48:35 +0200 Alexander Lobakin wrote:
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index 95a59ac78f82..d0cf9a2d82de 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -1155,6 +1155,7 @@ sub dump_struct($$) {
> $members =~ s/\bstruct_group_at
On Tue, 28 May 2024 15:48:45 +0200 Alexander Lobakin wrote:
> Currently, idpf uses the following model for the header buffers:
>
> * buffers are allocated via dma_alloc_coherent();
> * when receiving, napi_alloc_skb() is called and then the header is
> copied to the newly allocated linear part.
> -Original Message-
> From: Intel-wired-lan On Behalf Of Jacob
> Keller
> Sent: Saturday, May 25, 2024 4:37 AM
> To: Kitszel, Przemyslaw ; Intel Wired LAN
> ; Paul Menzel
> Cc: Keller, Jacob E ; Greenwalt, Paul
>
> Subject: [Intel-wired-lan] [PATCH iwl-net v4] ice: fix iteration of T
Dear Karen, dear Jan,
Thank you for the patch.
Am 29.05.24 um 09:17 schrieb Karen Ostrowska:
From: Jan Sokolowski
TC queues needs to be correctly updated when the number of queues on
need
a VSI is reconfigured, so netdev's queue and TC settings will be
dynamically adjusted and could accu
> -Original Message-
> From: Andy Shevchenko
> Sent: Monday, May 27, 2024 8:04 PM
> To: D, Lakshmi Sowjanya
> Cc: Andy Shevchenko ; t...@linutronix.de;
> jstu...@google.com; giome...@enneenne.com; cor...@lwn.net; linux-
> ker...@vger.kernel.org; x...@kernel.org; net...@vger.kernel.org;
>-Original Message-
>From: Intel-wired-lan On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, May 15, 2024 9:32 PM
>To: intel-wired-...@lists.osuosl.org; Keller, Jacob E
>
>Cc: Fijalkowski, Maciej ; Jesper Dangaard Brouer
>; Daniel Borkmann ; Zaremba,
>Larysa ; Kitszel, Przemyslaw
>; John
>-Original Message-
>From: Intel-wired-lan On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, May 15, 2024 9:32 PM
>To: intel-wired-...@lists.osuosl.org; Keller, Jacob E
>
>Cc: Fijalkowski, Maciej ; Jesper Dangaard Brouer
>; Daniel Borkmann ; Zaremba,
>Larysa ; Kitszel, Przemyslaw
>; John
>-Original Message-
>From: Intel-wired-lan On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, May 15, 2024 9:32 PM
>To: intel-wired-...@lists.osuosl.org; Keller, Jacob E
>
>Cc: Fijalkowski, Maciej ; Jesper Dangaard Brouer
>; Daniel Borkmann ; Zaremba,
>Larysa ; Kitszel, Przemyslaw
>; John
28 matches
Mail list logo
