Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change usleep_range to udelay in PHY mdic access

2024-04-26 Thread Linux regression tracking (Thorsten Leemhuis)
[CCing the maintainers and a few lists] On 17.04.24 21:03, Vitaly Lifshits wrote: > This is a partial revert of commit 6dbdd4de0362 ("e1000e: Workaround > for sporadic MDI error on Meteor Lake systems"). The referenced commit > introduced an issue on vPro systems, where disconnecting and reconnect

Re: [Intel-wired-lan] [PATCH iwl-next v5 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors

2024-04-26 Thread Mateusz Polchlopek
On 4/23/2024 12:51 PM, Sunil Kovvuri Goutham wrote: -Original Message- From: Mateusz Polchlopek Sent: Thursday, April 18, 2024 10:55 AM To: intel-wired-...@lists.osuosl.org Cc: net...@vger.kernel.org; ho...@kernel.org; anthony.l.ngu...@intel.com; Jacob Keller ; Wojciech Drewek ; Ma

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-26 Thread Jiri Pirko
Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote: > > >On 4/24/2024 8:07 AM, Jiri Pirko wrote: >> Wed, Apr 24, 2024 at 12:03:25AM CEST, jacob.e.kel...@intel.com wrote: >>> >>> >>> On 4/23/2024 6:14 AM, Jiri Pirko wrote: Tue, Apr 23, 2024 at 01:56:55PM CEST, sergey.temerkha.

Re: [Intel-wired-lan] [PATCH iwl-next v5 5/5] ixgbe: Enable link management in E610 device

2024-04-26 Thread Kwapulinski, Piotr
>-Original Message- >From: Paul Menzel >Sent: Wednesday, April 24, 2024 4:53 PM >To: Kwapulinski, Piotr >Cc: intel-wired-...@lists.osuosl.org; j...@resnulli.us; >net...@vger.kernel.org; Jagielski, Jedrzej ; >ho...@kernel.org; Wyborny, Carolyn ; Glaza, Jan > >Subject: Re: [Intel-wired-l

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-26 Thread Przemek Kitszel
On 4/26/24 13:19, Jiri Pirko wrote: Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote: On 4/24/2024 8:07 AM, Jiri Pirko wrote: Wed, Apr 24, 2024 at 12:03:25AM CEST, jacob.e.kel...@intel.com wrote: On 4/23/2024 6:14 AM, Jiri Pirko wrote: Tue, Apr 23, 2024 at 01:56:55PM C

[Intel-wired-lan] [RFC net-next (what uAPI?) ice: add support for more than 16 RSS queues for VF

2024-04-26 Thread Przemek Kitszel
Main aim for this RFC is to ask for the preferred uAPI, but let me start with some background. Then I describe considered uAPIs, from most readily available to most implementation-needed. ## why We want to extend ice+iavf in order to support more than 16 RSS-enabled queues for a VF. To do so we h

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-26 Thread Jiri Pirko
Fri, Apr 26, 2024 at 02:49:40PM CEST, przemyslaw.kits...@intel.com wrote: >On 4/26/24 13:19, Jiri Pirko wrote: >> Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote: >> > >> > >> > On 4/24/2024 8:07 AM, Jiri Pirko wrote: >> > > Wed, Apr 24, 2024 at 12:03:25AM CEST, jacob.e.kel..

Re: [Intel-wired-lan] [PATCH v2 5/6] cio: ensure the copied buf is NUL terminated

2024-04-26 Thread Jakub Kicinski
On Fri, 26 Apr 2024 12:10:35 +0200 Alexander Gordeev wrote: > On Wed, Apr 24, 2024 at 05:16:56PM +0200, Alexander Gordeev wrote: > > Applied, thanks! > > Hi Jakub, > > I just want to make sure you do not have plans to pull this patch > via the net tree, right? (I schedulled it for the s390 tree

Re: [Intel-wired-lan] [PATCH net v2] igb: cope with large MAX_SKB_FRAGS

2024-04-26 Thread Corinna Vinschen
Hi Eric, On Apr 23 16:10, Eric Dumazet wrote: > On Tue, Apr 23, 2024 at 3:47 PM Corinna Vinschen wrote: > > > > From: Paolo Abeni > > > > Sabrina reports that the igb driver does not cope well with large > > MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload > > corruption on TX. > >

[Intel-wired-lan] [PATCH iwl] idpf: don't enable NAPI and interrupts prior to allocating Rx buffers

2024-04-26 Thread Alexander Lobakin
Currently, idpf enables NAPI and interrupts prior to allocating Rx buffers. This may lead to frame loss (there are no buffers to place incoming frames) and even crashes on quick ifup-ifdown. Interrupts must be enabled only after all the resources are here and available. Split interrupt init into tw

Re: [Intel-wired-lan] [PATCH v2 5/6] cio: ensure the copied buf is NUL terminated

2024-04-26 Thread Alexander Gordeev
On Wed, Apr 24, 2024 at 05:16:56PM +0200, Alexander Gordeev wrote: > Applied, thanks! Hi Jakub, I just want to make sure you do not have plans to pull this patch via the net tree, right? (I schedulled it for the s390 tree already). Thanks!

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS e3eb7dd47bd4806f00e104eb6da092c435f9fb21

2024-04-26 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20240426 gcc arc randconfig-002-20240426 gcc arm

[Intel-wired-lan] [PATCH iwl-net] idpf: Interpret .set_channels() input differently

2024-04-26 Thread Larysa Zaremba
Unlike ice, idpf does not check, if user has requested at least 1 combined channel. Instead, it relies on a check in the core code. Unfortunately, the check does not trigger for us because of the hacky .set_channels() interpretation logic that is not consistent with the core code. This naturally l

Re: [Intel-wired-lan] [PATCH iwl-next v2 0/7] i40e: cleanups & refactors

2024-04-26 Thread Ivan Vecera
On 12. 04. 24 23:19, Tony Nguyen wrote: On 3/27/2024 12:57 AM, Ivan Vecera wrote: This series do following: Patch 1 - Removes write-only flags field from i40e_veb structure and    from i40e_veb_setup() parameters Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes()

[Intel-wired-lan] [PATCH net-next v3 0/7] i40e: cleanups & refactors

2024-04-26 Thread Ivan Vecera
This series do following: Patch 1 - Removes write-only flags field from i40e_veb structure and from i40e_veb_setup() parameters Patch 2 - Refactors parameter of i40e_notify_client_of_l2_param_changes() and i40e_notify_client_of_netdev_close() Patch 3 - Refactors parameter of i40

[Intel-wired-lan] [PATCH net-next v3 2/7] i40e: Refactor argument of several client notification functions

2024-04-26 Thread Ivan Vecera
Commit 0ef2d5afb12d ("i40e: KISS the client interface") simplified the client interface so in practice it supports only one client per i40e netdev. But we have still 2 notification functions that uses as parameter a pointer to VSI of netdevice associated with the client. After the mentioned commit

[Intel-wired-lan] [PATCH net-next v3 1/7] i40e: Remove flags field from i40e_veb

2024-04-26 Thread Ivan Vecera
The field is initialized always to zero and it is never read. Remove it. Reviewed-by: Michal Schmidt Reviewed-by: Aleksandr Loktionov Reviewed-by: Kalesh AP Reviewed-by: Tony Nguyen Tested-by: Pucha Himasekhar Reddy Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h

[Intel-wired-lan] [PATCH net-next v3 3/7] i40e: Refactor argument of i40e_detect_recover_hung()

2024-04-26 Thread Ivan Vecera
Commit 07d44190a389 ("i40e/i40evf: Detect and recover hung queue scenario") changes i40e_detect_recover_hung() argument type from i40e_pf* to i40e_vsi* to be shareable by both i40e and i40evf. Because the i40evf does not exist anymore and the function is exclusively used by i40e we can revert this

[Intel-wired-lan] [PATCH net-next v3 5/7] i40e: Consolidate checks whether given VSI is main

2024-04-26 Thread Ivan Vecera
In the driver code there are 3 types of checks whether given VSI is main or not: 1. vsi->type ==/!= I40E_VSI_MAIN 2. vsi ==/!= pf->vsi[pf->lan_vsi] 3. vsi->seid ==/!= pf->vsi[pf->lan_vsi]->seid All of them are equivalent and can be consolidated. Convert cases 2 and 3 to case 1. Reviewed-by: Micha

[Intel-wired-lan] [PATCH net-next v3 4/7] i40e: Add helper to access main VSI

2024-04-26 Thread Ivan Vecera
Add simple helper i40e_pf_get_main_vsi(pf) to access main VSI that replaces pattern 'pf->vsi[pf->lan_vsi]' Reviewed-by: Michal Schmidt Reviewed-by: Tony Nguyen Tested-by: Pucha Himasekhar Reddy Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h| 11 ++ drivers/net/

[Intel-wired-lan] [PATCH net-next v3 6/7] i40e: Add helper to access main VEB

2024-04-26 Thread Ivan Vecera
Add a helper to access main VEB: i40e_pf_get_main_veb(pf) replaces 'pf->veb[pf->lan_veb]' Reviewed-by: Michal Schmidt Reviewed-by: Aleksandr Loktionov Reviewed-by: Tony Nguyen Tested-by: Pucha Himasekhar Reddy Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e.h| 11

[Intel-wired-lan] [PATCH net-next v3 7/7] i40e: Add and use helper to reconfigure TC for given VSI

2024-04-26 Thread Ivan Vecera
Add helper i40e_vsi_reconfig_tc(vsi) that configures TC for given VSI using previously stored TC bitmap. Effectively replaces open-coded patterns: enabled_tc = vsi->tc_config.enabled_tc; vsi->tc_config.enabled_tc = 0; i40e_vsi_config_tc(vsi, enabled_tc); Reviewed-by: Michal Schmidt Reviewed-by:

Re: [Intel-wired-lan] [PATCH net v2] igb: cope with large MAX_SKB_FRAGS

2024-04-26 Thread Eric Dumazet
On Fri, Apr 26, 2024 at 4:30 PM Corinna Vinschen wrote: > > Hi Eric, > > On Apr 23 16:10, Eric Dumazet wrote: > > On Tue, Apr 23, 2024 at 3:47 PM Corinna Vinschen > > wrote: > > > > > > From: Paolo Abeni > > > > > > Sabrina reports that the igb driver does not cope well with large > > > MAX_SKB

Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove correct filters during eswitch release

2024-04-26 Thread Simon Horman
On Tue, Apr 23, 2024 at 04:36:32PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > ice_clear_dflt_vsi() is only removing default rule. Both default RX and > TX rule should be removed during release. > > If it isn't switching to switchdev, second time results in error, because > TX fil

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-26 Thread Jacob Keller
On 4/26/2024 6:43 AM, Jiri Pirko wrote: > Fri, Apr 26, 2024 at 02:49:40PM CEST, przemyslaw.kits...@intel.com wrote: >> On 4/26/24 13:19, Jiri Pirko wrote: >>> Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote: On 4/24/2024 8:07 AM, Jiri Pirko wrote: > Wed, A

[Intel-wired-lan] [PATCH iwl-next] ice: add and use roundup_u64 instead of open coding equivalent

2024-04-26 Thread Jacob Keller
In ice_ptp_cfg_clkout(), the ice driver needs to calculate the nearest next second of a current time value specified in nanoseconds. It implements this using div64_u64, because the time value is a u64. It could use div_u64 since NSEC_PER_SEC is smaller than 32-bits. Ideally this would be implement