[Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Karthik Sundaravel
Dear Maintainers, Thanks for the review and suggestions for my patch. v6 -> v7 - Addressed Smatch and checkpatch issues v5 -> v6 - Changed data type of vf_id to u16 - Used container_of(port, struct ice_vf, devlink_port) to get the vf instead of ice_get_vf_by_id()/ice_put_v

[Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Karthik Sundaravel
Changing the MAC address of the VFs is currently unsupported via devlink. Add the function handlers to set and get the HW address for the VFs. Signed-off-by: Karthik Sundaravel --- drivers/net/ethernet/intel/ice/ice_devlink.c | 63 +++- drivers/net/ethernet/intel/ice/ice_sriov.c

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-02 Thread Wojciech Drewek
On 29.03.2024 23:16, Jakub Kicinski wrote: > On Fri, 29 Mar 2024 10:23:18 +0100 Wojciech Drewek wrote: >> Some ethernet modules use nonstandard power levels [1]. Extend ethtool >> module implementation to support new attributes that will allow user >> to change maximum power. Rename structures a

Re: [Intel-wired-lan] [PATCH net-next v5 00/21] ice: add PFCP filter support

2024-04-02 Thread Niklas Schnelle
On Mon, 2024-02-12 at 12:35 +0100, Alexander Lobakin wrote: > From: Jakub Kicinski > Date: Wed, 7 Feb 2024 07:05:35 -0800 > > > On Tue, 6 Feb 2024 13:46:44 +0100 Alexander Lobakin wrote: > > > > Add support for creating PFCP filters in switchdev mode. Add pfcp module > > > > that allows to create

Re: [Intel-wired-lan] [PATCH net-next v5 00/21] ice: add PFCP filter support

2024-04-02 Thread Alexander Lobakin
From: Niklas Schnelle Date: Tue, 02 Apr 2024 12:59:19 +0200 > On Mon, 2024-02-12 at 12:35 +0100, Alexander Lobakin wrote: >> From: Jakub Kicinski >> Date: Wed, 7 Feb 2024 07:05:35 -0800 >> >>> On Tue, 6 Feb 2024 13:46:44 +0100 Alexander Lobakin wrote: > Add support for creating PFCP filters

Re: [Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Jiri Pirko
Tue, Apr 02, 2024 at 11:22:54AM CEST, ksund...@redhat.com wrote: >Changing the MAC address of the VFs is currently unsupported via devlink. >Add the function handlers to set and get the HW address for the VFs. > >Signed-off-by: Karthik Sundaravel >--- > drivers/net/ethernet/intel/ice/ice_devlink.c

Re: [Intel-wired-lan] [PATCH net-next 2/3] ethtool: Introduce max power support

2024-04-02 Thread Wojciech Drewek
On 29.03.2024 23:29, Jakub Kicinski wrote: > On Fri, 29 Mar 2024 10:23:20 +0100 Wojciech Drewek wrote: >> Some modules use nonstandard power levels. Adjust ethtool >> module implementation to support new attributes that will allow user >> to change maximum power. >> >> Add three new get attribut

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-02 Thread Wojciech Drewek
On 30.03.2024 22:57, Andrew Lunn wrote: > On Fri, Mar 29, 2024 at 10:23:18AM +0100, Wojciech Drewek wrote: >> Some ethernet modules use nonstandard power levels [1]. Extend ethtool >> module implementation to support new attributes that will allow user >> to change maximum power. Rename structur

Re: [Intel-wired-lan] [PATCH v4 iwl-next 00/12] Introduce ETH56G PHY model for E825C products

2024-04-02 Thread Kolacinski, Karol
Hi Anthony, On 3/29/2024 9:23 AM, Anthony L Nguyen wrote: > It hasn't been 24 hours since the v3 [1]; for larger changes, you should > wait longer than that [2]. I'm really sorry, I forgot about 24h rule. > Also, where's the changelog? The only thing that changed between V1 and V4 was patch 07

Re: [Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Karthik Sundaravel
On Tue, Apr 2, 2024 at 4:51 PM Jiri Pirko wrote: > > Tue, Apr 02, 2024 at 11:22:54AM CEST, ksund...@redhat.com wrote: > >Changing the MAC address of the VFs is currently unsupported via devlink. > >Add the function handlers to set and get the HW address for the VFs. > > > >Signed-off-by: Karthik S

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-02 Thread Jakub Kicinski
On Tue, 2 Apr 2024 13:38:59 +0200 Wojciech Drewek wrote: > > Also, this is about the board, the SFP cage, not the actual SFP > > module? Maybe the word cage needs to be in these names? > > It's about cage. Thanks for bringing it to my attention because now I > see it might be misleading. I'm ex

Re: [Intel-wired-lan] [PATCH net-next 2/3] ethtool: Introduce max power support

2024-04-02 Thread Jakub Kicinski
On Tue, 2 Apr 2024 13:25:07 +0200 Wojciech Drewek wrote: > On 29.03.2024 23:29, Jakub Kicinski wrote: > > On Fri, 29 Mar 2024 10:23:20 +0100 Wojciech Drewek wrote: > >> Some modules use nonstandard power levels. Adjust ethtool > >> module implementation to support new attributes that will allow u

Re: [Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Jiri Pirko
Tue, Apr 02, 2024 at 03:57:35PM CEST, ksund...@redhat.com wrote: >On Tue, Apr 2, 2024 at 4:51 PM Jiri Pirko wrote: >> >> Tue, Apr 02, 2024 at 11:22:54AM CEST, ksund...@redhat.com wrote: >> >Changing the MAC address of the VFs is currently unsupported via devlink. >> >Add the function handlers to s

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-02 Thread Andrew Lunn
On Tue, Apr 02, 2024 at 01:38:59PM +0200, Wojciech Drewek wrote: > > > On 30.03.2024 22:57, Andrew Lunn wrote: > > On Fri, Mar 29, 2024 at 10:23:18AM +0100, Wojciech Drewek wrote: > >> Some ethernet modules use nonstandard power levels [1]. Extend ethtool > >> module implementation to support new

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-02 Thread Andrew Lunn
On Tue, Apr 02, 2024 at 07:25:47AM -0700, Jakub Kicinski wrote: > On Tue, 2 Apr 2024 13:38:59 +0200 Wojciech Drewek wrote: > > > Also, this is about the board, the SFP cage, not the actual SFP > > > module? Maybe the word cage needs to be in these names? > > > > It's about cage. Thanks for brin

Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

2024-04-02 Thread Jakub Kicinski
On Tue, 2 Apr 2024 16:46:54 +0200 Andrew Lunn wrote: > Looking at > https://www.optcore.net/wp-content/uploads/2017/04/QSFP-MSA.pdf table > 7 it indicates different power budget classifications. Power level 1 > is a Maximum power of 1.5W. So does your parameter represent this? It > is the minimum

[Intel-wired-lan] [PATCH iwl-next v4] ice: Reset VF on Tx MDD event

2024-04-02 Thread Marcin Szycik
In cases when VF sends malformed packets that are classified as malicious, sometimes it causes Tx queue to freeze. This frozen queue can be stuck for several minutes being unusable. This behavior can be reproduced with a faulty userspace app running on VF. When any Malicious Driver Detection event

Re: [Intel-wired-lan] [PATCH 1/3] e1000e: Remove redundant runtime resume for ethtool_ops

2024-04-02 Thread naamax.meir
On 3/26/2024 00:29, Bjorn Helgaas wrote: From: Bjorn Helgaas e60b22c5b7e5 ("e1000e: fix accessing to suspended device") added ethtool_ops.begin() and .complete(), which used pm_runtime_get_sync() to resume suspended devices before any ethtool_ops callback and allow suspend after it completed.

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS ea2a1cfc3b2019bdea6324acd3c03606b60d71ad

2024-04-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git 200GbE branch HEAD: ea2a1cfc3b2019bdea6324acd3c03606b60d71ad i40e: Fix VF MAC filter removal elapsed time: 1322m configs tested: 176 configs skipped: 3 The following configs have been built successfully. More con

[Intel-wired-lan] [tnguy-next-queue:main] BUILD SUCCESS 5fc68320c1fb3c7d456ddcae0b4757326a043e6f

2024-04-02 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc nsimosci_hs_smp_defconfig gcc arc randconfig-001-20240402 gcc arc randconfig-001

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 399ae3414794886450a7cc094d0656a86dd6c4ca

2024-04-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue branch HEAD: 399ae3414794886450a7cc094d0656a86dd6c4ca i40e: Report MFS in decimal base instead of hex elapsed time: 803m configs tested: 170 configs skipped: 3 The following configs have been built succ

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 3dc13dee4c2c1810f8047cf2ee93f9355eddadd9

2024-04-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue branch HEAD: 3dc13dee4c2c1810f8047cf2ee93f9355eddadd9 ice: update E830 device ids and comments elapsed time: 841m configs tested: 162 configs skipped: 4 The following configs have been built successful

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: Reset VF on Tx MDD event

2024-04-02 Thread Loktionov, Aleksandr
> -Original Message- > From: Intel-wired-lan On > Behalf Of Marcin Szycik > Sent: Tuesday, April 2, 2024 6:52 PM > To: intel-wired-...@lists.osuosl.org > Cc: Drewek, Wojciech ; Wang, Liang-min > ; net...@vger.kernel.org; Chmielewski, > Pawel ; Marcin Szycik > ; Nguyen, Anthony L > ; ho.