Re: [Intel-wired-lan] [PATCH net-next 0/3] ethtool: Max power support

[Wojciech Drewek]

On 29.03.2024 23:16, Jakub Kicinski wrote:
> On Fri, 29 Mar 2024 10:23:18 +0100 Wojciech Drewek wrote:
>> Some ethernet modules use nonstandard power levels [1]. Extend ethtool
>> module implementation to support new attributes that will allow user
>> to change maximum power. Rename structures and functions to be more
>> generic. Introduce an example of the new API in ice driver.
> 
> I'm no SFP expert but seems reasonable.
> 
> Would be good to insert more references to the SFP / CMIS specs
> which describe the standard registers.

Sure, I'll search for additional references.

> 
> Also the series is suffering from lack of docs and spec, please
> update both:
> 
>   Documentation/networking/ethtool-netlink.rst
>   Documentation/netlink/specs/ethtool.yaml


Sure thing, I'll write the documentation.