Re: [Intel-wired-lan] [PATCH iwl-net v2 2/2] igc: Check VLAN TCI mask

2023-12-26 Thread naamax.meir
On 12/1/2023 09:50, Kurt Kanzenbach wrote: Currently the driver accepts VLAN TCI steering rules regardless of the configured mask. And things might fail silently or with confusing error messages to the user. There are two ways to handle the VLAN TCI mask: 1. Match on the PCP field using a VLA

Re: [Intel-wired-lan] [PATCH net v3] net: ethtool: do runtime PM outside RTNL

2023-12-26 Thread Marc MERLIN
On Fri, Dec 15, 2023 at 09:46:34AM -0800, Marc MERLIN wrote: > On Fri, Dec 15, 2023 at 02:42:01PM +0100, Heiner Kallweit wrote: > > Why don't you simply disable runtime pm for the affected device as a > > workaround? This can be done via sysfs. > > 1) because I didn't know what the exact bug was a

Re: [Intel-wired-lan] [PATCH net v3] net: ethtool: do runtime PM outside RTNL

2023-12-26 Thread Marc MERLIN
On Mon, Dec 25, 2023 at 10:03:23AM +0200, Sasha Neftin wrote: > > > I can't patch that kernel easily. How exactly do I disable runtime PM > > > from the kernel command line for "that device" which I'm not even sure > > > > Change /power/control from "auto" to "on". > > Need to figure out your con

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Check VLAN EtherType mask

2023-12-26 Thread naamax.meir
On 12/6/2023 16:07, Kurt Kanzenbach wrote: Currently the driver accepts VLAN EtherType steering rules regardless of the configured mask. And things might fail silently or with confusing error messages to the user. The VLAN EtherType can only be matched by full mask. Therefore, add a check for tha

Re: [Intel-wired-lan] [PATCH RFC net-next 00/34] Christmas 3-serie XDP for idpf (+generic stuff)

2023-12-26 Thread Willem de Bruijn
Alexander Lobakin wrote: > I was highly asked to send this WIP before the holidays to trigger > some discussions at least for the generic parts. > > This all depends on libie[0] and WB-on-ITR fix[1]. The RFC does not > guarantee to work perfectly, but at least regular XDP seems to work > for me...

Re: [Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix link_down_on_close message

2023-12-26 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Wojciech Drewek > Sent: Friday, December 15, 2023 4:32 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix link_down_on_close > message > > From: Katar

Re: [Intel-wired-lan] [PATCH iwl-net 2/2] ice: Shut down VSI with "link-down-on-close" enabled

2023-12-26 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Wojciech Drewek > Sent: Friday, December 15, 2023 4:32 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH iwl-net 2/2] ice: Shut down VSI with > "link-down-on-close" enable