Re: [Intel-wired-lan] [PATCH net v3] net: ethtool: do runtime PM outside RTNL

2023-12-25 Thread Sasha Neftin
On 25/12/2023 1:12, Heiner Kallweit wrote: On 24.12.2023 17:30, Marc MERLIN wrote: On Fri, Dec 15, 2023 at 09:46:34AM -0800, Marc MERLIN wrote: On Fri, Dec 15, 2023 at 02:42:01PM +0100, Heiner Kallweit wrote: Why don't you simply disable runtime pm for the affected device as a workaround? This

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/15] intel: add bit macro includes where needed

2023-12-25 Thread Simon Horman
On Tue, Dec 05, 2023 at 05:01:01PM -0800, Jesse Brandeburg wrote: > This series is introducing the use of FIELD_GET and FIELD_PREP which > requires bitfield.h to be included. Fix all the includes in this one > change, and rearrange includes into alphabetical order to ease > readability and future m

Re: [Intel-wired-lan] [PATCH iwl-next v2 01/15] e1000e: make lost bits explicit

2023-12-25 Thread Simon Horman
On Tue, Dec 05, 2023 at 05:01:00PM -0800, Jesse Brandeburg wrote: > For more than 15 years this code has passed in a request for a page and > masked off that page when read/writing. This code has been here forever, > but FIELD_PREP finds the bug when converted to use it. Change the code > to do exa

Re: [Intel-wired-lan] [PATCH iwl-next v2 15/15] idpf: refactor some missing field get/prep conversions

2023-12-25 Thread Simon Horman
On Tue, Dec 05, 2023 at 05:01:14PM -0800, Jesse Brandeburg wrote: > Most of idpf correctly uses FIELD_GET and FIELD_PREP, but a couple spots > were missed so fix those. > > Automated conversion with coccinelle script and manually fixed up, > including audits for opportunities to convert to {get,en

Re: [Intel-wired-lan] [PATCH iwl-next v2 14/15] ice: cleanup inconsistent code

2023-12-25 Thread Simon Horman
On Thu, Dec 14, 2023 at 08:16:38AM +0100, Przemek Kitszel wrote: > On 12/13/23 19:27, Jesse Brandeburg wrote: > > Please don't use HTML email, your reply was likely dropped by most lists > > that filter HTML. > > > > On 12/12/2023 8:06 PM, Kalesh Anakkur Purayil wrote: > > > -       change_ty

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/2] igc: Report VLAN EtherType matching back to user

2023-12-25 Thread naamax.meir
On 12/1/2023 09:50, Kurt Kanzenbach wrote: Currently the driver allows to configure matching by VLAN EtherType. However, the retrieval function does not report it back to the user. Add it. Before: |root@host:~# ethtool -N enp3s0 flow-type ether vlan-etype 0x8100 action 0 |Added rule with ID 63 |