Re: [Intel-wired-lan] [PATCH iwl-net] ice: Fix PF with enabled XDP going no-carrier after reset

2023-12-18 Thread Rout, ChandanX
>-Original Message- >From: Intel-wired-lan On Behalf Of >Zaremba, Larysa >Sent: Tuesday, December 12, 2023 2:59 PM >To: intel-wired-...@lists.osuosl.org >Cc: Zaremba, Larysa ; net...@vger.kernel.org; >Brandeburg, Jesse ; Nguyen, Anthony L >; Kitszel, Przemyslaw >; Keller, Jacob E ; >Mic

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-18 Thread Marcin Szycik
On 15.12.2023 17:49, Jakub Kicinski wrote: > On Fri, 15 Dec 2023 11:11:23 +0100 Alexander Lobakin wrote: >> Ping? :s >> Or should we resubmit? > > Can you wait for next merge window instead? > We're getting flooded with patches as everyone seemingly tries to get > their own (i.e. the most impor

[Intel-wired-lan] [PATCH iwl-next v5 0/2] ixgbe: Refactor ixgbe internal status

2023-12-18 Thread Jedrzej Jagielski
A small 2 patches series removing currently used internal status codes in ixgbe driver and converting them to the regular ones. 1st patch deals specifically with overtemp error code, the 2nd one refactors the rest of the error codes. Jedrzej Jagielski (2): ixgbe: Refactor overtemp event handlin

[Intel-wired-lan] [PATCH iwl-next v5 1/2] ixgbe: Refactor overtemp event handling

2023-12-18 Thread Jedrzej Jagielski
Currently ixgbe driver is notified of overheating events via internal IXGBE_ERR_OVERTEMP error code. Change the approach for handle_lasi() to use freshly introduced is_overtemp function parameter which set when such event occurs. Change check_overtemp() to bool and return true if overtemp event oc

[Intel-wired-lan] [PATCH iwl-next v5 2/2] ixgbe: Refactor returning internal error codes

2023-12-18 Thread Jedrzej Jagielski
Change returning codes to the kernel ones instead of the internal ones for the entire ixgbe driver. Reviewed-by: Jacob Keller Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman Signed-off-by: Jedrzej Jagielski --- v3: do not use ENOSYS; rebase --- .../net/ethernet/intel/ixgbe/ixgbe_82598.

Re: [Intel-wired-lan] [PATCH v2 iwl-next] ice: Fix some null pointer dereference issues in ice_ptp.c

2023-12-18 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Kunwu > Chan > Sent: Tuesday, December 12, 2023 8:10 AM > To: Brandeburg, Jesse ; Nguyen, Anthony L > ; da...@davemloft.net; eduma...@google.com; > k...@kernel.org; pab...@redhat.com; richardcoch...@gmail.com; Keller, Jacob E >

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: avoid compiler introduced padding in virtchnl2_rss_key struct

2023-12-18 Thread Simon Horman
On Fri, Dec 15, 2023 at 03:48:07PM -0800, Pavan Kumar Linga wrote: > Size of the virtchnl2_rss_key struct should be 7 bytes but the > compiler introduces a padding byte for the structure alignment. > This results in idpf sending an additional byte of memory to the device > control plane than the ex

Re: [Intel-wired-lan] [PATCH iwl-next v6] ice: Add support for packet mirroring using hardware in switchdev mode

2023-12-18 Thread Buvaneswaran, Sujai
> -Original Message- > From: Intel-wired-lan On Behalf Of > Andrii Staikov > Sent: Tuesday, December 12, 2023 6:21 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Szycik, Marcin ; > Drewek, Wojciech ; linux- > ker...@vger.kernel.org; Staikov, Andrii > Subject: [Int

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-18 Thread Alexander Lobakin
From: Marcin Szycik Date: Mon, 18 Dec 2023 11:04:01 +0100 > > > On 15.12.2023 17:49, Jakub Kicinski wrote: >> On Fri, 15 Dec 2023 11:11:23 +0100 Alexander Lobakin wrote: >>> Ping? :s >>> Or should we resubmit? >> >> Can you wait for next merge window instead? >> We're getting flooded with patch

[Intel-wired-lan] [PATCH iwl-net v2] ice: dpll: fix phase offset value

2023-12-18 Thread Arkadiusz Kubalewski
Stop dividing the phase_offset value received from firmware. This fault is present since the initial implementation. The phase_offset value received from firmware is in 0.01ps resolution. Dpll subsystem is using the value in 0.001ps, raw value is adjusted before providing it to the user. The user

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: dpll: fix phase offset value

2023-12-18 Thread Paul Menzel
Dear Arkadiusz, Am 18.12.23 um 15:58 schrieb Arkadiusz Kubalewski: Stop dividing the phase_offset value received from firmware. This fault is present since the initial implementation. The phase_offset value received from firmware is in 0.01ps resolution. Dpll subsystem is using the value in 0.0

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-18 Thread Yury Norov
+ Alexander Potapenko On Mon, Dec 18, 2023 at 01:47:01PM +0100, Alexander Lobakin wrote: > From: Marcin Szycik > Date: Mon, 18 Dec 2023 11:04:01 +0100 > > > > > > > On 15.12.2023 17:49, Jakub Kicinski wrote: > >> On Fri, 15 Dec 2023 11:11:23 +0100 Alexander Lobakin wrote: > >>> Ping? :s > >>>

Re: [Intel-wired-lan] [net PATCH] i40e: fix use-after-free in i40e_aqc_add_filters()

2023-12-18 Thread xia...@sangfor.com.cn
On 2023/12/16 1:16, Brett Creeley wrote: On 12/13/2023 2:49 AM, Ke Xiao wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet

[Intel-wired-lan] [net PATCH v2] i40e: fix use-after-free in i40e_aqc_add_filters()

2023-12-18 Thread Ke Xiao
Commit 3116f59c12bd ("i40e: fix use-after-free in i40e_sync_filters_subtask()") avoided use-after-free issues, by increasing refcount during update the VSI filter list to the HW. However, it missed the unicast situation. When deleting an unicast FDB entry, the i40e driver will release the mac_filt

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

2023-12-18 Thread Nick Desaulniers
On Sun, Dec 17, 2023 at 1:45 AM Simon Horman wrote: > > Although it does not seem to have any untoward side-effects, > the use of ';' to separate to assignments seems more appropriate than ','. > > Flagged by clang-17 -Wcomma Yikes! This kind of example is why I hate the comma operator! Reviewed

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-18 Thread Alexander Potapenko
On Mon, Dec 18, 2023 at 4:57 PM Yury Norov wrote: > > + Alexander Potapenko > > On Mon, Dec 18, 2023 at 01:47:01PM +0100, Alexander Lobakin wrote: > > From: Marcin Szycik > > Date: Mon, 18 Dec 2023 11:04:01 +0100 > > > > > > > > > > > On 15.12.2023 17:49, Jakub Kicinski wrote: > > >> On Fri, 15 D

[Intel-wired-lan] [ANN] no call tomorrow

2023-12-18 Thread Jakub Kicinski
Hi folks, many people are on winter break already, so there will be no netdev call tomorrow. This weeks reviewers are: Intel Happy holidays everyone! ___ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/

Re: [Intel-wired-lan] linux-next: Tree for Dec 15 (drivers/net/ethernet/intel/ice/ice_base.c)

2023-12-18 Thread Tony Nguyen
On 12/15/2023 9:26 PM, Randy Dunlap wrote: On 12/14/23 20:01, Stephen Rothwell wrote: Hi all, Changes since 20231214: on s390: # CONFIG_XDP_SOCKETS is not set ../drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_xsk_pool_fill_cb': ../drivers/net/ethernet/intel/ice/ice_base.

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

2023-12-18 Thread Nick Desaulniers
On Mon, Dec 18, 2023 at 11:00 AM Nathan Chancellor wrote: > > On Mon, Dec 18, 2023 at 08:32:28AM -0800, Nick Desaulniers wrote: > > (Is -Wcomma enabled by -Wall?) > > No and last time that I looked into enabling it, there were a lot of > instances in the kernel: > > https://lore.kernel.org/2023063

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

2023-12-18 Thread Paolo Abeni
On Fri, 2023-12-15 at 14:41 -0800, Jakub Kicinski wrote: > I explained before (perhaps on the netdev call) - Qdiscs have two > different offload models. "local" and "switchdev", here we want "local" > AFAIU and TBF only has "switchdev" offload (take a look at the enqueue > method and which drivers

Re: [Intel-wired-lan] [net PATCH v2] i40e: fix use-after-free in i40e_aqc_add_filters()

2023-12-18 Thread Jacob Keller
On 12/17/2023 11:08 PM, Ke Xiao wrote: > Commit 3116f59c12bd ("i40e: fix use-after-free in > i40e_sync_filters_subtask()") avoided use-after-free issues, > by increasing refcount during update the VSI filter list to > the HW. However, it missed the unicast situation. > > When deleting an unicas

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

2023-12-18 Thread Jakub Kicinski
On Mon, 18 Dec 2023 21:12:35 +0100 Paolo Abeni wrote: > On Fri, 2023-12-15 at 14:41 -0800, Jakub Kicinski wrote: > > I explained before (perhaps on the netdev call) - Qdiscs have two > > different offload models. "local" and "switchdev", here we want "local" > > AFAIU and TBF only has "switchdev" o

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

2023-12-18 Thread Nathan Chancellor
On Mon, Dec 18, 2023 at 08:32:28AM -0800, Nick Desaulniers wrote: > On Sun, Dec 17, 2023 at 1:45 AM Simon Horman wrote: > > > > Although it does not seem to have any untoward side-effects, > > the use of ';' to separate to assignments seems more appropriate than ','. > > > > Flagged by clang-17 -W

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Reset VF on Tx MDD event

2023-12-18 Thread Tony Nguyen
On 12/14/2023 8:51 AM, Pawel Chmielewski wrote: On Thu, Dec 14, 2023 at 09:37:32AM +0100, Michal Schmidt wrote: On Thu, Nov 2, 2023 at 4:56 PM Pawel Chmielewski wrote: From: Liang-Min Wang ... When Malicious Driver Detection event occurs, perform graceful VF reset to quickly bring VF ba

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: add trace events related to SFP module IOCTLs

2023-12-18 Thread Tony Nguyen
On 12/14/2023 6:10 AM, Aleksandr Loktionov wrote: Add trace events related to SFP module IOCTLs for troubleshooting. Riewed-by: Przemek Kitszel Signed-off-by: Aleksandr Loktionov --- src/CORE/i40e_ethtool.c | 5 + src/CORE/i40e_trace.h | 18 ++ 2 files changed, 23

Re: [Intel-wired-lan] [PATCH iwl-next v5 1/2] ixgbe: Refactor overtemp event handling

2023-12-18 Thread Jacob Keller
On 12/18/2023 2:39 AM, Jedrzej Jagielski wrote: > Currently ixgbe driver is notified of overheating events > via internal IXGBE_ERR_OVERTEMP error code. > > Change the approach for handle_lasi() to use freshly introduced > is_overtemp function parameter which set when such event occurs. > Chang

Re: [Intel-wired-lan] [PATCH net-next 20/24] net: intel: Use nested-BH locking for XDP redirect.

2023-12-18 Thread Nathan Chancellor
On Sat, Dec 16, 2023 at 12:53:43PM +0800, kernel test robot wrote: > Hi Sebastian, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on net-next/main] > > url: > https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/locking-local_lock-Int

Re: [Intel-wired-lan] [PATCH iwl-next v2 01/15] e1000e: make lost bits explicit

2023-12-18 Thread naamax.meir
On 12/6/2023 03:01, Jesse Brandeburg wrote: For more than 15 years this code has passed in a request for a page and masked off that page when read/writing. This code has been here forever, but FIELD_PREP finds the bug when converted to use it. Change the code to do exactly the same thing but allo