[Intel-wired-lan] [PATCH net] ice: lag: in RCU, use atomic allocation

2023-10-23 Thread Michal Schmidt
Sleeping is not allowed in RCU read-side critical sections. Use atomic allocations under rcu_read_lock. Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on bonded interface") Fixes: 41ccedf5ca8f ("ice: implement lag netdev event handler") Fixes: 3579aa86fb40 ("ice: update

Re: [Intel-wired-lan] [PATCH net] ice: lag: in RCU, use atomic allocation

2023-10-23 Thread Drewek, Wojciech
> -Original Message- > From: Michal Schmidt > Sent: Monday, October 23, 2023 1:00 PM > To: net...@vger.kernel.org > Cc: Ertman, David M ; Daniel Machon > ; Nguyen, Anthony L > ; Brandeburg, Jesse ; > intel-wired-...@lists.osuosl.org > Subject: [PATCH net] ice: lag: in RCU, use atomic

[Intel-wired-lan] [PATCH 6.1 137/196] ice: Remove redundant pci_enable_pcie_error_reporting()

2023-10-23 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Bjorn Helgaas [ Upstream commit ba153552c18d7eb839ec0bad7d7484e29ba4719c ] pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable err

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: read internal temperature sensor

2023-10-23 Thread Knitter, Konrad
> -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Sunday, October 22, 2023 6:46 PM > To: Knitter, Konrad ; intel-wired- > l...@lists.osuosl.org > Cc: net...@vger.kernel.org; jdelv...@suse.com; Marcin Domagala > ; Joyner, Eric ; Marcin > Szycik ; Kitszel, Przemys

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: read internal temperature sensor

2023-10-23 Thread Guenter Roeck
On 10/23/23 04:37, Knitter, Konrad wrote: -Original Message- From: Guenter Roeck On Behalf Of Guenter Roeck Sent: Sunday, October 22, 2023 6:46 PM To: Knitter, Konrad ; intel-wired- l...@lists.osuosl.org Cc: net...@vger.kernel.org; jdelv...@suse.com; Marcin Domagala ; Joyner, Eric ; Marc

[Intel-wired-lan] [PATCH net-next] i40e: increase max descriptors for XL710

2023-10-23 Thread Justin Bronder
In Tables 8-12 and 8-22 in the X710/XXV710/XL710 datasheet, the QLEN description states that the maximum size of the descriptor queue is 8k minus 32, or 8160. Signed-off-by: Justin Bronder --- drivers/net/ethernet/intel/i40e/i40e.h| 1 + .../net/ethernet/intel/i40e/i40e_ethtool.c| 2

Re: [Intel-wired-lan] [PATCH net-next] i40e: increase max descriptors for XL710

2023-10-23 Thread Paul Menzel
Dear Justin, Thank you for your patch. Am 23.10.23 um 16:35 schrieb Justin Bronder:> In Tables 8-12 and 8-22 in the X710/XXV710/XL710 datasheet, the QLEN description states that the maximum size of the descriptor queue is 8k minus 32, or 8160. Maybe state the problem more clearly, that curr

Re: [Intel-wired-lan] i40e: increase max descriptors for XL710

2023-10-23 Thread Justin Bronder
My apologies I didn't notice my last email did get moderator approval and made it to the list. Please ignore this email. On 23/10/23 10:35 -0400, Justin Bronder wrote: > In Tables 8-12 and 8-22 in the X710/XXV710/XL710 datasheet, the QLEN > description states that the maximum size of the descrip

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: read internal temperature sensor

2023-10-23 Thread Knitter, Konrad
> -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Monday, October 23, 2023 3:36 PM > To: Knitter, Konrad ; intel-wired- > l...@lists.osuosl.org > Cc: net...@vger.kernel.org; jdelv...@suse.com; Marcin Domagala > ; Joyner, Eric ; Marcin > Szycik ; Kitszel, Przem

[Intel-wired-lan] [PATCH iwl-next 1/3] i40e: Move i40e_is_aq_api_ver_ge helper

2023-10-23 Thread Ivan Vecera
Move i40e_is_aq_api_ver_ge helper function (used to check if AdminQ API version is recent enough) to header so it can be used from other .c files. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_common.c | 23 --- drivers/net/ethernet/intel/i40e/i40e_type.h

[Intel-wired-lan] [PATCH iwl-next 2/3] i40e: Add other helpers to check version of running firmware and AQ API

2023-10-23 Thread Ivan Vecera
Add another helper functions that will be used by subsequent patch to refactor existing open-coded checks whether the version of running firmware and AdminQ API is recent enough to provide certain capabilities. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_type.h | 54 +

[Intel-wired-lan] [PATCH iwl-next 3/3] i40e: Use helpers to check running FW and AQ API versions

2023-10-23 Thread Ivan Vecera
Use new helpers to check versions of running FW and provided AQ API to make the code more readable. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_adminq.c | 69 +++ drivers/net/ethernet/intel/i40e/i40e_common.c | 25 --- drivers/net/ethernet/intel/i40e/i

[Intel-wired-lan] [PATCH iwl-next 0/3] i40e: Add and use version check helpers

2023-10-23 Thread Ivan Vecera
The series moves an existing check for AQ API version to header file, adds another ones for firmware version check and use them to refactor existing open-coded version checks. Series content: Patch 1: Moves i40e_is_aq_api_ver_ge() helper to header file Patch 2: Adds another helpers to check runnin

Re: [Intel-wired-lan] [PATCH] igb: e1000_82575: add an error code check in igb_set_d0_lplu_state_82575

2023-10-23 Thread Simon Horman
On Fri, Oct 20, 2023 at 05:24:31PM +0800, Su Hui wrote: > igb_set_d0_lplu_state_82575() check all phy->ops.read_reg()'s return value > except this one, just fix this. > > Signed-off-by: Su Hui Reviewed-by: Simon Horman ___ Intel-wired-lan mailing lis

Re: [Intel-wired-lan] [PATCH iwl-next 2/3] i40e: Add other helpers to check version of running firmware and AQ API

2023-10-23 Thread kernel test robot
Hi Ivan, kernel test robot noticed the following build warnings: [auto build test WARNING on tnguy-next-queue/dev-queue] url: https://github.com/intel-lab-lkp/linux/commits/Ivan-Vecera/i40e-Move-i40e_is_aq_api_ver_ge-helper/20231024-003221 base: https://git.kernel.org/pub/scm/linux/kernel/

Re: [Intel-wired-lan] [PATCH iwl-next 2/3] i40e: Add other helpers to check version of running firmware and AQ API

2023-10-23 Thread Jacob Keller
On 10/23/2023 9:29 AM, Ivan Vecera wrote: > Add another helper functions that will be used by subsequent > patch to refactor existing open-coded checks whether the version > of running firmware and AdminQ API is recent enough to provide > certain capabilities. > > Signed-off-by: Ivan Vecera >

Re: [Intel-wired-lan] [PATCH iwl-next 1/3] i40e: Move i40e_is_aq_api_ver_ge helper

2023-10-23 Thread Jacob Keller
On 10/23/2023 9:29 AM, Ivan Vecera wrote: > +/** > + * i40e_is_aq_api_ver_ge > + * @hw: pointer to i40e_hw structure > + * @maj: API major value to compare > + * @min: API minor value to compare > + * > + * Assert whether current HW API version is greater/equal than provided. > + **/ > +static i

Re: [Intel-wired-lan] [PATCH iwl-next 3/3] i40e: Use helpers to check running FW and AQ API versions

2023-10-23 Thread Jacob Keller
On 10/23/2023 9:29 AM, Ivan Vecera wrote: > Use new helpers to check versions of running FW and provided > AQ API to make the code more readable. > > Signed-off-by: Ivan Vecera > --- This has a couple checkpatch.pl warnings: > CHECK: Alignment should match open parenthesis > #81: FILE: drive