On 10/23/2023 9:29 AM, Ivan Vecera wrote:
> Use new helpers to check versions of running FW and provided
> AQ API to make the code more readable.
>
> Signed-off-by: Ivan Vecera <ivec...@redhat.com>
> ---
This has a couple checkpatch.pl warnings:
> CHECK: Alignment should match open parenthesis
> #81: FILE: drivers/net/ethernet/intel/i40e/i40e_adminq.c:566:
> + if (i40e_is_aq_api_ver_ge(hw, 1,
> + I40E_MINOR_VER_FW_LLDP_STOPPABLE_X722)) {
>
> WARNING: braces {} are not necessary for single statement blocks
> #110: FILE: drivers/net/ethernet/intel/i40e/i40e_adminq.c:583:
> + if (i40e_is_aq_api_ver_ge(hw, 1, 5)) {
> set_bit(I40E_HW_CAP_NVM_READ_REQUIRES_LOCK, hw->caps);
> + }
>
> WARNING: braces {} are not necessary for single statement blocks
> #118: FILE: drivers/net/ethernet/intel/i40e/i40e_adminq.c:587:
> + if (i40e_is_aq_api_ver_ge(hw, 1, 7)) {
> set_bit(I40E_HW_CAP_802_1AD, hw->caps);
> + }
>
> WARNING: braces {} are not necessary for single statement blocks
> #125: FILE: drivers/net/ethernet/intel/i40e/i40e_adminq.c:590:
> + if (i40e_is_aq_api_ver_ge(hw, 1, 8)) {
> set_bit(I40E_HW_CAP_FW_LLDP_PERSISTENT, hw->caps);
> + }
>
> WARNING: braces {} are not necessary for single statement blocks
> #132: FILE: drivers/net/ethernet/intel/i40e/i40e_adminq.c:593:
> + if (i40e_is_aq_api_ver_ge(hw, 1, 9)) {
> set_bit(I40E_HW_CAP_AQ_PHY_ACCESS_EXTENDED, hw->caps);
> + }
>
> total: 0 errors, 4 warnings, 1 checks, 212 lines checked
Thanks,
Jake
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
