Re: [Intel-wired-lan] [PATCH iwl-next v3 13/13] vfio/ice: Implement vfio_pci driver for E800 devices

2023-10-16 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Friday, October 13, 2023 10:08 PM > > On Fri, Oct 13, 2023 at 08:52:07AM +, Tian, Kevin wrote: > > > From: Cao, Yahui > > > Sent: Monday, September 18, 2023 2:26 PM > > > > > > +static struct file * > > > +ice_vfio_pci_step_device_state_locked(struct ice_vfio_

Re: [Intel-wired-lan] [PATCH iwl-next v5] i40e: add restore default speed when changed PHY doesn't support it

2023-10-16 Thread Przemek Kitszel
On 10/16/23 08:56, Loktionov, Aleksandr wrote: -Original Message- From: Kitszel, Przemyslaw Sent: Friday, October 13, 2023 2:35 PM To: Loktionov, Aleksandr ; intel-wired- l...@lists.osuosl.org; Nguyen, Anthony L ; Jagielski, Jedrzej Cc: net...@vger.kernel.org Subject: Re: [PATCH iwl-

Re: [Intel-wired-lan] [PATCH v1 net-next 7/7] igc: replace deprecated strncpy with strscpy

2023-10-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Justin Stitt > Sent: Wednesday, October 11, 2023 3:57 AM > To: Brandeburg, Jesse ; Nguyen, Anthony L > ; David S. Miller ; Eric > Dumazet ; Jakub Kicinski ; Paolo Abeni > > Cc: net...@vger.kernel.org; Justin Stitt ; > intel-

Re: [Intel-wired-lan] [PATCH v1 net-next 6/7] igbvf: replace deprecated strncpy with strscpy

2023-10-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Justin Stitt > Sent: Wednesday, October 11, 2023 3:57 AM > To: Brandeburg, Jesse ; Nguyen, Anthony L > ; David S. Miller ; Eric > Dumazet ; Jakub Kicinski ; Paolo Abeni > > Cc: net...@vger.kernel.org; Justin Stitt ; > intel-

Re: [Intel-wired-lan] [PATCH v1 net-next 5/7] igb: replace deprecated strncpy with strscpy

2023-10-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Justin Stitt > Sent: Wednesday, October 11, 2023 3:57 AM > To: Brandeburg, Jesse ; Nguyen, Anthony L > ; David S. Miller ; Eric > Dumazet ; Jakub Kicinski ; Paolo Abeni > > Cc: net...@vger.kernel.org; Justin Stitt ; > intel-

Re: [Intel-wired-lan] [PATCH v1 net-next 4/7] i40e: use scnprintf over strncpy+strncat

2023-10-16 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of > Justin Stitt > Sent: Wednesday, October 11, 2023 3:57 AM > To: Brandeburg, Jesse ; Nguyen, Anthony L > ; David S. Miller ; Eric > Dumazet ; Jakub Kicinski ; Paolo Abeni > > Cc: net...@vger.kernel.org; Justin Stitt ; > intel-

Re: [Intel-wired-lan] [PATCH iwl-next v3 0/5] ice: Support 5 layer Tx scheduler topology

2023-10-16 Thread Simon Horman
On Mon, Oct 09, 2023 at 05:07:06AM -0400, Mateusz Polchlopek wrote: > For performance reasons there is a need to have support for selectable > Tx scheduler topology. Currently firmware supports only the default > 9-layer and 5-layer topology. This patch series enables switch from > default to 5-lay

Re: [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-16 Thread Simon Horman
On Thu, Oct 12, 2023 at 06:01:15AM +, Takeru Hayasaka wrote: > This is a patch that enables RSS functionality for GTP packets using > ethtool. > A user can include her TEID and make RSS work for GTP-U over IPv4 by > doing the following: > `ethtool -N ens3 rx-flow-hash gtpu4 sde` > In addition t

Re: [Intel-wired-lan] [PATCH net-next 1/2] igb: Fix an end of loop test

2023-10-16 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jesse Brandeburg > Sent: Monday, October 9, 2023 5:18 PM > To: Dan Carpenter ; Jinjie Ruan > > Cc: intel-wired-...@lists.osuosl.org; kernel-janit...@vger.kernel.org; Eric > Dumazet ; Nguyen, Anthony L > ; Simon Horman ; > net...@

Re: [Intel-wired-lan] [PATCH net-next 2/2] ixgbe: fix end of loop test in ixgbe_set_vf_macvlan()

2023-10-16 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jesse Brandeburg > Sent: Monday, October 9, 2023 5:18 PM > To: Dan Carpenter ; Jinjie Ruan > > Cc: net...@vger.kernel.org; kernel-janit...@vger.kernel.org; Eric Dumazet > ; Nguyen, Anthony L > ; Simon Horman ; Jakub > Kicinski ;

[Intel-wired-lan] [PATCH iwl-next v4] ice: read internal temperature sensor

2023-10-16 Thread Konrad Knitter
Since 4.30 firmware exposes internal thermal sensor reading via admin queue commands. Expose those readouts via hwmon API when supported. Driver provides current reading from HW as well as device specific thresholds for thermal alarm (Warning, Critical, Fatal) events. $ sensors Output ==

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: read internal temperature sensor

2023-10-16 Thread Paul Menzel
Dear Konrad, Thank you for the patch. Am 16.10.23 um 12:29 schrieb Konrad Knitter: Since 4.30 firmware exposes internal thermal sensor reading via admin queue commands. Expose those readouts via hwmon API when supported. For completeness, it’d be great if you added the datasheet, where the

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: read internal temperature sensor

2023-10-16 Thread Paul Menzel
[Cc: -marcinx.domag...@intel.com] Am 16.10.23 um 12:45 schrieb Paul Menzel: Dear Konrad, Thank you for the patch. Am 16.10.23 um 12:29 schrieb Konrad Knitter: Since 4.30 firmware exposes internal thermal sensor reading via admin queue commands. Expose those readouts via hwmon API when suppor

Re: [Intel-wired-lan] [PATCH iwl-net, v3] ice: Fix VF-VF filter rules in switchdev mode

2023-10-16 Thread Simon Horman
On Fri, Oct 13, 2023 at 07:13:42PM +0530, Aniruddha Paul wrote: > Any packet leaving VSI i.e VF's VSI is considered as > egress traffic by HW, thus failing to match the added > rule. > > Mark the direction for redirect rules as below: > 1. VF-VF - Egress > 2. Uplink-VF - Ingress > 3. VF-Uplink - E

Re: [Intel-wired-lan] [PATCH net-next 3/5] i40e: Add handler for devlink .info_get

2023-10-16 Thread Jakub Kicinski
On Fri, 13 Oct 2023 19:07:53 +0200 Ivan Vecera wrote: > "serial_number" -> The PCI DSN of the adapter > "fw.mgmt" -> The version of the firmware > "fw.mgmt.api" -> The API version of interface exposed over the AdminQ > "fw.psid" -> The version of the NVM image Your board reports "fw.psid 9.30"

Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Jakub Kicinski
On Sat, 14 Oct 2023 06:19:54 -0600 Ahmed Zaki wrote: > >> +#defineRXH_SYMMETRIC_XOR (1 << 30) > >> +#defineRXH_DISCARD (1 << 31) > >> > >> Are these indentation changes intentional? > >> > >> > >> Yes, for alignment ("RXH_SYMMETRIC_XOR" is too long). > > > > I t

Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Ahmed Zaki
On 2023-10-16 09:02, Jakub Kicinski wrote: On Sat, 14 Oct 2023 06:19:54 -0600 Ahmed Zaki wrote: +#defineRXH_SYMMETRIC_XOR (1 << 30) +#defineRXH_DISCARD (1 << 31) Are these indentation changes intentional? Yes, for alignment ("RXH_SYMMETRIC_XOR" is too long

[Intel-wired-lan] [PATCH net-next v4 0/6] Support symmetric RSS (Toeplitz) hash

2023-10-16 Thread Ahmed Zaki
Patch 1 adds the support at the Kernel level, allowing the user to set a symmetric RSS hash for any flow type via: # ethtool -N|-U eth0 rx-flow-hash s|d|f|n symmetric-xor Support for the new "symmetric-xor" flag will be later sent to the "ethtool" user-space tool. Patch 2 fixes a long stand

[Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Ahmed Zaki
Symmetric RSS hash functions are beneficial in applications that monitor both Tx and Rx packets of the same flow (IDS, software firewalls, ..etc). Getting all traffic of the same flow on the same RX queue results in higher CPU cache efficiency. A NIC that supports "symmetric-xor" can achieve this

[Intel-wired-lan] [PATCH net-next v4 2/6] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values

2023-10-16 Thread Ahmed Zaki
Fix the values of the ICE_AQ_VSI_Q_OPT_RSS_* registers. Shifting is already done when the values are used, no need to double shift. Bug was not discovered earlier since only ICE_AQ_VSI_Q_OPT_RSS_TPLZ (Zero) is currently used. Also, rename ICE_AQ_VSI_Q_OPT_RSS_XXX to ICE_AQ_VSI_Q_OPT_RSS_HASH_XXX f

[Intel-wired-lan] [PATCH net-next v4 3/6] ice: refactor RSS configuration

2023-10-16 Thread Ahmed Zaki
From: Qi Zhang Refactor the driver to use a communication data structure for RSS config. To do so we introduce the new ice_rss_hash_cfg struct, and then pass it as an argument to several functions. Also introduce enum ice_rss_cfg_hdr_type to specify a more granular and flexible RSS configuration

[Intel-wired-lan] [PATCH net-next v4 4/6] ice: refactor the FD and RSS flow ID generation

2023-10-16 Thread Ahmed Zaki
The flow director and RSS blocks use separate methods to generate a unique 64 bit ID for the flow. This is not extendable, especially for the RSS that already uses all 64 bit space. Refactor the flow generation API so that the ID is generated within ice_flow_add_prof(). The FD and RSS blocks cache

[Intel-wired-lan] [PATCH net-next v4 5/6] ice: enable symmetric RSS Toeplitz hash for any flow type

2023-10-16 Thread Ahmed Zaki
From: Jeff Guo The hash function in the E800 NICs is set per-VSI and a specific AQ command is needed to modify the hash function. Use the AQ command to enable setting the symmetric Toeplitz RSS hash function for any VSI. When the Symmetric Toeplitz hash function is used, the hardware sets the in

[Intel-wired-lan] [PATCH net-next v4 6/6] iavf: enable symmetric RSS Toeplitz hash

2023-10-16 Thread Ahmed Zaki
Allow the VFs to support symmetric RSS for any flow type. The symmetric RSS will not be supported on PFs not advertising the ADV RSS Offload flag (ADV_RSS_SUPPORT()), for example the E700 series (i40e). Reviewed-by: Madhu Chittim Signed-off-by: Ahmed Zaki --- .../net/ethernet/intel/iavf/iavf_ad

[Intel-wired-lan] [PATCH iwl-next 0/4] iavf: cleanups, dead code removal

2023-10-16 Thread Michal Schmidt
The first 3 patches are quite simple cleanups. Patch 4 removes the whole unused iavf client interface and the supporting code. Michal Schmidt (4): iavf: rely on netdev's own registered state iavf: use unregister_netdev iavf: add a common function for undoing the interrupt scheme iavf: dele

[Intel-wired-lan] [PATCH iwl-next 4/4] iavf: delete the iavf client interface

2023-10-16 Thread Michal Schmidt
The iavf client interface was added in 2017 by commit ed0e894de7c1 ("i40evf: add client interface"), but there have never been any in-tree callers. It's not useful for future development either. The Intel out-of-tree iavf and irdma drivers instead use an auxiliary bus, which is a better solution.

[Intel-wired-lan] [PATCH iwl-next 1/4] iavf: rely on netdev's own registered state

2023-10-16 Thread Michal Schmidt
The information whether a netdev has been registered is already present in the netdev itself. There's no need for a driver flag with the same meaning. Signed-off-by: Michal Schmidt --- drivers/net/ethernet/intel/iavf/iavf.h | 1 - drivers/net/ethernet/intel/iavf/iavf_main.c | 9 +++-- 2

[Intel-wired-lan] [PATCH iwl-next 3/4] iavf: add a common function for undoing the interrupt scheme

2023-10-16 Thread Michal Schmidt
Add a new function iavf_free_interrupt_scheme that does the inverse of iavf_init_interrupt_scheme. Symmetry is nice. And there will be three callers already. Signed-off-by: Michal Schmidt --- drivers/net/ethernet/intel/iavf/iavf_main.c | 26 - 1 file changed, 15 insertions(+)

[Intel-wired-lan] [PATCH iwl-next 2/4] iavf: use unregister_netdev

2023-10-16 Thread Michal Schmidt
Use unregister_netdev, which takes rtnl_lock for us. We don't have to check the reg_state under rtnl_lock. There's nothing to race with. We have just cancelled the finish_config work. Signed-off-by: Michal Schmidt --- drivers/net/ethernet/intel/iavf/iavf_main.c | 4 +--- 1 file changed, 1 insert

Re: [Intel-wired-lan] [PATCH iwl-next v3 00/13] Add E800 live migration driver

2023-10-16 Thread Jason Gunthorpe
On Mon, Sep 18, 2023 at 06:25:33AM +, Yahui Cao wrote: > This series adds vfio live migration support for Intel E810 VF devices > based on the v2 migration protocol definition series discussed here[0]. > > Steps to test: > 1. Bind one or more E810 VF devices to the module ice_vfio_pci.ko > 2.

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Alexander H Duyck
On Mon, 2023-10-16 at 09:49 -0600, Ahmed Zaki wrote: > Symmetric RSS hash functions are beneficial in applications that monitor > both Tx and Rx packets of the same flow (IDS, software firewalls, ..etc). > Getting all traffic of the same flow on the same RX queue results in > higher CPU cache effic

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Ahmed Zaki
On 2023-10-16 14:17, Alexander H Duyck wrote: On Mon, 2023-10-16 at 09:49 -0600, Ahmed Zaki wrote: Symmetric RSS hash functions are beneficial in applications that monitor both Tx and Rx packets of the same flow (IDS, software firewalls, ..etc). Getting all traffic of the same flow on the same

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Alexander Duyck
On Mon, Oct 16, 2023 at 2:09 PM Ahmed Zaki wrote: > > > > On 2023-10-16 14:17, Alexander H Duyck wrote: > > On Mon, 2023-10-16 at 09:49 -0600, Ahmed Zaki wrote: > >> Symmetric RSS hash functions are beneficial in applications that monitor > >> both Tx and Rx packets of the same flow (IDS, software

Re: [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool

2023-10-16 Thread Jakub Kicinski
Thanks for the v2! Adding Willem, Pablo, and Harald to CC (please CC them on future versions). On Thu, 12 Oct 2023 06:01:15 + Takeru Hayasaka wrote: > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > index f7fba0dc87e5..a2d4f2081cf3 100644 > --- a/include/uapi/linux/

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Ahmed Zaki
On 2023-10-16 16:15, Alexander Duyck wrote: On Mon, Oct 16, 2023 at 2:09 PM Ahmed Zaki wrote: On 2023-10-16 14:17, Alexander H Duyck wrote: On Mon, 2023-10-16 at 09:49 -0600, Ahmed Zaki wrote: Symmetric RSS hash functions are beneficial in applications that monitor both Tx and Rx packets

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Alexander Duyck
On Mon, Oct 16, 2023 at 3:44 PM Ahmed Zaki wrote: > > > > On 2023-10-16 16:15, Alexander Duyck wrote: > > On Mon, Oct 16, 2023 at 2:09 PM Ahmed Zaki wrote: > >> > >> > >> > >> On 2023-10-16 14:17, Alexander H Duyck wrote: > >>> On Mon, 2023-10-16 at 09:49 -0600, Ahmed Zaki wrote: > Symmetric

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Jakub Kicinski
On Mon, 16 Oct 2023 15:55:21 -0700 Alexander Duyck wrote: > It would make more sense to just add it as a variant hash function of > toeplitz. If you did it right you could probably make the formatting > pretty, something like: > RSS hash function: > toeplitz: on > symmetric xor: on >

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-16 Thread Ahmed Zaki
On 2023-10-16 17:30, Jakub Kicinski wrote: On Mon, 16 Oct 2023 15:55:21 -0700 Alexander Duyck wrote: It would make more sense to just add it as a variant hash function of toeplitz. If you did it right you could probably make the formatting pretty, something like: RSS hash function: toepl