> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Jesse Brandeburg
> Sent: Monday, October 9, 2023 5:18 PM
> To: Dan Carpenter <dan.carpen...@linaro.org>; Jinjie Ruan
> <ruanjin...@huawei.com>
> Cc: net...@vger.kernel.org; kernel-janit...@vger.kernel.org; Eric Dumazet
> <eduma...@google.com>; Nguyen, Anthony L
> <anthony.l.ngu...@intel.com>; Simon Horman <ho...@kernel.org>; Jakub
> Kicinski <k...@kernel.org>; Keller, Jacob E <jacob.e.kel...@intel.com>; intel-
> wired-...@lists.osuosl.org; Paolo Abeni <pab...@redhat.com>; David S.
> Miller <da...@davemloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net-next 2/2] ixgbe: fix end of loop
> test
> in ixgbe_set_vf_macvlan()
>
> On 10/5/2023 6:58 AM, Dan Carpenter wrote:
> > The list iterator in a list_for_each_entry() loop can never be NULL.
> > If the loop exits without hitting a break then the iterator points to
> > an offset off the list head and dereferencing it is an out of bounds
> > access.
> >
> > Before we transitioned to using list_for_each_entry() loops, then it
> > was possible for "entry" to be NULL and the comments mention this. I
> > have updated the comments to match the new code.
> >
> > Fixes: c1fec890458a ("ethernet/intel: Use list_for_each_entry()
> > helper")
> > Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
>
> Reviewed-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
>
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by: Rafal Romanowski <rafal.romanow...@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
