[Intel-wired-lan] [tnguy-next-queue:40GbE] BUILD SUCCESS beabc8ccaf4c075b73c93b438c9357d8e9de8398

2023-10-03 Thread kernel test robot
arc allnoconfig gcc arc allyesconfig gcc arc axs101_defconfig gcc arc defconfig gcc arc randconfig-001-20231003 gcc arm

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Add support for packet mirroring using hardware in switchdev mode

2023-10-03 Thread Buvaneswaran, Sujai
> -Original Message- > From: Intel-wired-lan On Behalf Of > Andrii Staikov > Sent: Tuesday, September 12, 2023 3:00 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Staikov, Andrii > Subject: [Intel-wired-lan] [PATCH iwl-next v2] ice: Add support for packet > mirror

Re: [Intel-wired-lan] [PATCH iwl-net] ice: block default rule setting on LAG interface

2023-10-03 Thread Buvaneswaran, Sujai
> -Original Message- > From: Intel-wired-lan On Behalf Of > Marcin Szycik > Sent: Friday, September 15, 2023 9:05 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Marcin Szycik ; > Kitszel, Przemyslaw ; Michal Swiatkowski > > Subject: [Intel-wired-lan] [PATCH iwl-ne

Re: [Intel-wired-lan] [PATCH iwl-next 4/4] ice: cleanup ice_find_netlist_node

2023-10-03 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: Wednesday, September 20, 2023 5:05 AM > To: Intel Wired LAN > Cc: Keller, Jacob E ; Nguyen, Anthony L > > Subject: [Intel-wired-lan] [PATCH iwl-next 4/4] ice: cleanup > ice_find_netlist_node > > The ice_f

[Intel-wired-lan] [PATCH iwl-net v1] ice: Fix safe mode when DDP is missing

2023-10-03 Thread Jan Sokolowski
From: Mateusz Pacuszka One thing is broken in the safe mode, that is ice_deinit_features() is being executed even that ice_init_features() was not causing stack trace during pci_unregister_driver(). Add check on the top of the function. Fixes: 5b246e533d01 ("ice: split probe into smaller functi

Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Fix safe mode when DDP is missing

2023-10-03 Thread Przemek Kitszel
On 10/3/23 13:17, Jan Sokolowski wrote: From: Mateusz Pacuszka One thing is broken in the safe mode, that is ice_deinit_features() is being executed even that ice_init_features() was not causing stack trace during pci_unregister_driver(). Add check on the top of the function. Fixes: 5b246e533

Re: [Intel-wired-lan] [PATCH iwl-net, v2] ice: Fix VF-VF filter rules in switchdev mode

2023-10-03 Thread kernel test robot
Hi Aniruddha, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.6-rc4 next-20231003] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

[Intel-wired-lan] [tnguy-next-queue:main] BUILD SUCCESS 35766690d675f63c111afa0a2f5286b74a5b5cc2

2023-10-03 Thread kernel test robot
lmodconfig gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arcnsimosci_defconfig gcc arc randconfig-001-20231003

Re: [Intel-wired-lan] [PATCH iwl-next 4/4] ice: cleanup ice_find_netlist_node

2023-10-03 Thread Paul Menzel
Dear Jacob, Thank you for your patch. A small nit for the subject: The verb *clean up* is spelled with a space. Am 20.09.23 um 01:34 schrieb Jacob Keller: The ice_find_netlist_node function was introduced in commit 8a3a565ff210 ("ice: add admin commands to access cgu configuration"). Variati

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-03 Thread Kubalewski, Arkadiusz
>From: Jiri Pirko >Sent: Tuesday, October 3, 2023 8:32 AM > >Tue, Oct 03, 2023 at 01:03:00AM CEST, arkadiusz.kubalew...@intel.com wrote: >>>From: Jiri Pirko >>>Sent: Monday, October 2, 2023 5:04 PM >>> >>>Mon, Oct 02, 2023 at 04:32:30PM CEST, arkadiusz.kubalew...@intel.com >>>wrote: >From: Va

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-03 Thread Kubalewski, Arkadiusz
>From: Jiri Pirko >Sent: Tuesday, October 3, 2023 8:27 AM >To: Kubalewski, Arkadiusz > >Tue, Oct 03, 2023 at 01:10:39AM CEST, arkadiusz.kubalew...@intel.com wrote: >>>From: Intel-wired-lan On Behalf Of >>>Vadim Fedorenko >>>Sent: Monday, October 2, 2023 5:09 PM >>> >>>On 02/10/2023 16:04, Jiri P

Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix over-shifted variable

2023-10-03 Thread Simon Horman
On Mon, Oct 02, 2023 at 10:31:10PM -0700, Jesse Brandeburg wrote: > Since the introduction of the ice driver the code has been > double-shifting the RSS enabling field, because the define already has > shifts in it and can't have the regular pattern of "a << shiftval & > mask" applied. > > Most pl

[Intel-wired-lan] [PATCH iwl-net, v2] ice: Fix VF-VF filter rules in switchdev mode

2023-10-03 Thread Aniruddha Paul
Any packet leaving VSI i.e VF's VSI is considered as egress traffic by HW, thus failing to match the added rule. Mark the direction for redirect rules as below: 1. VF-VF - Egress 2. Uplink-VF - Ingress 3. VF-Uplink - Egress 4. Link_Partner-Uplink - Ingress 5. Link_Partner-VF - Ingress Fixes: 0960

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS b6aed813cbe277cd41af1c898e7b8f9b762a75c0

2023-10-03 Thread kernel test robot
allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc randconfig-001-20231003 gcc arm allmodconfig gcc arm

Re: [Intel-wired-lan] [PATCH net-next] iavf: Avoid a memory allocation in iavf_print_link_message()

2023-10-03 Thread Jesse Brandeburg
On 9/23/2023 5:17 AM, Christophe JAILLET wrote: > IAVF_MAX_SPEED_STRLEN is only 13 and 'speed' is allocated and freed within > iavf_print_link_message(). > > 'speed' is only used with some snprintf() and netdev_info() calls. > > So there is no real use to kzalloc()/free() it. Use the stack instea

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-03 Thread Jiri Pirko
Tue, Oct 03, 2023 at 04:29:13PM CEST, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Tuesday, October 3, 2023 8:27 AM >>To: Kubalewski, Arkadiusz >> >>Tue, Oct 03, 2023 at 01:10:39AM CEST, arkadiusz.kubalew...@intel.com wrote: From: Intel-wired-lan On Behalf Of Vadim Fe

Re: [Intel-wired-lan] [PATCH net-next 3/4] dpll: netlink/core: add support for pin-dpll signal phase offset/adjust

2023-10-03 Thread Jiri Pirko
Tue, Oct 03, 2023 at 04:29:43PM CEST, arkadiusz.kubalew...@intel.com wrote: >>From: Jiri Pirko >>Sent: Tuesday, October 3, 2023 8:32 AM >> >>Tue, Oct 03, 2023 at 01:03:00AM CEST, arkadiusz.kubalew...@intel.com wrote: From: Jiri Pirko Sent: Monday, October 2, 2023 5:04 PM Mon, Oct

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: reset first in crash dump kernels

2023-10-03 Thread Jay Vosburgh
Jesse Brandeburg wrote: >On 10/2/2023 4:49 PM, Jay Vosburgh wrote: >> Jesse Brandeburg wrote: >> >>> When the system boots into the crash dump kernel after a panic, the ice >>> networking device may still have pending transactions that can cause errors >>> or machine checks when the device is r

[Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format specifier cleanups

2023-10-03 Thread Jesse Brandeburg
Clean up some warnings from the W=1 build which moves the intel directory back to "clean" state. This mostly involved converting to using ethtool_sprintf where appropriate and kasprintf in other places. The second patch goes the extra mile and cleans up -Wformat=2 warnings as suggested by Alex Lob

[Intel-wired-lan] [PATCH iwl-next v1 1/2] intel: fix string truncation warnings

2023-10-03 Thread Jesse Brandeburg
Fix -Wformat-truncated warnings to complete the intel directories' W=1 clean efforts. The W=1 recently got enhanced with a few new flags and this brought up some new warnings. Switch to using kasprintf() when possible so we always allocate the right length strings. summary of warnings: drivers/ne

[Intel-wired-lan] [PATCH iwl-next v1 2/2] intel: fix format warnings

2023-10-03 Thread Jesse Brandeburg
Get ahead of the game and fix all the -Wformat=2 noted warnings in the intel drivers directory. There are one set of i40e and iavf warnings I couldn't figure out how to fix because the driver is already using vsnprintf without an explicit "const char *" format string. Tested with both gcc-12 and

Re: [Intel-wired-lan] [PATCH net-next] iavf: Avoid a memory allocation in iavf_print_link_message()

2023-10-03 Thread Christophe JAILLET
Le 03/10/2023 à 19:14, Jesse Brandeburg a écrit : On 9/23/2023 5:17 AM, Christophe JAILLET wrote: IAVF_MAX_SPEED_STRLEN is only 13 and 'speed' is allocated and freed within iavf_print_link_message(). 'speed' is only used with some snprintf() and netdev_info() calls. So there is no real use to

Re: [Intel-wired-lan] [PATCH net-next v5 0/7] introduce DEFINE_FLEX() macro

2023-10-03 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 12 Sep 2023 07:59:30 -0400 you wrote: > Add DEFINE_FLEX() macro, that helps on-stack allocation of structures > with trailing flex array member. > Expose __struct_size() macro which reads size of data allocat

Re: [Intel-wired-lan] [PATCH iwl-next v3 13/13] vfio/ice: Implement vfio_pci driver for E800 devices

2023-10-03 Thread Alex Williamson
On Mon, 18 Sep 2023 06:25:46 + Yahui Cao wrote: > From: Lingyu Liu > > Add a vendor-specific vfio_pci driver for E800 devices. > > It uses vfio_pci_core to register to the VFIO subsystem and then > implements the E800 specific logic to support VF live migration. > > It implements the devi

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: reset first in crash dump kernels

2023-10-03 Thread Tony Nguyen
On 10/2/2023 1:02 PM, Jesse Brandeburg wrote: When the system boots into the crash dump kernel after a panic, the ice networking device may still have pending transactions that can cause errors or machine checks when the device is re-enabled. This can prevent the crash dump kernel from loading

Re: [Intel-wired-lan] [PATCH] idpf: fix building without IPv4

2023-10-03 Thread Jakub Kicinski
On Mon, 25 Sep 2023 10:05:03 -0700 Tony Nguyen wrote: > Also, a pending patch for this [1], however, this does look a bit more > efficient. Adding Olek as he's author on the other patch. > > netdev maintainers, > > If this is the version that does get picked up, did you want to take it > direct

Re: [Intel-wired-lan] [PATCH net-next] iavf: Avoid a memory allocation in iavf_print_link_message()

2023-10-03 Thread Jesse Brandeburg
On 10/3/2023 1:33 PM, Christophe JAILLET wrote: kasprintf() is much better. cool! I just sent the patches and cc'd you earlier today. your patch still shows these errors I built-tested the patch before sending, so this is strange. However, I got a similar feedback from Greg KH and the "ke

[Intel-wired-lan] The difference between linux kernel driver and FreeBSD's with Intel X533

2023-10-03 Thread Skyler Mäntysaari
Hi there, It seems that for reasons unknown to me, my Intel X533 based 10G SFP+ doesn't want to work with kernel 6.1.55 in VyOS 1.4 nor Debian 12 but it does in OPNsense which is based on FreeBSD 13.2. How would I go about debugging this properly? Both sides see light, but no link unless I'm