> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Jacob
> Keller
> Sent: Wednesday, September 20, 2023 5:05 AM
> To: Intel Wired LAN <intel-wired-...@lists.osuosl.org>
> Cc: Keller, Jacob E <jacob.e.kel...@intel.com>; Nguyen, Anthony L
> <anthony.l.ngu...@intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next 4/4] ice: cleanup
> ice_find_netlist_node
>
> The ice_find_netlist_node function was introduced in commit 8a3a565ff210
> ("ice: add admin commands to access cgu configuration"). Variations of this
> function were reviewed concurrently on both intel-wired-lan[1][2], and
> netdev [3][4]
>
> [1]:
> https://lore.kernel.org/intel-wired-lan/20230913204943.1051233-7-vadim.fedore...@linux.dev/
> [2]:
> https://lore.kernel.org/intel-wired-lan/20230817000058.2433236-5-jacob.e.kel...@intel.com/
> [3]:
> https://lore.kernel.org/netdev/20230918212814.435688-1-anthony.l.ngu...@intel.com/
> [4]:
> https://lore.kernel.org/netdev/20230913204943.1051233-7-vadim.fedore...@linux.dev/
>
> The variant I posted had a few changes due to review feedback which were
> never incorporated into the DPLL series:
>
> * Replace the references to ancient and long removed ICE_SUCCESS and
> ICE_ERR_DOES_NOT_EXIST status codes in the function comment.
>
> * Return -ENOENT instead of -ENOTBLK, as a more common way to indicate that
> an entry doesn't exist.
>
> * Avoid the use of memset() and use simple static initialization for the
> cmd variable.
>
> * Use FIELD_PREP to assign the node_type_ctx.
>
> * Remove an unnecessary local variable to keep track of rec_node_handle,
> just pass the node_handle pointer directly into ice_aq_get_netlist_node.
>
> Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_common.c | 30 ++++++++++-----------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pu...@intel.com> (A
Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
