[Intel-wired-lan] [PATCH net-next v2] ixgbevf: Remove unused ixgbevf_hv_mbx_ops

2025-01-05 Thread linux
From: "Dr. David Alan Gilbert" The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)") but has remained unused. The functions it references are still referenced elsewhere. Remove it. Signed-off-by: Dr. David Alan Gilber

[Intel-wired-lan] [PATCH net-next 2/3] igc: Remove unused igc_read/write_pci_cfg wrappers

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" igc_read_pci_cfg() and igc_write_pci_cfg were added in 2018 as part of commit 146740f9abc4 ("igc: Add support for PF") but have remained unused. Remove them. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/igc/igc_hw.h | 2 -- drivers/net

[Intel-wired-lan] [PATCH net-next 3/3] igc: Remove unused igc_read/write_pcie_cap_reg

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" The last uses of igc_read_pcie_cap_reg() and igc_write_pcie_cap_reg() were removed in 2019 by commit 16ecd8d9af26 ("igc: Remove the obsolete workaround") Remove them. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/igc/igc_hw.h | 3 --- d

[Intel-wired-lan] [PATCH net-next 1/9] i40e: Deadcode i40e_aq_*

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" i40e_aq_add_mirrorrule(), i40e_aq_delete_mirrorrule() and i40e_aq_set_vsi_vlan_promisc() were added in 2016 by commit 7bd6875bef70 ("i40e: APIs to Add/remove port mirroring rules") but haven't been used. They were the last user of i40e_mirrorrule_op(). i40e_aq_rea

[Intel-wired-lan] [PATCH net-next 0/3] igc deadcoding

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" Hi, This set removes some functions that are entirely unused and have been since ~2018. Build tested. Signed-off-by: Dr. David Alan Gilbert (Repost now netdev is open) Dr. David Alan Gilbert (3): igc: Remove unused igc_acquire/release_nvm igc: Remove unuse

[Intel-wired-lan] [PATCH net-next 1/3] igc: Remove unused igc_acquire/release_nvm

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" igc_acquire_nvm() and igc_release_nvm() were added in 2018 as part of commit ab4056126813 ("igc: Add NVM support") but never used. Remove them. The igc_1225.c has it's own specific implementations. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet

[Intel-wired-lan] [PATCH net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)") but has remained unused. The functions it references are still referenced elsewhere. Remove it. Signed-off-by: Dr. David Alan Gilber

[Intel-wired-lan] [PATCH net-next 2/9] i40e: Remove unused i40e_blink_phy_link_led

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" i40e_blink_phy_link_led() was added in 2016 by commit fd077cd3399b ("i40e: Add functions to blink led on 10GBaseT PHY") but hasn't been used. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/intel/i40e/i40e_commo

[Intel-wired-lan] [PATCH net-next 0/9] i40e deadcoding

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" Hi, This is a bunch of deadcoding of functions that are entirely uncalled in the i40e driver. Build tested only. Signed-off-by: Dr. David Alan Gilbert (Resend now that netdev has woken up) Dr. David Alan Gilbert (9): i40e: Deadcode i40e_aq_* i40e: Remove

[Intel-wired-lan] [PATCH net-next 4/9] i40e: Deadcode profile code

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" i40e_add_pinfo_to_list() was added in 2017 by commit 1d5c960c5ef5 ("i40e: new AQ commands") i40e_find_section_in_profile() was added in 2019 by commit cdc594e00370 ("i40e: Implement DDP support in i40e driver") Neither have been used. Remove them. Signed-off-by:

[Intel-wired-lan] [PATCH net-next 3/9] i40e: Remove unused i40e_(read|write)_phy_register

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" i40e_read_phy_register() and i40e_write_phy_register() were added in 2016 by commit f62ba91458b5 ("i40e: Add functions which apply correct PHY access method for read and write operation") but haven't been used. Remove them. (There are more specific _clause* varia

[Intel-wired-lan] [PATCH net-next 9/9] i40e: Remove unused i40e_dcb_hw_get_num_tc

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" The last useof i40e_dcb_hw_get_num_tc() was removed in 2022 by commit fe20371578ef ("Revert "i40e: Fix reset bw limit when DCB enabled with 1 TC"") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/intel/i40e/i40e_

[Intel-wired-lan] [PATCH net-next 6/9] i40e: Remove unused i40e_del_filter

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" The last use of i40e_del_filter() was removed in 2016 by commit 9569a9a4547d ("i40e: when adding or removing MAC filters, correctly handle VLANs") Remove it. Fix up a comment that referenced it. Note: The __ version of this function is still used. Signed-off-by:

[Intel-wired-lan] [PATCH net-next 8/9] i40e: Remove unused i40e_asq_send_command_v2

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" i40e_asq_send_command_v2() was added in 2022 by commit 74073848b0d7 ("i40e: Add new versions of send ASQ command functions") but hasn't been used. Remove it. (The _atomic_v2 version of the function is used, so leave it). Signed-off-by: Dr. David Alan Gilbert ---

[Intel-wired-lan] [PATCH net-next 5/9] i40e: Remove unused i40e_get_cur_guaranteed_fd_count

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" The last use of i40e_get_cur_guaranteed_fd_count() was removed in 2015 by commit 04294e38a451 ("i40e: FD filters flush policy changes") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/intel/i40e/i40e.h | 1

[Intel-wired-lan] [PATCH net-next 7/9] i40e: Remove unused i40e_commit_partition_bw_setting

2025-01-02 Thread linux
From: "Dr. David Alan Gilbert" i40e_commit_partition_bw_setting() was added in 2017 by commit 4fc8c6763957 ("i40e: genericize the partition bandwidth control") but hasn't been used. Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Kalesh AP --- drivers/net/ethernet/intel/i40e/i4

[Intel-wired-lan] [RFC net-next 3/3] igc: Remove unused igc_read/write_pcie_cap_reg

2024-12-26 Thread linux
From: "Dr. David Alan Gilbert" The last uses of igc_read_pcie_cap_reg() and igc_write_pcie_cap_reg() were removed in 2019 by commit 16ecd8d9af26 ("igc: Remove the obsolete workaround") Remove them. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/igc/igc_hw.h | 3 --- d

[Intel-wired-lan] [RFC net-next 1/3] igc: Remove unused igc_acquire/release_nvm

2024-12-26 Thread linux
From: "Dr. David Alan Gilbert" igc_acquire_nvm() and igc_release_nvm() were added in 2018 as part of commit ab4056126813 ("igc: Add NVM support") but never used. Remove them. The igc_1225.c has it's own specific implementations. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet

[Intel-wired-lan] [RFC net-next 2/3] igc: Remove unused igc_read/write_pci_cfg wrappers

2024-12-26 Thread linux
From: "Dr. David Alan Gilbert" igc_read_pci_cfg() and igc_write_pci_cfg were added in 2018 as part of commit 146740f9abc4 ("igc: Add support for PF") but have remained unused. Remove them. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/igc/igc_hw.h | 2 -- drivers/net

[Intel-wired-lan] [RFC net-next 0/3] igc deadcoding

2024-12-26 Thread linux
From: "Dr. David Alan Gilbert" Hi, This set removes some functions that are entirely unused and have been since ~2018. Build tested. Signed-off-by: Dr. David Alan Gilbert Dr. David Alan Gilbert (3): igc: Remove unused igc_acquire/release_nvm igc: Remove unused igc_read/write_pci_cfg wr

[Intel-wired-lan] [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops

2024-12-26 Thread linux
From: "Dr. David Alan Gilbert" The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)") but has remained unused. The functions it references are still referenced elsewhere. Remove it. Signed-off-by: Dr. David Alan Gilber

[Intel-wired-lan] [RFC net-next 3/9] i40e: Remove unused i40e_(read|write)_phy_register

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" i40e_read_phy_register() and i40e_write_phy_register() were added in 2016 by commit f62ba91458b5 ("i40e: Add functions which apply correct PHY access method for read and write operation") but haven't been used. Remove them. (There are more specific _clause* varia

[Intel-wired-lan] [RFC net-next 2/9] i40e: Remove unused i40e_blink_phy_link_led

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" i40e_blink_phy_link_led() was added in 2016 by commit fd077cd3399b ("i40e: Add functions to blink led on 10GBaseT PHY") but hasn't been used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/i40e/i40e_common.c | 74 ---

[Intel-wired-lan] [RFC net-next 1/9] i40e: Deadcode i40e_aq_*

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" i40e_aq_add_mirrorrule(), i40e_aq_delete_mirrorrule() and i40e_aq_set_vsi_vlan_promisc() were added in 2016 by commit 7bd6875bef70 ("i40e: APIs to Add/remove port mirroring rules") but haven't been used. They were the last user of i40e_mirrorrule_op(). i40e_aq_rea

[Intel-wired-lan] [RFC net-next 5/9] i40e: Remove unused i40e_get_cur_guaranteed_fd_count

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" The last use of i40e_get_cur_guaranteed_fd_count() was removed in 2015 by commit 04294e38a451 ("i40e: FD filters flush policy changes") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/i40e/i40e.h | 1 - drivers/net/ethernet/

[Intel-wired-lan] [RFC net-next 8/9] i40e: Remove unused i40e_asq_send_command_v2

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" i40e_asq_send_command_v2() was added in 2022 by commit 74073848b0d7 ("i40e: Add new versions of send ASQ command functions") but hasn't been used. Remove it. (The _atomic_v2 version of the function is used, so leave it). Signed-off-by: Dr. David Alan Gilbert ---

[Intel-wired-lan] [RFC net-next 4/9] i40e: Deadcode profile code

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" i40e_add_pinfo_to_list() was added in 2017 by commit 1d5c960c5ef5 ("i40e: new AQ commands") i40e_find_section_in_profile() was added in 2019 by commit cdc594e00370 ("i40e: Implement DDP support in i40e driver") Neither have been used. Remove them. Signed-off-by:

[Intel-wired-lan] [RFC net-next 9/9] i40e: Remove unused i40e_dcb_hw_get_num_tc

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" The last useof i40e_dcb_hw_get_num_tc() was removed in 2022 by commit fe20371578ef ("Revert "i40e: Fix reset bw limit when DCB enabled with 1 TC"") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/i40e/i40e_dcb.c | 13 -

[Intel-wired-lan] [RFC net-next 6/9] i40e: Remove unused i40e_del_filter

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" The last use of i40e_del_filter() was removed in 2016 by commit 9569a9a4547d ("i40e: when adding or removing MAC filters, correctly handle VLANs") Remove it. Fix up a comment that referenced it. Note: The __ version of this function is still used. Signed-off-by:

[Intel-wired-lan] [RFC net-next 7/9] i40e: Remove unused i40e_commit_partition_bw_setting

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" i40e_commit_partition_bw_setting() was added in 2017 by commit 4fc8c6763957 ("i40e: genericize the partition bandwidth control") but hasn't been used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/i40e/i40e.h | 1 - driver

[Intel-wired-lan] [RFC net-next 0/9] i40e deadcoding

2024-12-21 Thread linux
From: "Dr. David Alan Gilbert" Hi, This is a bunch of deadcoding of functions that are entirely uncalled in the i40e driver. Build tested only. Signed-off-by: Dr. David Alan Gilbert Dr. David Alan Gilbert (9): i40e: Deadcode i40e_aq_* i40e: Remove unused i40e_blink_phy_link_led i40

[Intel-wired-lan] [PATCH net-next] intel/fm10k: Remove unused fm10k_iov_msg_mac_vlan_pf

2024-11-18 Thread linux
From: "Dr. David Alan Gilbert" fm10k_iov_msg_mac_vlan_pf() has been unused since 2017's commit 1f5c27e52857 ("fm10k: use the MAC/VLAN queue for VF<->PF MAC/VLAN requests") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 120 --

[Intel-wired-lan] [regression] igc does not function anymore after second resume from standby

2024-08-14 Thread Linux regression tracking (Thorsten Leemhuis)
[Tony, Przemek: lore did not find any mail from Sasha in the past few weeks, so from here it looks like this might be something somebody else needs to handle.] Hi, Thorsten here, the Linux kernel's regression tracker. Sasha, I noticed a report about a regression in bugzilla.kernel.org

Re: [Intel-wired-lan] [PATCH 1/2] Revert "igc: fix a log entry using uninitialized netdev"

2024-05-31 Thread Linux regression tracking (Thorsten Leemhuis)
On 01.06.24 07:06, Mika Westerberg wrote: > This reverts commit 86167183a17e03ec77198897975e9fdfbd53cb0b. TWIMC, Sasha Neftin already submitted a revert for that commit on Wednesday: https://lore.kernel.org/all/20240529051307.3094901-1-sasha.nef...@intel.com/ Regression reports for this problem I

Re: [Intel-wired-lan] Non-functional ixgbe driver between Intel X553 chipset and Cisco switch via kernel >=6.1 under Debian

2024-05-06 Thread Linux regression tracking (Thorsten Leemhuis)
On 06.05.24 23:18, Jacob Keller wrote: > On 5/4/2024 6:29 AM, kernel.org-fo5...@ycharbi.fr wrote: >> > Ideally, if you could use git bisect on the setup that could >> > efficiently locate what regressed the behavior. >> I really want to, but I have no idea how to go about it. Can you write >> me

Re: [Intel-wired-lan] [BUG] e1000e, scheduling while atomic (stable)

2024-04-28 Thread Linux regression tracking (Thorsten Leemhuis)
On 27.04.24 13:14, Greg KH wrote: > On Sat, Apr 27, 2024 at 10:54:23AM +, Artem S. Tashkinov wrote: >> This fix is still not queued in 6.8 stable: > What fix? FWIW, this one: https://lore.kernel.org/all/20240417190320.3159360-1-vitaly.lifsh...@intel.com/ But sadly the review is still pending

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change usleep_range to udelay in PHY mdic access

2024-04-26 Thread Linux regression tracking (Thorsten Leemhuis)
24a.ca...@zougloub.eu/ Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.

Re: [Intel-wired-lan] [REGRESSION] Intel ICE Ethernet driver in linux >= 6.6.9 triggers extra memory consumption and cause continous kswapd* usage and continuous swapping

2024-03-05 Thread Linux regression tracking (Thorsten Leemhuis)
s something changes. FWIW, it seems nobody really cares, so I'll strop tracking this issue: #regzbot inconclusive: might not qualify as a regression Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression

Re: [Intel-wired-lan] [REGRESSION] Intel ICE Ethernet driver in linux >= 6.6.9 triggers extra memory consumption and cause continous kswapd* usage and continuous swapping

2024-01-24 Thread Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. On 11.01.24 09:26, Jaroslav Pulchart wrote: >> On 1/8/2024 2:49 AM, Jaroslav Pulchart wrote: >> First, thank you for your work trying to chase this! >>> I would like to report a regression triggered by rece

Re: [Intel-wired-lan] [REGRESSION] Intel ICE Ethernet driver in linux >= 6.6.9 triggers extra memory consumption and cause continous kswapd* usage and continuous swapping

2024-01-19 Thread Linux regression tracking (Thorsten Leemhuis)
[TLDR: I'm adding this report to the list of tracked Linux kernel regressions; the text you find below is based on a few templates paragraphs you might have encountered already in similar form. See link in footer if these mails annoy you.] On 08.01.24 11:49, Jaroslav Pulchart wrote: > &

Re: [Intel-wired-lan] sr-iov related bonding regression (two regressions in one report)

2023-11-14 Thread Linux regression tracking (Thorsten Leemhuis)
verything working > fine"), it's plausible that the underlying cause is something > platform-specific. Maybe, but when it comes to the "no regressions" rule that likely makes no difference from Linus perspective. But I guess unless the intel folks or someone else has a