On 11/14/24 10:06 AM, Ertman, David M wrote:
case ICE_AQC_CAPS_RDMA:
- caps->rdma = (number == 1);
+ if (IS_ENABLED(CONFIG_INFINIBAND_IRDMA))
+ caps->rdma = (number == 1);
ice_debug(hw, ICE_DBG_INIT, "%s: rdma = %d\n", pref
On Fri, Nov 15, 2024 at 12:51 AM Przemek Kitszel
wrote:
>
> On 11/14/24 01:00, jbran...@kernel.org wrote:
> > From: Jesse Brandeburg
> >
> > If the CONFIG_INFINIBAND_IRDMA symbol is not enabled as a module or a
> > built-in, then don't let the driver reserve
On 6/17/2024 1:29 PM, Paul Menzel wrote:
> Dear Jesse,
>
>
> Am 17.06.24 um 21:07 schrieb Jesse Brandeburg:
>> Since Jesse has moved to a new role, replace him with a new maintainer
>> to work with Tony on representing Intel networking drivers in the
>> kernel.
&
Since Jesse has moved to a new role, replace him with a new maintainer
to work with Tony on representing Intel networking drivers in the
kernel.
Cc: Przemek Kitszel
Signed-off-by: Jesse Brandeburg
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b
Kicinski
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 42 ++-
.../net/ethernet/intel/ice/ice_flex_pipe.c| 8 +---
drivers/net/ethernet/intel/ice/ice_lag.c | 5 +--
drivers/net/ethernet/intel/ice/ice_main.c | 7 +---
drivers/net
all u32 as before, and are less likely so will
wrap less.
Reviewed-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 9 +
drivers/net/ethernet/intel/ice/ice_ptp.h | 1 +
2 files changed, 10 insertions(+)
diff
The kernel now has common statistics for transmit timestamps, so
implement them in the ice driver.
use via
ethtool -I -T eth0
Reviewed-by: Jacob Keller
Reviewed-by: Jakub Kicinski
Reviewed-by: Hariprasad Kelam
Signed-off-by: Jesse Brandeburg
---
$ sudo ethtool -I -T eth0
Time stamping
Jacob Keller
Reviewed-by: Jakub Kicinski
Signed-off-by: Jesse Brandeburg
---
Example output:
Standard stats for ens785f1np1:
eth-mac-FramesTransmittedOK: 296
eth-mac-FramesReceivedOK: 339
eth-mac-FrameCheckSequenceErrors: 0
eth-mac-OctetsTransmittedOK: 70410
eth-mac-OctetsReceivedOK: 51414
eth-mac
ical order.
Cc: Rahul Rameshbabu
Reviewed-by: Jacob Keller
Reviewed-by: Rahul Rameshbabu
Reviewed-by: Jakub Kicinski
Signed-off-by: Jesse Brandeburg
---
v2: fix up a mixup of backticks and quotes (Jakub)
I didn't add a Fixes: tag because this is not an urgent kind of fix that
should re
one reviewer in commit message
pick up some reviewed-bys from the list
v1:
https://lore.kernel.org/netdev/20240604221327.299184-1-jesse.brandeb...@intel.com/
Jesse Brandeburg (5):
net: docs: add missing features that can have stats
ice: implement ethtool standard stats
ice: add tracking
On 6/5/2024 5:48 PM, Jakub Kicinski wrote:
> On Tue, 4 Jun 2024 15:13:21 -0700 Jesse Brandeburg wrote:
>> - - `ETHTOOL_MSG_PAUSE_GET`
>>- `ETHTOOL_MSG_FEC_GET`
>> + - 'ETHTOOL_MSG_LINKSTATE_GET'
>>- `ETHTOOL_MSG_MM_GET`
>> + - `ETHTOOL_MSG
all u32 as before, and are less likely so will
wrap less.
Reviewed-by: Jacob Keller
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 9 +
drivers/net/ethernet/intel/ice/ice_ptp.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/drivers/net/ethernet
since most L2 frames have
a type/length field specifying a "type", and raw ethernet frames aren't
used much any longer.
NOTE: I didn't implement Ctrl aka control frame stats because the
hardware doesn't seem to implement support.
Reviewed-by: Marcin Szycik
Signed
The kernel now has common statistics for transmit timestamps, so
implement them in the ice driver.
use via
ethtool -I -T eth0
Reviewed-by: Jacob Keller
Signed-off-by: Jesse Brandeburg
---
$ sudo ethtool -I -T eth0
Time stamping parameters for eth0:
Capabilities:
hardware-transmit
ical order.
Cc: Rahul Rameshbabu
Reviewed-by: Jacob Keller
Signed-off-by: Jesse Brandeburg
---
I didn't add a Fixes: tag because this is not an urgent kind of fix that
should require backports.
---
Documentation/networking/statistics.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-
Use the ice_netdev_to_pf() helper in more places and remove a bunch of
boilerplate code. Not every instance could be replaced due to use of the
netdev_priv() output or the vsi variable within a bunch of functions.
Reviewed-by: Jacob Keller
Signed-off-by: Jesse Brandeburg
---
drivers/net
The main point of this series is to implement the standard stats for the
ice driver, but also add a related documentation fix and finish the
series off with a cleanup that removes a bunch of code.
Jesse Brandeburg (5):
net: docs: add missing features that can have stats
ice: implement ethtool
> Fix this by adding 200G support to ice_print_link_msg().
>
> Fixes: 24407a01e57c ("ice: Add 200G speed/phy type use")
> Reviewed-by: Michal Swiatkowski
> Signed-off-by: Paul Greenwalt
Reviewed-by: Jesse Brandeburg
!
Reviewed-by: Jesse Brandeburg
On 4/4/2024 7:59 PM, James Dutton wrote:
> Hi,
>
> I have source code for a sfp phy that is setting
> phydev->link = 1
> What else do I have to do to make ethtool think the
> Link detected: yes
>
> Is there a function I need to call from the phy code to cause the
> carrier state to be UP ?
> etht
On 3/21/2024 1:20 PM, Julia Lawall wrote:
Does one prefer an initialization of null at the top of the function
or an initialization to a meaningful value in the middle of the
function ?
I think the latter.
There was a related patch explaining the direction, from Dan posted here:
https://lore.k
.841
> sockperf: ---> percentile 99.999 = 45.026
> sockperf: ---> percentile 99.990 = 39.009
> sockperf: ---> percentile 99.900 = 35.922
> sockperf: ---> percentile 99.000 = 33.482
> sockperf: ---> percentile 90.000 = 28.902
> sockperf: --->
On 3/14/2024 5:00 AM, Ivan Vecera wrote:
> As for ice bug fixed by commit b7306b42beaf ("ice: manage interrupts
> during poll exit") followed by commit 23be7075b318 ("ice: fix software
> generating extra interrupts") I'm seeing the similar issue also with
> i40e driver.
Please see my comments on v
On 3/13/2024 5:54 AM, Ivan Vecera wrote:
> As for ice bug fixed by commit b7306b42beaf ("ice: manage interrupts
> during poll exit") I'm seeing the similar issue also with i40e driver.
>
> In certain situation when busy-loop is enabled together with adaptive
> coalescing, the driver occasionally m
On 3/6/2024 5:33 PM, Jesse Brandeburg wrote:
On 3/6/2024 8:56 AM, Maciej Fijalkowski wrote:
Fixes: b3e7b3a6ee92 ("ice: prevent NULL pointer deref during reload")
Reported-by: Robert Elliott
Signed-off-by: Jesse Brandeburg
Reviewed-by: Maciej Fijalkowski
Well, that refactor of c
On 3/6/2024 8:56 AM, Maciej Fijalkowski wrote:
Fixes: b3e7b3a6ee92 ("ice: prevent NULL pointer deref during reload")
Reported-by: Robert Elliott
Signed-off-by: Jesse Brandeburg
Reviewed-by: Maciej Fijalkowski
Well, that refactor of config path introduced lots of issues. Could
.
Checked with network-enabled allnoconfig, allyesconfig, allmodconfig on
x64_64.
Reviewed-by: Alan Brady
Signed-off-by: Jesse Brandeburg
---
v2: added ice driver changes to series
v1: original net-next posting
all changes except for ice were reviewed by Simon Horman
no other changes besides to
The igb driver was pre-declaring tons of functions just so that it could
have an early declaration of the pci_driver struct.
Delete a bunch of the declarations and move the struct to the bottom of the
file, after all the functions are declared.
Reviewed-by: Alan Brady
Signed-off-by: Jesse
, which is then cleaned up in 2/2
original v1:
Link:
https://lore.kernel.org/netdev/20240210220109.3179408-1-jesse.brandeb...@intel.com/
[1] https://lore.kernel.org/netdev/20211207002102.26414-1-p...@crapouillou.net/
Jesse Brandeburg (2):
igb: simplify pci ops declaration
net: intel
1] ret_from_fork_asm+0x1b/0x30
[1026677.481050]
Fixes: b3e7b3a6ee92 ("ice: prevent NULL pointer deref during reload")
Reported-by: Robert Elliott
Signed-off-by: Jesse Brandeburg
---
v2: fix uninitialized coalesce pointer on the exit path by moving the
kfree to the later goto (simo
On 3/5/2024 5:17 AM, Simon Horman wrote:
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
>> @@ -3238,7 +3238,7 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, u32 vsi_flags)
>> {
>> struct ice_vsi_cfg_params params = {};
>> struct ice_coalesc
Fix an obviously incorrect assignment, created with a typo or cut-n-paste
error.
Fixes: 5995ef88e3a8 ("ice: realloc VSI stats arrays")
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
1] ret_from_fork_asm+0x1b/0x30
[1026677.481050]
Fixes: b3e7b3a6ee92 ("ice: prevent NULL pointer deref during reload")
Reported-by: Robert Elliott
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/ice/ice_lib.c | 16
1 file changed, 8 insertions(+
On 2/29/2024 11:02 PM, Jakub Kicinski wrote:
> struct net_device poll_dev in struct igc_q_vector was added
> in one of the initial commits, but never used.
>
> Signed-off-by: Jakub Kicinski
Thanks Jakub, you can just apply this directly AFAICS.
Reviewed-by: Jesse Brandeburg
On 2/22/2024 2:25 PM, Tony Nguyen wrote:
I think he means that the tests won't pass without Amritha's patch
because we'll hit the ASSERT_RTNL in the suspend flow otherwise.
Got it. Anyways, this doesn't apply to net-queue, could we rebase or
base it off of that tree?
Ok, will send v2 off -n
7.464235] ? __pfx_kthread+0x10/0x10
[1026677.468445] ret_from_fork+0x2d/0x50
[1026677.472476] ? __pfx_kthread+0x10/0x10
[1026677.476671] ret_from_fork_asm+0x1b/0x30
[1026677.481050]
Fixes: 5b246e533d01 ("ice: split probe into smaller functions")
Reported-by: Robert Elliott
Reviewed-by:
On 2/19/2024 1:15 AM, Simon Horman wrote:
> On Sat, Feb 10, 2024 at 02:01:08PM -0800, Jesse Brandeburg wrote:
>> The igb driver was pre-declaring tons of functions just so that it could
>> have an early declaration of the pci_driver struct.
>>
>> Delete a bunch of th
On 2/13/2024 6:13 PM, Jakub Kicinski wrote:
> On Fri, 9 Feb 2024 18:09:57 -0800 Jesse Brandeburg wrote:
>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>> @@ -10416,14 +10416,11 @@ static const
.
Checked with network-enabled allnoconfig, allyesconfig, allmodconfig on
x64_64.
Reviewed-by: Alan Brady
Signed-off-by: Jesse Brandeburg
---
e1p-v2: dropped errant idpf change, updated after v2 1/2 updates to
move the declation down for igb_pm_ops.
---
drivers/net/ethernet/intel/e100.c
The igb driver was pre-declaring tons of functions just so that it could
have an early declaration of the pci_driver struct.
Delete a bunch of the declarations and move the struct to the bottom of the
file, after all the functions are declared.
Reviewed-by: Alan Brady
Signed-off-by: Jesse
]
Mostly compile-tested only.
ice driver is skipped in this series because the driver was fixed as
part of a bug fix to make it use the new APIs, and will be arriving via
-net tree.
[1] https://lore.kernel.org/netdev/20211207002102.26414-1-p...@crapouillou.net/
Jesse Brandeburg (2):
igb
e is a bunch of code in ixgbe under IXGBE_FCOE defines which is only
defined when CONFIG_FCOE is defined, but I didn't want to fix hundreds
of those so just left most of them.
Signed-off-by: Jesse Brandeburg
---
.../net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 --
.../net/ethernet/broadcom
rted-by: Geert Uytterhoeven
Closes:
https://lore.kernel.org/lkml/d03e90ca-8485-4d1b-5ec1-c3398e0e...@linux-m68k.org/
#i40e #ice
Fixes: 62589808d73b ("i40e: field get conversion")
Fixes: 5a259f8e0baf ("ice: field get conversion")
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethern
On 1/23/2024 3:45 AM, Geert Uytterhoeven wrote:
> in drivers/net/ethernet/intel/ice/ice_base.c
>
> powerpc-gcc5/ppc32_allmodconfig
> in drivers/net/ethernet/intel/ice/ice_nvm.c
>
> aarcharm64-gcc5/arm64-allmodconfig
> powerpc-gcc5/ppc32_allmodconfig
> powerpc-gcc5/powerpc-allmodconfig
> powerpc-g
On 2/4/2024 12:39 PM, Geert Uytterhoeven wrote:
> On Sun, 4 Feb 2024, Geert Uytterhoeven wrote:
>> JFYI, when comparing v6.8-rc3[1] to v6.8-rc2[3], the summaries are:
>> - build errors: +4/-44
>
> + /kisskb/src/include/linux/compiler_types.h: error: call to
> '__compiletime_assert_1093' declare
rt. In
> this patch I chose to do it in the same place in the idpf_cfg_netdev
> function.
>
> Fixes: 0fe45467a104 ("idpf: add create vport and netdev configuration")
> Signed-off-by: Michal Schmidt
LGTM! Thanks Michal! I checked our latest internal development branch
and it matches what you've added here.
Reviewed-by: Jesse Brandeburg
On 1/8/2024 2:49 AM, Jaroslav Pulchart wrote:
> Hello
First, thank you for your work trying to chase this!
>
> I would like to report a regression triggered by recent change in
> Intel ICE Ethernet driver in the 6.6.9 linux kernel. The problem was
> bisected and the regression is triggered by
>
Please don't use HTML email, your reply was likely dropped by most lists
that filter HTML.
On 12/12/2023 8:06 PM, Kalesh Anakkur Purayil wrote:
> - change_type = FIELD_GET(ICE_AQ_LLDP_MIB_TYPE_M, mib->type);
> + change_type = FIELD_GET(ICE_AQ_LLDP_MIB_TYPE_M, mib->type);
>
>
On 12/12/2023 1:28 PM, Jakub Kicinski wrote:
> On Mon, 11 Dec 2023 10:59:27 +0800 Kunwu Chan wrote:
>> kasprintf() returns a pointer to dynamically allocated memory
>> which can be NULL upon failure.
>>
>> Fixes: 1978d3ead82c ("intel: fix string truncation warnings")
>
> No need for the allocation
On 12/4/2023 2:26 AM, Alexander Lobakin wrote:
yping.
>
> What is "not a constant"?
>
> ring[nta] = FIELD_PREP(IDPF_RX_BI_GEN_M,
> test_bit(__IDPF_Q_GEN_CHK, flags));
>
> Is there a problem with this ^ code?
>
> "The scripts ignored that" is not a good argumen
eviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: add a couple get_bits
---
drivers/net/ethernet/intel/i40e/i40e_common.c | 56 +++
drivers/net/ethernet/intel/i40e/i40e_dcb.c| 158 +++---
drivers/net/ethernet/intel/i40e/i40e_dcb_nl.c | 3 +-
drivers/net/ethernet/
C: Alexander Lobakin
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: added a couple more preps, some code cleanups found when looking for
le32_set/encode opportunities.
---
drivers/net/ethernet/intel/ice/ice_base.c | 20 ++---
drivers/net/ethernet/in
> shift)
+FIELD_GET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
Cc: Julia Lawall
CC: Alexander Lobakin
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: update to le16_encode_bits i
alue was 0. The code makes way more sense as a FIELD_PREP and
was in fact the only FIELD_GET with two constant arguments in this
series.
Didn't squash this patch to make it easier to call out the
(non-impactful) bug.
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/ice/ice_dcb.c
, a)
@get@
constant shift,mask;
type T;
expression a;
@@
-((T)((a) & mask) >> shift)
+FIELD_GET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
CC: Alexander Lobakin
Reviewed-by: Przemek Kitszel
Signed-off-by: Jesse Brandeburg
)((a) & mask) >> shift)
+FIELD_GET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
.../net/ethernet/intel/iavf/iavf
mask) >> shift)
+FIELD_GET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
CC: Alexander Lobakin
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: added a couple more get c
@@
-((T)((a) << shift) & mask)
+FIELD_PREP(mask, a)
Cc: Julia Lawall
Cc: Ahmed Zaki
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: updated commit message
---
drivers/net/ethernet/intel/iavf/iavf_common.c | 31 ---
dri
) & mask) >> shift)
+FIELD_GET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/igc/igc_
VLAN EMODE defines as well.
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: no change
---
.../net/ethernet/intel/ice/ice_adminq_cmd.h| 18 +-
drivers/net/ethernet/intel/ice/ice_lib.c | 7 ---
drivers/net/ethernet
prep2@
constant shift,mask;
type T;
expression a;
@@
-(((T)(a) << shift) & mask)
+FIELD_PREP(mask, a)
@prep@
constant shift,mask;
type T;
expression a;
@@
-((T)((a) << shift) & mask)
+FIELD_PREP(mask, a)
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed
& mask)
+FIELD_PREP(mask, a)
@prep@
constant shift,mask;
type T;
expression a;
@@
-((T)((a) << shift) & mask)
+FIELD_PREP(mask, a)
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: updated commit message with new script
---
& mask)
+FIELD_PREP(mask, a)
@prep@
constant shift,mask;
type T;
expression a;
@@
-((T)((a) << shift) & mask)
+FIELD_PREP(mask, a)
Cc: Julia Lawall
Cc: Sasha Neftin
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: no change
---
drivers/ne
leXX_{get,set,encode}_bits() call, as suggested by Alex.
CC: Alexander Lobakin
Reviewed-by: Marcin Szycik
Reviewed-by: Simon Horman
Signed-off-by: Jesse Brandeburg
---
v2: add some conversions to the ice patch, add the idpf patch, respond to
comments from reviewers, resulting in more le*_bits u
#x27;s own includes as it
should. This required including bits.h for virtchnl.h.
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/e1000/e1000_hw.c | 1 +
drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 1 +
drivers/net/ethernet/intel/fm10k/fm10k_v
ff-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/e1000e/80003es2lan.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/80003es2lan.c
b/drivers/net/ethernet/intel/e1000e/80003es2lan.c
index be9c695dde12..74671201208e 100644
On 12/1/2023 5:41 AM, tedheadster wrote:
>>> Has anyone tried compiling the out-of-tree kernel network software
>>> for the 'ice' driver on 32 bit i386? I tried it for the
>>> long-term-support 5.10.197 kernel and got these compile time errors:
>>
>> Are those regressions?
>> Have you tried 1.12.x?
On 12/1/2023 6:32 AM, Alexander Lobakin wrote:
> From: Jesse Brandeburg
>> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
>> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
>> @@ -505,7 +505,7 @@ static void idpf_rx_post_buf_refill(struct idpf_sw_queue
&g
Most of idpf correctly uses FIELD_GET and FIELD_PREP, but a couple spots
were missed so fix those.
This conversion was automated via a coccinelle script as posted with the
previous series.
Signed-off-by: Jesse Brandeburg
---
This patch should be applied after the larger FIELD_PREP/FIELD_GET
On 11/24/2023 3:03 AM, Simon Horman wrote:
> On Tue, Nov 21, 2023 at 01:19:21PM -0800, Jesse Brandeburg wrote:
>> Refactor the ice driver to use FIELD_GET() for mask and shift reads,
>> which reduces lines of code and adds clarity of intent.
>>
>> This code was
VLAN EMODE defines as well.
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
.../net/ethernet/intel/ice/ice_adminq_cmd.h| 18 +-
drivers/net/ethernet/intel/ice/ice_lib.c | 7 ---
drivers/net/ethernet/intel/ice/ice_virtchnl.c | 10 +-
.../ne
@prep@
constant shift,mask;
type T;
expression a;
@@
-(((T)(a) << shift) & mask)
+FIELD_PREP(mask, a)
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/i40e/i40e_common.c | 83 ++---
drivers/net/ethernet/intel/i40e/i40e
& mask)
+FIELD_PREP(mask, a)
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/e1000e/80003es2lan.c | 7 +++
drivers/net/ethernet/intel/e1000e/phy.c | 7 +++
drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 3 +--
drivers/ne
) << shift) & mask)
+FIELD_PREP(mask, a)
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/ice/ice_base.c | 20 +++---
drivers/net/ethernet/intel/ice/ice_common.c | 23 +++
drivers/net/ethernet/intel/ice/ice_dcb.c
mask) >> shift)
+FIELD_GET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/ice/ice_base.c | 12 +--
drivers/net/ethernet
mask) >> shift)
+FIELD_GET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
.../net/ethernet/intel/iavf/iavf_ethtool.c| 3 +--
drivers/net/ethernet/
mask) >> shift)
+FIELD_GET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/igc/igc_base.c | 6 ++
drivers/net/ethernet
llow the
use of the FIELD_* macros and fix up the unexpected "shifts included"
defines found while creating this series.
The rest are the conversion to use FIELD_PREP()/FIELD_GET().
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
Jesse Brandeburg (13):
e1000e: make lost bit
ET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
Cc: Julia Lawall
Reviewed-by: Aleksandr Loktionov
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/i40e/i40e_common.c | 56 +++
drivers/ne
EP(mask, a)
Cc: Julia Lawall
Cc: Sasha Neftin
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
b/drivers/net/ethernet
ET(mask, a)
and applied via:
spatch --sp-file field_prep.cocci --in-place --dir \
drivers/net/ethernet/intel/
Cc: Julia Lawall
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/e1000/e1000_hw.c | 45 ---
.../net/ethernet/intel/e1000e/800
#x27;s own includes as it
should. This required including bits.h for virtchnl.h.
Reviewed-by: Marcin Szycik
Signed-off-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/e1000/e1000_hw.c | 1 +
drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 1 +
drivers/net/ethernet/intel/fm10k/fm10k_v
p; blat)
y |= cpu_to_*((blahs << blahs_blahs) & blats)
to
x = FIELD_PREP(blat blah)
x |= FIELD_PREP(blats, blahs)
y = cpu_to_*(x);
@prep@
constant shift,mask;
expression a;
@@
-((a << shift) & mask)
+FIELD_PREP(mask, a)
Cc: Julia Lawall
Cc: Ahmed Zaki
Reviewed-by: Marcin Szycik
S
ff-by: Jesse Brandeburg
---
drivers/net/ethernet/intel/e1000e/80003es2lan.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/80003es2lan.c
b/drivers/net/ethernet/intel/e1000e/80003es2lan.c
index be9c695dde12..74671201208e 100644
On 11/8/2023 7:10 AM, Ivan Vecera wrote:
> Commit 3a2c6ced90e1 ("i40e: Add a check to see if MFS is set") added
> a check for port's MFS (max frame size) value. The value is stored
> in PRTGL_SAH register for each physical port. According datasheet this
> register is defined as:
>
> PRTGL_SAH[PRT]
On 11/7/2023 2:40 PM, Sachin Bahadur wrote:
> PF interface part of LAG should not allow driver reinit via devlink. The
> Bond config will be lost due to driver reinit. ice_devlink_reload_down is
> called before PF driver reinit. If PF is attached to bond,
> ice_devlink_reload_down returns error.
>
ed-strings
> [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
> [2]
> Link: https://github.com/KSPP/linux/issues/90
> Signed-off-by: Justin Stitt
Thanks Justin for fixing all these!
For the series:
Reviewed
On 10/10/2023 2:20 PM, Jesse Brandeburg wrote:
> On 10/10/2023 2:12 PM, Justin Stitt wrote:
>> `strncpy` is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.
>>
>>
On 10/10/2023 2:15 PM, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect netdev->name to be NUL-terminated based on its use with format
> strings:
> |
On 10/10/2023 2:07 PM, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We see that netdev->name is expected to be NUL-terminated based on its
> usage with format s
On 10/10/2023 1:53 PM, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> Moreover, `strncat` shouldn't really be used either as per
> fortify-string.h:
> * Do not u
On 10/10/2023 2:12 PM, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect netdev->name to be NUL-terminated based on its usage with
> `strlen` and format st
On 10/4/2023 10:08 AM, Skyler Mäntysaari wrote:
>>> Hi there,
>>>
>>> It seems that for reasons unknown to me, my Intel X533 based 10G SFP+
>>> doesn't want to work with kernel 6.1.55 in VyOS 1.4 nor Debian 12 but
>>> it does in OPNsense which is based on FreeBSD 13.2.
>>>
>>> How would I go about
On 10/6/2023 5:53 AM, Dan Carpenter wrote:
> The adapter->vf_mvs.l list needs to be initialized even if the list is
> empty. Otherwise it will lead to crashes.
>
> Fixes: a1cbb15c1397 ("ixgbe: Add macvlan support for VF")
> Signed-off-by: Dan Carpenter
R
we transitioned to using list_for_each_entry() loops, then
> it was possible for "entry" to be NULL and the comments mention
> this. I have updated the comments to match the new code.
>
> Fixes: c1fec890458a ("ethernet/intel: Use list_for_each_entry() helper")
&
to be true and we end up corrupting memory.
>
> The way to test for these is to just set a flag.
>
> Fixes: c1fec890458a ("ethernet/intel: Use list_for_each_entry() helper")
> Signed-off-by: Dan Carpenter
Reviewed-by: Jesse Brandeburg
__
Reported-by: Vishal Agrawal
Reviewed-by: Przemek Kitszel
Signed-off-by: Jesse Brandeburg
___
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
let it load automatically) with modprobe ice
- The system crashes again during pcim_enable_device()
Fixes: 837f08fdecbe ("ice: Add basic driver framework for Intel(R) E800 Series")
Reported-by: Vishal Agrawal
Reviewed-by: Jay Vosburgh
Reviewed-by: Przemek Kitszel
Signed-off-by: Jesse Br
On 10/3/2023 4:25 PM, Skyler Mäntysaari wrote:
Hi there,
It seems that for reasons unknown to me, my Intel X533 based 10G SFP+
doesn't want to work with kernel 6.1.55 in VyOS 1.4 nor Debian 12 but it
does in OPNsense which is based on FreeBSD 13.2.
How would I go about debugging this properl
On 10/3/2023 1:33 PM, Christophe JAILLET wrote:
kasprintf() is much better.
cool! I just sent the patches and cc'd you earlier today.
your patch still shows these errors
I built-tested the patch before sending, so this is strange.
However, I got a similar feedback from Greg KH and the "ke
1 - 100 of 110 matches
Mail list logo
