On 11/7/2023 2:40 PM, Sachin Bahadur wrote:
> PF interface part of LAG should not allow driver reinit via devlink. The
> Bond config will be lost due to driver reinit. ice_devlink_reload_down is
> called before PF driver reinit. If PF is attached to bond,
> ice_devlink_reload_down returns error.
>
> Reviewed-by: Jacob Keller <jacob.e.kel...@intel.com>
> Signed-off-by: Sachin Bahadur <sachin.baha...@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_devlink.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c
> b/drivers/net/ethernet/intel/ice/ice_devlink.c
> index 80dc5445b50d..45e40b587e82 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devlink.c
> +++ b/drivers/net/ethernet/intel/ice/ice_devlink.c
> @@ -457,6 +457,10 @@ ice_devlink_reload_down(struct devlink *devlink, bool
> netns_change,
> "Remove all VFs before doing
> reinit\n");
> return -EOPNOTSUPP;
> }
> + if (pf->lag && pf->lag->bonded) {
> + NL_SET_ERR_MSG_MOD(extack, "Remove all associated Bonds
> before doing reinit\n");
no linefeeds on extack messages. see
make M=`pwd`/drivers/net/ethernet/intel/ice coccicheck
output.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
