> So you have confirmed with the datsheet that the write is not needed?
>
> As i said, this is a hardware register, not memory. Writes are not
> always idempotent. It might be necessary to write it twice.
I have checked following datasheets and I can not find that we need to write
RDH, RDT, TDH, T
On 8/30/2024 6:30 AM, Alexander Lobakin wrote:
> From: Paul Greenwalt
> Date: Mon, 26 Aug 2024 13:39:16 -0400
>
>> E830 supports generic receive and HW_CSUM transmit checksumming.
>>
>> Generic receive checksum support is provided by hardware calculating the
>> checksum over the whole packet a
> -Original Message-
> From: Kitszel, Przemyslaw
> Sent: Friday, August 30, 2024 7:14 PM
> To: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L
>
> Cc: Pucha, HimasekharX Reddy ; Kitszel,
> Przemyslaw ; Zaremba, Larysa
> ; Philipp Stanner
> Subject: [PATCH iwl-net v2] ice: stop ca
On 9/3/2024 3:13 PM, Vladimir Oltean wrote:
> On Tue, Sep 03, 2024 at 02:16:59PM -0700, Jacob Keller wrote:
>> I only kept my interface in terms of lsb+size because I did not want to
>> attempt to re-write the table. I actually did re-write the table at
>> first, and discovered a documentation b
On Tue, Sep 03, 2024 at 02:16:59PM -0700, Jacob Keller wrote:
> I only kept my interface in terms of lsb+size because I did not want to
> attempt to re-write the table. I actually did re-write the table at
> first, and discovered a documentation bug because our documentation for
> the table has inc
On Fri, 30 Aug 2024 17:12:56 +
"Ertman, David M" wrote:
> > -Original Message-
> > From: Thomas Bogendoerfer
> > Sent: Tuesday, August 27, 2024 12:12 PM
> > To: Kitszel, Przemyslaw
> > Cc: Nguyen, Anthony L ; David S. Miller
> > ; Eric Dumazet ; Jakub
> > Kicinski ; Paolo Abeni ; in
On 9/3/2024 5:22 AM, Yue Haibing wrote:
>
> Yue Haibing (3):
> iavf: Remove unused declarations
> igb: Cleanup unused declarations
> ice: Cleanup unused declarations
>
It would be interesting to see when the code for these declarations was
removed (if it was ever present in the kernel t
On 9/2/2024 5:08 PM, Vladimir Oltean wrote:
> On Wed, Aug 28, 2024 at 01:57:26PM -0700, Jacob Keller wrote:
>> The major difference with is that it expects the unpacked
>> data will always be a u64. This is somewhat limiting, but can be worked
>> around by using a local temporary u64.
>>
>> As
On 9/2/2024 4:25 PM, Vladimir Oltean wrote:
> Hi Jacob,
>
> It's very cool that you and Przemek (and possibly others) spent the time
> to untangle this. Thanks! Just a microscopic nitpick below.
>
> On Wed, Aug 28, 2024 at 01:57:24PM -0700, Jacob Keller wrote:
>> That is, QUIRK_MSB_ON_THE_RI
On Fri, Aug 30, 2024 at 09:28:07PM +0200, Aleksandr Loktionov wrote:
> In cases when vf sends malformed packets that are classified as
> malicious, sometimes it causes tx queue to freeze. This frozen queue can be
> stuck for several minutes being unusable. When mdd event occurs, there is a
> posibi
> > On Fri, Aug 30, 2024 at 9:28 PM Aleksandr Loktionov
> > wrote:
> > >
> > > In cases when vf sends malformed packets that are classified as
> > > malicious, sometimes it causes tx queue to freeze. This frozen queue
> > > can be stuck for several minutes being unusable. When mdd event
> > > occu
When a mailbox message is received, the driver is checking for a non 0
datalen in the controlq descriptor. If it is valid, the payload is
attached to the ctlq message to give to the upper layer. However, the
payload response size given to the upper layer was taken from the buffer
metadata which is
Avoid the following warning when trying to free an already freed IRQ,
The issue happens when trying to call i40e_remove() twice from two
different contexts which will lead to calling i40e_vsi_free_irq() twice,
Fix the issue by using a flag to mark that the IRQ has already been freed.
i40e :07:
> -Original Message-
> From: Michal Schmidt
> Sent: Monday, September 2, 2024 3:25 PM
> To: Loktionov, Aleksandr
> Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L
> ; net...@vger.kernel.org; Sokolowski, Jan
> ; Connolly, Padraig J
>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-n
In cases when synchronizing DMA operations is necessary,
xsk_buff_alloc_batch() returns a single buffer instead of the requested
count. Detect such situation when filling HW Rx ring in ZC driver and
use xsk_buff_alloc() in a loop manner so that ring gets the buffers to
be used.
Reported-and-tested
On Tue, Sep 03, 2024 at 07:46:42PM +0900, Takamitsu Iwai wrote:
> > Did the same sequence of read/writes happen before 0845d45e900c? Or
> > did 0845d45e900c add additional writes, not just move them around?
>
> The sequence of read/writes happened before 0845d45e900c because the similar
> writel()
> -Original Message-
> From: Intel-wired-lan On Behalf Of Kurt
> Kanzenbach
> Sent: Thursday, August 22, 2024 12:42 AM
> To: Nguyen, Anthony L ; Kitszel, Przemyslaw
>
> Cc: Jesper Dangaard Brouer ; Daniel Borkmann
> ; Sriram Yagnaraman
> ; Sebastian Andrzej Siewior
> ; Kurt Kanzenbach ; J
On Mon, Sep 02, 2024 at 01:55:41PM -0600, Gustavo A. R. Silva wrote:
>
>
> On 02/09/24 06:46, Simon Horman wrote:
> > ethtool_puts() is the preferred method for copying ethtool strings.
> > And ethtool_puts() is already used to copy ethtool strings in
> > igc_ethtool_get_strings(). With this patc
This patch addresses an issue with improper reference count handling in the
ice_sriov_set_msix_vec_count() function.
First, the function calls ice_get_vf_by_id(), which increments the
reference count of the vf pointer. If the subsequent call to
ice_get_vf_vsi() fails, the function currently return
This patch addresses a reference count handling issue in the
ice_dpll_init_rclk_pins() function. The function calls ice_dpll_get_pins(),
which increments the reference count of the relevant resources. However,
if the condition WARN_ON((!vsi || !vsi->netdev)) is met, the function
currently returns a
> Did the same sequence of read/writes happen before 0845d45e900c? Or
> did 0845d45e900c add additional writes, not just move them around?
The sequence of read/writes happened before 0845d45e900c because the similar
writel() exists in ew32() above the writel() moved by 0845d45e900c.
The commit 08
Duplicated register initialization codes exist in e1000_configure_tx()
and e1000_configure_rx().
For example, writel(0, tx_ring->head) writes 0 to tx_ring->head, which
is adapter->hw.hw_addr + E1000_TDH(0).
This initialization is already done in ew32(TDH(0), 0).
ew32(TDH(0), 0) is equivalent to
We have for some time the assign_bit() API to replace open coded
if (foo)
set_bit(n, bar);
else
clear_bit(n, bar);
Use this API to clean the code. No functional change intended.
Signed-off-by: Hongbo Li
---
drivers/net/ethernet/intel/ice/ice_main.c | 3 +--
1 fi
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Larysa Zaremba
> Sent: Friday, August 23, 2024 2:59 AM
> To: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L
>
> Cc: Drewek, Wojciech ; Fijalkowski, Maciej
> ; Jesper Dangaard Brouer ;
> Daniel Borkmann ; Zaremba, Larysa
> ;
Hi Yue,
I know these patches are obvious but one sentence in cover letter
wouldn't hurt 😊
Anyways, for the content:
Reviewed-by: Maciej Fijalkowski
> Yue Haibing (3):
> iavf: Remove unused declarations
> igb: Cleanup unused declarations
> ice: Cleanup unused declarations
>
> drivers/net
e1000_init_function_pointers_82575() is never implemented and used since
commit 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver").
And commit 9835fd7321a6 ("igb: Add new function to read part number from
EEPROM in string format") removed igb_read_part_num() implementation.
Signed-off
There is no caller and implementation in tree.
Signed-off-by: Yue Haibing
---
drivers/net/ethernet/intel/iavf/iavf.h | 10 --
drivers/net/ethernet/intel/iavf/iavf_prototype.h | 3 ---
2 files changed, 13 deletions(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf.h
b/driv
Since commit fff292b47ac1 ("ice: add VF representors one by one")
ice_eswitch_configure() is not used anymore.
Commit 1b8f15b64a00 ("ice: refactor filter functions") removed
ice_vsi_cfg_mac_fltr() but leave declaration.
Commit a24b4c6e9aab ("ice: xsk: Do not convert to buff to frame for
XDP_TX") le
Yue Haibing (3):
iavf: Remove unused declarations
igb: Cleanup unused declarations
ice: Cleanup unused declarations
drivers/net/ethernet/intel/iavf/iavf.h | 10 --
drivers/net/ethernet/intel/iavf/iavf_prototype.h | 3 ---
drivers/net/ethernet/intel/ice/ice_eswitch.h
29 matches
Mail list logo
