> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Kurt
> Kanzenbach
> Sent: Thursday, August 22, 2024 12:42 AM
> To: Nguyen, Anthony L <anthony.l.ngu...@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kits...@intel.com>
> Cc: Jesper Dangaard Brouer <h...@kernel.org>; Daniel Borkmann
> <dan...@iogearbox.net>; Sriram Yagnaraman
> <sriram.yagnara...@ericsson.com>; Sebastian Andrzej Siewior
> <bige...@linutronix.de>; Kurt Kanzenbach <k...@linutronix.de>; John Fastabend
> <john.fastab...@gmail.com>; Alexei Starovoitov <a...@kernel.org>; Sriram
> Yagnaraman <sriram.yagnara...@est.tech>; Benjamin Steinke
> <benjamin.stei...@woks-audio.com>; Eric Dumazet <eduma...@google.com>;
> net...@vger.kernel.org; Fijalkowski, Maciej <maciej.fijalkow...@intel.com>;
> intel-
> wired-...@lists.osuosl.org; Jakub Kicinski <k...@kernel.org>;
> b...@vger.kernel.org; Paolo Abeni <pab...@redhat.com>; David S. Miller
> <da...@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-net] igb: Always call
> igb_xdp_ring_update_tail()
> under Tx lock
>
> From: Sriram Yagnaraman <sriram.yagnara...@est.tech>
>
> Always call igb_xdp_ring_update_tail() under __netif_tx_lock, add a comment
> and
> lockdep assert to indicate that. This is needed to share the same TX ring
> between
> XDP, XSK and slow paths. Furthermore, the current XDP implementation is racy
> on
> tail updates.
>
> Fixes: 9cbc948b5a20 ("igb: add XDP support")
> Signed-off-by: Sriram Yagnaraman <sriram.yagnara...@est.tech>
> [Kurt: Add lockdep assert and fixes tag]
> Signed-off-by: Kurt Kanzenbach <k...@linutronix.de>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
Tested-by: George Kuruvinakunnel <george.kuruvinakun...@intel.com>
