On Fri, 30 Aug 2024 11:39:00 -0700 Jakub Kicinski wrote:
> > There is a misunderstanding. This helper will be used in a following
> > patch (7/12) with a different 'type' argument:
> > NET_SHAPER_A_BINDING_IFINDEX. I've put a note in the commit message, but
> > was unintentionally dropped in one
> -Original Message-
> From: Kitszel, Przemyslaw
> Sent: Thursday, August 29, 2024 11:05 PM
> To: Keller, Jacob E ; Nguyen, Anthony L
>
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; google-lan-
> revi...@googlegroups.com; Manoj Vishwanathan ;
> David S. Miller ; Eric Dumaz
In cases when vf sends malformed packets that are classified as
malicious, sometimes it causes tx queue to freeze. This frozen queue can be
stuck for several minutes being unusable. When mdd event occurs, there is a
posibility to perform a graceful vf reset to quickly bring vf back to
operational s
On Fri, 30 Aug 2024 17:43:08 +0200 Paolo Abeni wrote:
> Please allow me to put a few high level questions together, to both
> underline them as most critical, and keep the thread focused.
>
> On 8/30/24 03:20, Jakub Kicinski wrote:
> > This 'binding' has the same meaning as 'binding' in TCP ZC?
On Fri, 30 Aug 2024 18:48:41 +0200 Paolo Abeni wrote:
> >> + const struct net_shaper_ops *ops = net_shaper_binding_ops(binding);
> >> + struct net_shaper_info *parent = NULL;
> >> + struct net_shaper_handle leaf_handle;
> >> + int i, ret;
> >> +
> >> + if (node_handle->scope == NET_SHAPER_SCOP
On Fri, 30 Aug 2024 12:55:05 +0200 Paolo Abeni wrote:
> On 8/30/24 03:20, Jakub Kicinski wrote:>> +/* Initialize the context
> fetching the relevant device and
> >> + * acquiring a reference to it.
> >> + */
> >> +static int net_shaper_ctx_init(const struct genl_info *info, int type,
> >> +
> -Original Message-
> From: Thomas Bogendoerfer
> Sent: Tuesday, August 27, 2024 12:12 PM
> To: Kitszel, Przemyslaw
> Cc: Nguyen, Anthony L ; David S. Miller
> ; Eric Dumazet ; Jakub
> Kicinski ; Paolo Abeni ; intel-
> wired-...@lists.osuosl.org; net...@vger.kernel.org; linux-
> ker...@v
On 8/30/24 04:04, Jakub Kicinski wrote:
+static int __net_shaper_group(struct net_shaper_binding *binding,
+ int leaves_count,
+ const struct net_shaper_handle *leaves_handles,
+ struct net_shaper_info *leaves,
+
Hi,
Please allow me to put a few high level questions together, to both
underline them as most critical, and keep the thread focused.
On 8/30/24 03:20, Jakub Kicinski wrote:
> This 'binding' has the same meaning as 'binding' in TCP ZC? :(
I hope we can agree that good naming is difficult. I t
On 29.08.24 21:22, Dan Carpenter wrote:
Call rtnl_unlock() on this error path, before returning.
Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/intel/igc/igc_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/
When auxiliary_device_add() returns error and then calls
auxiliary_device_uninit(), callback function adev_release
calls kfree(iadev). We shouldn't call kfree(iadev) again
in the error handling path. Set 'iadev' to NULL.
Cc: sta...@vger.kernel.org
Fixes: f9f5301e7e2d ("ice: Register auxiliary devi
From: Ma Ke
Date: Fri, 30 Aug 2024 21:33:24 +0800
> When auxiliary_device_add() returns error and then calls
> auxiliary_device_uninit(), callback function adev_release
> calls kfree(iadev). We shouldn't call kfree(iadev) again
> in the error handling path. Set 'iadev' to NULL.
>
> Cc: sta...@vg
Our driver uses devres to manage resources, in particular we call
pcim_enable_device(), what also means we express the intent to get
automatic pci_disable_device() call at driver removal. Manual calls to
pci_disable_device() misuse the API.
Recent commit (see "Fixes" tag) has changed the removal a
From: Paul Greenwalt
Date: Mon, 26 Aug 2024 13:39:16 -0400
> E830 supports generic receive and HW_CSUM transmit checksumming.
>
> Generic receive checksum support is provided by hardware calculating the
> checksum over the whole packet and providing it to the driver in the Rx
> flex descriptor.
From: Yochai Hagvi
PTP pins assignment and their related SDPs (Software Definable Pins) are
currently hardcoded.
Fix that by reading NVM section instead on products supporting this,
which are E810 products.
If SDP section is not defined in NVM, the driver continues to use the
hardcoded table.
Re
From: Sergey Temerkhanov
Implement configuring 1PPS signal output from CGU. Use maximal amplitude
because Linux PTP pin API does not have any way for user to set signal
level.
This change is necessary for E825C products to properly output any
signal from 1PPS pin.
Reviewed-by: Arkadiusz Kubalew
When setting a new supported function for a pin on E810, disable other
enabled pin that shares the same GPIO.
Reviewed-by: Arkadiusz Kubalewski
Signed-off-by: Karol Kolacinski
Reviewed-by: Simon Horman
---
V1 -> V2: Fixed incorrect call to ice_ptp_set_sma_cfg_e810t()
drivers/net/ethernet/inte
Cache original PTP GPIO requests instead of saving each parameter in
internal structures for periodic output or external timestamp request.
Factor out all periodic output register writes from ice_ptp_cfg_clkout
to a separate function to improve readability.
Reviewed-by: Arkadiusz Kubalewski
Sign
Instead of having separate PTP GPIO implementation for E810T, use
existing one from all other products.
Reviewed-by: Arkadiusz Kubalewski
Signed-off-by: Karol Kolacinski
Reviewed-by: Simon Horman
---
V1 -> V2: restored blank line and moved enable and verify assignment
drivers/net/ethernet/int
Add support of PTP SDPs (Software Definable Pins) for E825C products.
Reviewed-by: Arkadiusz Kubalewski
Signed-off-by: Karol Kolacinski
Reviewed-by: Simon Horman
---
V1 -> V2: Removed redundant n_pins assignment and enable and verify move
drivers/net/ethernet/intel/ice/ice_ptp.c | 20
Add a new internal structure describing PTP pins.
Use the new structure for all non-E810T products.
Reviewed-by: Arkadiusz Kubalewski
Signed-off-by: Karol Kolacinski
Reviewed-by: Simon Horman
---
V1 -> V2: Removed unused err variable
drivers/net/ethernet/intel/ice/ice_ptp.c | 256
This series cleans up current PTP GPIO pin handling, fixes minor bugs,
refactors implementation for all products, introduces SDP (Software
Definable Pins) for E825C and implements reading SDP section from NVM
for E810 products.
Karol Kolacinski (5):
ice: Implement ice_ptp_pin_desc
ice: Add SDP
On 8/30/24 03:20, Jakub Kicinski wrote:>> +/* Initialize the context
fetching the relevant device and
+ * acquiring a reference to it.
+ */
+static int net_shaper_ctx_init(const struct genl_info *info, int type,
+ struct net_shaper_nl_ctx *ctx)
+{
+ struct net *
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Wojciech Drewek
> Sent: Monday, August 5, 2024 7:14 PM
> To: net...@vger.kernel.org
> Cc: Nguyen, Anthony L ; intel-wired-
> l...@lists.osuosl.org; Kitszel, Przemyslaw
> Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Flush FDB e
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Michal Swiatkowski
> Sent: Monday, August 19, 2024 3:44 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Drewek, Wojciech
> ; Kitszel, Przemyslaw
>
> Subject: [Intel-wired-lan] [iwl-next v1] ice: set correc
25 matches
Mail list logo
