Re: [Intel-wired-lan] [PATCH net] igc: Unlock on error in igc_io_resume()

[Gerhard Engleder]

On 29.08.24 21:22, Dan Carpenter wrote:

Call rtnl_unlock() on this error path, before returning.

Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
---
  drivers/net/ethernet/intel/igc/igc_main.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c 
b/drivers/net/ethernet/intel/igc/igc_main.c
index dfd6c00b4205..0a095cdea4fb 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -7413,6 +7413,7 @@ static void igc_io_resume(struct pci_dev *pdev)
        rtnl_lock();
        if (netif_running(netdev)) {
                if (igc_open(netdev)) {
+                       rtnl_unlock();
                        netdev_err(netdev, "igc_open failed after reset\n");
                        return;
                }

Reviewed-by: Gerhard Engleder <gerh...@engleder-embedded.com>