Re: [Intel-wired-lan] [PATCH iwl-next] ice: use irq_update_affinity_hint()

2024-05-27 Thread Michal Schmidt
On Fri, May 24, 2024 at 11:04 PM Jacob Keller wrote: > On 5/22/2024 4:12 PM, Michal Schmidt wrote: > > irq_set_affinity_hint() is deprecated. Use irq_update_affinity_hint() > > instead. This removes the side-effect of actually applying the affinity. > > > > The driver does not really need to worry

[Intel-wired-lan] [iwl-next v3 15/15] ice: allow to activate and deactivate subfunction

2024-05-27 Thread Michal Swiatkowski
From: Piotr Raczynski Use previously implemented SF aux driver. It is probe during SF activation and remove after deactivation. Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatkowski --- .../ethernet/intel/ice/devlink/devlink_port.c | 173 ++ .../ethernet/intel/ice/d

[Intel-wired-lan] [iwl-next v3 14/15] ice: basic support for VLAN in subfunctions

2024-05-27 Thread Michal Swiatkowski
Implement add / delete vlan for subfunction type VSI. Reviewed-by: Wojciech Drewek Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/Makefile | 1 + .../ethernet/intel/ice/ice_sf_vsi_vlan_ops.c | 21 +++ .../ethernet/intel/ice/ice_sf_vsi_vlan_ops.h |

[Intel-wired-lan] [iwl-next v3 13/15] ice: support subfunction devlink Tx topology

2024-05-27 Thread Michal Swiatkowski
Flow for creating Tx topology is the same as for VF port representors, but the devlink port is stored in different place (sf->devlink_port). When creating VF devlink lock isn't taken, when creating subfunction it is. Setting Tx topology function needs to take this lock, check if it was taken befor

[Intel-wired-lan] [iwl-next v3 12/15] ice: implement netdevice ops for SF representor

2024-05-27 Thread Michal Swiatkowski
Subfunction port representor needs the basic netdevice ops to work correctly. Create them. Reviewed-by: Wojciech Drewek Reviewed-by: Jiri Pirko Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice_repr.c | 57 +-- 1 file changed, 43 insertions(+), 14 del

[Intel-wired-lan] [iwl-next v3 11/15] ice: check if SF is ready in ethtool ops

2024-05-27 Thread Michal Swiatkowski
Now there is another type of port representor. Correct checking if parent device is ready to reflect also new PR type. Reviewed-by: Wojciech Drewek Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 +++ drivers/net/ethernet/intel/ice/ice_repr.c| 12

[Intel-wired-lan] [iwl-next v3 10/15] ice: don't set target VSI for subfunction

2024-05-27 Thread Michal Swiatkowski
Add check for subfunction before setting target VSI. It is needed for PF in switchdev mode but not for subfunction (even in switchdev mode). Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[Intel-wired-lan] [iwl-next v3 09/15] ice: create port representor for SF

2024-05-27 Thread Michal Swiatkowski
Implement attaching and detaching SF port representor. It is done in the same way as the VF port representor. SF port representor is always added or removed with devlink lock taken. Signed-off-by: Michal Swiatkowski --- .../ethernet/intel/ice/devlink/devlink_port.c | 6 +-- drivers/net/etherne

[Intel-wired-lan] [iwl-next v3 08/15] ice: make representor code generic

2024-05-27 Thread Michal Swiatkowski
Keep the same flow of port representor creation, but instead of general attach function create helpers for specific representor type. Store function pointer for add and remove representor. Type of port representor can be also known based on VSI type, but it is more clean to have it directly saved

[Intel-wired-lan] [iwl-next v3 07/15] ice: implement netdev for subfunction

2024-05-27 Thread Michal Swiatkowski
From: Piotr Raczynski Configure netdevice for subfunction usecase. Mostly it is reusing ops from the PF netdevice. SF netdev is linked to devlink port registered after SF activation. Reviewed-by: Jiri Pirko Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatkowski --- drivers/net/eth

[Intel-wired-lan] [iwl-next v3 06/15] ice: base subfunction aux driver

2024-05-27 Thread Michal Swiatkowski
From: Piotr Raczynski Implement subfunction driver. It is probe when subfunction port is activated. VSI is already created. During the probe VSI is being configured. MAC unicast and broadcast filter is added to allow traffic to pass. Store subfunction pointer in VSI struct. The same is done for

[Intel-wired-lan] [iwl-next v3 05/15] ice: allocate devlink for subfunction

2024-05-27 Thread Michal Swiatkowski
From: Piotr Raczynski Make devlink allocation function generic to use it for PF and for SF. Add function for SF devlink port creation. It will be used in next patch. Create header file for subfunction device. Define subfunction device structure there as it is needed for devlink allocation and p

[Intel-wired-lan] [iwl-next v3 04/15] ice: treat subfunction VSI the same as PF VSI

2024-05-27 Thread Michal Swiatkowski
When subfunction VSI is open the same code as for PF VSI should be executed. Also when up is complete. Reflect that in code by adding subfunction VSI to consideration. In case of stopping, PF doesn't have additional tasks, so the same is with subfunction VSI. Signed-off-by: Michal Swiatkowski --

[Intel-wired-lan] [iwl-next v3 03/15] ice: add basic devlink subfunctions support

2024-05-27 Thread Michal Swiatkowski
From: Piotr Raczynski Implement devlink port handlers responsible for ethernet type devlink subfunctions. Create subfunction devlink port and setup all resources needed for a subfunction netdev to operate. Configure new VSI for each new subfunction, initialize and configure interrupts and Tx/Rx r

[Intel-wired-lan] [iwl-next v3 02/15] ice: export ice ndo_ops functions

2024-05-27 Thread Michal Swiatkowski
From: Piotr Raczynski Make some of the netdevice_ops functions visible from outside for another VSI type created netdev. Reviewed-by: Przemek Kitszel Reviewed-by: Wojciech Drewek Signed-off-by: Piotr Raczynski Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice.h |

[Intel-wired-lan] [iwl-next v3 01/15] ice: add new VSI type for subfunctions

2024-05-27 Thread Michal Swiatkowski
From: Piotr Raczynski Add required plumbing for new VSI type dedicated to devlink subfunctions. Make sure that the vsi is properly configured and destroyed. Also allow loading XDP and AF_XDP sockets. The first implementation of devlink subfunctions supports only one Tx/Rx queue pair per given su

[Intel-wired-lan] [iwl-next v3 00/15] ice: support devlink subfunction

2024-05-27 Thread Michal Swiatkowski
Hi, Currently ice driver does not allow creating more than one networking device per physical function. The only way to have more hardware backed netdev is to use SR-IOV. Following patchset adds support for devlink port API. For each new pcisf type port, driver allocates new VSI, configures all r

[Intel-wired-lan] [PATCH iwl-next v2 13/13] iavf: add support for offloading tc U32 cls filters

2024-05-27 Thread Ahmed Zaki
Add support for offloading cls U32 filters. Only "skbedit queue_mapping" and "drop" actions are supported. Also, only "ip" and "802_3" tc protocols are allowed. The PF must advertise the VIRTCHNL_VF_OFFLOAD_TC_U32 capability flag. Since the filters will be enabled via the FD stage at the PF, a new

[Intel-wired-lan] [PATCH iwl-next v2 12/13] iavf: refactor add/del FDIR filters

2024-05-27 Thread Ahmed Zaki
In preparation for a second type of FDIR filters that can be added by tc-u32, move the add/del of the FDIR logic to be entirely contained in iavf_fdir.c. The iavf_find_fdir_fltr_by_loc() is renamed to iavf_find_fdir_fltr() to be more agnostic to the filter ID parameter (for now @loc, which is rele

[Intel-wired-lan] [PATCH iwl-next v2 11/13] ice: enable FDIR filters from raw binary patterns for VFs

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Enable VFs to create FDIR filters from raw binary patterns. The corresponding processes for raw flow are added in the Parse / Create / Destroy stages. Reviewed-by: Marcin Szycik Signed-off-by: Junfeng Guo Co-developed-by: Ahmed Zaki Signed-off-by: Ahmed Zaki --- .../net/et

[Intel-wired-lan] [PATCH iwl-next v2 10/13] ice: add method to disable FDIR SWAP option

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo The SWAP Flag in the FDIR Programming Descriptor doesn't work properly, it is always set and cannot be unset (hardware bug). Thus, add a method to effectively disable the FDIR SWAP option by setting the FDSWAP instead of FDINSET registers. Reviewed-by: Marcin Szycik Signed-off

[Intel-wired-lan] [PATCH iwl-next v2 09/13] virtchnl: support raw packet in protocol header

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo The patch extends existing virtchnl_proto_hdrs structure to allow VF to pass a pair of buffers as packet data and mask that describe a match pattern of a filter rule. Then the kernel PF driver is requested to parse the pair of buffer and figure out low level hardware metadata (p

[Intel-wired-lan] [PATCH iwl-next v2 08/13] ice: add API for parser profile initialization

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Add API ice_parser_profile_init() to init a parser profile based on a parser result and a mask buffer. The ice_parser_profile struct is used by the low level FXP engine to create HW profile/field vectors. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfe

[Intel-wired-lan] [PATCH iwl-next v2 07/13] ice: add UDP tunnels support to the parser

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Add support for the vxlan, geneve, ecpri UDP tunnels through the following APIs: - ice_parser_vxlan_tunnel_set() - ice_parser_geneve_tunnel_set() - ice_parser_ecpri_tunnel_set() Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Signed-off-by: Ahme

[Intel-wired-lan] [PATCH iwl-next v2 06/13] ice: support turning on/off the parser's double vlan mode

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Add API ice_parser_dvm_set() to support turning on/off the parser's double vlan mode. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Co-developed-by: Ahmed Zaki Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/ice_parser.c | 77 +

[Intel-wired-lan] [PATCH iwl-next v2 05/13] ice: add parser execution main loop

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Implement the core work of the runtime parser via: - ice_parser_rt_execute() - ice_parser_rt_reset() - ice_parser_rt_pkt_buf_set() Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/Mak

[Intel-wired-lan] [PATCH iwl-next v2 04/13] ice: add parser internal helper functions

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Add the following internal helper functions: - ice_bst_tcam_match(): to perform ternary match on boost TCAM. - ice_pg_cam_match(): to perform parse graph key match in cam table. - ice_pg_nm_cam_match(): to perform parse graph key no match in cam table. - ice_ptype_mk_t

[Intel-wired-lan] [PATCH iwl-next v2 03/13] ice: add debugging functions for the parser sections

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Add debug for all parser sections. Reviewed-by: Marcin Szycik Signed-off-by: Qi Zhang Signed-off-by: Junfeng Guo Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/ice_parser.c | 470 1 file changed, 470 insertions(+) diff --git a/drivers/ne

[Intel-wired-lan] [PATCH iwl-next v2 02/13] ice: parse and init various DDP parser sections

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Parse the following DDP sections: - ICE_SID_RXPARSER_IMEM into an array of struct ice_imem_item - ICE_SID_RXPARSER_METADATA_INIT into an array of struct ice_metainit_item - ICE_SID_RXPARSER_CAM or ICE_SID_RXPARSER_PG_SPILL into an array of struct ice_pg_cam_item - ICE_SID

[Intel-wired-lan] [PATCH iwl-next v2 01/13] ice: add parser create and destroy skeleton

2024-05-27 Thread Ahmed Zaki
From: Junfeng Guo Add new parser module which can parse a packet in binary and generate information like ptype, protocol/offset pairs and flags which can be later used to feed the FXP profile creation directly. Add skeleton of the create and destroy APIs: ice_parser_create() ice_parser_destroy()

[Intel-wired-lan] [PATCH iwl-next v2 00/13] ice: iavf: add support for TC U32 filters on VFs

2024-05-27 Thread Ahmed Zaki
The Intel® Ethernet 800 Series is designed with a pipeline that has an on-chip programmable capability called Dynamic Device Personalization (DDP). A DDP package is loaded by the driver during probe time. The DDP package programs functionality in both the parser and switching blocks in the pipeline

Re: [Intel-wired-lan] [PATCH v8 12/12] ABI: pps: Add ABI documentation for Intel TIO

2024-05-27 Thread Andy Shevchenko
Mon, May 27, 2024 at 11:53:07AM +, D, Lakshmi Sowjanya kirjoitti: > > -Original Message- > > From: Andy Shevchenko > > Sent: Monday, May 13, 2024 4:52 PM > > On Mon, May 13, 2024 at 04:08:13PM +0530, lakshmi.sowjany...@intel.com > > wrote: ... > > > +Date:June 2024 > > >

[Intel-wired-lan] [PATCH iwl-next v7 7/7] ixgbe: Enable link management in E610 device

2024-05-27 Thread Piotr Kwapulinski
Add high level link management support for E610 device. Enable the following features: - driver load - bring up network interface - IP address assignment - pass traffic - show statistics (e.g. via ethtool) - disable network interface - driver unload Co-developed-by: Carolyn Wyborny Signed-off-by:

[Intel-wired-lan] [PATCH iwl-next v7 6/7] ixgbe: Clean up the E610 link management related code

2024-05-27 Thread Piotr Kwapulinski
Required for enabling the link management in E610 device. Signed-off-by: Piotr Kwapulinski --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 17 +++-- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 12 ++-- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/d

[Intel-wired-lan] [PATCH iwl-next v7 5/7] ixgbe: Add ixgbe_x540 multiple header inclusion protection

2024-05-27 Thread Piotr Kwapulinski
Required to adopt x540 specific functions by E610 device. Signed-off-by: Piotr Kwapulinski --- drivers/net/ethernet/intel/ixgbe/ixgbe_x540.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.h b/drivers/net/ethernet/intel/ixgbe

[Intel-wired-lan] [PATCH iwl-next v7 4/7] ixgbe: Add support for NVM handling in E610 device

2024-05-27 Thread Piotr Kwapulinski
Add low level support for accessing NVM in E610 device. NVM operations are handled via the Admin Command Interface. Add the following NVM specific operations: - acquire, release, read - validate checksum - read shadow ram Co-developed-by: Stefan Wegrzyn Signed-off-by: Stefan Wegrzyn Co-developed

[Intel-wired-lan] [PATCH iwl-next v7 3/7] ixgbe: Add link management support for E610 device

2024-05-27 Thread Piotr Kwapulinski
Add low level link management support for E610 device. Link management operations are handled via the Admin Command Interface. Add the following link management operations: - get link capabilities - set up link - get media type - get link status, link status events - link power management Co-devel

[Intel-wired-lan] [PATCH iwl-next v7 2/7] ixgbe: Add support for E610 device capabilities detection

2024-05-27 Thread Piotr Kwapulinski
Add low level support for E610 device capabilities detection. The capabilities are discovered via the Admin Command Interface. Discover the following capabilities: - function caps: vmdq, dcb, rss, rx/tx qs, msix, nvm, orom, reset - device caps: vsi, fdir, 1588 - phy caps Co-developed-by: Stefan We

[Intel-wired-lan] [PATCH iwl-next v7 1/7] ixgbe: Add support for E610 FW Admin Command Interface

2024-05-27 Thread Piotr Kwapulinski
Add low level support for Admin Command Interface (ACI). ACI is the Firmware interface used by a driver to communicate with E610 adapter. Add the following ACI features: - data structures, macros, register definitions - commands handling - events handling Co-developed-by: Stefan Wegrzyn Signed-of

[Intel-wired-lan] [PATCH iwl-next v7 0/7] ixgbe: Add support for Intel(R) E610 device

2024-05-27 Thread Piotr Kwapulinski
Add initial support for Intel(R) E610 Series of network devices. The E610 is based on X550 but adds firmware managed link, enhanced security capabilities and support for updated server manageability. This patch series adds low level support for the following features and enables link management.

Re: [Intel-wired-lan] [PATCH v8 10/12] pps: generators: Add PPS Generator TIO Driver

2024-05-27 Thread Andy Shevchenko
Mon, May 27, 2024 at 11:48:54AM +, D, Lakshmi Sowjanya kirjoitti: > > -Original Message- > > From: Andy Shevchenko > > Sent: Monday, May 13, 2024 4:49 PM > > On Mon, May 13, 2024 at 04:08:11PM +0530, lakshmi.sowjany...@intel.com > > wrote: ... > > > +static ssize_t enable_store(struc

[Intel-wired-lan] REGRESSION: 86167183a17e ("igc: fix a log entry using uninitialized netdev")

2024-05-27 Thread Jani Nikula
Hi all, the Intel graphics CI hits a lockdep issue with commit 86167183a17e ("igc: fix a log entry using uninitialized netdev") in v6.10-rc1. The commit moved igc_ptp_init() which initializes spinlocks after igt_reset() which ends up using the adapter->ptp_tx_lock. Lockdep isn't happy: <3>[ 1

Re: [Intel-wired-lan] [PATCH v8 12/12] ABI: pps: Add ABI documentation for Intel TIO

2024-05-27 Thread D, Lakshmi Sowjanya
> -Original Message- > From: Andy Shevchenko > Sent: Monday, May 13, 2024 4:52 PM > To: D, Lakshmi Sowjanya > Cc: t...@linutronix.de; jstu...@google.com; giome...@enneenne.com; > cor...@lwn.net; linux-ker...@vger.kernel.org; x...@kernel.org; > net...@vger.kernel.org; linux-...@vger.ker

Re: [Intel-wired-lan] [PATCH v8 10/12] pps: generators: Add PPS Generator TIO Driver

2024-05-27 Thread D, Lakshmi Sowjanya
> -Original Message- > From: Andy Shevchenko > Sent: Monday, May 13, 2024 4:49 PM > To: D, Lakshmi Sowjanya > Cc: t...@linutronix.de; jstu...@google.com; giome...@enneenne.com; > cor...@lwn.net; linux-ker...@vger.kernel.org; x...@kernel.org; > net...@vger.kernel.org; linux-...@vger.ker

Re: [Intel-wired-lan] [PATCH RFC iwl-next 08/12] idpf: reuse libeth's definitions of parsed ptype structures

2024-05-27 Thread Alexander Lobakin
From: Mina Almasry Date: Fri, 10 May 2024 09:22:05 -0700 > On Fri, May 10, 2024 at 8:30 AM Alexander Lobakin > wrote: >> >> idpf's in-kernel parsed ptype structure is almost identical to the one >> used in the previous Intel drivers, which means it can be converted to >> use libeth's definitions

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: add and use roundup_u64 instead of open coding equivalent

2024-05-27 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: Tuesday, May 14, 2024 3:52 AM > To: Intel Wired LAN > Cc: Keller, Jacob E > Subject: [Intel-wired-lan] [PATCH iwl-next v2] ice: add and use roundup_u64 > instead of open coding equivalent > > In ice_ptp_cf

Re: [Intel-wired-lan] [PATCH iwl-net v4] ice: fix iteration of TLVs in Preserved Fields Area

2024-05-27 Thread Przemek Kitszel
On 5/25/24 01:06, Jacob Keller wrote: The ice_get_pfa_module_tlv() function iterates over the Type-Length-Value structures in the Preserved Fields Area (PFA) of the NVM. This is used by the driver to access data such as the Part Board Assembly identifier. The function uses simple logic to iterat

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: check for unregistering correct number of devlink params

2024-05-27 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Dave > Ertman > Sent: Friday, May 24, 2024 2:34 AM > To: intel-wired-...@lists.osuosl.org > Cc: Kitszel, Przemyslaw ; Czapnik, Lukasz > > Subject: [Intel-wired-lan] [PATCH iwl-net v2] ice: check for unregistering > correct numbe

Re: [Intel-wired-lan] [PATCH v10 iwl-next 08/12] ice: Change CGU regs struct to anonymous

2024-05-27 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karol > Kolacinski > Sent: Wednesday, April 24, 2024 7:00 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Kubalewski, Arkadiusz > ; Kolacinski, Karol > ; Nguyen, Anthony L ; > Kitszel, Przemyslaw > Subje

Re: [Intel-wired-lan] [PATCH v10 iwl-next 09/12] ice: Add support for E825-C TS PLL handling

2024-05-27 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karol > Kolacinski > Sent: Wednesday, April 24, 2024 7:00 PM > To: intel-wired-...@lists.osuosl.org > Cc: Michal Michalik ; net...@vger.kernel.org; > Kubalewski, Arkadiusz ; Kolacinski, Karol > ; Nguyen, Anthony L ; > Kitszel, P

Re: [Intel-wired-lan] [PATCH v10 iwl-next 05/12] ice: Move CGU block

2024-05-27 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karol > Kolacinski > Sent: Wednesday, April 24, 2024 7:00 PM > To: intel-wired-...@lists.osuosl.org > Cc: Temerkhanov, Sergey ; > net...@vger.kernel.org; Kubalewski, Arkadiusz > ; Kolacinski, Karol > ; Nguyen, Anthony L ; > Kit

Re: [Intel-wired-lan] [PATCH v10 iwl-next 04/12] ice: Add PHY OFFSET_READY register clearing

2024-05-27 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Karol > Kolacinski > Sent: Wednesday, April 24, 2024 7:00 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Kubalewski, Arkadiusz > ; Kolacinski, Karol > ; Nguyen, Anthony L ; > Kitszel, Przemyslaw > Subje