Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix integer overflow in ice_get_pfa_module_tlv

2024-05-16 Thread Paul Menzel
Dear Paul, dear Jacob, Am 16.05.24 um 23:18 schrieb Jacob Keller: From: Paul Greenwalt It's possible that an NVM with an invalid tlv_len could cause an integer overflow of next_tlv which can result an infinite loop. Fix this issue by changing next_tlv from u16 to u32 to prevent overflow. W

Re: [Intel-wired-lan] [linus:master] [e1000e] 861e808602: suspend-stress.fail (e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue)

2024-05-16 Thread Paul Menzel
Dear Rui, Thank you for your quick reply. Am 15.05.24 um 11:29 schrieb Zhang, Rui: On Wed, 2024-05-15 at 06:57 +0200, Paul Menzel wrote: Can you please share on what test system this fails, and provide the hardware information? This is an Intel BroadWell NUC. The problem is reproduced on

Re: [Intel-wired-lan] [PATCH v2] e1000e: move force SMBUS near the end of enable_ulp function

2024-05-16 Thread Paul Menzel
Dear Hui, Thank you for your patch. Am 08.05.24 um 14:06 schrieb Hui Wang: The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue") introduces a regression on CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without the referred commit, the *P*CH ethernet

Re: [Intel-wired-lan] [PATCH net] idpf: don't skip over ethtool tcp-data-split setting

2024-05-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 15 May 2024 11:24:14 +0200 you wrote: > Disabling tcp-data-split on idpf silently fails: > # ethtool -G $NETDEV tcp-data-split off > # ethtool -g $NETDEV | grep 'TCP data split' > TCP data split:on >

Re: [Intel-wired-lan] [PATCH iwl-net V4, 1/2] i40e: factoring out i40e_suspend/i40e_resume

2024-05-16 Thread Thinh Tran
On 5/16/2024 2:11 PM, Jacob Keller wrote: I applied this to IWL net dev-queue, but I had some conflicts when applying which I resolved manually. I would appreciate review of the contents as committed: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git/commit/?h=dev-queue&id=

Re: [Intel-wired-lan] [PATCH net-next v6 00/21] ice: add PFCP filter support

2024-05-16 Thread Harald Welte
Hi Michal, thanks for your response. On Thu, May 16, 2024 at 12:44:13PM +0200, Michal Swiatkowski wrote: > > I'm curious to understand why are *pfcp* packets hardware offloaded? > > PFCP is just the control plane, similar to you can consider netlink the > > control plane by which userspace progr

[Intel-wired-lan] [PATCH iwl-net] ice: fix integer overflow in ice_get_pfa_module_tlv

2024-05-16 Thread Jacob Keller
; + } if (tlv_sub_module_type == module_type) { if (tlv_len) { *module_tlv = next_tlv; --- base-commit: 83e93942796db58652288f0391ac00072401816f change-id: 20240516-iwl-net-2024-05-16-fix-nvm-tlv-issue-99ebb2c55c52 Best regards, -- Jacob Keller

Re: [Intel-wired-lan] [PATCH iwl-net V4, 1/2] i40e: factoring out i40e_suspend/i40e_resume

2024-05-16 Thread Jacob Keller

Re: [Intel-wired-lan] [PATCH v2] e1000e: move force SMBUS near the end of enable_ulp function

2024-05-16 Thread Jacob Keller
On 5/8/2024 5:06 AM, Hui Wang wrote: > The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp > function to avoid PHY loss issue") introduces a regression on > CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without the referred commit, the > ethernet works well after suspend and resume, but a

[Intel-wired-lan] [PATCH iwl-net 2/3] ice: add flag to distinguish reset from .ndo_bpf in XDP rings config

2024-05-16 Thread Sergey Temerkhanov
This patch also fixes an issue when XDP programs become detached from the RX rings on channel number reconfiguration Regards, Sergey

Re: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: map XDP queues to vectors in ice_vsi_map_rings_to_vectors()

2024-05-16 Thread Jacob Keller
On 5/16/2024 4:59 AM, Simon Horman wrote: > On Thu, May 16, 2024 at 01:43:18PM +0200, Larysa Zaremba wrote: >> On Thu, May 16, 2024 at 09:27:13AM +0100, Simon Horman wrote: >>> On Wed, May 15, 2024 at 06:02:16PM +0200, Larysa Zaremba wrote: ice_pf_dcb_recfg() re-maps queues to vectors with

[Intel-wired-lan] [PATCH iwl-net] i40e: Fix XDP program unloading while removing the driver

2024-05-16 Thread Michal Kubiak
The commit 6533e558c650 ("i40e: Fix reset path while removing the driver") introduced a new PF state "__I40E_IN_REMOVE" to block modifying the XDP program while the driver is being removed. Unfortunately, such a change is useful only if the ".ndo_bpf()" callback was called out of the rmmod context

Re: [Intel-wired-lan] [PATCH iwl-net] ice: implement AQ download pkg retry

2024-05-16 Thread Brett Creeley
On 5/16/2024 7:04 AM, Wojciech Drewek wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. ice_aqc_opc_download_pkg (0x0C40) AQ sporadically returns error due to FW issue. Fix this by retrying five times

Re: [Intel-wired-lan] [PATCH iwl-next v9] ice: Add get/set hw address for VFs using devlink commands

2024-05-16 Thread Brett Creeley
On 5/15/2024 2:21 PM, Keller, Jacob E wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. -Original Message- From: Brett Creeley Sent: Wednesday, May 15, 2024 9:53 AM To: Karthik Sundaravel ;

Re: [Intel-wired-lan] [PATCH iwl-net] ice: implement AQ download pkg retry

2024-05-16 Thread Simon Horman
On Thu, May 16, 2024 at 04:04:26PM +0200, Wojciech Drewek wrote: > ice_aqc_opc_download_pkg (0x0C40) AQ sporadically returns error due > to FW issue. Fix this by retrying five times before moving to > Safe Mode. Hi Wojciech, As this is for iwl-net, and therefore net, please consider supplying a F

[Intel-wired-lan] [PATCH iwl-net] ice: implement AQ download pkg retry

2024-05-16 Thread Wojciech Drewek
ice_aqc_opc_download_pkg (0x0C40) AQ sporadically returns error due to FW issue. Fix this by retrying five times before moving to Safe Mode. Reviewed-by: Michal Swiatkowski Signed-off-by: Wojciech Drewek --- drivers/net/ethernet/intel/ice/ice_ddp.c | 19 +-- 1 file changed, 17 i

Re: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: map XDP queues to vectors in ice_vsi_map_rings_to_vectors()

2024-05-16 Thread Simon Horman
On Thu, May 16, 2024 at 01:43:18PM +0200, Larysa Zaremba wrote: > On Thu, May 16, 2024 at 09:27:13AM +0100, Simon Horman wrote: > > On Wed, May 15, 2024 at 06:02:16PM +0200, Larysa Zaremba wrote: > > > ice_pf_dcb_recfg() re-maps queues to vectors with > > > ice_vsi_map_rings_to_vectors(), which doe

Re: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: map XDP queues to vectors in ice_vsi_map_rings_to_vectors()

2024-05-16 Thread Larysa Zaremba
On Thu, May 16, 2024 at 09:27:13AM +0100, Simon Horman wrote: > On Wed, May 15, 2024 at 06:02:16PM +0200, Larysa Zaremba wrote: > > ice_pf_dcb_recfg() re-maps queues to vectors with > > ice_vsi_map_rings_to_vectors(), which does not restore the previous > > state for XDP queues. This leads to no AF

Re: [Intel-wired-lan] [PATCH net-next v6 00/21] ice: add PFCP filter support

2024-05-16 Thread Michal Swiatkowski
On Wed, May 15, 2024 at 01:55:42PM +0200, Harald Welte wrote: > Daer Alexander, Wojciech, Hi Harald, > > forgive me for being late to the party, but I just saw the PFCP support > hitting Linus'' git repo in 1b294a1f35616977caddaddf3e9d28e576a1adbc > and was trying to figure out what it is all ab

Re: [Intel-wired-lan] [PATCH RFC iwl-next 07/12] idpf: compile singleq code only under default-n CONFIG_IDPF_SINGLEQ

2024-05-16 Thread Alexander Lobakin
From: Tantilov, Emil S Date: Mon, 13 May 2024 19:01:30 -0700 > On 5/10/2024 8:26 AM, Alexander Lobakin wrote: >> Currently, there's no HW supporting idpf in the singleq model. Still, >> this dead code is supported by the driver and often times add hotpath > The driver supports the HW in single qu

Re: [Intel-wired-lan] [PATCH iwl-net V4, 2/2] i40e: Fully suspend and resume IO operations in EEH case

2024-05-16 Thread Simon Horman
On Wed, May 15, 2024 at 04:07:05PM -0500, Thinh Tran wrote: > When EEH events occurs, the callback functions in the i40e, which are > managed by the EEH driver, will completely suspend and resume all IO > operations. > > - In the PCI error detected callback, replaced i40e_prep_for_reset() > with

Re: [Intel-wired-lan] [PATCH iwl-net V4, 1/2] i40e: factoring out i40e_suspend/i40e_resume

2024-05-16 Thread Simon Horman
On Wed, May 15, 2024 at 04:07:04PM -0500, Thinh Tran wrote: > Two new functions, i40e_io_suspend() and i40e_io_resume(), have been > introduced. These functions were factored out from the existing > i40e_suspend() and i40e_resume() respectively. This factoring was > done due to concerns about the

[Intel-wired-lan] [PATCH iwl-next v10] ice: Add get/set hw address for VFs using devlink commands

2024-05-16 Thread Karthik Sundaravel
Changing the MAC address of the VFs is currently unsupported via devlink. Add the function handlers to set and get the HW address for the VFs. Signed-off-by: Karthik Sundaravel --- .../ethernet/intel/ice/devlink/devlink_port.c | 59 ++- drivers/net/ethernet/intel/ice/ice_sriov.c

Re: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps bitmap

2024-05-16 Thread Simon Horman
On Wed, May 15, 2024 at 06:02:14PM +0200, Larysa Zaremba wrote: > Referenced commit has introduced a bitmap to distinguish between ZC and > copy-mode AF_XDP queues, because xsk_get_pool_from_qid() does not do this > for us. > > The bitmap would be especially useful when restoring previous state af

[Intel-wired-lan] [PATCH iwl-next v10] ice: Add get/set hw address for VFs using devlink commands

2024-05-16 Thread Karthik Sundaravel
Dear Maintainers, Thanks for the review and suggestions for my patch. v9 -> v10 - Refactor ice_set_vf_mac() to use reuse the common code blocks for setting the MAC addresses in both netdev and devlink flow. v8 -> v9 - Rebasing against dev-queue branch of next-queue tree v

Re: [Intel-wired-lan] [PATCH iwl-net 2/3] ice: add flag to distinguish reset from .ndo_bpf in XDP rings config

2024-05-16 Thread Simon Horman
On Wed, May 15, 2024 at 06:02:15PM +0200, Larysa Zaremba wrote: > Commit 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") > has placed ice_vsi_free_q_vectors() after ice_destroy_xdp_rings() in > the rebuild process. The behaviour of the XDP rings config functions is > context-depend

Re: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: map XDP queues to vectors in ice_vsi_map_rings_to_vectors()

2024-05-16 Thread Simon Horman
On Wed, May 15, 2024 at 06:02:16PM +0200, Larysa Zaremba wrote: > ice_pf_dcb_recfg() re-maps queues to vectors with > ice_vsi_map_rings_to_vectors(), which does not restore the previous > state for XDP queues. This leads to no AF_XDP traffic after rebuild. > > Map XDP queues to vectors in ice_vsi_