On Wed, May 15, 2024 at 04:07:04PM -0500, Thinh Tran wrote:
> Two new functions, i40e_io_suspend() and i40e_io_resume(), have been
> introduced. These functions were factored out from the existing
> i40e_suspend() and i40e_resume() respectively. This factoring was
> done due to concerns about the logic of the I40E_SUSPENSED state, which
> caused the device to be unable to recover. The functions are now used
> in the EEH handling for device suspend/resume callbacks.
>
> The function i40e_enable_mc_magic_wake() has been moved ahead of
> i40e_io_suspend() to ensure it is declared before being used.
>
> Tested-by: Robert Thomas <rob.tho...@ibm.com>
> Signed-off-by: Thinh Tran <thin...@linux.ibm.com>
Hi Thrinh,
Sorry to nit-pick, but the request from Paul in his review of v3
was to use imperative mood in the title.
Factor out i40e_suspend/i40e_resume
In any case, this patch looks good to me.
Reviewed-by: Simon Horman <ho...@kernel.org>
