Re: [Intel-wired-lan] [PATCH net-next v9 7/9] libeth: add Rx buffer management

2024-04-05 Thread Jakub Kicinski
On Thu, 4 Apr 2024 17:44:00 +0200 Alexander Lobakin wrote: > +/** > + * struct libeth_fq - structure representing a buffer queue > + * @fp: hotpath part of the structure Second time this happens this week, so maybe some tooling change in 6.9 but apparently kdoc does not want to know about the tag

Re: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime resume for ethtool_ops

2024-04-05 Thread Mekala, SunithaX D
> -Original Message- > From: Intel-wired-lan On Behalf Of Bjorn > Helgaas > Sent: Monday, March 25, 2024 3:30 PM > To: Brandeburg, Jesse ; Nguyen, Anthony L > ; David S . Miller ; Eric > Dumazet ; Jakub Kicinski ; Paolo Abeni > > Cc: Neftin, Sasha ; net...@vger.kernel.org; Wysocki, >

Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Heiner Kallweit
On 05.04.2024 21:16, Lukas Wunner wrote: > On Fri, Apr 05, 2024 at 07:48:08PM +0200, Lukas Wunner wrote: >> Roman, does the below patch fix the issue? > > Actually the patch in my previous e-mail was crap as the unregistering > of the LEDs happened after unbind of the pdev, i.e. after > igc_releas

Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Lukas Wunner
On Fri, Apr 05, 2024 at 07:48:08PM +0200, Lukas Wunner wrote: > Roman, does the below patch fix the issue? Actually the patch in my previous e-mail was crap as the unregistering of the LEDs happened after unbind of the pdev, i.e. after igc_release_hw_control() and pci_disable_device(). The driver

Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Lukas Wunner
On Fri, Apr 05, 2024 at 03:31:34PM +0200, Heiner Kallweit wrote: > On 05.04.2024 12:02, Lukas Wunner wrote: > > On Fri, Apr 05, 2024 at 11:14:01AM +0200, Roman Lozko wrote: > > > Hi, I'm using HP G4 Thunderbolt docking station, and recently (?) > > > kernel started to "partially" deadlock after dis

Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Heiner Kallweit
On 05.04.2024 19:48, Lukas Wunner wrote: > On Fri, Apr 05, 2024 at 03:31:34PM +0200, Heiner Kallweit wrote: >> On 05.04.2024 12:02, Lukas Wunner wrote: >>> On Fri, Apr 05, 2024 at 11:14:01AM +0200, Roman Lozko wrote: Hi, I'm using HP G4 Thunderbolt docking station, and recently (?) kernel

Re: [Intel-wired-lan] [PATCH iwl-next v1 1/5] ixgbe: Add support for E610 FW Admin Command Interface

2024-04-05 Thread Vinicius Costa Gomes
"Kwapulinski, Piotr" writes: >>-Original Message- >>From: Gomes, Vinicius >>Sent: Friday, April 5, 2024 2:04 AM >>To: Kwapulinski, Piotr ; >>intel-wired-...@lists.osuosl.org >>Cc: Kwapulinski, Piotr ; net...@vger.kernel.org; >>Jagielski, Jedrzej ; Michal Swiatkowski >>; Wegrzyn, Stef

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 0a3074e5b4b523fb60f4ae9fb32bb180ea1fb6ef

2024-04-05 Thread kernel test robot
gcc arc allnoconfig gcc arc allyesconfig gcc arc defconfig gcc arc haps_hs_smp_defconfig gcc arc randconfig-001-20240405 gcc arc

Re: [Intel-wired-lan] How to set interface up / down ?

2024-04-05 Thread Jesse Brandeburg
On 4/4/2024 7:59 PM, James Dutton wrote: > Hi, > > I have source code for a sfp phy that is setting > phydev->link = 1 > What else do I have to do to make ethtool think the > Link detected: yes > > Is there a function I need to call from the phy code to cause the > carrier state to be UP ? > etht

Re: [Intel-wired-lan] [PATCH v6 iwl-next 05/12] ice: Move CGU block

2024-04-05 Thread kernel test robot
Hi Karol, kernel test robot noticed the following build warnings: [auto build test WARNING on 0a3074e5b4b523fb60f4ae9fb32bb180ea1fb6ef] url: https://github.com/intel-lab-lkp/linux/commits/Karol-Kolacinski/ice-Introduce-ice_ptp_hw-struct/20240405-180941 base

Re: [Intel-wired-lan] [PATCH iwl-next v1 3/5] ixgbe: Add link management support for E610 device

2024-04-05 Thread Kwapulinski, Piotr
>-Original Message- >From: Gomes, Vinicius >Sent: Friday, April 5, 2024 2:15 AM >To: Kwapulinski, Piotr ; >intel-wired-...@lists.osuosl.org >Cc: Kwapulinski, Piotr ; net...@vger.kernel.org; >Jagielski, Jedrzej ; Glaza, Jan >; Wegrzyn, Stefan >Subject: Re: [Intel-wired-lan] [PATCH iwl-

Re: [Intel-wired-lan] [PATCH v6 iwl-next 07/12] ice: Introduce ETH56G PHY model for E825C products

2024-04-05 Thread kernel test robot
Hi Karol, kernel test robot noticed the following build errors: [auto build test ERROR on 0a3074e5b4b523fb60f4ae9fb32bb180ea1fb6ef] url: https://github.com/intel-lab-lkp/linux/commits/Karol-Kolacinski/ice-Introduce-ice_ptp_hw-struct/20240405-180941 base

Re: [Intel-wired-lan] [PATCH iwl-next v1 1/5] ixgbe: Add support for E610 FW Admin Command Interface

2024-04-05 Thread Kwapulinski, Piotr
>-Original Message- >From: Gomes, Vinicius >Sent: Friday, April 5, 2024 2:04 AM >To: Kwapulinski, Piotr ; >intel-wired-...@lists.osuosl.org >Cc: Kwapulinski, Piotr ; net...@vger.kernel.org; >Jagielski, Jedrzej ; Michal Swiatkowski >; Wegrzyn, Stefan > >Subject: Re: [Intel-wired-lan] [

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS a492c2b597db11fab1eb7d23500bcd2c7c621a66

2024-04-05 Thread kernel test robot
nsim_700_defconfig gcc arc randconfig-001-20240405 gcc arc randconfig-002-20240405 gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig gcc

Re: [Intel-wired-lan] [PATCH v6 iwl-next 05/12] ice: Move CGU block

2024-04-05 Thread kernel test robot
Hi Karol, kernel test robot noticed the following build warnings: [auto build test WARNING on 0a3074e5b4b523fb60f4ae9fb32bb180ea1fb6ef] url: https://github.com/intel-lab-lkp/linux/commits/Karol-Kolacinski/ice-Introduce-ice_ptp_hw-struct/20240405-180941 base

Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Lukas Wunner
[cc += netdev maintainers] On Fri, Apr 05, 2024 at 11:14:01AM +0200, Roman Lozko wrote: > Hi, I'm using HP G4 Thunderbolt docking station, and recently (?) > kernel started to "partially" deadlock after disconnecting the dock > station. This results in inability to turn network interfaces on or >

Re: [Intel-wired-lan] Deadlock in pciehp on dock disconnect

2024-04-05 Thread Heiner Kallweit
On 05.04.2024 12:02, Lukas Wunner wrote: > [cc += netdev maintainers] > > On Fri, Apr 05, 2024 at 11:14:01AM +0200, Roman Lozko wrote: >> Hi, I'm using HP G4 Thunderbolt docking station, and recently (?) >> kernel started to "partially" deadlock after disconnecting the dock >> station. This result

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 1dee310c26677460fc1cc1d98c2d90b6e968988c

2024-04-05 Thread kernel test robot
_defconfig gcc arc randconfig-001-20240405 gcc arc randconfig-002-20240405 gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS 0c83842df40f86e529db6842231154772c20edcc

2024-04-05 Thread kernel test robot
nsim_700_defconfig gcc arc randconfig-001-20240405 gcc arc randconfig-002-20240405 gcc arm allmodconfig gcc arm allnoconfig clang arm allyesconfig gcc arm

Re: [Intel-wired-lan] [PATCH net-next 0/1] XYZ: Handle HAS_IOPORT dependencies

2024-04-05 Thread Niklas Schnelle
On Fri, 2024-04-05 at 13:18 +0200, Niklas Schnelle wrote: > Hi networking maintainers, > > This is a follow up in my ongoing effort of making inb()/outb() and > similar I/O port accessors compile-time optional. Previously I sent this > as a treewide series titled "treewide: Remove I/O port accesso

[Intel-wired-lan] [PATCH net-next 1/1] net: handle HAS_IOPORT dependencies

2024-04-05 Thread Niklas Schnelle
In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at compile time. We thus need to add HAS_IOPORT as dependency for those drivers requiring them. For the DEFXX driver the use of I/O ports is optional and we only need to fence specific code paths. It also turns out that with HAS_I

[Intel-wired-lan] [PATCH net-next 0/1] XYZ: Handle HAS_IOPORT dependencies

2024-04-05 Thread Niklas Schnelle
Hi networking maintainers, This is a follow up in my ongoing effort of making inb()/outb() and similar I/O port accessors compile-time optional. Previously I sent this as a treewide series titled "treewide: Remove I/O port accessors for HAS_IOPORT=n" with the latest being its 5th version[0]. With

Re: [Intel-wired-lan] [PATCH net-next v9 4/9] slab: introduce kvmalloc_array_node() and kvcalloc_node()

2024-04-05 Thread Vlastimil Babka
On 4/4/24 5:43 PM, Alexander Lobakin wrote: > Add NUMA-aware counterparts for kvmalloc_array() and kvcalloc() to be > able to flexibly allocate arrays for a particular node. > Rewrite kvmalloc_array() to kvmalloc_array_node(NUMA_NO_NODE) call. > > Signed-off-by: Alexander Lobakin Acked-by: Vlast

Re: [Intel-wired-lan] [PATCH net-next v9 7/9] libeth: add Rx buffer management

2024-04-05 Thread Przemek Kitszel
On 4/4/24 17:44, Alexander Lobakin wrote: Add a couple intuitive helpers to hide Rx buffer implementation details in the library and not multiplicate it between drivers. The settings are sorta optimized for 100G+ NICs, but nothing really HW-specific here. Use the new page_pool_dev_alloc() to dyna

Re: [Intel-wired-lan] [PATCH net-next v9 2/9] iavf: kill "legacy-rx" for good

2024-04-05 Thread Przemek Kitszel
On 4/4/24 17:43, Alexander Lobakin wrote: Ever since build_skb() became stable, the old way with allocating an skb for storing the headers separately, which will be then copied manually, was slower, less flexible, and thus obsolete. * It had higher pressure on MM since it actually allocates new

Re: [Intel-wired-lan] [PATCH net-next v9 4/9] slab: introduce kvmalloc_array_node() and kvcalloc_node()

2024-04-05 Thread Przemek Kitszel
On 4/4/24 17:43, Alexander Lobakin wrote: Add NUMA-aware counterparts for kvmalloc_array() and kvcalloc() to be able to flexibly allocate arrays for a particular node. Rewrite kvmalloc_array() to kvmalloc_array_node(NUMA_NO_NODE) call. Signed-off-by: Alexander Lobakin --- include/linux/slab.h

[Intel-wired-lan] [PATCH v6 iwl-next 12/12] ice: Adjust PTP init for 2x50G E825C devices

2024-04-05 Thread Karol Kolacinski
From: Grzegorz Nitka >From FW/HW perspective, 2 port topology in E825C devices requires merging of 2 port mapping internally and breakout mapping externally. As a consequence, it requires different port numbering from PTP code perspective. For that topology, pf_id can not be used to index PTP por

[Intel-wired-lan] [PATCH v6 iwl-next 11/12] ice: Support 2XNAC configuration using auxbus

2024-04-05 Thread Karol Kolacinski
There are E825C products featuring 2 NACs. Those have only one source clock on the primary NAC. For those devices, there should be only one clock controller on the primary NAC. All PFs from both NACs should connect as auxiliary devices to the auxiliary driver on the primary NAC. Reviewed-by: Igor

[Intel-wired-lan] [PATCH v6 iwl-next 09/12] ice: Add support for E825-C TS PLL handling

2024-04-05 Thread Karol Kolacinski
From: Michal Michalik The CGU layout of E825-C is a little different than E822/E823. Add support the new hardware adding relevant functions. Signed-off-by: Michal Michalik Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V4 -> V5: added UL to

[Intel-wired-lan] [PATCH v6 iwl-next 10/12] ice: Add NAC Topology device capability parser

2024-04-05 Thread Karol Kolacinski
From: Grzegorz Nitka Add new device capability ICE_AQC_CAPS_NAC_TOPOLOGY which allows to determine the mode of operation (1 or 2 NAC). Define a new structure to store data from new capability and corresponding parser code. Co-developed-by: Prathisna Padmasanan Signed-off-by: Prathisna Padmasana

[Intel-wired-lan] [PATCH v6 iwl-next 07/12] ice: Introduce ETH56G PHY model for E825C products

2024-04-05 Thread Karol Kolacinski
From: Sergey Temerkhanov E825C products feature a new PHY model - ETH56G. Introduces all necessary PHY definitions, functions etc. for ETH56G PHY, analogous to E82X and E810 ones with addition of a few HW-specific functionalities for ETH56G like one-step timestamping. It ensures correct PTP ini

[Intel-wired-lan] [PATCH v6 iwl-next 08/12] ice: Change CGU regs struct to anonymous

2024-04-05 Thread Karol Kolacinski
Simplify the code by using anonymous struct in CGU registers instead of naming each structure 'field'. Suggested-by: Przemek Kitszel Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- drivers/net/ethernet/intel/ice/ice_cgu_regs.h | 12 ++--- dri

[Intel-wired-lan] [PATCH v6 iwl-next 05/12] ice: Move CGU block

2024-04-05 Thread Karol Kolacinski
From: Sergey Temerkhanov Move CGU block to the beginning of ice_ptp_hw.c Signed-off-by: Sergey Temerkhanov Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V5 -> V6: - adjusted returns in ice_read/write_cgu_reg_e82x() - added cgu_ms

[Intel-wired-lan] [PATCH v6 iwl-next 06/12] ice: Introduce ice_get_base_incval() helper

2024-04-05 Thread Karol Kolacinski
From: Jacob Keller Add a new helper for getting base clock increment value for specific HW. Signed-off-by: Jacob Keller Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V4 -> V5: Removed unused UNKNOWN_INCVAL_E82X drivers/net/ethernet/intel

[Intel-wired-lan] [PATCH v6 iwl-next 04/12] ice: Add PHY OFFSET_READY register clearing

2024-04-05 Thread Karol Kolacinski
Add a possibility to mark all transmitted/received timestamps as invalid by clearing PHY OFFSET_READY registers. Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- drivers/net/ethernet/intel/ice/ice_ptp.c| 11 --- drivers/net/ethernet/int

[Intel-wired-lan] [PATCH v6 iwl-next 03/12] ice: Implement Tx interrupt enablement functions

2024-04-05 Thread Karol Kolacinski
From: Sergey Temerkhanov Introduce functions enabling/disabling Tx TS interrupts for the E822 and ETH56G PHYs Signed-off-by: Sergey Temerkhanov Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V5 -> V6: Adjusted return in ice_phy_cfg_intr_e82

[Intel-wired-lan] [PATCH v6 iwl-next 02/12] ice: Introduce helper to get tmr_cmd_reg values

2024-04-05 Thread Karol Kolacinski
From: Jacob Keller Multiple places in the driver code need to convert enum ice_ptp_tmr_cmd values into register bits for both the main timer and the PHY port timers. The main MAC register has one bit scheme for timer commands, while the PHY commands use a different scheme. The E810 and E830 devi

[Intel-wired-lan] [PATCH v6 iwl-next 01/12] ice: Introduce ice_ptp_hw struct

2024-04-05 Thread Karol Kolacinski
Create new ice_ptp_hw struct and use it for all HW and PTP-related fields from struct ice_hw. Replace definitions with struct fields, which values are set accordingly to a specific device. Reviewed-by: Przemek Kitszel Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Karol Kolacinski --- V4 -> V

[Intel-wired-lan] [PATCH v6 iwl-next 00/12] Introduce ETH56G PHY model for E825C products

2024-04-05 Thread Karol Kolacinski
E825C products have a different PHY model than E822, E823 and E810 products. This PHY is ETH56G and its support is necessary to have functional PTP stack for E825C products. Grzegorz Nitka (2): ice: Add NAC Topology device capability parser ice: Adjust PTP init for 2x50G E825C devices Jacob K

Re: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles

2024-04-05 Thread Michal Swiatkowski
On Mon, Apr 01, 2024 at 09:28:30AM +, Buvaneswaran, Sujai wrote: > > -Original Message- > > From: Michal Swiatkowski > > Sent: Friday, March 29, 2024 1:56 PM > > To: Buvaneswaran, Sujai > > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Marcin Szycik > > ; Kubiak, Micha