> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Bjorn
> Helgaas
> Sent: Monday, March 25, 2024 3:30 PM
> To: Brandeburg, Jesse <jesse.brandeb...@intel.com>; Nguyen, Anthony L
> <anthony.l.ngu...@intel.com>; David S . Miller <da...@davemloft.net>; Eric
> Dumazet <eduma...@google.com>; Jakub Kicinski <k...@kernel.org>; Paolo Abeni
> <pab...@redhat.com>
> Cc: Neftin, Sasha <sasha.nef...@intel.com>; net...@vger.kernel.org; Wysocki,
> Rafael J <rafael.j.wyso...@intel.com>; linux-ker...@vger.kernel.org; Bjorn
> Helgaas <bhelg...@google.com>; intel-wired-...@lists.osuosl.org; Zheng Yan
> <zheng.z....@intel.com>; Konstantin Khlebnikov <khlebni...@openvz.org>;
> Heiner Kallweit <hkallwe...@gmail.com>
> Subject: [Intel-wired-lan] [PATCH 2/3] igb: Remove redundant runtime resume
> for ethtool_ops
>
> From: Bjorn Helgaas <bhelg...@google.com>
>
> 749ab2cd1270 ("igb: add basic runtime PM support") added
> ethtool_ops.begin() and .complete(), which used pm_runtime_get_sync() to
> resume suspended devices before any ethtool_ops callback and allow suspend
> after it completed.
>
> Subsequently, f32a21376573 ("ethtool: runtime-resume netdev parent before
> ethtool ioctl ops") added pm_runtime_get_sync() in the dev_ethtool() path,
> so the device is resumed before any ethtool_ops callback even if the driver
> didn't supply a .begin() callback.
>
> Remove the .begin() and .complete() callbacks, which are now redundant
> because dev_ethtool() already resumes the device.
>
>Signed-off-by: Bjorn Helgaas <bhelg...@google.com>
>---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
Tested-by: Sunitha Mekala <sunithax.d.mek...@intel.com> (A Contingent worker at
Intel)
