[Intel-wired-lan] [PATCH net-next v4 9/9] net: ethtool: eee: Remove legacy _u32 from keee

2024-02-18 Thread Andrew Lunn
All MAC drivers have been converted to use the link mode members of keee. So remove the _u32 values, and the code in the ethtool core to convert the legacy _u32 values to link modes. Signed-off-by: Andrew Lunn --- include/linux/ethtool.h | 3 --- net/ethtool/eee.c | 31 ---

[Intel-wired-lan] [PATCH net-next v4 8/9] net: intel: igc: Use linkmode helpers for EEE

2024-02-18 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 + 1 file changed, 5 insertions(+), 4 deletion

[Intel-wired-lan] [PATCH net-next v4 7/9] net: intel: igb: Use linkmode helpers for EEE

2024-02-18 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 35 ++-- 1 file changed, 23 inse

[Intel-wired-lan] [PATCH net-next v4 6/9] net: intel: e1000e: Use linkmode helpers for EEE

2024-02-18 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/intel/e1000e/ethtool.c | 17 - 1 file changed, 12 insertions(+), 5

[Intel-wired-lan] [PATCH net-next v4 5/9] net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities

2024-02-18 Thread Andrew Lunn
Energy Efficient Ethernet should always be negotiated with the link peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for supported, advertised or lp_advertised, since it is assumed. Additionally, ethtool(1) ignores the set bit, and no other driver sets this. Reviewed-by: Jacob Kel

[Intel-wired-lan] [PATCH net-next v4 4/9] net: ethernet: ixgbe: Convert EEE to use linkmodes

2024-02-18 Thread Andrew Lunn
Convert the tables to make use of ETHTOOL link mode bits, rather than the old u32 SUPPORTED speeds. Make use of the linkmode helps to set bits and compare linkmodes. As a result, the _u32 members of keee are no longer used, a step towards removing them. Signed-off-by: Andrew Lunn --- drivers/net

[Intel-wired-lan] [PATCH net-next v4 2/9] net: usb: ax88179_178a: Use linkmode helpers for EEE

2024-02-18 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Signed-off-by: Andrew Lunn --- drivers/net/usb/ax88179_178a.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --g

[Intel-wired-lan] [PATCH net-next v4 3/9] net: qlogic: qede: Use linkmode helpers for EEE

2024-02-18 Thread Andrew Lunn
Make use of the existing linkmode helpers for bit manipulation of EEE advertise, support and link partner support. The aim is to drop the restricted _u32 variants in the near future. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 60 - 1

[Intel-wired-lan] [PATCH net-next v4 0/9] drivers: net: Convert EEE handling to use linkmode bitmaps

2024-02-18 Thread Andrew Lunn
EEE has until recently been limited to lower speeds due to the use of the legacy u32 for link speeds. This restriction has been lifted, with the use of linkmode bitmaps, added in the following patches: 1f069de63602 ethtool: add linkmode bitmap support to struct ethtool_keee 1d756ff13da6 ethtool: a

[Intel-wired-lan] [PATCH net-next v4 1/9] net: usb: r8152: Use linkmode helpers for EEE

2024-02-18 Thread Andrew Lunn
Make use of the existing linkmode helpers for converting PHY EEE register values into links modes, now that ethtool_keee uses link modes, rather than u32 values. Rework determining if EEE is active to make is similar as to how phylib decides, and make use of a phylib helper to validate if EEE is v

Re: [Intel-wired-lan] [iwl-net v1 1/2] igc: Fix missing time sync events

2024-02-18 Thread Kurt Kanzenbach
On Fri Feb 16 2024, Vinicius Costa Gomes wrote: > Fix "double" clearing of interrupts, which can cause external events > or timestamps to be missed. > > The IGC_TSIRC Time Sync Interrupt Cause register can be cleared in two > ways, by either reading it or by writing '1' into the specific cause > bi