Re: [Intel-wired-lan] linux-next: Tree for Dec 15 (drivers/net/ethernet/intel/ice/ice_base.c)

2023-12-15 Thread Randy Dunlap
On 12/14/23 20:01, Stephen Rothwell wrote: > Hi all, > > Changes since 20231214: > on s390: # CONFIG_XDP_SOCKETS is not set ../drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_xsk_pool_fill_cb': ../drivers/net/ethernet/intel/ice/ice_base.c:533:16: error: variable 'desc' has init

[Intel-wired-lan] [linux-next:master] BUILD REGRESSION 17cb8a20bde66a520a2ca7aad1063e1ce7382240

2023-12-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 17cb8a20bde66a520a2ca7aad1063e1ce7382240 Add linux-next specific files for 20231215 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202312151816.munfee4l-...@intel.com https

Re: [Intel-wired-lan] [PATCH net-next 20/24] net: intel: Use nested-BH locking for XDP redirect.

2023-12-15 Thread kernel test robot
Hi Sebastian, kernel test robot noticed the following build errors: [auto build test ERROR on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/locking-local_lock-Introduce-guard-definition-for-local_lock/20231216-011911 base: net-next/main patch

[Intel-wired-lan] [PATCH iwl-net] idpf: avoid compiler introduced padding in virtchnl2_rss_key struct

2023-12-15 Thread Pavan Kumar Linga
Size of the virtchnl2_rss_key struct should be 7 bytes but the compiler introduces a padding byte for the structure alignment. This results in idpf sending an additional byte of memory to the device control plane than the expected buffer size. As the control plane enforces virtchnl message size che

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

2023-12-15 Thread Jakub Kicinski
On Fri, 15 Dec 2023 12:06:52 +0100 Paolo Abeni wrote: > > uAPI aside, why would we use ndo_setup_tc(TC_SETUP_QDISC_TBF) > > to implement common basis? > > > > Is it not cleaner to have a separate driver API, with its ops > > and capabilities? > > We understand one of the end goal is consolidati

[Intel-wired-lan] [tnguy-next-queue:100GbE] BUILD SUCCESS d96f04e05f2634b2dea3cdfc9651f5704d829292

2023-12-15 Thread kernel test robot
allmodconfig clang i386 allnoconfig clang i386 allyesconfig clang i386 buildonly-randconfig-001-20231215 clang i386 buildonly-randconfig-002-20231215 clang i386 buildonly-randconfig-003-20231215 clang i386

Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: enable WB_ON_ITR

2023-12-15 Thread Brett Creeley
On 12/15/2023 11:37 AM, Michal Kubiak wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Joshua Hay Tell hardware to write back completed descriptors even when interrupts are disabled. Otherwise,

[Intel-wired-lan] [PATCH iwl-net v2] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
From: Joshua Hay Tell hardware to write back completed descriptors even when interrupts are disabled. Otherwise, descriptors might not be written back until the hardware can flush a full cacheline of descriptors. This can cause unnecessary delays when traffic is light (or even trigger Tx queue ti

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
On Fri, Dec 15, 2023 at 10:01:36AM -0800, Brett Creeley wrote: > [...] > > > > > diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > b/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > index df76493faa75..50761c2d9f3b 100644 > > --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.h > > +++

Re: [Intel-wired-lan] [PATCH net v3] net: ethtool: do runtime PM outside RTNL

2023-12-15 Thread Marc MERLIN
On Fri, Dec 15, 2023 at 02:42:01PM +0100, Heiner Kallweit wrote: > Why don't you simply disable runtime pm for the affected device as a > workaround? This can be done via sysfs. 1) because I didn't know what the exact bug was and how to work around it :) 2) without power management, the battery us

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Brett Creeley
On 12/12/2023 6:55 AM, Michal Kubiak wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Joshua Hay Tell hardware to writeback completed descriptors even when interrupts are disabled. Otherwise,

Re: [Intel-wired-lan] [PATCH iwl-next v6] ice: Add support for packet mirroring using hardware in switchdev mode

2023-12-15 Thread Brett Creeley
On 12/12/2023 4:51 AM, Andrii Staikov wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Switchdev mode allows to add mirroring rules to mirror incoming and outgoing packets to the interface's port rep

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
On Thu, Dec 14, 2023 at 01:59:57PM +0100, Paul Menzel wrote: > Lieber Michal, > > > Am 13.12.23 um 14:23 schrieb Michal Kubiak: > > On Tue, Dec 12, 2023 at 05:50:55PM +0100, Paul Menzel wrote: > > > > On 12/12/23 15:55, Michal Kubiak wrote: > > > > From: Joshua Hay > > > > > > > > Tell hardwar

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: enable WB_ON_ITR

2023-12-15 Thread Michal Kubiak
On Wed, Dec 13, 2023 at 03:06:09PM -0800, Tony Nguyen wrote: > > > On 12/13/2023 2:22 PM, Nguyen, Anthony L wrote: > > > > > > > -Original Message- > > > From: Kubiak, Michal > > > Sent: Wednesday, December 13, 2023 5:51 AM > > > > > > On Wed, Dec 13, 2023 at 02:23:19PM +0100, Michal

[Intel-wired-lan] [PATCH net-next 20/24] net: intel: Use nested-BH locking for XDP redirect.

2023-12-15 Thread Sebastian Andrzej Siewior
The per-CPU variables used during bpf_prog_run_xdp() invocation and later during xdp_do_redirect() rely on disabled BH for their protection. Without locking in local_bh_disable() on PREEMPT_RT these data structure require explicit locking. This is a follow-up on the previous change which introduce

Re: [Intel-wired-lan] [net PATCH] i40e: fix use-after-free in i40e_aqc_add_filters()

2023-12-15 Thread Brett Creeley
On 12/13/2023 2:49 AM, Ke Xiao wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Commit 3116f59c12bd ("i40e: fix use-after-free in i40e_sync_filters_subtask()") avoided use-after-free issues, by increasi

[Intel-wired-lan] [PATCH iwl-next, v1 1/1] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2023-12-15 Thread Song Yoong Siang
This patch adds support to per-packet Tx hardware timestamp request to AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that user needs to enable Tx HW timestamp capability via igc_ioctl() with SIOCSHWTSTAMP cmd before sending xsk Tx timestamp request. Same as implementation in R

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-15 Thread Jakub Kicinski
On Fri, 15 Dec 2023 11:11:23 +0100 Alexander Lobakin wrote: > Ping? :s > Or should we resubmit? Can you wait for next merge window instead? We're getting flooded with patches as everyone seemingly tries to get their own (i.e. the most important!) work merged before the end of the year. The set of

[Intel-wired-lan] [tnguy-net-queue:main] BUILD SUCCESS 7bb26ea74aa86fdf894b7dbd8c5712c5b4187da7

2023-12-15 Thread kernel test robot
randconfig-001-20231215 gcc arc randconfig-001-20231216 gcc arc randconfig-002-20231215 gcc arc randconfig-002-20231216 gcc arm allnoconfig gcc arm

Re: [Intel-wired-lan] [net PATCH] i40e: fix use-after-free in i40e_aqc_add_filters()

2023-12-15 Thread Simon Horman
On Wed, Dec 13, 2023 at 06:49:11PM +0800, Ke Xiao wrote: > Commit 3116f59c12bd ("i40e: fix use-after-free in > i40e_sync_filters_subtask()") avoided use-after-free issues, > by increasing refcount during update the VSI filter list to > the HW. However, it missed the unicast situation. > > When del

Re: [Intel-wired-lan] [PATCH net v3] net: ethtool: do runtime PM outside RTNL

2023-12-15 Thread Heiner Kallweit
On 11.12.2023 05:52, Marc MERLIN wrote: > On Thu, Dec 07, 2023 at 09:40:21AM -0800, Jakub Kicinski wrote: >> On Thu, 7 Dec 2023 11:16:10 +0100 Przemek Kitszel wrote: >>> I have let know our igc TL, architect, and anybody that could be >>> interested via cc: IWL. And I'm happy that this could be don

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

2023-12-15 Thread Jiri Pirko
Fri, Dec 15, 2023 at 12:06:52PM CET, pab...@redhat.com wrote: >On Thu, 2023-12-14 at 17:46 -0800, Jakub Kicinski wrote: >> On Thu, 14 Dec 2023 21:29:51 +0100 Paolo Abeni wrote: >> > Together with Simon, I spent some time on the above. We think the >> > ndo_setup_tc(TC_SETUP_QDISC_TBF) hook could be

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

2023-12-15 Thread Jiri Pirko
Fri, Dec 15, 2023 at 02:46:04AM CET, k...@kernel.org wrote: >On Thu, 14 Dec 2023 21:29:51 +0100 Paolo Abeni wrote: >> Together with Simon, I spent some time on the above. We think the >> ndo_setup_tc(TC_SETUP_QDISC_TBF) hook could be used as common basis for >> this offloads, with some small extens

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: alter feature support check for SRIOV and LAG

2023-12-15 Thread Simon Horman
On Mon, Dec 11, 2023 at 01:19:28PM -0800, Dave Ertman wrote: > Previously, the ice driver had support for using a hanldler for bonding > netdev events to ensure that conflicting features were not allowed to be > activated at the same time. While this was still in place, additional > support was ad

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

2023-12-15 Thread Paolo Abeni
On Fri, 2023-12-15 at 12:06 +0100, Paolo Abeni wrote: > 1) AFAICS devlink (and/or devlink_port) does not have fine grained, per > queue representation and intel want to be able to configure shaping on > per queue basis. I think/hope we don't want to bring the discussion to > extending the devlink i

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support'

2023-12-15 Thread Paolo Abeni
On Thu, 2023-12-14 at 17:46 -0800, Jakub Kicinski wrote: > On Thu, 14 Dec 2023 21:29:51 +0100 Paolo Abeni wrote: > > Together with Simon, I spent some time on the above. We think the > > ndo_setup_tc(TC_SETUP_QDISC_TBF) hook could be used as common basis for > > this offloads, with some small exten

[Intel-wired-lan] [PATCH iwl-net 2/2] ice: Shut down VSI with "link-down-on-close" enabled

2023-12-15 Thread Wojciech Drewek
From: Ngai-Mint Kwan Disabling netdev with ethtool private flag "link-down-on-close" enabled can cause NULL pointer dereference bug. Shut down VSI regardless of "link-down-on-close" state. Fixes: 8ac7132704f3 ("ice: Fix interface being down after reset with link-down-on-close flag on") Reviewed

[Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix link_down_on_close message

2023-12-15 Thread Wojciech Drewek
From: Katarzyna Wieczerzycka The driver should not report an error message when for a medialess port the link_down_on_close flag is enabled and the physical link cannot be set down. Fixes: 8ac7132704f3 ("ice: Fix interface being down after reset with link-down-on-close flag on") Reviewed-by: Pr

[Intel-wired-lan] [PATCH iwl-net 0/2] Fixes for link-down-on-close flag

2023-12-15 Thread Wojciech Drewek
Small series of fixes for link-down-on-close ethtool flag usecase. Katarzyna Wieczerzycka (1): ice: Fix link_down_on_close message Ngai-Mint Kwan (1): ice: Shut down VSI with "link-down-on-close" enabled drivers/net/ethernet/intel/ice/ice_main.c | 12 +--- 1 file changed, 9 insertio

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-15 Thread Alexander Lobakin
From: Marcin Szycik Date: Tue, 12 Dec 2023 11:45:24 +0100 > > > On 11.12.2023 22:23, Tony Nguyen wrote: >> >> >> On 12/11/2023 4:38 AM, Alexander Lobakin wrote: >>> From: Tony Nguyen >>> Date: Fri, 8 Dec 2023 13:34:10 -0800 >>> On 12/7/2023 8:49 AM, Marcin Szycik wrote: > Ad

Re: [Intel-wired-lan] [PATCH iwl-net] ice: dpll: fix phase offset value

2023-12-15 Thread Kubalewski, Arkadiusz
>From: Intel-wired-lan On Behalf Of >Paul Menzel >Sent: Thursday, December 14, 2023 10:31 AM > >Dear Arkadiusz, > > >Thank you for your patch. > >Am 14.12.23 um 09:50 schrieb Arkadiusz Kubalewski: >> Stop dividing the phase_offset value received from firmware, this is >> fault introduced with the