On Fri, 2023-12-15 at 12:06 +0100, Paolo Abeni wrote: > 1) AFAICS devlink (and/or devlink_port) does not have fine grained, per > queue representation and intel want to be able to configure shaping on > per queue basis. I think/hope we don't want to bring the discussion to > extending the devlink interface with queue support, I fear that will > block us for a long time. Perhaps I’m missing or misunderstanding > something here. Otherwise in retrospect this looks like a reasonable > point to completely avoid devlink here.
Note to self: never send a message to the ML before my 3rd morning coffee. This thread started with Intel trying to using devlink rate for their use-case, apparently slamming my doubt above. My understanding is that in the patches the queue devlink <> queue relationship was kept inside the driver and not exposed to the devlink level. If we want to use the devlink rate api to replace e.g. ndo_set_tx_maxrate, we would need a devlink queue(id) or the like, hence this point. Cheer, Paolo _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
