Re: [Intel-wired-lan] [PATCH v5 5/5] i40e: Remove VEB recursion

2023-11-29 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Friday, November 24, 2023 8:34 PM > To: intel-wired-...@lists.osuosl.org > Cc: Drewek, Wojciech ; net...@vger.kernel.org; > Brandeburg, Jesse ; linux-ker...@vger.kernel.org; > Eric Dumazet ; Nguyen, Anthony

Re: [Intel-wired-lan] [PATCH v5 4/5] i40e: Fix broken support for floating VEBs

2023-11-29 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Friday, November 24, 2023 8:34 PM > To: intel-wired-...@lists.osuosl.org > Cc: Drewek, Wojciech ; net...@vger.kernel.org; > Brandeburg, Jesse ; linux-ker...@vger.kernel.org; > Eric Dumazet ; Nguyen, Anthony

Re: [Intel-wired-lan] [PATCH v5 2/5] i40e: Introduce and use macros for iterating VSIs and VEBs

2023-11-29 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Friday, November 24, 2023 8:34 PM > To: intel-wired-...@lists.osuosl.org > Cc: Drewek, Wojciech ; net...@vger.kernel.org; > Brandeburg, Jesse ; linux-ker...@vger.kernel.org; > Eric Dumazet ; Nguyen, Anthony

Re: [Intel-wired-lan] [PATCH v5 1/5] i40e: Use existing helper to find flow director VSI

2023-11-29 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Friday, November 24, 2023 8:34 PM > To: intel-wired-...@lists.osuosl.org > Cc: Drewek, Wojciech ; net...@vger.kernel.org; > Brandeburg, Jesse ; linux-ker...@vger.kernel.org; > Eric Dumazet ; Nguyen, Anthony

Re: [Intel-wired-lan] [PATCH v5 3/5] i40e: Add helpers to find VSI and VEB by SEID and use them

2023-11-29 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Ivan > Vecera > Sent: Friday, November 24, 2023 8:34 PM > To: intel-wired-...@lists.osuosl.org > Cc: Drewek, Wojciech ; net...@vger.kernel.org; > Brandeburg, Jesse ; linux-ker...@vger.kernel.org; > Eric Dumazet ; Nguyen, Anthony

Re: [Intel-wired-lan] [PATCH iwl-next v1 13/13] ice: field get conversion

2023-11-29 Thread Jesse Brandeburg
On 11/24/2023 3:03 AM, Simon Horman wrote: > On Tue, Nov 21, 2023 at 01:19:21PM -0800, Jesse Brandeburg wrote: >> Refactor the ice driver to use FIELD_GET() for mask and shift reads, >> which reduces lines of code and adds clarity of intent. >> >> This code was generated by the following coccinelle

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix ST code value for Clause 45

2023-11-29 Thread Jacob Keller
On 11/29/2023 8:17 AM, Ivan Vecera wrote: > ST code value for clause 45 that has been changed by > commit 8196b5fd6c73 ("i40e: Refactor I40E_MDIO_CLAUSE* macros") > is currently wrong. > > The mentioned commit refactored ..MDIO_CLAUSE??_STCODE_MASK so > their value is the same for both clauses.

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Print NIC FW version during init

2023-11-29 Thread Jacob Keller
On 11/29/2023 9:56 AM, Sachin Bahadur wrote: > Print NIC FW version during PF initialization. FW version in dmesg is used > to identify and isolate issues. Particularly useful when dmesg is read > after reboot. > > Example log from dmesg: > ice :ca:00.0: fw 6.2.9 api 1.7.9 nvm 3.32 0x8000d8

[Intel-wired-lan] [PATCH iwl-net, v2] iavf: Fix iavf_shutdown to call iavf_remove instead iavf_close

2023-11-29 Thread Ranganatha Rao
From: Slawomir Laba Make the flow for pci shutdown be the same to the pci remove. iavf_shutdown was implementing an incomplete version of iavf_remove. It misses several calls to the kernel like iavf_free_misc_irq, iavf_reset_interrupt_capability, iounmap that might break the system on reboot or

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: replace ice_vf_recreate_vsi() with ice_vf_reconfig_vsi()

2023-11-29 Thread Keller, Jacob E
> -Original Message- > From: Kitszel, Przemyslaw > Sent: Wednesday, November 29, 2023 3:16 AM > To: Keller, Jacob E ; Intel Wired LAN l...@lists.osuosl.org> > Cc: Romanowski, Rafal ; poros > ; Michal Swiatkowski ; > Buchocki, JakubX ; Nguyen, Anthony L > ; Polchlopek, Mateusz > > Subje

[Intel-wired-lan] [PATCH iwl-next v2] ice: Print NIC FW version during init

2023-11-29 Thread Sachin Bahadur
Print NIC FW version during PF initialization. FW version in dmesg is used to identify and isolate issues. Particularly useful when dmesg is read after reboot. Example log from dmesg: ice :ca:00.0: fw 6.2.9 api 1.7.9 nvm 3.32 0x8000d83e 1.3146.0 Reviewed-by: Paul Menzel Reviewed-by: Pawel Ka

Re: [Intel-wired-lan] [PATCH iwl-next v4 05/12] ice: Log virtual channel messages in PF

2023-11-29 Thread Simon Horman
On Tue, Nov 21, 2023 at 02:51:04AM +, Yahui Cao wrote: > From: Lingyu Liu > > Save the virtual channel messages sent by VF on the source side during > runtime. The logged virtchnl messages will be transferred and loaded > into the device on the destination side during the device resume stage.

Re: [Intel-wired-lan] [PATCH iwl-next] ice: Rename E822 to E82X

2023-11-29 Thread Simon Horman
On Fri, Nov 24, 2023 at 12:45:55PM +0100, Karol Kolacinski wrote: > When code is applicable for both E822 and E823 devices, rename it from > E822 to E82X. > ICE_PHY_PER_NAC_E822 was unused, so just remove it. > > Signed-off-by: Karol Kolacinski > Reviewed-by: Przemek Kitszel Hi Karol, while I

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Fix kernel crash during macvlan offloading setup

2023-11-29 Thread Simon Horman
On Fri, Nov 24, 2023 at 05:42:33PM +0100, Ivan Vecera wrote: > Function i40e_fwd_add() computes num of created channels and > num of queues per channel according value of pf->num_lan_msix. > > This is wrong because the channels are used for subordinated net > devices that reuse existing queues fro

[Intel-wired-lan] [PATCH iwl-net] i40e: Fix ST code value for Clause 45

2023-11-29 Thread Ivan Vecera
ST code value for clause 45 that has been changed by commit 8196b5fd6c73 ("i40e: Refactor I40E_MDIO_CLAUSE* macros") is currently wrong. The mentioned commit refactored ..MDIO_CLAUSE??_STCODE_MASK so their value is the same for both clauses. The value is correct for clause 22 but not for clause 45

[Intel-wired-lan] [PATCH iwl-next] ice: ice_base.c: Add const modifier to params and vars

2023-11-29 Thread Jan Glaza
Add const modifier to function parameters and variables where appropriate in ice_base.c and corresponding declarations in ice_base.h. The reason for starting the change is that read-only pointers should be marked as const when possible to allow for smoother and more optimal code generation and opt

Re: [Intel-wired-lan] [PATCH iwl-net v4] ice: Block PF reinit if attached to bond

2023-11-29 Thread Jiri Pirko
Tue, Nov 28, 2023 at 06:45:47PM CET, sachin.baha...@intel.com wrote: > > >> From: Jiri Pirko >> Sent: Monday, November 27, 2023 11:38 PM >> To: Bahadur, Sachin >> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux- >> ker...@vger.kernel.org >> Subject: Re: [PATCH iwl-net v4] ice:

[Intel-wired-lan] [PATCH iwl-next v1] i40e: Fix VF disable behavior to block all traffic

2023-11-29 Thread Andrii Staikov
Currently, if a VF is disabled using the 'ip link set dev $ETHX vf $VF_NUM state disable' command, the VF is still able to receive traffic. Fix the behavior of the 'ip link set dev $ETHX vf $VF_NUM state disable' to completely shutdown the VF's queues making it entirely disabled and not able to re

Re: [Intel-wired-lan] [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats

2023-11-29 Thread Jakub Kicinski
On Wed, 29 Nov 2023 14:40:33 +0100 Alexander Lobakin wrote: > > Expand the libie generic per-queue stats with the generic Page Pool > > stats provided by the API itself, when CONFIG_PAGE_POOL_STATS is > > enabled. When it's not, there'll be no such fields in the stats > > structure, so no space was

Re: [Intel-wired-lan] [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats

2023-11-29 Thread Alexander Lobakin
From: Alexander Lobakin Date: Fri, 24 Nov 2023 16:47:31 +0100 > Expand the libie generic per-queue stats with the generic Page Pool > stats provided by the API itself, when CONFIG_PAGE_POOL_STATS is > enabled. When it's not, there'll be no such fields in the stats > structure, so no space wasted.

Re: [Intel-wired-lan] [PATCH net-next v5 03/14] page_pool: avoid calling no-op externals when possible

2023-11-29 Thread Alexander Lobakin
From: Yunsheng Lin Date: Wed, 29 Nov 2023 11:17:50 +0800 > On 2023/11/27 22:32, Alexander Lobakin wrote: >> >> Chris, any thoughts on a global flag for skipping DMA syncs ladder? > > It seems there was one already in the past: > > https://lore.kernel.org/netdev/7c55a4d7-b4aa-25d4-1917-f6f355bd7

Re: [Intel-wired-lan] [PATCH net-next v5 01/14] page_pool: make sure frag API fields don't span between cachelines

2023-11-29 Thread Alexander Lobakin
From: Yunsheng Lin Date: Wed, 29 Nov 2023 10:55:00 +0800 > On 2023/11/27 22:08, Alexander Lobakin wrote: >> From: Yunsheng Lin >> Date: Sat, 25 Nov 2023 20:29:22 +0800 >> >>> On 2023/11/24 23:47, Alexander Lobakin wrote: After commit 5027ec19f104 ("net: page_pool: split the page_pool_params

[Intel-wired-lan] [PATCH v2 iwl-next 2/2] ice: Enable SW interrupt from FW for LL TS

2023-11-29 Thread Karol Kolacinski
Introduce new capability - Low Latency Timestamping with Interrupt. On supported devices, driver can request a single timestamp from FW without polling the register afterwards. Instead, FW can issue a dedicated interrupt when the timestamp was read from the PHY register and its value is available t

[Intel-wired-lan] [PATCH v2 iwl-next 1/2] ice: Schedule service task in IRQ top half

2023-11-29 Thread Karol Kolacinski
Schedule service task and EXTTS in the top half to avoid bottom half scheduling if possible, which significantly reduces timestamping delay. Co-developed-by: Michal Michalik Signed-off-by: Michal Michalik Reviewed-by: Przemek Kitszel Signed-off-by: Karol Kolacinski --- V1 -> V2: Added missing

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: replace ice_vf_recreate_vsi() with ice_vf_reconfig_vsi()

2023-11-29 Thread Przemek Kitszel
On 11/28/23 20:42, Jacob Keller wrote: The ice_vf_create_vsi() function and its VF ops helper introduced by commit a4c785e8162e ("ice: convert vf_ops .vsi_rebuild to .create_vsi") are used during an individual VF reset to re-create the VSI. This was done in order to ensure that the VSI gets prope

Re: [Intel-wired-lan] [PATCH net-next 0/5] igc: ethtool: Check VLAN TCI mask

2023-11-29 Thread Kurt Kanzenbach
On Tue Nov 28 2023, Vinicius Costa Gomes wrote: > Kurt Kanzenbach writes: > >> Hi, >> >> currently it is possible to configure receive queue assignment using the VLAN >> TCI field with arbitrary masks. However, the hardware only supports steering >> either by full TCI or the priority (PCP) field.

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic

2023-11-29 Thread Przemek Kitszel
On 11/29/23 11:26, Sokolowski, Jan wrote: On 11/20/2023 3:27 AM, Jan Sokolowski wrote: It was found that this statistic is incorrectly reported by HW and thus, useless. Remove it. Is there any further information about what is reported incorrectly? Is rx_length_errors part of netdev stats an

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: remove rx_len_errors statistic

2023-11-29 Thread Sokolowski, Jan
> >On 11/20/2023 3:27 AM, Jan Sokolowski wrote: >> It was found that this statistic is incorrectly reported >> by HW and thus, useless. >> >> Remove it. > >Is there any further information about what is reported incorrectly? Is >rx_length_errors part of netdev stats and standardized? Does HW fail

[Intel-wired-lan] [PATCH iwl-net v2] i40e:Fix filter input checks to prevent config with invalid values

2023-11-29 Thread Aleksandr Loktionov
From: Sudheer Mogilappagari Prevent VF from configuring filters with unsupported actions or use REDIRECT action with invalid tc number. Current checks could cause out of bounds access on PF side. Fixes: e284fc280473 ("i40e: Add and delete cloud filter") Reviewed-by: Andrii Staikov Signed-off-by

[Intel-wired-lan] [PATCH iwl-net v1] i40e:Fix filter input checks to prevent config with invalid values

2023-11-29 Thread Aleksandr Loktionov
From: Sudheer Mogilappagari Prevent VF from configuring filters with unsupported actions or use REDIRECT action with invalid tc number. Current checks could cause out of bounds access on PF side. Reviewed-by: Andrii Staikov Signed-off-by: Sudheer Mogilappagari Signed-off-by: Aleksandr Loktiono

Re: [Intel-wired-lan] [PATCH v5 4/5] i40e: Fix broken support for floating VEBs

2023-11-29 Thread Ivan Vecera
On 27. 11. 23 9:43, Dan Carpenter wrote: 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14720 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14721 pf = veb->pf; 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14722 41c445ff0f482bb Jesse Brandeburg 2013-09-11 14723 /* find the remaining VSI an